Commit Graph

4 Commits

Author SHA1 Message Date
Sungbo Eo
a22b7a60d9 kernel: fix *-gpio-custom module unloading
Unloading and reloading the modules fails, as platform_device_put() does not
release resources fully.

root@OpenWrt:/# insmod i2c-gpio-custom bus0=0,18,0,5
[  196.860620] Custom GPIO-based I2C driver version 0.1.1
[  196.871162] ------------[ cut here ]------------
[  196.880517] WARNING: CPU: 0 PID: 1365 at fs/sysfs/dir.c:31 0x80112158
[  196.893431] sysfs: cannot create duplicate filename '/devices/platform/i2c-gpio.0'
...
[  197.513200] kobject_add_internal failed for i2c-gpio.0 with -EEXIST, don't try to register things with the same name in the same directory.

This patch fixes it by replacing platform_device_put() to
platform_device_unregister().

Fixes: da77408537 ("i2c-gpio-custom: minor bugfix")
Fixes: 3bc81edc70 ("package: fix w1-gpio-custom package (closes #6770)")

Signed-off-by: Sungbo Eo <mans0n@gorani.run>
2019-12-23 00:22:07 +01:00
John Crispin
61c23c2eaa w1-gpio-custom: Fix uninitialised variable causing 1-wire to not bind to GPIO
Signed-off-by: Andrew McDonnell <bugs@andrewmcdonnell.net>

SVN-Revision: 45739
2015-05-23 15:29:20 +00:00
Gabor Juhos
1928106d0d package/w1-gpio-custom: fix checkpatch errors in module source
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

SVN-Revision: 37874
2013-09-02 08:45:31 +00:00
John Crispin
4ebf19b48f packages: clean up the package folder
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 37007
2013-06-21 16:54:37 +00:00