Commit Graph

379 Commits

Author SHA1 Message Date
Felix Fietkau
76af0eff3f netifd: update to the latest version, adds various fixes
Signed-off-by: Felix Fietkau <nbd@nbd.name>
2016-09-28 09:56:32 +02:00
Felix Fietkau
c487bde9e4 netifd: update to the latest version
Adds fixes for wireless device error handling
Adds link state fixes for shell proto handlers

Signed-off-by: Felix Fietkau <nbd@nbd.name>
2016-08-23 11:08:35 +02:00
Felix Fietkau
009d6d6024 netifd: update to the latest version, adds an event handling fix
Signed-off-by: Felix Fietkau <nbd@nbd.name>
2016-07-29 19:51:31 +02:00
Felix Fietkau
d9ff187003 netifd: update to the latest version
Emits an initial event after the first link-up of a force_link
interface. This is needed for making the dnsmasq dhcp check more
reliable

Signed-off-by: Felix Fietkau <nbd@nbd.name>
2016-07-29 16:41:09 +02:00
Merlijn Wajer
4a0c4d8151 netifd: Use -x hostname:$hostname instead of -H
Passing the hostname is currently broken in since the shipped busybox includes this commit:
https://git.busybox.net/busybox/commit/networking/udhcp/dhcpc.c?id=2017d48c0d70bef8768efb42909e605ea8eb5a21

Before:

    Sun Jan 31 18:11:32 2016 daemon.notice netifd: Interface 'wan' is now down
    Sun Jan 31 18:11:32 2016 daemon.notice netifd: Interface 'wan' is setting up now
    Sun Jan 31 18:11:32 2016 daemon.notice netifd: wan (18158): udhcpc: option -h NAME is deprecated, use -x hostname:NAME
    Sun Jan 31 18:11:32 2016 daemon.notice netifd: wan (18158): udhcpc: malformed hex string 'WR150'

After:

    Sun Jan 31 18:11:33 2016 daemon.notice netifd: wan (18169): udhcpc (v1.23.2) started
    Sun Jan 31 18:11:33 2016 daemon.notice netifd: wan (18169): Sending discover...
    Sun Jan 31 18:11:33 2016 daemon.notice netifd: wan (18169): Sending select for xxx.yyy.zzz.xyz...
    Sun Jan 31 18:11:33 2016 daemon.notice netifd: wan (18169): Lease of xxx.yyy.zzz.xyz obtained, lease time 600

Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
2016-07-24 06:59:55 +02:00
Hans Dedecker
99e5bec2c6 netifd: quote vendorid and hostname variables in dhcp script
Quote hostname and vendorid variables in dhcp script so they can
hold strings having white spaces

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2016-07-12 14:33:49 +02:00
John Crispin
62dc9831d3 package/*: update git urls for project repos
Signed-off-by: John Crispin <john@phrozen.org>
2016-06-13 22:51:41 +02:00
Felix Fietkau
7eeb254cc4 treewide: replace nbd@openwrt.org with nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name>
2016-06-07 08:58:42 +02:00
Felix Fietkau
754565a84b netifd: update to the latest version
Signed-off-by: Felix Fietkau <nbd@nbd.name>
2016-06-06 15:46:35 +02:00
Hans Dedecker
f9a3123bbf netifd: Remove hardcoded DHCP release option
Remove the udhcpc -R release option as sending a DHCP release
is configurable via the uci option release.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2016-05-11 16:46:17 +02:00
Hans Dedecker
a83f049b5b netifd: Add configurable DHCP release behavior
Make sending a DHCP release configurable when the client exits allowing to clean up
IP/mac state info in intermediate devices.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2016-04-28 13:44:47 +02:00
Hans Dedecker
81a5f1ac9e netifd: Send DHCP release when client exits
Let DHCP client send a release when it exists so the DHCP server is
informed the IP address is released and allowing to clean up IP/mac
state info in intermediate devices.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2016-03-31 12:18:29 +02:00
Jo-Philipp Wich
564330e013 netifd: fix default ip rules
Update to latest HEAD in order to remove the faulty "prelocal" ip rule leading
to unexpected policy rule precedence.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2016-03-31 00:05:02 +02:00
Jo-Philipp Wich
dab37abc4d netifd: fix build error
Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>

SVN-Revision: 48920
2016-03-04 18:37:45 +00:00
Jo-Philipp Wich
81399345fe netifd: fix VTI ikey/okey endianess
Ensure that ikey and okey are sent in network byte order to the kernel.
Also don't mangle external IP addrs and routes when reconfiguring iinterfaces.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>

SVN-Revision: 48919
2016-03-04 17:48:18 +00:00
Felix Fietkau
208b3098f0 netifd: update to the latest version, adds many fixes
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 48595
2016-02-01 12:02:05 +00:00
Felix Fietkau
c49bc55669 netifd: update to the latest version, adds a cosmetic fix for a wpa related variable
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 48397
2016-01-20 19:11:41 +00:00
Jo-Philipp Wich
5cf88bb032 netifd: fix PKG_VERSION (#21630)
Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>

SVN-Revision: 48280
2016-01-17 17:15:01 +00:00
Felix Fietkau
eb1ac66ce7 netifd: update to the latest version, adds VTI support and a policy routing fix
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 48273
2016-01-17 11:05:53 +00:00
Felix Fietkau
9cd6162b63 packages: use OPENWRT_GIT to point at the main openwrt git repo
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 48118
2016-01-04 15:11:49 +00:00
Felix Fietkau
a99c78a09a netifd: update to the latest version, fixes more route table issues
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 47897
2015-12-16 23:15:15 +00:00
Felix Fietkau
513702e658 netifd: update to the latest version, fixes reload issues on routing table changes
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 47893
2015-12-15 11:01:47 +00:00
Felix Fietkau
6fb259b6df netifd: ifup-shellscript - fix wrong usage of 'local'
this error was not visible until recent bump to
busybox 1.24.1 stable which introduced a warning message
when keyword 'local' is not used with a shell-function.

this does not change behavior and is a cosmetic cleanup.
fixes the following output:

root@box:~ ifup <interface>
/sbin/ifup: local: line 362: not in a function
/sbin/ifup: local: line 362: not in a function
/sbin/ifup: local: line 1: not in a function

Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>

SVN-Revision: 47828
2015-12-10 12:53:30 +00:00
Felix Fietkau
59dbc9fa4e netifd: update to the latest version, fixes an issue with moving a wifi iface to a different network
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 47683
2015-12-02 13:52:08 +00:00
Jo-Philipp Wich
49b3fc70e5 netifd: fix device status reporting for external interfaces
Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>

SVN-Revision: 47493
2015-11-17 16:34:43 +00:00
Felix Fietkau
e4859508be netifd: update to the latest version, contains several fixes, including one for interface ip4/ip6table for device routes
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 47460
2015-11-12 00:24:27 +00:00
Felix Fietkau
38182373e0 netifd: update to the latest version, fixes spurious client isolation in unbridged AP configurations (#20574)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 47053
2015-09-26 23:18:40 +00:00
Felix Fietkau
ced2b641e2 base-files: set kernel.core_pattern in sysctl.conf
Move the pattern setting from netifd's service script to
/etc/sysctl.conf.  Put the timestamp component '%t' just after
executable name '%e' for more natural order from output of ls command.

Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>

SVN-Revision: 46867
2015-09-11 16:35:17 +00:00
Felix Fietkau
7e57d753a1 netifd: update to the latest version, fixes a WDS STA mode regression caused by multicast-to-unicast handling (#20466)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 46841
2015-09-10 21:00:19 +00:00
Felix Fietkau
d4e9c8d7ef netifd: update to the latest version, adds multicast-to-unicast fixes
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 46719
2015-08-25 07:24:53 +00:00
Steven Barth
9f67c7fc8a netifd: various updates
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 46718
2015-08-25 06:27:37 +00:00
Felix Fietkau
26d71e9b25 netifd: update to the latest version, fixes setting RPS/XPS for wlan devices
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 46421
2015-07-18 23:14:19 +00:00
Steven Barth
a742fcaf3b netifd: add mtu6 option to override IPv6 MTU
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 46135
2015-06-29 06:47:19 +00:00
Steven Barth
ebfe8d8b08 netifd: bump to latest, various fixes
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 45926
2015-06-08 11:04:10 +00:00
Steven Barth
e6f9641df1 netifd: fix and optimize ipv6 onlink-route handling
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 45768
2015-05-26 12:48:12 +00:00
Felix Fietkau
4eeeb91661 netifd: bump to current HEAD
This introduces a new config parameter "no-proto-task" useful for
xl2tpd.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>

SVN-Revision: 45748
2015-05-25 21:15:31 +00:00
Steven Barth
241dbffcf9 netifd: improve IPv6 onlink-route handling
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 45701
2015-05-19 09:01:34 +00:00
Felix Fietkau
bf84a53f9b netifd-dhcp: supply parameters to user-script
hand over parameters to user-script e.g. $1=deconfig

Signed-off-by: Leon George <leon@georgemail.de>
Signed-off-by: Christian Mehlis <christian@m3hlis.de>

SVN-Revision: 45626
2015-05-08 10:44:19 +00:00
Steven Barth
a132313238 dhcp: add option specifying overriding custom-routes
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 45594
2015-05-02 07:44:55 +00:00
Felix Fietkau
fe14e2a674 netifd: update to the latest version, fixes retry when proto handlers exit without changing the state
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 45550
2015-04-21 12:11:07 +00:00
Felix Fietkau
a285a0a034 netifd: update to the latest version, fixes more interface device config handling issues
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 45503
2015-04-19 09:50:49 +00:00
Felix Fietkau
6293aae9d3 netifd: update to the latest version, fixes more device config handling issues
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 45497
2015-04-18 21:35:16 +00:00
Felix Fietkau
bdd241ee29 netifd: update to the latest version, fixes issues in handling device config from interfaces
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 45483
2015-04-17 19:28:10 +00:00
Steven Barth
6b062ad848 network: shorten names of generated interfaces
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 45476
2015-04-17 13:10:19 +00:00
John Crispin
dcdd5c1ecb netifd: Interface last error support
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 45334
2015-04-09 10:33:05 +00:00
Steven Barth
4a1f19e15d netifd: revert policy routing (broke some custom user rules)
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 45185
2015-03-31 13:14:40 +00:00
Steven Barth
edf9b7a2a5 netifd: add metric argument for ipv4 proto routes
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 45182
2015-03-31 11:36:20 +00:00
Steven Barth
7edbd6b4d7 netifd: adjust default local policy rules
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 45059
2015-03-27 14:19:10 +00:00
John Crispin
242e37454a netifd: update to latest git HEAD
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 45020
2015-03-26 10:59:40 +00:00
Felix Fietkau
7cacd6bdb6 netifd: fix default initialization of RPS/XPS
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 44944
2015-03-22 17:40:39 +00:00
Felix Fietkau
78692595e7 netifd: update to the latest version, adds support for configuring RPS/XPS (enabled by default where available)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 44943
2015-03-22 16:42:44 +00:00
Steven Barth
8cfe2fb30b netifd: fix ipv6 route regression
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 44919
2015-03-21 18:28:08 +00:00
Steven Barth
b27efd6e07 netifd: device update fixes, improvements in policy routing
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 44899
2015-03-20 07:50:45 +00:00
Jo-Philipp Wich
eb7f470e7b netifd: dhcp: install host route to gateway (#19182)
Certain DHCP servers push a gateway outside of the assigned interface subnet,
to support those situations install a host route towards the gateway.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>

SVN-Revision: 44789
2015-03-15 14:48:18 +00:00
John Crispin
59c20174f8 json-c: update to 0.12 and bump all depending services
Version 0.12 deprecates json_object_object_get and moves the header files around

Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 44657
2015-03-11 15:54:33 +00:00
Steven Barth
c975f83cc2 netifd: various device config / event fixes (thx Hans Dedecker)
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 44480
2015-02-17 14:14:51 +00:00
Felix Fietkau
00d422fc60 netifd: update to the latest version, reverts a commit causing MTU issues (fixes #18869)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 44461
2015-02-16 09:07:19 +00:00
Steven Barth
6ee8d1f178 netifd: fix device config handling and add some config options
Thanks to Hans Dedecker

Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 44331
2015-02-09 08:30:06 +00:00
Felix Fietkau
ea638e4eba netifd: fix a regression with some VLAN configurations introduced in the last update
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 44098
2015-01-24 14:16:36 +00:00
Felix Fietkau
18d4b8783c netifd: do not stop service on shutdown, only call ifdown
Also add a small delay, like on restart

Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 44096
2015-01-24 13:41:04 +00:00
Felix Fietkau
c71cf8e6e4 netifd: update to the latest version, fixes bridge reload (#18351) and device config issues
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 44093
2015-01-24 00:30:36 +00:00
Jo-Philipp Wich
1f6411e436 netifd: store additional DHCP lease information
Extend the DHCPv4 handler script to store additional information from the
DHCP lease in the per-interface data object.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>

SVN-Revision: 44092
2015-01-23 22:19:29 +00:00
Steven Barth
99fa07d07e netifd: add option to customize IPv6 interface identifiers (thx Hans Dedecker)
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 44050
2015-01-19 08:39:04 +00:00
Steven Barth
4746ffd7a6 netifd: minor fixes, add mldversion option
thanks to Hans Dedecker

Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 43771
2014-12-23 13:34:04 +00:00
Steven Barth
f565e0598d netifd: Set source IP for DHCP static routes as well
Commit ce92f6650bd8a86db04c7a6cbb58e7fdb200a7e6 added source IP support
for DHCP default routes. As a side effect of this change the default route
could be present twice in netifd (once with source IP set and once with
source IP unset) if it was sent by the server in both the router and static
route options. Therefore add source IP support as well for static routes as this
case was not considered. Additional remove unused parameter type.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>

SVN-Revision: 43645
2014-12-12 09:39:07 +00:00
Steven Barth
1f4ddec7f2 netifd: several fixes and optimizations
Thanks to Hans Dedecker and Kristian Evensen

Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 43583
2014-12-08 17:43:14 +00:00
Steven Barth
15d67644f1 This patch depends on "Pass source address to proto_add_ipv4_route".
I have not found a scenario that would break by setting the source address on
default, but please let me know if any special considerations should be taken.

Signed-off-by: Kristian Evensen <kristian.evensen at gmail.com>

SVN-Revision: 43582
2014-12-08 17:43:03 +00:00
Steven Barth
200c30b426 netifd: correctly handle source-parameter for IPv4 routes
Thanks to Kristian Evensen

Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 43400
2014-11-27 07:26:10 +00:00
Felix Fietkau
185172bdd3 netifd: update to the latest version, fixes issues when changing a bridge member from a vlan to its base device (#18351)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 43346
2014-11-23 16:07:00 +00:00
Steven Barth
047f1c8dca netifd: fix race, expose config options
Thanks to Hans Dedecker

Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 43299
2014-11-19 08:31:13 +00:00
Steven Barth
990b501ec4 netifd: fix default ORO-setting for 6rd
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 43214
2014-11-08 12:24:49 +00:00
Steven Barth
bec9d38fa4 Add a few SPDX tags
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 43151
2014-11-02 12:20:54 +00:00
Felix Fietkau
3cefd0af7d netifd: update to the latest version, fixes a use-after-free bug
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 43044
2014-10-24 13:04:12 +00:00
Felix Fietkau
188eb85f5b netifd: update to the latest version, fixes link status handling on VLAN devices (#18106)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 43007
2014-10-20 20:09:35 +00:00
Steven Barth
9106cc0af9 netifd: Make mtu configurable of dynamic 6rd tunnel interface
Patch allows to configure the mtu of the dynamic 6rd tunnel interface when created by dhcp script.
In some setups it's desirable to have config control over the 6rd tunnel mtu to maximize the traffic throughput

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>

SVN-Revision: 42871
2014-10-12 12:27:21 +00:00
Steven Barth
73179a188c netifd: fix an error message during network shutdown
When 'wifi down' is called by /etc/init.d/network, it is run from
stop_service( ). This function is in turn invoked from stop( ).
stop( ) messes up the order by first procd_kill-ing the network
settings, then calling wifi to down the wifi networking
interfaces. By redefining stop( ) instead, the proper order is
restored.

Signed-off-by: Michel Stam <m.stam@fugro.nl>

SVN-Revision: 42745
2014-10-02 19:37:25 +00:00
Steven Barth
1c166058df netifd: add IPIP tunnel support (thx Hans Dedecker)
SVN-Revision: 42744
2014-10-02 19:37:17 +00:00
Steven Barth
30912c5d81 netifd: add support for promisc and GRE tos option
SVN-Revision: 42699
2014-09-29 17:59:50 +00:00
Steven Barth
bd74df01b1 netifd: work-around kernel IPv6 on-link route issue
SVN-Revision: 42439
2014-09-08 14:45:56 +00:00
Felix Fietkau
008c7a9e5a netifd: update to the latest version, adds interface cleanup fixes
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 42345
2014-08-31 13:09:01 +00:00
Felix Fietkau
ba62bcbf24 netifd: update to the latest version, fixes proto-shell teardown after renew
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 42344
2014-08-31 12:26:26 +00:00
John Crispin
2ae05c57f8 package/*: remove useless explicit set of function returncode
somebody started to set a function returncode in the validation
stuff and everybody copies it, e.g.

myfunction()
{
	fire_command

	return $?
}

a function automatically returns with the last returncode,
so we can safely remove the command 'return $?'. reference:

http://tldp.org/LDP/abs/html/exit-status.html
"The last command executed in the function or script determines the exit status."

Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>

SVN-Revision: 42278
2014-08-25 06:35:50 +00:00
Steven Barth
92ef017054 netifd: assign ipv6-prefixes with length <64 with /64 on-link routes
SVN-Revision: 42161
2014-08-13 14:57:11 +00:00
Steven Barth
b95b4ede4c netifd: unblock some proto shell actions in teardown state
SVN-Revision: 42032
2014-08-07 10:21:08 +00:00
Steven Barth
6656292619 netifd: disable ds-lite, map & gre for old kernels
this unbreaks netifd compilation on old kernels

SVN-Revision: 42019
2014-08-06 19:57:19 +00:00
Steven Barth
1e6ab23098 netifd: minor fixes (thanks Hans Dedecker)
SVN-Revision: 42000
2014-08-05 10:03:10 +00:00
Steven Barth
e413bb0e7e netifd: fixes and GRE support (thx Hans Dedecker)
SVN-Revision: 41896
2014-07-30 13:21:52 +00:00
Steven Barth
86671615de netifd: suppress fw3 warnings in dhcp script
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>

SVN-Revision: 41892
2014-07-30 13:17:56 +00:00
Steven Barth
6a50e69b21 netifd: more race condition fixes in proto-shell
SVN-Revision: 41887
2014-07-29 17:24:23 +00:00
Steven Barth
7f17639742 netifd: more dynamic interface improvements
SVN-Revision: 41862
2014-07-28 20:35:53 +00:00
Felix Fietkau
76d7397bc2 netifd: fix a small issue in r41831
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 41836
2014-07-26 14:35:15 +00:00
Felix Fietkau
ee4f8c8b99 netifd: update to the latest version, fixes a race condition with renew/setup
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 41831
2014-07-26 01:46:34 +00:00
Steven Barth
ae50480d77 netifd: Fix some race-conditions in interface handling
SVN-Revision: 41825
2014-07-24 22:05:19 +00:00
Steven Barth
9231df5665 softwires: redesign dhcp(v6) provisioning
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 41823
2014-07-24 14:17:41 +00:00
Felix Fietkau
5206b2dac0 netifd: update to the latest version, enables bridge multicast querier and fixes interface reload issues with wifi
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 41818
2014-07-24 09:13:04 +00:00
Felix Fietkau
51fbfde474 netifd: update to the latest version, adds a small validation fix
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 41731
2014-07-18 11:45:42 +00:00
Felix Fietkau
51b11ba5ea netifd: update to the latest version, enables igmp snooping by default
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 41683
2014-07-17 14:55:17 +00:00
Felix Fietkau
5db42f92fd netifd: update to the latest version, fixes a crash on reload with hotplugged devices
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 41393
2014-06-29 21:27:28 +00:00
Felix Fietkau
50c05b20cb netifd: update to the latest version, addds a few fixes and enables multicast->unicast for igmp snooping on wireless devices
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 41390
2014-06-29 18:34:22 +00:00
Steven Barth
22ffa5ef16 netifd: various routing table handling fixes
SVN-Revision: 41287
2014-06-20 17:51:25 +00:00
Jo-Philipp Wich
005884bff4 Revert "netifd: fix handling of "lookup main" for ip rules (#15315)"
The netifd fixes went to the wrong repository, revert until it is sorted out.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>

SVN-Revision: 41283
2014-06-20 12:28:35 +00:00
Jo-Philipp Wich
de51f6022f netifd: fix handling of "lookup main" for ip rules (#15315)
Reworks the handling of RT_TABLE_MAIN in system-linux.c so that ip rules
with lookup main can be properly setup.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>

SVN-Revision: 41282
2014-06-20 09:58:16 +00:00
Steven Barth
8d177a8e78 netifd: various bugfixes (thanks Hans Dedecker)
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 41259
2014-06-18 11:29:09 +00:00
Felix Fietkau
500d3072ec netifd: use procd_add_reload_trigger
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 41147
2014-06-11 17:05:50 +00:00
Felix Fietkau
3ab9651cb0 netifd: update to latest version, fixes reload issue (#16754) and adds 802.1ad support
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 41112
2014-06-11 10:23:12 +00:00
Steven Barth
b81ebf6db1 netifd: add support for onlink-flag for routes
SVN-Revision: 41098
2014-06-10 16:04:40 +00:00
John Crispin
7a0606124a netfid: make procd watch the network.interface object for events
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 41010
2014-06-05 10:56:14 +00:00
John Crispin
91de9c589c netifd: update to latest git HEAD
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 41009
2014-06-05 10:56:10 +00:00
John Crispin
40218343cd package: netifd: remove blank line at the end of file
Signed-off-by: Zhao, Gang <gamerh2o@gmail.com>

SVN-Revision: 40937
2014-06-02 12:44:51 +00:00
Felix Fietkau
d866ee2e30 netifd: replace the sleep 5 with an ubus wait_for call to speed up init script
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40891
2014-05-31 23:49:23 +00:00
Steven Barth
5696b94b76 netifd: fix a segfault and improve ipip6 tunnel setup
SVN-Revision: 40821
2014-05-22 20:04:43 +00:00
Felix Fietkau
cfbd90d2bf netifd: update to the latest version, fixes wireless setup cancellation
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40771
2014-05-15 20:03:04 +00:00
Felix Fietkau
127ce4d5ec netifd: update to latest version, fixes a regression on wds client support
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40748
2014-05-10 18:03:24 +00:00
Steven Barth
0c06d76c79 netifd: Fix nested protocols going offline at reload + various route issues
Much thanks to Hans Dedecker

SVN-Revision: 40746
2014-05-09 13:55:34 +00:00
Felix Fietkau
770ec0082b netifd: update to the latest version, fixes some corner cases related to hotplug device handling
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40660
2014-05-02 18:12:28 +00:00
Felix Fietkau
d33c6f7b80 netifd: update to the latest version, fixes a use-after-free bug on wireless config reload
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40589
2014-04-29 13:18:59 +00:00
Felix Fietkau
b4532ad21e netifd: update to the latest version, fixes some route table and dynamic interface issues
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40572
2014-04-26 19:48:11 +00:00
Felix Fietkau
b079019bd9 netifd: update to latest version, adds support for disabling interfaces
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40555
2014-04-22 17:28:14 +00:00
Felix Fietkau
3c95232ab7 netifd: update to the latest version, fixes some more issues related to l3_dev handling
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40529
2014-04-19 09:58:40 +00:00
Felix Fietkau
7b960069a2 netifd: switch to using git.openwrt.org
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40459
2014-04-11 20:28:55 +00:00
Felix Fietkau
92ab194d63 netifd: update to latest version, adds a force_link parameter to bring up an interface without active device carrier
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40456
2014-04-11 13:48:41 +00:00
Felix Fietkau
a28b8ecc47 netifd: update to the latest version, fixes some reload issues with proto=static
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40449
2014-04-10 15:21:13 +00:00
Felix Fietkau
8a7a02bd2e netifd: fix a regression related to ppp + multiple updates (ipv4 + ipv6)
Fixes #15504

Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40443
2014-04-10 11:31:21 +00:00
Felix Fietkau
255546bbfd netifd: update to the latest version, fixes a l3_dev handling regression leading to a crash
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40414
2014-04-07 11:12:06 +00:00
Felix Fietkau
dca014db76 netifd: Add renew handler for proto dhcp
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>

SVN-Revision: 40385
2014-04-05 18:17:22 +00:00
Felix Fietkau
0dd2d18400 netifd: update to latest version, fixes issues when l3 interface changes on reload (e.g. ppp -> dhcp/static)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40384
2014-04-05 18:17:18 +00:00
John Crispin
c7168b64ef dhcp: Fix broadcast parameter validation support, remove unused netmask parameter
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>

SVN-Revision: 40332
2014-03-30 13:07:52 +00:00
Steven Barth
0555ebf66d 6rd / ds-lite: make the firewall-zones of nested-protocols configurable
SVN-Revision: 40020
2014-03-26 10:12:49 +00:00
Steven Barth
2a893c2057 dhcp: send 6rd-ORO when expecting 6rd-information
SVN-Revision: 40019
2014-03-26 09:48:20 +00:00
Felix Fietkau
5c53e63836 netifd: update to the latest version, adds support for reloading proto handlers on toplogy changes
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 40001
2014-03-21 15:55:27 +00:00
Felix Fietkau
3eb2d6d5d4 netifd: update to the latest version, fixes ubus handling of proto data items
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39970
2014-03-20 20:06:59 +00:00
Felix Fietkau
e926cfd9ac netifd: update to latest version, fixes an autostart handling with link detection
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39967
2014-03-20 13:57:28 +00:00
Felix Fietkau
ad72198abb netifd: update to latest version, adds support for specifying a config path
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39956
2014-03-19 14:26:51 +00:00
Steven Barth
edd75e332c netifd: pass on delegate flag from dhcp to 6rd
SVN-Revision: 39909
2014-03-13 10:33:26 +00:00
Felix Fietkau
83f9fc12d6 netifd: update to latest version, includes interface handling fixes by Hans Dedecker
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39870
2014-03-11 09:28:28 +00:00
Felix Fietkau
452d019d3e netifd: update to latest version, adds a bridge reload fix and fixes #15157
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39791
2014-03-07 18:14:41 +00:00
Steven Barth
f294f23c02 netifd: don't incorrectly announce up-status via ubus
Signed-off-by: Steven Barth <steven@midlink.org>

SVN-Revision: 39777
2014-03-05 17:36:14 +00:00
Steven Barth
1b3a868309 netifd: Reintroduce link-layer sensing (thx Hans Decker, Karl Vogel)
SVN-Revision: 39757
2014-02-27 12:42:38 +00:00
Steven Barth
0bf9032145 netifd: don't always assume addrs & routes are applied
netifd didn't check the netlink return values and kept assuming
routes are in place even if they weren't

SVN-Revision: 39755
2014-02-26 13:27:32 +00:00
Felix Fietkau
a15524582c netifd: depend on libubox directly to rebuild on ABI changes
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39723
2014-02-23 17:32:15 +00:00
Felix Fietkau
6c8300df3d netifd: update to latest version, fixes wireless device reload handling
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39706
2014-02-23 08:13:28 +00:00
Jo-Philipp Wich
354efde275 netifd: fix validation constraints
Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>

SVN-Revision: 39648
2014-02-21 00:17:04 +00:00
John Crispin
8fb44e0d1e netifd: add validation support
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 39621
2014-02-18 13:34:04 +00:00
John Crispin
204e859542 netifd: update to latest git head
this adds support for proto and wireless handler adding uci validation rules

Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 39614
2014-02-18 13:33:36 +00:00
Steven Barth
41acaaf893 netifd: work around dangling prefix kernel-routes (fixes #14963)
SVN-Revision: 39597
2014-02-16 11:20:22 +00:00
Steven Barth
af8f06beca netifd: fix source-routing breaking 6in4 + others
6in4 historically allowed an ip6addr without a mask however the newly
introduced source-routing segfaulted in this scenario (#14958 + #14858).

Fixes include: "Fix ubus route src mask printing" and
"Disable netlink auto ack" (thanks to Hans Dedecker)

SVN-Revision: 39586
2014-02-14 21:21:44 +00:00
Steven Barth
229d186490 netifd: don't add unnecessary NOP policy rules
SVN-Revision: 39351
2014-01-20 18:23:02 +00:00
Steven Barth
bc8412b90e netifd: Add IFUPDATE-flags and use main IPv6 routing table again
SVN-Revision: 39306
2014-01-17 13:59:40 +00:00
Felix Fietkau
20151a3394 netifd: initialize the switch early at start time and on reload (fixes #13015)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39183
2013-12-31 13:09:20 +00:00
Felix Fietkau
6865f1d6b2 netifd: update to the latest version, fixes wireless related segfaults on arm
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39180
2013-12-29 02:26:34 +00:00
Felix Fietkau
5607a13aa1 netifd: update to the latest version, fixes wifi related segfaults
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39176
2013-12-28 14:19:54 +00:00
Jo-Philipp Wich
1789744958 netifd: add reload trigger for /etc/config/wireless as well
SVN-Revision: 39131
2013-12-18 12:38:29 +00:00
Felix Fietkau
12c05542e8 netifd: update to latest version, fixes a null pointer crash
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39088
2013-12-16 10:08:13 +00:00
Steven Barth
e49d67f192 Convert DHCP->6rd and DHCPv6->DS-Lite autoconfig to dynamic interface
SVN-Revision: 39061
2013-12-15 19:38:53 +00:00
Felix Fietkau
ce062a7b5c netifd: update to the latest version, adds a revert of the link state handling patches which caused regressions in combination with wifi devices
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39050
2013-12-14 14:59:05 +00:00
Felix Fietkau
47730fe355 netifd: prevent an unnecessary restart of netifd-managed wifi interfaces at boot time
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39046
2013-12-13 16:43:11 +00:00
Felix Fietkau
3f744a4ad3 netifd: fix crashes triggered by adding/removing wireless devices on reload
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39035
2013-12-11 18:23:52 +00:00
John Crispin
31a2912cd9 netifd: enable coredumps again
got broken due procd startup. Requires procd resource limit patch.

Signed-off-by: Ulrich Weber <uw@xyne.com>

SVN-Revision: 39020
2013-12-09 17:29:34 +00:00
Felix Fietkau
6242255df2 netifd: update to the latest version, adds tunnel fixes by Hans Dedecker and adds back support for multiple networks per wifi-iface
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 39004
2013-12-08 18:00:05 +00:00
Felix Fietkau
4155016637 netifd: update to the latest version, improves wireless status output and fixes some bridge handling issues
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 38992
2013-12-03 14:17:44 +00:00
Felix Fietkau
3c50feca19 wifi: rename the "reload" (restarting non-netifd wifi) command to "reload_legacy"
Add a new "reload" command that reloads the netifd config as well

Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 38989
2013-12-02 16:53:24 +00:00
Felix Fietkau
498d84fc4e netifd: add wireless configuration support and port mac80211 to the new framework
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 38988
2013-12-02 16:41:03 +00:00
Felix Fietkau
107bcb5de3 netifd: remove redundant calls to /sbin/wifi down
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 38982
2013-12-02 13:08:00 +00:00
Felix Fietkau
e78e720a6f netifd: remove connect_time from /var/state, it is unused
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 38704
2013-11-10 10:01:33 +00:00
Felix Fietkau
e16f104a6f netifd: update to the latest version, fixes regression in proto-shell scripts (#14400, #14402)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 38627
2013-10-31 11:22:01 +00:00
Felix Fietkau
22890e6382 netifd: update to latest version, adds fixes and some preparation for supporting wifi devices
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 38606
2013-10-30 11:25:01 +00:00
Steven Barth
91b173d231 netifd: Fix ifupdate events
SVN-Revision: 38458
2013-10-19 11:01:25 +00:00
Steven Barth
c3bcdd59de netifd: various improvements
* Add ubus methods for global interface status
* Add ubus function to create nested interfaces
* Add protocol update notifications and hotplug legacy calls
* Fix: key to data elements point at wrong memory area
* Add support for source-restricted routes
* Add option "delegate" to toggle prefix delegation
* Reevaluate target routes also on interface update

SVN-Revision: 38453
2013-10-18 13:39:43 +00:00
Steven Barth
56bc536713 netifd: rename customopts to sendopts for consistency
SVN-Revision: 38437
2013-10-17 13:12:06 +00:00
Steven Barth
c759b49a4f Added 'customopts' dhcp protocol option, which is an array passed along to udhcpc as series of -x options.
Signed-off-by: Markus Stenberg <markus.stenberg@iki.fi>

SVN-Revision: 38436
2013-10-17 12:55:40 +00:00
Felix Fietkau
e96695df10 netifd: update to latest version, adds macvlan support
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 38299
2013-10-03 14:51:34 +00:00
Steven Barth
1d485c737e netifd: don't remove & readd addresses that only have a changed lifetime
SVN-Revision: 38269
2013-10-01 17:30:05 +00:00
John Crispin
f874094402 procd: convert various packages to procd style init.d scripts
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 38023
2013-09-17 21:45:30 +00:00
Felix Fietkau
7fc90889d5 netifd: update to the latest version, fixes a bridge handling corner case on config reload
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 37856
2013-08-29 22:20:36 +00:00
Steven Barth
54ae5ce507 netifd: Fix IPv6-prefix assignment with continuous hints
SVN-Revision: 37371
2013-07-16 12:07:11 +00:00
Luka Perkov
1a963355b0 netifd: update to latest version, add bridge_empty option
with this option enabled it's possible to create empty bridges

Signed-off-by: Luka Perkov <luka@openwrt.org>

SVN-Revision: 37318
2013-07-14 18:50:04 +00:00
Steven Barth
d8051a8814 netifd: fix typo in dhcp script
SVN-Revision: 37051
2013-06-28 04:19:21 +00:00
Felix Fietkau
b4babf9f81 netifd: update to latest version, fixes a NULL pointer deref bug
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 36965
2013-06-18 16:24:48 +00:00
Steven Barth
9f1899242c netifd: IPv6: Fix sorting order in last commit.
SVN-Revision: 36952
2013-06-17 21:29:14 +00:00
Steven Barth
213269a8f7 netifd: Satisfy IPv6 assignments ordered by prefix length
SVN-Revision: 36950
2013-06-17 21:16:22 +00:00
Felix Fietkau
9fb5bf176e netifd: update to latest version, uses the new uci/blob code from libuci
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 36909
2013-06-10 12:42:30 +00:00
Steven Barth
491deaed2c netifd: improve reloading behaviour
SVN-Revision: 36903
2013-06-10 10:42:15 +00:00
Steven Barth
f995c90329 netifd: Improve IPv6 source-routing policies
SVN-Revision: 36884
2013-06-08 13:26:33 +00:00
Jonas Gorski
b9de8ca7f5 netifd: bring wifi down before shutting down
works around wifiX references not being freed on network restart.

Signed-off-by: Jonas Gorski <jogo@openwrt.org>

SVN-Revision: 36883
2013-06-08 11:44:12 +00:00
Steven Barth
519f27cd33 netifd: updated IPv6 prefix delegation * Added support for prefix classes * Various bugfixes
SVN-Revision: 36771
2013-05-30 15:42:25 +00:00
Steven Barth
439fdd4d65 netifd: fix IPv6-addresses disappearing due to lifetime-overflows
SVN-Revision: 36748
2013-05-28 18:32:01 +00:00
Steven Barth
0f1be4425f netifd: Unify interface-based routing for IPv4 and IPv6 * Add interface option to set routing table for protocol routes * Enabled for IPv6 for source-based filtering, disabled for IPv4
Based on a patch by Kristian Evensen. Thank You.

SVN-Revision: 36653
2013-05-17 14:44:02 +00:00
Steven Barth
5ce135ed87 netifd: Various IPv6 improvements * Add support for IP-in-IPv6 tunnels (DS-Lite) * Use source-based routing for IPv6 to allow multi-wan * Various smaller tunnel setup improvements
SVN-Revision: 36627
2013-05-13 17:12:34 +00:00
Steven Barth
ea71678b09 netifd: added support for setting up 6rd from DHCP
SVN-Revision: 36626
2013-05-13 17:12:30 +00:00
Jo-Philipp Wich
f1497ccf4f netifd: update to git head - disables multicast snooping by default on bridges
SVN-Revision: 36463
2013-04-27 09:28:40 +00:00
Felix Fietkau
5062838fa5 netifd: update to the latest version, fixes interface reload issues when removing the ifname option
SVN-Revision: 36424
2013-04-25 16:28:19 +00:00
Steven Barth
17b8c0c7b8 netifd: Improve IPv6-ULA assignment handling
SVN-Revision: 36383
2013-04-22 19:40:06 +00:00
Felix Fietkau
099e3d8183 netifd: update to latest version, fixes some device handling crashes
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 36336
2013-04-15 14:21:45 +00:00
Jo-Philipp Wich
f90f025f20 netifd: fix route / route6 regression (#13303)
SVN-Revision: 36281
2013-04-09 12:21:12 +00:00
Steven Barth
3abc915522 Remove deprecated ip6slaac option * use proto=dhcpv6 with reqprefix=no instead
SVN-Revision: 36280
2013-04-09 12:12:30 +00:00
Steven Barth
35d716fbbb netifd: Bump to latest version * Fix a memory corruption when updating IPv6 prefixes * Fix route sorting order (nbd) * Add support for ip rules (jow) * Implement support for route / route6 table attribute (jow)
SVN-Revision: 36196
2013-04-05 12:28:06 +00:00
Steven Barth
0393e52623 netifd: Rewrite IPv6 prefix assignment * Add ip6hint option to specify assigned subprefixes * Add preliminary support for RFC 6603 prefix exclusion
SVN-Revision: 36193
2013-04-03 17:08:21 +00:00
Steven Barth
261be7b8f3 netifd: Fix adding IPv6 DNS-servers to resolv.conf
In some cases IPv6 DNS-servers were not added correctly.

SVN-Revision: 36095
2013-03-20 13:49:39 +00:00
Steven Barth
a7b262dc0a netifd: only update resolv.conf.auto if changed This avoids logspam under certain conditions.
SVN-Revision: 35743
2013-02-22 08:56:29 +00:00
Steven Barth
6a43437908 netifd: Improved IPv6 featureset * Fix reloading of ula-prefixes * Added support for temporary addresses and routes * Added support for offlink addresses * Improved status-output for assigned prefixes
SVN-Revision: 35420
2013-02-01 12:28:43 +00:00