From f8a2e1c68b48d72234172543f4232e77f065ca4d Mon Sep 17 00:00:00 2001 From: Tomasz Maciej Nowak Date: Tue, 4 Mar 2025 17:43:10 +0100 Subject: [PATCH] uboot-mediatek: u7623: remove keys pin function Apparently U-Boot will discard whole node if requested pin function is unknown to the driver. This resulted in inability to interact with U-Boot on the said board, as U-Boot always assumed the recovery key pressed and issued recovery procedure. Log snippet: button_gpio gpio-keys: pinctrl_select_state_full: pinctrl_config_one: err=-38 reset button found button pushed, resetting environment Recovery procedure also booted recovery image, which didn't affect much the 23.05.x release, since the root fs argument was valid, so changes persisted. But as 24.10.x hit with fitblk, the board will boot only recovery image (initramfs) because of default bootargs will reset on each boot and U-Boot provided bootargs took precedence. Fixes: 42eeb22450f2 ("uboot-mediatek: fix factory/reset button") Signed-off-by: Tomasz Maciej Nowak Link: https://patchwork.ozlabs.org/project/openwrt/patch/20250304164507.60511-1-tmn505@terefe.re/ Signed-off-by: Hauke Mehrtens --- .../uboot-mediatek/patches/401-update-u7623-defconfig.patch | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package/boot/uboot-mediatek/patches/401-update-u7623-defconfig.patch b/package/boot/uboot-mediatek/patches/401-update-u7623-defconfig.patch index d90bf88c59a..109c5b0cf02 100644 --- a/package/boot/uboot-mediatek/patches/401-update-u7623-defconfig.patch +++ b/package/boot/uboot-mediatek/patches/401-update-u7623-defconfig.patch @@ -188,13 +188,12 @@ leds { compatible = "gpio-leds"; -@@ -109,6 +122,19 @@ +@@ -109,6 +122,18 @@ }; }; + key_pins_a: keys-alt { + mux { -+ function = "gpio"; + groups = "msdc3"; + }; +