ExternalVendorCode/openwrt
1
0
Fork 0
mirror of https://github.com/openwrt/openwrt.git synced 2025-02-07 19:40:39 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

staging: mt7621-eth: fix return value check in mtk_connect_phy_node()

Browse Source 
In case of error, the function of_phy_connect() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: e3cbf478f846 ("staging: mt7621-eth: add the drivers core files")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2018-05-14 11:14:24 -07:00 committed by John Crispin
parent c4ae54dfab
commit edec251870
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
target/linux/ramips/files-4.14/drivers/net/ethernet/mtk/mdio.c
View File

@ -82,10 +82,10 @@ int fe_connect_phy_node(struct fe_priv *priv, struct device_node *phy_node)
phydev = of_phy_connect(priv->netdev, phy_node, fe_phy_link_adjust, phydev = of_phy_connect(priv->netdev, phy_node, fe_phy_link_adjust,
0, phy_mode); 0, phy_mode);
if (IS_ERR(phydev)) { if (!phydev) {
dev_err(priv->dev, "could not connect to PHY\n"); dev_err(priv->dev, "could not connect to PHY\n");
priv->phy->phy_node[port] = NULL; priv->phy->phy_node[port] = NULL;
return PTR_ERR(phydev); return -ENODEV;
} }
phydev->supported &= PHY_GBIT_FEATURES; phydev->supported &= PHY_GBIT_FEATURES;