mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-18 21:28:02 +00:00
at91: 6.1: remove upstreamed patches
Remove the upstreamed patches. Signed-off-by: Nick Hainke <vincent@systemli.org>
This commit is contained in:
parent
de9ad1e704
commit
db2c907260
File diff suppressed because it is too large
Load Diff
@ -1,89 +0,0 @@
|
||||
From 63a0c32028148e91ea91cfbf95841c4ecd69d21b Mon Sep 17 00:00:00 2001
|
||||
From: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Date: Mon, 11 Oct 2021 14:27:06 +0300
|
||||
Subject: [PATCH 235/247] clk: at91: pmc: execute suspend/resume only for
|
||||
backup mode
|
||||
|
||||
Before going to backup mode architecture specific PM code sets the first
|
||||
word in securam (file arch/arm/mach-at91/pm.c, function at91_pm_begin()).
|
||||
Thus take this into account when suspending/resuming clocks. This will
|
||||
avoid executing unnecessary instructions when suspending to non backup
|
||||
modes.
|
||||
|
||||
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Link: https://lore.kernel.org/r/20211011112719.3951784-3-claudiu.beznea@microchip.com
|
||||
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
|
||||
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
|
||||
---
|
||||
drivers/clk/at91/pmc.c | 39 +++++++++++++++++++++++++++++++++++++++
|
||||
1 file changed, 39 insertions(+)
|
||||
|
||||
--- a/drivers/clk/at91/pmc.c
|
||||
+++ b/drivers/clk/at91/pmc.c
|
||||
@@ -8,6 +8,7 @@
|
||||
#include <linux/clkdev.h>
|
||||
#include <linux/clk/at91_pmc.h>
|
||||
#include <linux/of.h>
|
||||
+#include <linux/of_address.h>
|
||||
#include <linux/mfd/syscon.h>
|
||||
#include <linux/platform_device.h>
|
||||
#include <linux/regmap.h>
|
||||
@@ -110,13 +111,35 @@ struct pmc_data *pmc_data_allocate(unsig
|
||||
}
|
||||
|
||||
#ifdef CONFIG_PM
|
||||
+
|
||||
+/* Address in SECURAM that say if we suspend to backup mode. */
|
||||
+static void __iomem *at91_pmc_backup_suspend;
|
||||
+
|
||||
static int at91_pmc_suspend(void)
|
||||
{
|
||||
+ unsigned int backup;
|
||||
+
|
||||
+ if (!at91_pmc_backup_suspend)
|
||||
+ return 0;
|
||||
+
|
||||
+ backup = readl_relaxed(at91_pmc_backup_suspend);
|
||||
+ if (!backup)
|
||||
+ return 0;
|
||||
+
|
||||
return clk_save_context();
|
||||
}
|
||||
|
||||
static void at91_pmc_resume(void)
|
||||
{
|
||||
+ unsigned int backup;
|
||||
+
|
||||
+ if (!at91_pmc_backup_suspend)
|
||||
+ return;
|
||||
+
|
||||
+ backup = readl_relaxed(at91_pmc_backup_suspend);
|
||||
+ if (!backup)
|
||||
+ return;
|
||||
+
|
||||
clk_restore_context();
|
||||
}
|
||||
|
||||
@@ -144,6 +167,22 @@ static int __init pmc_register_ops(void)
|
||||
}
|
||||
of_node_put(np);
|
||||
|
||||
+ np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-securam");
|
||||
+ if (!np)
|
||||
+ return -ENODEV;
|
||||
+
|
||||
+ if (!of_device_is_available(np)) {
|
||||
+ of_node_put(np);
|
||||
+ return -ENODEV;
|
||||
+ }
|
||||
+ of_node_put(np);
|
||||
+
|
||||
+ at91_pmc_backup_suspend = of_iomap(np, 0);
|
||||
+ if (!at91_pmc_backup_suspend) {
|
||||
+ pr_warn("%s(): unable to map securam\n", __func__);
|
||||
+ return -ENOMEM;
|
||||
+ }
|
||||
+
|
||||
register_syscore_ops(&pmc_syscore_ops);
|
||||
|
||||
return 0;
|
@ -1,124 +0,0 @@
|
||||
From c716562753d1e51a1c53647aa77a332f97187d15 Mon Sep 17 00:00:00 2001
|
||||
From: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Date: Mon, 11 Oct 2021 14:27:08 +0300
|
||||
Subject: [PATCH 237/247] clk: at91: clk-master: add register definition for
|
||||
sama7g5's master clock
|
||||
|
||||
SAMA7G5 has 4 master clocks (MCK1..4) which are controlled though the
|
||||
register at offset 0x30 (relative to PMC). In the last/first phase of
|
||||
suspend/resume procedure (which is architecture specific) the parent
|
||||
of master clocks are changed (via assembly code) for more power saving
|
||||
(see file arch/arm/mach-at91/pm_suspend.S, macros at91_mckx_ps_enable
|
||||
and at91_mckx_ps_restore). Thus the macros corresponding to register
|
||||
at offset 0x30 need to be shared b/w clk-master.c and pm_suspend.S.
|
||||
commit ec03f18cc222 ("clk: at91: add register definition for sama7g5's
|
||||
master clock") introduced the proper macros but didn't adapted the
|
||||
clk-master.c as well. Thus, this commit adapt the clk-master.c to use
|
||||
the macros introduced in commit ec03f18cc222 ("clk: at91: add register
|
||||
definition for sama7g5's master clock").
|
||||
|
||||
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Link: https://lore.kernel.org/r/20211011112719.3951784-5-claudiu.beznea@microchip.com
|
||||
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
|
||||
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
|
||||
---
|
||||
drivers/clk/at91/clk-master.c | 50 ++++++++++++++++-------------------
|
||||
1 file changed, 23 insertions(+), 27 deletions(-)
|
||||
|
||||
--- a/drivers/clk/at91/clk-master.c
|
||||
+++ b/drivers/clk/at91/clk-master.c
|
||||
@@ -17,15 +17,7 @@
|
||||
#define MASTER_DIV_SHIFT 8
|
||||
#define MASTER_DIV_MASK 0x7
|
||||
|
||||
-#define PMC_MCR 0x30
|
||||
-#define PMC_MCR_ID_MSK GENMASK(3, 0)
|
||||
-#define PMC_MCR_CMD BIT(7)
|
||||
-#define PMC_MCR_DIV GENMASK(10, 8)
|
||||
-#define PMC_MCR_CSS GENMASK(20, 16)
|
||||
#define PMC_MCR_CSS_SHIFT (16)
|
||||
-#define PMC_MCR_EN BIT(28)
|
||||
-
|
||||
-#define PMC_MCR_ID(x) ((x) & PMC_MCR_ID_MSK)
|
||||
|
||||
#define MASTER_MAX_ID 4
|
||||
|
||||
@@ -687,20 +679,22 @@ static void clk_sama7g5_master_set(struc
|
||||
{
|
||||
unsigned long flags;
|
||||
unsigned int val, cparent;
|
||||
- unsigned int enable = status ? PMC_MCR_EN : 0;
|
||||
+ unsigned int enable = status ? AT91_PMC_MCR_V2_EN : 0;
|
||||
|
||||
spin_lock_irqsave(master->lock, flags);
|
||||
|
||||
- regmap_write(master->regmap, PMC_MCR, PMC_MCR_ID(master->id));
|
||||
- regmap_read(master->regmap, PMC_MCR, &val);
|
||||
- regmap_update_bits(master->regmap, PMC_MCR,
|
||||
- enable | PMC_MCR_CSS | PMC_MCR_DIV |
|
||||
- PMC_MCR_CMD | PMC_MCR_ID_MSK,
|
||||
+ regmap_write(master->regmap, AT91_PMC_MCR_V2,
|
||||
+ AT91_PMC_MCR_V2_ID(master->id));
|
||||
+ regmap_read(master->regmap, AT91_PMC_MCR_V2, &val);
|
||||
+ regmap_update_bits(master->regmap, AT91_PMC_MCR_V2,
|
||||
+ enable | AT91_PMC_MCR_V2_CSS | AT91_PMC_MCR_V2_DIV |
|
||||
+ AT91_PMC_MCR_V2_CMD | AT91_PMC_MCR_V2_ID_MSK,
|
||||
enable | (master->parent << PMC_MCR_CSS_SHIFT) |
|
||||
(master->div << MASTER_DIV_SHIFT) |
|
||||
- PMC_MCR_CMD | PMC_MCR_ID(master->id));
|
||||
+ AT91_PMC_MCR_V2_CMD |
|
||||
+ AT91_PMC_MCR_V2_ID(master->id));
|
||||
|
||||
- cparent = (val & PMC_MCR_CSS) >> PMC_MCR_CSS_SHIFT;
|
||||
+ cparent = (val & AT91_PMC_MCR_V2_CSS) >> PMC_MCR_CSS_SHIFT;
|
||||
|
||||
/* Wait here only if parent is being changed. */
|
||||
while ((cparent != master->parent) && !clk_master_ready(master))
|
||||
@@ -725,10 +719,12 @@ static void clk_sama7g5_master_disable(s
|
||||
|
||||
spin_lock_irqsave(master->lock, flags);
|
||||
|
||||
- regmap_write(master->regmap, PMC_MCR, master->id);
|
||||
- regmap_update_bits(master->regmap, PMC_MCR,
|
||||
- PMC_MCR_EN | PMC_MCR_CMD | PMC_MCR_ID_MSK,
|
||||
- PMC_MCR_CMD | PMC_MCR_ID(master->id));
|
||||
+ regmap_write(master->regmap, AT91_PMC_MCR_V2, master->id);
|
||||
+ regmap_update_bits(master->regmap, AT91_PMC_MCR_V2,
|
||||
+ AT91_PMC_MCR_V2_EN | AT91_PMC_MCR_V2_CMD |
|
||||
+ AT91_PMC_MCR_V2_ID_MSK,
|
||||
+ AT91_PMC_MCR_V2_CMD |
|
||||
+ AT91_PMC_MCR_V2_ID(master->id));
|
||||
|
||||
spin_unlock_irqrestore(master->lock, flags);
|
||||
}
|
||||
@@ -741,12 +737,12 @@ static int clk_sama7g5_master_is_enabled
|
||||
|
||||
spin_lock_irqsave(master->lock, flags);
|
||||
|
||||
- regmap_write(master->regmap, PMC_MCR, master->id);
|
||||
- regmap_read(master->regmap, PMC_MCR, &val);
|
||||
+ regmap_write(master->regmap, AT91_PMC_MCR_V2, master->id);
|
||||
+ regmap_read(master->regmap, AT91_PMC_MCR_V2, &val);
|
||||
|
||||
spin_unlock_irqrestore(master->lock, flags);
|
||||
|
||||
- return !!(val & PMC_MCR_EN);
|
||||
+ return !!(val & AT91_PMC_MCR_V2_EN);
|
||||
}
|
||||
|
||||
static int clk_sama7g5_master_set_rate(struct clk_hw *hw, unsigned long rate,
|
||||
@@ -842,10 +838,10 @@ at91_clk_sama7g5_register_master(struct
|
||||
master->mux_table = mux_table;
|
||||
|
||||
spin_lock_irqsave(master->lock, flags);
|
||||
- regmap_write(master->regmap, PMC_MCR, master->id);
|
||||
- regmap_read(master->regmap, PMC_MCR, &val);
|
||||
- master->parent = (val & PMC_MCR_CSS) >> PMC_MCR_CSS_SHIFT;
|
||||
- master->div = (val & PMC_MCR_DIV) >> MASTER_DIV_SHIFT;
|
||||
+ regmap_write(master->regmap, AT91_PMC_MCR_V2, master->id);
|
||||
+ regmap_read(master->regmap, AT91_PMC_MCR_V2, &val);
|
||||
+ master->parent = (val & AT91_PMC_MCR_V2_CSS) >> PMC_MCR_CSS_SHIFT;
|
||||
+ master->div = (val & AT91_PMC_MCR_V2_DIV) >> MASTER_DIV_SHIFT;
|
||||
spin_unlock_irqrestore(master->lock, flags);
|
||||
|
||||
hw = &master->hw;
|
@ -1,40 +0,0 @@
|
||||
From 17b53ad1574cb5f41789993289d3d94f7a50f0ce Mon Sep 17 00:00:00 2001
|
||||
From: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Date: Mon, 11 Oct 2021 14:27:09 +0300
|
||||
Subject: [PATCH 238/247] clk: at91: clk-master: improve readability by using
|
||||
local variables
|
||||
|
||||
Improve readability in clk_sama7g5_master_set() by using local
|
||||
variables.
|
||||
|
||||
Suggested-by: Nicolas Ferre <nicolas.ferre@microchip.com>
|
||||
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Link: https://lore.kernel.org/r/20211011112719.3951784-6-claudiu.beznea@microchip.com
|
||||
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
|
||||
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
|
||||
---
|
||||
drivers/clk/at91/clk-master.c | 6 +++---
|
||||
1 file changed, 3 insertions(+), 3 deletions(-)
|
||||
|
||||
--- a/drivers/clk/at91/clk-master.c
|
||||
+++ b/drivers/clk/at91/clk-master.c
|
||||
@@ -680,6 +680,8 @@ static void clk_sama7g5_master_set(struc
|
||||
unsigned long flags;
|
||||
unsigned int val, cparent;
|
||||
unsigned int enable = status ? AT91_PMC_MCR_V2_EN : 0;
|
||||
+ unsigned int parent = master->parent << PMC_MCR_CSS_SHIFT;
|
||||
+ unsigned int div = master->div << MASTER_DIV_SHIFT;
|
||||
|
||||
spin_lock_irqsave(master->lock, flags);
|
||||
|
||||
@@ -689,9 +691,7 @@ static void clk_sama7g5_master_set(struc
|
||||
regmap_update_bits(master->regmap, AT91_PMC_MCR_V2,
|
||||
enable | AT91_PMC_MCR_V2_CSS | AT91_PMC_MCR_V2_DIV |
|
||||
AT91_PMC_MCR_V2_CMD | AT91_PMC_MCR_V2_ID_MSK,
|
||||
- enable | (master->parent << PMC_MCR_CSS_SHIFT) |
|
||||
- (master->div << MASTER_DIV_SHIFT) |
|
||||
- AT91_PMC_MCR_V2_CMD |
|
||||
+ enable | parent | div | AT91_PMC_MCR_V2_CMD |
|
||||
AT91_PMC_MCR_V2_ID(master->id));
|
||||
|
||||
cparent = (val & AT91_PMC_MCR_V2_CSS) >> PMC_MCR_CSS_SHIFT;
|
@ -1,39 +0,0 @@
|
||||
From 8a38e0dda46c9d941a61d8b2e6c14704531b7871 Mon Sep 17 00:00:00 2001
|
||||
From: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Date: Mon, 11 Oct 2021 14:27:10 +0300
|
||||
Subject: [PATCH 239/247] clk: at91: pmc: add sama7g5 to the list of available
|
||||
pmcs
|
||||
|
||||
Add SAMA7G5 to the list of available PMCs such that the suspend/resume
|
||||
code for clocks to be used on backup mode.
|
||||
|
||||
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Link: https://lore.kernel.org/r/20211011112719.3951784-7-claudiu.beznea@microchip.com
|
||||
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
|
||||
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
|
||||
---
|
||||
drivers/clk/at91/pmc.c | 5 +++--
|
||||
1 file changed, 3 insertions(+), 2 deletions(-)
|
||||
|
||||
--- a/drivers/clk/at91/pmc.c
|
||||
+++ b/drivers/clk/at91/pmc.c
|
||||
@@ -148,8 +148,9 @@ static struct syscore_ops pmc_syscore_op
|
||||
.resume = at91_pmc_resume,
|
||||
};
|
||||
|
||||
-static const struct of_device_id sama5d2_pmc_dt_ids[] = {
|
||||
+static const struct of_device_id pmc_dt_ids[] = {
|
||||
{ .compatible = "atmel,sama5d2-pmc" },
|
||||
+ { .compatible = "microchip,sama7g5-pmc", },
|
||||
{ /* sentinel */ }
|
||||
};
|
||||
|
||||
@@ -157,7 +158,7 @@ static int __init pmc_register_ops(void)
|
||||
{
|
||||
struct device_node *np;
|
||||
|
||||
- np = of_find_matching_node(NULL, sama5d2_pmc_dt_ids);
|
||||
+ np = of_find_matching_node(NULL, pmc_dt_ids);
|
||||
if (!np)
|
||||
return -ENODEV;
|
||||
|
@ -1,46 +0,0 @@
|
||||
From 27c11c09346b7b9f67eeb39db1b943f4a9742ff3 Mon Sep 17 00:00:00 2001
|
||||
From: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Date: Mon, 11 Oct 2021 14:27:13 +0300
|
||||
Subject: [PATCH 241/247] clk: at91: clk-master: mask mckr against layout->mask
|
||||
|
||||
Mask values read/written from/to MCKR against layout->mask as this
|
||||
mask may be different b/w PMC versions.
|
||||
|
||||
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Link: https://lore.kernel.org/r/20211011112719.3951784-10-claudiu.beznea@microchip.com
|
||||
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
|
||||
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
|
||||
---
|
||||
drivers/clk/at91/clk-master.c | 7 +++++--
|
||||
1 file changed, 5 insertions(+), 2 deletions(-)
|
||||
|
||||
--- a/drivers/clk/at91/clk-master.c
|
||||
+++ b/drivers/clk/at91/clk-master.c
|
||||
@@ -186,8 +186,8 @@ static int clk_master_div_set_rate(struc
|
||||
if (ret)
|
||||
goto unlock;
|
||||
|
||||
- tmp = mckr & master->layout->mask;
|
||||
- tmp = (tmp >> MASTER_DIV_SHIFT) & MASTER_DIV_MASK;
|
||||
+ mckr &= master->layout->mask;
|
||||
+ tmp = (mckr >> MASTER_DIV_SHIFT) & MASTER_DIV_MASK;
|
||||
if (tmp == div)
|
||||
goto unlock;
|
||||
|
||||
@@ -384,6 +384,7 @@ static unsigned long clk_master_pres_rec
|
||||
regmap_read(master->regmap, master->layout->offset, &val);
|
||||
spin_unlock_irqrestore(master->lock, flags);
|
||||
|
||||
+ val &= master->layout->mask;
|
||||
pres = (val >> master->layout->pres_shift) & MASTER_PRES_MASK;
|
||||
if (pres == MASTER_PRES_MAX && characteristics->have_div3_pres)
|
||||
pres = 3;
|
||||
@@ -403,6 +404,8 @@ static u8 clk_master_pres_get_parent(str
|
||||
regmap_read(master->regmap, master->layout->offset, &mckr);
|
||||
spin_unlock_irqrestore(master->lock, flags);
|
||||
|
||||
+ mckr &= master->layout->mask;
|
||||
+
|
||||
return mckr & AT91_PMC_CSS;
|
||||
}
|
||||
|
@ -1,312 +0,0 @@
|
||||
From e76d2af5009f52aa02d3db7ae32d150ad66398f9 Mon Sep 17 00:00:00 2001
|
||||
From: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Date: Mon, 11 Oct 2021 14:27:15 +0300
|
||||
Subject: [PATCH 243/247] clk: at91: clk-sam9x60-pll: add notifier for div part
|
||||
of PLL
|
||||
|
||||
SAM9X60's PLL which is also part of SAMA7G5 is composed of 2 parts:
|
||||
one fractional part and one divider. On SAMA7G5 the CPU PLL could be
|
||||
changed at run-time to implement DVFS. The hardware clock tree on
|
||||
SAMA7G5 for CPU PLL is as follows:
|
||||
|
||||
+---- div1 ----------------> cpuck
|
||||
|
|
||||
FRAC PLL ---> DIV PLL -+-> prescaler ---> div0 ---> mck0
|
||||
|
||||
The div1 block is not implemented in Linux; on prescaler block it has
|
||||
been discovered a bug on some scenarios and will be removed from Linux
|
||||
in next commits. Thus, the final clock tree that will be used in Linux
|
||||
will be as follows:
|
||||
|
||||
+-----------> cpuck
|
||||
|
|
||||
FRAC PLL ---> DIV PLL -+-> div0 ---> mck0
|
||||
|
||||
It has been proposed in [1] to not introduce a new CPUFreq driver but
|
||||
to overload the proper clock drivers with proper operation such that
|
||||
cpufreq-dt to be used. To accomplish this DIV PLL and div0 implement
|
||||
clock notifiers which applies safe dividers before FRAC PLL is changed.
|
||||
The current commit treats only the DIV PLL by adding a notifier that
|
||||
sets a safe divider on PRE_RATE_CHANGE events. The safe divider is
|
||||
provided by initialization clock code (sama7g5.c). The div0 is treated
|
||||
in next commits (to keep the changes as clean as possible).
|
||||
|
||||
[1] https://lore.kernel.org/lkml/20210105104426.4tmgc2l3vyicwedd@vireshk-i7/
|
||||
|
||||
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Link: https://lore.kernel.org/r/20211011112719.3951784-12-claudiu.beznea@microchip.com
|
||||
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
|
||||
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
|
||||
---
|
||||
drivers/clk/at91/clk-sam9x60-pll.c | 102 ++++++++++++++++++++++-------
|
||||
drivers/clk/at91/pmc.h | 3 +-
|
||||
drivers/clk/at91/sam9x60.c | 6 +-
|
||||
drivers/clk/at91/sama7g5.c | 13 +++-
|
||||
4 files changed, 95 insertions(+), 29 deletions(-)
|
||||
|
||||
--- a/drivers/clk/at91/clk-sam9x60-pll.c
|
||||
+++ b/drivers/clk/at91/clk-sam9x60-pll.c
|
||||
@@ -5,6 +5,7 @@
|
||||
*/
|
||||
|
||||
#include <linux/bitfield.h>
|
||||
+#include <linux/clk.h>
|
||||
#include <linux/clk-provider.h>
|
||||
#include <linux/clkdev.h>
|
||||
#include <linux/clk/at91_pmc.h>
|
||||
@@ -47,12 +48,15 @@ struct sam9x60_div {
|
||||
struct sam9x60_pll_core core;
|
||||
struct at91_clk_pms pms;
|
||||
u8 div;
|
||||
+ u8 safe_div;
|
||||
};
|
||||
|
||||
#define to_sam9x60_pll_core(hw) container_of(hw, struct sam9x60_pll_core, hw)
|
||||
#define to_sam9x60_frac(core) container_of(core, struct sam9x60_frac, core)
|
||||
#define to_sam9x60_div(core) container_of(core, struct sam9x60_div, core)
|
||||
|
||||
+static struct sam9x60_div *notifier_div;
|
||||
+
|
||||
static inline bool sam9x60_pll_ready(struct regmap *regmap, int id)
|
||||
{
|
||||
unsigned int status;
|
||||
@@ -329,6 +333,26 @@ static const struct clk_ops sam9x60_frac
|
||||
.restore_context = sam9x60_frac_pll_restore_context,
|
||||
};
|
||||
|
||||
+/* This function should be called with spinlock acquired. */
|
||||
+static void sam9x60_div_pll_set_div(struct sam9x60_pll_core *core, u32 div,
|
||||
+ bool enable)
|
||||
+{
|
||||
+ struct regmap *regmap = core->regmap;
|
||||
+ u32 ena_msk = enable ? core->layout->endiv_mask : 0;
|
||||
+ u32 ena_val = enable ? (1 << core->layout->endiv_shift) : 0;
|
||||
+
|
||||
+ regmap_update_bits(regmap, AT91_PMC_PLL_CTRL0,
|
||||
+ core->layout->div_mask | ena_msk,
|
||||
+ (div << core->layout->div_shift) | ena_val);
|
||||
+
|
||||
+ regmap_update_bits(regmap, AT91_PMC_PLL_UPDT,
|
||||
+ AT91_PMC_PLL_UPDT_UPDATE | AT91_PMC_PLL_UPDT_ID_MSK,
|
||||
+ AT91_PMC_PLL_UPDT_UPDATE | core->id);
|
||||
+
|
||||
+ while (!sam9x60_pll_ready(regmap, core->id))
|
||||
+ cpu_relax();
|
||||
+}
|
||||
+
|
||||
static int sam9x60_div_pll_set(struct sam9x60_pll_core *core)
|
||||
{
|
||||
struct sam9x60_div *div = to_sam9x60_div(core);
|
||||
@@ -346,17 +370,7 @@ static int sam9x60_div_pll_set(struct sa
|
||||
if (!!(val & core->layout->endiv_mask) && cdiv == div->div)
|
||||
goto unlock;
|
||||
|
||||
- regmap_update_bits(regmap, AT91_PMC_PLL_CTRL0,
|
||||
- core->layout->div_mask | core->layout->endiv_mask,
|
||||
- (div->div << core->layout->div_shift) |
|
||||
- (1 << core->layout->endiv_shift));
|
||||
-
|
||||
- regmap_update_bits(regmap, AT91_PMC_PLL_UPDT,
|
||||
- AT91_PMC_PLL_UPDT_UPDATE | AT91_PMC_PLL_UPDT_ID_MSK,
|
||||
- AT91_PMC_PLL_UPDT_UPDATE | core->id);
|
||||
-
|
||||
- while (!sam9x60_pll_ready(regmap, core->id))
|
||||
- cpu_relax();
|
||||
+ sam9x60_div_pll_set_div(core, div->div, 1);
|
||||
|
||||
unlock:
|
||||
spin_unlock_irqrestore(core->lock, flags);
|
||||
@@ -502,16 +516,7 @@ static int sam9x60_div_pll_set_rate_chg(
|
||||
if (cdiv == div->div)
|
||||
goto unlock;
|
||||
|
||||
- regmap_update_bits(regmap, AT91_PMC_PLL_CTRL0,
|
||||
- core->layout->div_mask,
|
||||
- (div->div << core->layout->div_shift));
|
||||
-
|
||||
- regmap_update_bits(regmap, AT91_PMC_PLL_UPDT,
|
||||
- AT91_PMC_PLL_UPDT_UPDATE | AT91_PMC_PLL_UPDT_ID_MSK,
|
||||
- AT91_PMC_PLL_UPDT_UPDATE | core->id);
|
||||
-
|
||||
- while (!sam9x60_pll_ready(regmap, core->id))
|
||||
- cpu_relax();
|
||||
+ sam9x60_div_pll_set_div(core, div->div, 0);
|
||||
|
||||
unlock:
|
||||
spin_unlock_irqrestore(core->lock, irqflags);
|
||||
@@ -538,6 +543,48 @@ static void sam9x60_div_pll_restore_cont
|
||||
sam9x60_div_pll_set(core);
|
||||
}
|
||||
|
||||
+static int sam9x60_div_pll_notifier_fn(struct notifier_block *notifier,
|
||||
+ unsigned long code, void *data)
|
||||
+{
|
||||
+ struct sam9x60_div *div = notifier_div;
|
||||
+ struct sam9x60_pll_core core = div->core;
|
||||
+ struct regmap *regmap = core.regmap;
|
||||
+ unsigned long irqflags;
|
||||
+ u32 val, cdiv;
|
||||
+ int ret = NOTIFY_DONE;
|
||||
+
|
||||
+ if (code != PRE_RATE_CHANGE)
|
||||
+ return ret;
|
||||
+
|
||||
+ /*
|
||||
+ * We switch to safe divider to avoid overclocking of other domains
|
||||
+ * feed by us while the frac PLL (our parent) is changed.
|
||||
+ */
|
||||
+ div->div = div->safe_div;
|
||||
+
|
||||
+ spin_lock_irqsave(core.lock, irqflags);
|
||||
+ regmap_update_bits(regmap, AT91_PMC_PLL_UPDT, AT91_PMC_PLL_UPDT_ID_MSK,
|
||||
+ core.id);
|
||||
+ regmap_read(regmap, AT91_PMC_PLL_CTRL0, &val);
|
||||
+ cdiv = (val & core.layout->div_mask) >> core.layout->div_shift;
|
||||
+
|
||||
+ /* Stop if nothing changed. */
|
||||
+ if (cdiv == div->safe_div)
|
||||
+ goto unlock;
|
||||
+
|
||||
+ sam9x60_div_pll_set_div(&core, div->div, 0);
|
||||
+ ret = NOTIFY_OK;
|
||||
+
|
||||
+unlock:
|
||||
+ spin_unlock_irqrestore(core.lock, irqflags);
|
||||
+
|
||||
+ return ret;
|
||||
+}
|
||||
+
|
||||
+static struct notifier_block sam9x60_div_pll_notifier = {
|
||||
+ .notifier_call = sam9x60_div_pll_notifier_fn,
|
||||
+};
|
||||
+
|
||||
static const struct clk_ops sam9x60_div_pll_ops = {
|
||||
.prepare = sam9x60_div_pll_prepare,
|
||||
.unprepare = sam9x60_div_pll_unprepare,
|
||||
@@ -647,7 +694,8 @@ struct clk_hw * __init
|
||||
sam9x60_clk_register_div_pll(struct regmap *regmap, spinlock_t *lock,
|
||||
const char *name, const char *parent_name, u8 id,
|
||||
const struct clk_pll_characteristics *characteristics,
|
||||
- const struct clk_pll_layout *layout, u32 flags)
|
||||
+ const struct clk_pll_layout *layout, u32 flags,
|
||||
+ u32 safe_div)
|
||||
{
|
||||
struct sam9x60_div *div;
|
||||
struct clk_hw *hw;
|
||||
@@ -656,9 +704,13 @@ sam9x60_clk_register_div_pll(struct regm
|
||||
unsigned int val;
|
||||
int ret;
|
||||
|
||||
- if (id > PLL_MAX_ID || !lock)
|
||||
+ /* We only support one changeable PLL. */
|
||||
+ if (id > PLL_MAX_ID || !lock || (safe_div && notifier_div))
|
||||
return ERR_PTR(-EINVAL);
|
||||
|
||||
+ if (safe_div >= PLL_DIV_MAX)
|
||||
+ safe_div = PLL_DIV_MAX - 1;
|
||||
+
|
||||
div = kzalloc(sizeof(*div), GFP_KERNEL);
|
||||
if (!div)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
@@ -678,6 +730,7 @@ sam9x60_clk_register_div_pll(struct regm
|
||||
div->core.layout = layout;
|
||||
div->core.regmap = regmap;
|
||||
div->core.lock = lock;
|
||||
+ div->safe_div = safe_div;
|
||||
|
||||
spin_lock_irqsave(div->core.lock, irqflags);
|
||||
|
||||
@@ -693,6 +746,9 @@ sam9x60_clk_register_div_pll(struct regm
|
||||
if (ret) {
|
||||
kfree(div);
|
||||
hw = ERR_PTR(ret);
|
||||
+ } else if (div->safe_div) {
|
||||
+ notifier_div = div;
|
||||
+ clk_notifier_register(hw->clk, &sam9x60_div_pll_notifier);
|
||||
}
|
||||
|
||||
return hw;
|
||||
--- a/drivers/clk/at91/pmc.h
|
||||
+++ b/drivers/clk/at91/pmc.h
|
||||
@@ -214,7 +214,8 @@ struct clk_hw * __init
|
||||
sam9x60_clk_register_div_pll(struct regmap *regmap, spinlock_t *lock,
|
||||
const char *name, const char *parent_name, u8 id,
|
||||
const struct clk_pll_characteristics *characteristics,
|
||||
- const struct clk_pll_layout *layout, u32 flags);
|
||||
+ const struct clk_pll_layout *layout, u32 flags,
|
||||
+ u32 safe_div);
|
||||
|
||||
struct clk_hw * __init
|
||||
sam9x60_clk_register_frac_pll(struct regmap *regmap, spinlock_t *lock,
|
||||
--- a/drivers/clk/at91/sam9x60.c
|
||||
+++ b/drivers/clk/at91/sam9x60.c
|
||||
@@ -242,7 +242,7 @@ static void __init sam9x60_pmc_setup(str
|
||||
* This feeds CPU. It should not
|
||||
* be disabled.
|
||||
*/
|
||||
- CLK_IS_CRITICAL | CLK_SET_RATE_GATE);
|
||||
+ CLK_IS_CRITICAL | CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
@@ -260,7 +260,7 @@ static void __init sam9x60_pmc_setup(str
|
||||
&pll_div_layout,
|
||||
CLK_SET_RATE_GATE |
|
||||
CLK_SET_PARENT_GATE |
|
||||
- CLK_SET_RATE_PARENT);
|
||||
+ CLK_SET_RATE_PARENT, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
@@ -279,7 +279,7 @@ static void __init sam9x60_pmc_setup(str
|
||||
hw = at91_clk_register_master_div(regmap, "masterck_div",
|
||||
"masterck_pres", &sam9x60_master_layout,
|
||||
&mck_characteristics, &mck_lock,
|
||||
- CLK_SET_RATE_GATE);
|
||||
+ CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
--- a/drivers/clk/at91/sama7g5.c
|
||||
+++ b/drivers/clk/at91/sama7g5.c
|
||||
@@ -127,6 +127,8 @@ static const struct clk_pll_characterist
|
||||
* @t: clock type
|
||||
* @f: clock flags
|
||||
* @eid: export index in sama7g5->chws[] array
|
||||
+ * @safe_div: intermediate divider need to be set on PRE_RATE_CHANGE
|
||||
+ * notification
|
||||
*/
|
||||
static const struct {
|
||||
const char *n;
|
||||
@@ -136,6 +138,7 @@ static const struct {
|
||||
unsigned long f;
|
||||
u8 t;
|
||||
u8 eid;
|
||||
+ u8 safe_div;
|
||||
} sama7g5_plls[][PLL_ID_MAX] = {
|
||||
[PLL_ID_CPU] = {
|
||||
{ .n = "cpupll_fracck",
|
||||
@@ -156,7 +159,12 @@ static const struct {
|
||||
.t = PLL_TYPE_DIV,
|
||||
/* This feeds CPU. It should not be disabled. */
|
||||
.f = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT,
|
||||
- .eid = PMC_CPUPLL, },
|
||||
+ .eid = PMC_CPUPLL,
|
||||
+ /*
|
||||
+ * Safe div=15 should be safe even for switching b/w 1GHz and
|
||||
+ * 90MHz (frac pll might go up to 1.2GHz).
|
||||
+ */
|
||||
+ .safe_div = 15, },
|
||||
},
|
||||
|
||||
[PLL_ID_SYS] = {
|
||||
@@ -966,7 +974,8 @@ static void __init sama7g5_pmc_setup(str
|
||||
sama7g5_plls[i][j].p, i,
|
||||
sama7g5_plls[i][j].c,
|
||||
sama7g5_plls[i][j].l,
|
||||
- sama7g5_plls[i][j].f);
|
||||
+ sama7g5_plls[i][j].f,
|
||||
+ sama7g5_plls[i][j].safe_div);
|
||||
break;
|
||||
|
||||
default:
|
@ -1,519 +0,0 @@
|
||||
From 75d5d1d584ae73ba0c36d1d7255db6153ca4d3f3 Mon Sep 17 00:00:00 2001
|
||||
From: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Date: Mon, 11 Oct 2021 14:27:16 +0300
|
||||
Subject: [PATCH 244/247] clk: at91: clk-master: add notifier for divider
|
||||
|
||||
SAMA7G5 supports DVFS by changing cpuck. On SAMA7G5 mck0 shares the same
|
||||
parent with cpuck as seen in the following clock tree:
|
||||
|
||||
+----------> cpuck
|
||||
|
|
||||
FRAC PLL ---> DIV PLL -+-> DIV ---> mck0
|
||||
|
||||
mck0 could go b/w 32KHz and 200MHz on SAMA7G5. To avoid mck0 overclocking
|
||||
while changing FRAC PLL or DIV PLL the commit implements a notifier for
|
||||
mck0 which applies a safe divider to register (maximum value of the divider
|
||||
which is 5) on PRE_RATE_CHANGE events (such that changes on PLL to not
|
||||
overclock mck0) and sets the maximum allowed rate on POST_RATE_CHANGE
|
||||
events.
|
||||
|
||||
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Link: https://lore.kernel.org/r/20211011112719.3951784-13-claudiu.beznea@microchip.com
|
||||
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
|
||||
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
|
||||
---
|
||||
drivers/clk/at91/at91rm9200.c | 2 +-
|
||||
drivers/clk/at91/at91sam9260.c | 2 +-
|
||||
drivers/clk/at91/at91sam9g45.c | 2 +-
|
||||
drivers/clk/at91/at91sam9n12.c | 2 +-
|
||||
drivers/clk/at91/at91sam9rl.c | 2 +-
|
||||
drivers/clk/at91/at91sam9x5.c | 2 +-
|
||||
drivers/clk/at91/clk-master.c | 244 +++++++++++++++++++++++----------
|
||||
drivers/clk/at91/dt-compat.c | 2 +-
|
||||
drivers/clk/at91/pmc.h | 2 +-
|
||||
drivers/clk/at91/sama5d2.c | 2 +-
|
||||
drivers/clk/at91/sama5d3.c | 2 +-
|
||||
drivers/clk/at91/sama5d4.c | 2 +-
|
||||
drivers/clk/at91/sama7g5.c | 2 +-
|
||||
13 files changed, 186 insertions(+), 82 deletions(-)
|
||||
|
||||
--- a/drivers/clk/at91/at91rm9200.c
|
||||
+++ b/drivers/clk/at91/at91rm9200.c
|
||||
@@ -152,7 +152,7 @@ static void __init at91rm9200_pmc_setup(
|
||||
"masterck_pres",
|
||||
&at91rm9200_master_layout,
|
||||
&rm9200_mck_characteristics,
|
||||
- &rm9200_mck_lock, CLK_SET_RATE_GATE);
|
||||
+ &rm9200_mck_lock, CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
--- a/drivers/clk/at91/at91sam9260.c
|
||||
+++ b/drivers/clk/at91/at91sam9260.c
|
||||
@@ -429,7 +429,7 @@ static void __init at91sam926x_pmc_setup
|
||||
&at91rm9200_master_layout,
|
||||
data->mck_characteristics,
|
||||
&at91sam9260_mck_lock,
|
||||
- CLK_SET_RATE_GATE);
|
||||
+ CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
--- a/drivers/clk/at91/at91sam9g45.c
|
||||
+++ b/drivers/clk/at91/at91sam9g45.c
|
||||
@@ -164,7 +164,7 @@ static void __init at91sam9g45_pmc_setup
|
||||
&at91rm9200_master_layout,
|
||||
&mck_characteristics,
|
||||
&at91sam9g45_mck_lock,
|
||||
- CLK_SET_RATE_GATE);
|
||||
+ CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
--- a/drivers/clk/at91/at91sam9n12.c
|
||||
+++ b/drivers/clk/at91/at91sam9n12.c
|
||||
@@ -191,7 +191,7 @@ static void __init at91sam9n12_pmc_setup
|
||||
&at91sam9x5_master_layout,
|
||||
&mck_characteristics,
|
||||
&at91sam9n12_mck_lock,
|
||||
- CLK_SET_RATE_GATE);
|
||||
+ CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
--- a/drivers/clk/at91/at91sam9rl.c
|
||||
+++ b/drivers/clk/at91/at91sam9rl.c
|
||||
@@ -132,7 +132,7 @@ static void __init at91sam9rl_pmc_setup(
|
||||
"masterck_pres",
|
||||
&at91rm9200_master_layout,
|
||||
&sam9rl_mck_characteristics,
|
||||
- &sam9rl_mck_lock, CLK_SET_RATE_GATE);
|
||||
+ &sam9rl_mck_lock, CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
--- a/drivers/clk/at91/at91sam9x5.c
|
||||
+++ b/drivers/clk/at91/at91sam9x5.c
|
||||
@@ -210,7 +210,7 @@ static void __init at91sam9x5_pmc_setup(
|
||||
"masterck_pres",
|
||||
&at91sam9x5_master_layout,
|
||||
&mck_characteristics, &mck_lock,
|
||||
- CLK_SET_RATE_GATE);
|
||||
+ CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
--- a/drivers/clk/at91/clk-master.c
|
||||
+++ b/drivers/clk/at91/clk-master.c
|
||||
@@ -5,6 +5,7 @@
|
||||
|
||||
#include <linux/clk-provider.h>
|
||||
#include <linux/clkdev.h>
|
||||
+#include <linux/clk.h>
|
||||
#include <linux/clk/at91_pmc.h>
|
||||
#include <linux/of.h>
|
||||
#include <linux/mfd/syscon.h>
|
||||
@@ -36,8 +37,12 @@ struct clk_master {
|
||||
u8 id;
|
||||
u8 parent;
|
||||
u8 div;
|
||||
+ u32 safe_div;
|
||||
};
|
||||
|
||||
+/* MCK div reference to be used by notifier. */
|
||||
+static struct clk_master *master_div;
|
||||
+
|
||||
static inline bool clk_master_ready(struct clk_master *master)
|
||||
{
|
||||
unsigned int bit = master->id ? AT91_PMC_MCKXRDY : AT91_PMC_MCKRDY;
|
||||
@@ -153,107 +158,81 @@ static const struct clk_ops master_div_o
|
||||
.restore_context = clk_master_div_restore_context,
|
||||
};
|
||||
|
||||
-static int clk_master_div_set_rate(struct clk_hw *hw, unsigned long rate,
|
||||
- unsigned long parent_rate)
|
||||
+/* This function must be called with lock acquired. */
|
||||
+static int clk_master_div_set(struct clk_master *master,
|
||||
+ unsigned long parent_rate, int div)
|
||||
{
|
||||
- struct clk_master *master = to_clk_master(hw);
|
||||
const struct clk_master_characteristics *characteristics =
|
||||
master->characteristics;
|
||||
- unsigned long flags;
|
||||
- unsigned int mckr, tmp;
|
||||
- int div, i;
|
||||
+ unsigned long rate = parent_rate;
|
||||
+ unsigned int max_div = 0, div_index = 0, max_div_index = 0;
|
||||
+ unsigned int i, mckr, tmp;
|
||||
int ret;
|
||||
|
||||
- div = DIV_ROUND_CLOSEST(parent_rate, rate);
|
||||
- if (div > ARRAY_SIZE(characteristics->divisors))
|
||||
- return -EINVAL;
|
||||
-
|
||||
for (i = 0; i < ARRAY_SIZE(characteristics->divisors); i++) {
|
||||
if (!characteristics->divisors[i])
|
||||
break;
|
||||
|
||||
- if (div == characteristics->divisors[i]) {
|
||||
- div = i;
|
||||
- break;
|
||||
+ if (div == characteristics->divisors[i])
|
||||
+ div_index = i;
|
||||
+
|
||||
+ if (max_div < characteristics->divisors[i]) {
|
||||
+ max_div = characteristics->divisors[i];
|
||||
+ max_div_index = i;
|
||||
}
|
||||
}
|
||||
|
||||
- if (i == ARRAY_SIZE(characteristics->divisors))
|
||||
- return -EINVAL;
|
||||
+ if (div > max_div)
|
||||
+ div_index = max_div_index;
|
||||
|
||||
- spin_lock_irqsave(master->lock, flags);
|
||||
ret = regmap_read(master->regmap, master->layout->offset, &mckr);
|
||||
if (ret)
|
||||
- goto unlock;
|
||||
+ return ret;
|
||||
|
||||
mckr &= master->layout->mask;
|
||||
tmp = (mckr >> MASTER_DIV_SHIFT) & MASTER_DIV_MASK;
|
||||
- if (tmp == div)
|
||||
- goto unlock;
|
||||
+ if (tmp == div_index)
|
||||
+ return 0;
|
||||
+
|
||||
+ rate /= characteristics->divisors[div_index];
|
||||
+ if (rate < characteristics->output.min)
|
||||
+ pr_warn("master clk div is underclocked");
|
||||
+ else if (rate > characteristics->output.max)
|
||||
+ pr_warn("master clk div is overclocked");
|
||||
|
||||
mckr &= ~(MASTER_DIV_MASK << MASTER_DIV_SHIFT);
|
||||
- mckr |= (div << MASTER_DIV_SHIFT);
|
||||
+ mckr |= (div_index << MASTER_DIV_SHIFT);
|
||||
ret = regmap_write(master->regmap, master->layout->offset, mckr);
|
||||
if (ret)
|
||||
- goto unlock;
|
||||
+ return ret;
|
||||
|
||||
while (!clk_master_ready(master))
|
||||
cpu_relax();
|
||||
-unlock:
|
||||
- spin_unlock_irqrestore(master->lock, flags);
|
||||
+
|
||||
+ master->div = characteristics->divisors[div_index];
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
-static int clk_master_div_determine_rate(struct clk_hw *hw,
|
||||
- struct clk_rate_request *req)
|
||||
+static unsigned long clk_master_div_recalc_rate_chg(struct clk_hw *hw,
|
||||
+ unsigned long parent_rate)
|
||||
{
|
||||
struct clk_master *master = to_clk_master(hw);
|
||||
- const struct clk_master_characteristics *characteristics =
|
||||
- master->characteristics;
|
||||
- struct clk_hw *parent;
|
||||
- unsigned long parent_rate, tmp_rate, best_rate = 0;
|
||||
- int i, best_diff = INT_MIN, tmp_diff;
|
||||
-
|
||||
- parent = clk_hw_get_parent(hw);
|
||||
- if (!parent)
|
||||
- return -EINVAL;
|
||||
-
|
||||
- parent_rate = clk_hw_get_rate(parent);
|
||||
- if (!parent_rate)
|
||||
- return -EINVAL;
|
||||
|
||||
- for (i = 0; i < ARRAY_SIZE(characteristics->divisors); i++) {
|
||||
- if (!characteristics->divisors[i])
|
||||
- break;
|
||||
-
|
||||
- tmp_rate = DIV_ROUND_CLOSEST_ULL(parent_rate,
|
||||
- characteristics->divisors[i]);
|
||||
- tmp_diff = abs(tmp_rate - req->rate);
|
||||
-
|
||||
- if (!best_rate || best_diff > tmp_diff) {
|
||||
- best_diff = tmp_diff;
|
||||
- best_rate = tmp_rate;
|
||||
- }
|
||||
-
|
||||
- if (!best_diff)
|
||||
- break;
|
||||
- }
|
||||
-
|
||||
- req->best_parent_rate = best_rate;
|
||||
- req->best_parent_hw = parent;
|
||||
- req->rate = best_rate;
|
||||
-
|
||||
- return 0;
|
||||
+ return DIV_ROUND_CLOSEST_ULL(parent_rate, master->div);
|
||||
}
|
||||
|
||||
static void clk_master_div_restore_context_chg(struct clk_hw *hw)
|
||||
{
|
||||
struct clk_master *master = to_clk_master(hw);
|
||||
+ unsigned long flags;
|
||||
int ret;
|
||||
|
||||
- ret = clk_master_div_set_rate(hw, master->pms.rate,
|
||||
- master->pms.parent_rate);
|
||||
+ spin_lock_irqsave(master->lock, flags);
|
||||
+ ret = clk_master_div_set(master, master->pms.parent_rate,
|
||||
+ DIV_ROUND_CLOSEST(master->pms.parent_rate,
|
||||
+ master->pms.rate));
|
||||
+ spin_unlock_irqrestore(master->lock, flags);
|
||||
if (ret)
|
||||
pr_warn("Failed to restore MCK DIV clock\n");
|
||||
}
|
||||
@@ -261,13 +240,116 @@ static void clk_master_div_restore_conte
|
||||
static const struct clk_ops master_div_ops_chg = {
|
||||
.prepare = clk_master_prepare,
|
||||
.is_prepared = clk_master_is_prepared,
|
||||
- .recalc_rate = clk_master_div_recalc_rate,
|
||||
- .determine_rate = clk_master_div_determine_rate,
|
||||
- .set_rate = clk_master_div_set_rate,
|
||||
+ .recalc_rate = clk_master_div_recalc_rate_chg,
|
||||
.save_context = clk_master_div_save_context,
|
||||
.restore_context = clk_master_div_restore_context_chg,
|
||||
};
|
||||
|
||||
+static int clk_master_div_notifier_fn(struct notifier_block *notifier,
|
||||
+ unsigned long code, void *data)
|
||||
+{
|
||||
+ const struct clk_master_characteristics *characteristics =
|
||||
+ master_div->characteristics;
|
||||
+ struct clk_notifier_data *cnd = data;
|
||||
+ unsigned long flags, new_parent_rate, new_rate;
|
||||
+ unsigned int mckr, div, new_div = 0;
|
||||
+ int ret, i;
|
||||
+ long tmp_diff;
|
||||
+ long best_diff = -1;
|
||||
+
|
||||
+ spin_lock_irqsave(master_div->lock, flags);
|
||||
+ switch (code) {
|
||||
+ case PRE_RATE_CHANGE:
|
||||
+ /*
|
||||
+ * We want to avoid any overclocking of MCK DIV domain. To do
|
||||
+ * this we set a safe divider (the underclocking is not of
|
||||
+ * interest as we can go as low as 32KHz). The relation
|
||||
+ * b/w this clock and its parents are as follows:
|
||||
+ *
|
||||
+ * FRAC PLL -> DIV PLL -> MCK DIV
|
||||
+ *
|
||||
+ * With the proper safe divider we should be good even with FRAC
|
||||
+ * PLL at its maximum value.
|
||||
+ */
|
||||
+ ret = regmap_read(master_div->regmap, master_div->layout->offset,
|
||||
+ &mckr);
|
||||
+ if (ret) {
|
||||
+ ret = NOTIFY_STOP_MASK;
|
||||
+ goto unlock;
|
||||
+ }
|
||||
+
|
||||
+ mckr &= master_div->layout->mask;
|
||||
+ div = (mckr >> MASTER_DIV_SHIFT) & MASTER_DIV_MASK;
|
||||
+
|
||||
+ /* Switch to safe divider. */
|
||||
+ clk_master_div_set(master_div,
|
||||
+ cnd->old_rate * characteristics->divisors[div],
|
||||
+ master_div->safe_div);
|
||||
+ break;
|
||||
+
|
||||
+ case POST_RATE_CHANGE:
|
||||
+ /*
|
||||
+ * At this point we want to restore MCK DIV domain to its maximum
|
||||
+ * allowed rate.
|
||||
+ */
|
||||
+ ret = regmap_read(master_div->regmap, master_div->layout->offset,
|
||||
+ &mckr);
|
||||
+ if (ret) {
|
||||
+ ret = NOTIFY_STOP_MASK;
|
||||
+ goto unlock;
|
||||
+ }
|
||||
+
|
||||
+ mckr &= master_div->layout->mask;
|
||||
+ div = (mckr >> MASTER_DIV_SHIFT) & MASTER_DIV_MASK;
|
||||
+ new_parent_rate = cnd->new_rate * characteristics->divisors[div];
|
||||
+
|
||||
+ for (i = 0; i < ARRAY_SIZE(characteristics->divisors); i++) {
|
||||
+ if (!characteristics->divisors[i])
|
||||
+ break;
|
||||
+
|
||||
+ new_rate = DIV_ROUND_CLOSEST_ULL(new_parent_rate,
|
||||
+ characteristics->divisors[i]);
|
||||
+
|
||||
+ tmp_diff = characteristics->output.max - new_rate;
|
||||
+ if (tmp_diff < 0)
|
||||
+ continue;
|
||||
+
|
||||
+ if (best_diff < 0 || best_diff > tmp_diff) {
|
||||
+ new_div = characteristics->divisors[i];
|
||||
+ best_diff = tmp_diff;
|
||||
+ }
|
||||
+
|
||||
+ if (!tmp_diff)
|
||||
+ break;
|
||||
+ }
|
||||
+
|
||||
+ if (!new_div) {
|
||||
+ ret = NOTIFY_STOP_MASK;
|
||||
+ goto unlock;
|
||||
+ }
|
||||
+
|
||||
+ /* Update the div to preserve MCK DIV clock rate. */
|
||||
+ clk_master_div_set(master_div, new_parent_rate,
|
||||
+ new_div);
|
||||
+
|
||||
+ ret = NOTIFY_OK;
|
||||
+ break;
|
||||
+
|
||||
+ default:
|
||||
+ ret = NOTIFY_DONE;
|
||||
+ break;
|
||||
+ }
|
||||
+
|
||||
+unlock:
|
||||
+ spin_unlock_irqrestore(master_div->lock, flags);
|
||||
+
|
||||
+ return ret;
|
||||
+}
|
||||
+
|
||||
+static struct notifier_block clk_master_div_notifier = {
|
||||
+ .notifier_call = clk_master_div_notifier_fn,
|
||||
+};
|
||||
+
|
||||
static void clk_sama7g5_master_best_diff(struct clk_rate_request *req,
|
||||
struct clk_hw *parent,
|
||||
unsigned long parent_rate,
|
||||
@@ -496,6 +578,8 @@ at91_clk_register_master_internal(struct
|
||||
struct clk_master *master;
|
||||
struct clk_init_data init;
|
||||
struct clk_hw *hw;
|
||||
+ unsigned int mckr;
|
||||
+ unsigned long irqflags;
|
||||
int ret;
|
||||
|
||||
if (!name || !num_parents || !parent_names || !lock)
|
||||
@@ -518,6 +602,16 @@ at91_clk_register_master_internal(struct
|
||||
master->chg_pid = chg_pid;
|
||||
master->lock = lock;
|
||||
|
||||
+ if (ops == &master_div_ops_chg) {
|
||||
+ spin_lock_irqsave(master->lock, irqflags);
|
||||
+ regmap_read(master->regmap, master->layout->offset, &mckr);
|
||||
+ spin_unlock_irqrestore(master->lock, irqflags);
|
||||
+
|
||||
+ mckr &= layout->mask;
|
||||
+ mckr = (mckr >> MASTER_DIV_SHIFT) & MASTER_DIV_MASK;
|
||||
+ master->div = characteristics->divisors[mckr];
|
||||
+ }
|
||||
+
|
||||
hw = &master->hw;
|
||||
ret = clk_hw_register(NULL, &master->hw);
|
||||
if (ret) {
|
||||
@@ -554,19 +648,29 @@ at91_clk_register_master_div(struct regm
|
||||
const char *name, const char *parent_name,
|
||||
const struct clk_master_layout *layout,
|
||||
const struct clk_master_characteristics *characteristics,
|
||||
- spinlock_t *lock, u32 flags)
|
||||
+ spinlock_t *lock, u32 flags, u32 safe_div)
|
||||
{
|
||||
const struct clk_ops *ops;
|
||||
+ struct clk_hw *hw;
|
||||
|
||||
if (flags & CLK_SET_RATE_GATE)
|
||||
ops = &master_div_ops;
|
||||
else
|
||||
ops = &master_div_ops_chg;
|
||||
|
||||
- return at91_clk_register_master_internal(regmap, name, 1,
|
||||
- &parent_name, layout,
|
||||
- characteristics, ops,
|
||||
- lock, flags, -EINVAL);
|
||||
+ hw = at91_clk_register_master_internal(regmap, name, 1,
|
||||
+ &parent_name, layout,
|
||||
+ characteristics, ops,
|
||||
+ lock, flags, -EINVAL);
|
||||
+
|
||||
+ if (!IS_ERR(hw) && safe_div) {
|
||||
+ master_div = to_clk_master(hw);
|
||||
+ master_div->safe_div = safe_div;
|
||||
+ clk_notifier_register(hw->clk,
|
||||
+ &clk_master_div_notifier);
|
||||
+ }
|
||||
+
|
||||
+ return hw;
|
||||
}
|
||||
|
||||
static unsigned long
|
||||
--- a/drivers/clk/at91/dt-compat.c
|
||||
+++ b/drivers/clk/at91/dt-compat.c
|
||||
@@ -399,7 +399,7 @@ of_at91_clk_master_setup(struct device_n
|
||||
|
||||
hw = at91_clk_register_master_div(regmap, name, "masterck_pres",
|
||||
layout, characteristics,
|
||||
- &mck_lock, CLK_SET_RATE_GATE);
|
||||
+ &mck_lock, CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto out_free_characteristics;
|
||||
|
||||
--- a/drivers/clk/at91/pmc.h
|
||||
+++ b/drivers/clk/at91/pmc.h
|
||||
@@ -182,7 +182,7 @@ at91_clk_register_master_div(struct regm
|
||||
const char *parent_names,
|
||||
const struct clk_master_layout *layout,
|
||||
const struct clk_master_characteristics *characteristics,
|
||||
- spinlock_t *lock, u32 flags);
|
||||
+ spinlock_t *lock, u32 flags, u32 safe_div);
|
||||
|
||||
struct clk_hw * __init
|
||||
at91_clk_sama7g5_register_master(struct regmap *regmap,
|
||||
--- a/drivers/clk/at91/sama5d2.c
|
||||
+++ b/drivers/clk/at91/sama5d2.c
|
||||
@@ -249,7 +249,7 @@ static void __init sama5d2_pmc_setup(str
|
||||
"masterck_pres",
|
||||
&at91sam9x5_master_layout,
|
||||
&mck_characteristics, &mck_lock,
|
||||
- CLK_SET_RATE_GATE);
|
||||
+ CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
--- a/drivers/clk/at91/sama5d3.c
|
||||
+++ b/drivers/clk/at91/sama5d3.c
|
||||
@@ -184,7 +184,7 @@ static void __init sama5d3_pmc_setup(str
|
||||
"masterck_pres",
|
||||
&at91sam9x5_master_layout,
|
||||
&mck_characteristics, &mck_lock,
|
||||
- CLK_SET_RATE_GATE);
|
||||
+ CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
--- a/drivers/clk/at91/sama5d4.c
|
||||
+++ b/drivers/clk/at91/sama5d4.c
|
||||
@@ -199,7 +199,7 @@ static void __init sama5d4_pmc_setup(str
|
||||
"masterck_pres",
|
||||
&at91sam9x5_master_layout,
|
||||
&mck_characteristics, &mck_lock,
|
||||
- CLK_SET_RATE_GATE);
|
||||
+ CLK_SET_RATE_GATE, 0);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
||||
--- a/drivers/clk/at91/sama7g5.c
|
||||
+++ b/drivers/clk/at91/sama7g5.c
|
||||
@@ -993,7 +993,7 @@ static void __init sama7g5_pmc_setup(str
|
||||
parent_names[0] = "cpupll_divpmcck";
|
||||
hw = at91_clk_register_master_div(regmap, "mck0", "cpupll_divpmcck",
|
||||
&mck0_layout, &mck0_characteristics,
|
||||
- &pmc_mck0_lock, 0);
|
||||
+ &pmc_mck0_lock, CLK_GET_RATE_NOCACHE, 5);
|
||||
if (IS_ERR(hw))
|
||||
goto err_free;
|
||||
|
@ -1,26 +0,0 @@
|
||||
From 9fd5a49f6da9de5da83f4a53eccefad647ab15ed Mon Sep 17 00:00:00 2001
|
||||
From: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Date: Mon, 11 Oct 2021 14:27:18 +0300
|
||||
Subject: [PATCH 246/247] clk: at91: sama7g5: set low limit for mck0 at 32KHz
|
||||
|
||||
MCK0 could go as low as 32KHz. Set this limit.
|
||||
|
||||
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Link: https://lore.kernel.org/r/20211011112719.3951784-15-claudiu.beznea@microchip.com
|
||||
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
|
||||
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
|
||||
---
|
||||
drivers/clk/at91/sama7g5.c | 2 +-
|
||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||
|
||||
--- a/drivers/clk/at91/sama7g5.c
|
||||
+++ b/drivers/clk/at91/sama7g5.c
|
||||
@@ -849,7 +849,7 @@ static const struct {
|
||||
|
||||
/* MCK0 characteristics. */
|
||||
static const struct clk_master_characteristics mck0_characteristics = {
|
||||
- .output = { .min = 50000000, .max = 200000000 },
|
||||
+ .output = { .min = 32768, .max = 200000000 },
|
||||
.divisors = { 1, 2, 4, 3, 5 },
|
||||
.have_div3_pres = 1,
|
||||
};
|
@ -1,32 +0,0 @@
|
||||
From fe07791494a78d5a4be1363385e6ba7940740644 Mon Sep 17 00:00:00 2001
|
||||
From: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Date: Mon, 11 Oct 2021 14:27:19 +0300
|
||||
Subject: [PATCH 247/247] clk: use clk_core_get_rate_recalc() in clk_rate_get()
|
||||
|
||||
In case clock flags contains CLK_GET_RATE_NOCACHE the clk_rate_get()
|
||||
will return the cached rate. Thus, use clk_core_get_rate_recalc() which
|
||||
takes proper action when clock flags contains CLK_GET_RATE_NOCACHE.
|
||||
|
||||
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
|
||||
Link: https://lore.kernel.org/r/20211011112719.3951784-16-claudiu.beznea@microchip.com
|
||||
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
|
||||
[sboyd@kernel.org: Grab prepare lock around operation]
|
||||
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
|
||||
---
|
||||
drivers/clk/clk.c | 5 ++++-
|
||||
1 file changed, 4 insertions(+), 1 deletion(-)
|
||||
|
||||
--- a/drivers/clk/clk.c
|
||||
+++ b/drivers/clk/clk.c
|
||||
@@ -3145,7 +3145,10 @@ static int clk_rate_get(void *data, u64
|
||||
{
|
||||
struct clk_core *core = data;
|
||||
|
||||
- *val = core->rate;
|
||||
+ clk_prepare_lock();
|
||||
+ *val = clk_core_get_rate_recalc(core);
|
||||
+ clk_prepare_unlock();
|
||||
+
|
||||
return 0;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user