ExternalVendorCode/openwrt
1
0
Fork 0
mirror of https://github.com/openwrt/openwrt.git synced 2024-12-20 06:08:08 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

ar71xx/ag71xx_ar7240_get_port_link: fix off-by-one check on argument port

Browse Source 
Found-by: Coverity Scan #1329901
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
This commit is contained in:
Alexander Couzens 2017-06-11 12:43:24 +02:00
parent fd952c7a83
commit d18cb142d5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c
View File

@ -963,7 +963,7 @@ ar7240_get_port_link(struct switch_dev *dev, int port,
struct mii_bus *mii = as->mii_bus; struct mii_bus *mii = as->mii_bus;
u32 status; u32 status;
if (port > AR7240_NUM_PORTS) if (port >= AR7240_NUM_PORTS)
return -EINVAL; return -EINVAL;
status = ar7240sw_reg_read(mii, AR7240_REG_PORT_STATUS(port)); status = ar7240sw_reg_read(mii, AR7240_REG_PORT_STATUS(port));
@ -1000,7 +1000,7 @@ ar7240_get_port_stats(struct switch_dev *dev, int port,
{ {
struct ar7240sw *as = sw_to_ar7240(dev); struct ar7240sw *as = sw_to_ar7240(dev);
if (port > AR7240_NUM_PORTS) if (port >= AR7240_NUM_PORTS)
return -EINVAL; return -EINVAL;
ar7240sw_capture_stats(as); ar7240sw_capture_stats(as);