ExternalVendorCode/openwrt
1
0
Fork 0
mirror of https://github.com/openwrt/openwrt.git synced 2025-04-14 06:27:03 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

mediatek: cast literal value to char

Browse Source 
Or the comparison against a signed char is always true, because the
literal 0xaa is treated as an unsigned int, to which the signed char is
casted during comparison. 0xaa is above the positive values of a signed
char and negative signed char values result in values larger than 0xaa
when casted to unsigned int.

Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
(cherry picked from commit e9a22ce2535c4a0faf83d5595304fe0e2c7bd1b2)
This commit is contained in:
Sven Wegener 2021-06-12 21:56:21 +02:00 committed by Daniel Golle
parent a2d251573b
commit cd0283788f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
target/linux/mediatek/files-5.10/drivers/leds/leds-ubnt-ledbar.c
View File

@ -26,7 +26,7 @@
#define UBNT_LEDBAR_MAX_BRIGHTNESS 0xff
#define UBNT_LEDBAR_TRANSACTION_LENGTH 8
#define UBNT_LEDBAR_TRANSACTION_SUCCESS 0xaa
#define UBNT_LEDBAR_TRANSACTION_SUCCESS (char) 0xaa
#define UBNT_LEDBAR_TRANSACTION_BLUE_IDX 2
#define UBNT_LEDBAR_TRANSACTION_GREEN_IDX 3