mediatek: filogic: PHY LEDs do have an address, gpio-leds don't
Some checks are pending
Build Kernel / Build all affected Kernels (push) Waiting to run
Build all core packages / Build all core packages for selected target (push) Waiting to run

Other than GPIO LEDs, PHY LEDs do have an address.

Fix node names such that all gpio-leds do *not* contain an '@' sign and
PHY leds which do have an address also do contain the '@' sign.

This is done to prevent more copy&paste'ry of non-complaint DT
fragments.

Fixes: 7cbe34170e ("mediatek: add support for the GL.iNet GL-MT3000")
Fixes: fe10f97439 ("filogic: add support for GL.iNet GL-MT6000")
Fixes: e8f7597317 ("mediatek: filogic: add support for Cudy RE3000 v1")
Fixes: c9cb6411c1 ("mediatek: add support for Cudy WR3000 v1")
Fixes: 7560af7647 ("mediatek: filogic: migrate ASUS TUF AX6000 to upstream PHY LED control")
Fixes: 25ea7ff393 ("mediatek: filogic: migrate Acer W6/W6d to upstream PHY LED control")
Fixes: d50d51d74e ("mediatek: filogic: migrate Zyxel NWA50AX Pro to upstream PHY LED control")
Fixes: b88de5d507 ("mediatek: filogic: migrate Zyxel EX5700 to upstream PHY LED control")
Fixes: 63d56af6c6 ("mediatek: filogic: migrate Netgate N60 to upstream PHY LED control")
Fixes: fd76a38190 ("mediatek: filogic: migrate SmartRG Bonanza to upstream PHY LED control")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
This commit is contained in:
Daniel Golle 2025-03-21 01:04:39 +00:00
parent c1d5b9a26a
commit a51fd20e0d
11 changed files with 37 additions and 37 deletions

View File

@ -44,31 +44,31 @@
leds {
compatible = "gpio-leds";
led_status: led@0 {
led_status: led-0 {
function = LED_FUNCTION_STATUS;
color = <LED_COLOR_ID_WHITE>;
gpios = <&pio 10 GPIO_ACTIVE_LOW>;
};
led@1 {
led-1 {
label = "red:wifi5";
gpios = <&pio 7 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy1tpt";
};
led@2 {
led-2 {
label = "white:wifi2";
gpios = <&pio 6 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
led@3 {
led-3 {
function = LED_FUNCTION_LAN;
color = <LED_COLOR_ID_GREEN>;
gpios = <&pio 9 GPIO_ACTIVE_LOW>;
};
led@4 {
led-4 {
function = LED_FUNCTION_WPS;
color = <LED_COLOR_ID_WHITE>;
gpios = <&pio 11 GPIO_ACTIVE_LOW>;

View File

@ -42,36 +42,36 @@
leds {
compatible = "gpio-leds";
led_status: led@0 {
led_status: led-0 {
function = LED_FUNCTION_STATUS;
color = <LED_COLOR_ID_BLUE>;
gpios = <&pio 10 GPIO_ACTIVE_LOW>;
};
led@1 {
led-1 {
label = "blue:internet";
gpios = <&pio 11 GPIO_ACTIVE_LOW>;
};
led@2 {
led-2 {
function = LED_FUNCTION_WAN;
color = <LED_COLOR_ID_BLUE>;
gpios = <&pio 5 GPIO_ACTIVE_LOW>;
};
led@3 {
led-3 {
function = LED_FUNCTION_LAN;
color = <LED_COLOR_ID_BLUE>;
gpios = <&pio 9 GPIO_ACTIVE_LOW>;
};
led@4 {
led-4 {
label = "blue:wifi2";
gpios = <&pio 6 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy0tpt";
};
led@5 {
led-5 {
label = "blue:wifi5";
gpios = <&pio 7 GPIO_ACTIVE_LOW>;
linux,default-trigger = "phy1tpt";

View File

@ -40,12 +40,12 @@
leds {
compatible = "gpio-leds";
led_lightblue: led@0 {
led_lightblue: led-0 {
label = "blue:run";
gpios = <&pio 31 GPIO_ACTIVE_LOW>;
};
led_white: led@1 {
led_white: led-1 {
label = "white:system";
gpios = <&pio 30 GPIO_ACTIVE_LOW>;
};

View File

@ -33,17 +33,17 @@
leds {
compatible = "gpio-leds";
led_green: led@0 {
led_green: led-0 {
label = "green:system";
gpios = <&pio 4 GPIO_ACTIVE_HIGH>;
};
led@1 {
led-1 {
label = "blue:system";
gpios = <&pio 6 GPIO_ACTIVE_HIGH>;
};
led_red: led@2 {
led_red: led-2 {
label = "red:system";
gpios = <&pio 7 GPIO_ACTIVE_HIGH>;
};
@ -89,13 +89,13 @@
#address-cells = <1>;
#size-cells = <0>;
led-0 {
led@0 {
reg = <0>;
color = <LED_COLOR_ID_AMBER>;
function = LED_FUNCTION_WAN;
};
led-3 {
led@3 {
reg = <3>;
color = <LED_COLOR_ID_GREEN>;
function = LED_FUNCTION_WAN;

View File

@ -191,13 +191,13 @@
#address-cells = <1>;
#size-cells = <0>;
led-2 {
led@2 {
reg = <2>;
color = <LED_COLOR_ID_AMBER>;
function = LED_FUNCTION_WAN;
};
led-3 {
led@3 {
reg = <3>;
color = <LED_COLOR_ID_GREEN>;
function = LED_FUNCTION_WAN;

View File

@ -177,13 +177,13 @@
#address-cells = <1>;
#size-cells = <0>;
led-2 {
led@2 {
reg = <2>;
color = <LED_COLOR_ID_AMBER>;
function = LED_FUNCTION_WAN;
};
led-3 {
led@3 {
reg = <3>;
color = <LED_COLOR_ID_GREEN>;
function = LED_FUNCTION_WAN;

View File

@ -150,7 +150,7 @@
#address-cells = <1>;
#size-cells = <0>;
led-0 {
led@0 {
reg = <0>;
active-high;
color = <LED_COLOR_ID_WHITE>;
@ -167,7 +167,7 @@
#address-cells = <1>;
#size-cells = <0>;
led-0 {
led@0 {
reg = <0>;
color = <LED_COLOR_ID_WHITE>;
function = LED_FUNCTION_WAN;

View File

@ -56,12 +56,12 @@
leds {
compatible = "gpio-leds";
led_blue: led@0 {
led_blue: led-0 {
label = "blue:run";
gpios = <&pio 38 GPIO_ACTIVE_LOW>;
};
led_white: led@1 {
led_white: led-1 {
label = "white:system";
gpios = <&pio 37 GPIO_ACTIVE_LOW>;
};

View File

@ -114,7 +114,7 @@
#address-cells = <1>;
#size-cells = <0>;
led-3 {
led@3 {
reg = <3>;
color = <LED_COLOR_ID_GREEN>;
function = LED_FUNCTION_WAN;

View File

@ -224,14 +224,14 @@
#address-cells = <1>;
#size-cells = <0>;
led-0 {
led@0 {
reg = <0>;
active-high;
color = <LED_COLOR_ID_AMBER>;
function = LED_FUNCTION_LAN;
};
led-1 {
led@1 {
reg = <1>;
active-high;
color = <LED_COLOR_ID_GREEN>;
@ -239,7 +239,7 @@
function-enumerator = <0>;
};
led-2 {
led@2 {
reg = <2>;
active-high;
color = <LED_COLOR_ID_GREEN>;
@ -258,14 +258,14 @@
#address-cells = <1>;
#size-cells = <0>;
led-0 {
led@0 {
reg = <0>;
active-high;
color = <LED_COLOR_ID_AMBER>;
function = LED_FUNCTION_WAN;
};
led-1 {
led@1 {
reg = <1>;
active-high;
color = <LED_COLOR_ID_GREEN>;
@ -273,7 +273,7 @@
function-enumerator = <0>;
};
led-2 {
led@2 {
reg = <2>;
active-high;
color = <LED_COLOR_ID_GREEN>;

View File

@ -163,13 +163,13 @@
#address-cells = <1>;
#size-cells = <0>;
led-0 {
led@0 {
reg = <0>;
color = <LED_COLOR_ID_GREEN>;
function = LED_FUNCTION_LAN;
};
led-1 {
led@1 {
reg = <1>;
color = <LED_COLOR_ID_AMBER>;
function = LED_FUNCTION_LAN;
@ -185,13 +185,13 @@
#address-cells = <1>;
#size-cells = <0>;
led-0 {
led@0 {
reg = <0>;
color = <LED_COLOR_ID_GREEN>;
function = LED_FUNCTION_WAN;
};
led-1 {
led@1 {
reg = <1>;
color = <LED_COLOR_ID_AMBER>;
function = LED_FUNCTION_WAN;