ExternalVendorCode/openwrt
1
0
Fork 0
mirror of https://github.com/openwrt/openwrt.git synced 2024-12-21 06:33:41 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

lldpd: only use snmp options when compiled in

Browse Source 
prevent SNMP options being passed unless lldpd supports them

Signed-off-by: Stephen Howell <howels@allthatwemight.be>
This commit is contained in:
Stephen Howell 2024-02-03 13:51:49 +00:00 committed by Stijn Tintel
parent 1b36d44323
commit 8b2d02e48c
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
package/network/services/lldpd/Makefile
View File

@ -83,7 +83,8 @@ ifneq ($(CONFIG_LLDPD_WITH_SONMP),y)
sed -i -e '/sonmp/d' $(1)/etc/config/lldpd sed -i -e '/sonmp/d' $(1)/etc/config/lldpd
endif endif
ifneq ($(CONFIG_LLDPD_WITH_SNMP),y) ifneq ($(CONFIG_LLDPD_WITH_SNMP),y)
sed -i -e '/agentxsocket/d' $(1)/etc/init.d/lldpd $(1)/etc/config/lldpd sed -i -e 's/CONFIG_LLDPD_WITH_SNMP=y/CONFIG_LLDPD_WITH_SNMP=n/g' $(1)/etc/init.d/lldpd
sed -i -e '/agentxsocket/d' $(1)/etc/config/lldpd
endif endif
ifneq ($(CONFIG_LLDPD_WITH_LLDPMED),y) ifneq ($(CONFIG_LLDPD_WITH_LLDPMED),y)
sed -i -e 's/CONFIG_LLDPD_WITH_LLDPMED=y/CONFIG_LLDPD_WITH_LLDPMED=n/g' $(1)/etc/init.d/lldpd sed -i -e 's/CONFIG_LLDPD_WITH_LLDPMED=y/CONFIG_LLDPD_WITH_LLDPMED=n/g' $(1)/etc/init.d/lldpd

7
package/network/services/lldpd/files/lldpd.init
View File

@ -7,6 +7,7 @@ STOP=01
CONFIG_LLDPD_WITH_CDP=y CONFIG_LLDPD_WITH_CDP=y
CONFIG_LLDPD_WITH_FDP=y CONFIG_LLDPD_WITH_FDP=y
CONFIG_LLDPD_WITH_LLDPMED=y CONFIG_LLDPD_WITH_LLDPMED=y
CONFIG_LLDPD_WITH_SNMP=y
CONFIG_LLDPD_WITH_SONMP=y CONFIG_LLDPD_WITH_SONMP=y
USE_PROCD=1 USE_PROCD=1
@ -37,7 +38,9 @@ get_config_restart_hash() {
config_load 'lldpd' config_load 'lldpd'
config_get v 'config' 'lldp_class'; append _string "$v" "," config_get v 'config' 'lldp_class'; append _string "$v" ","
if [ "$CONFIG_LLDPD_WITH_SNMP" == "y" ]; then
config_get v 'config' 'agentxsocket'; append _string "$v" "," config_get v 'config' 'agentxsocket'; append _string "$v" ","
fi
config_get v 'config' 'cid_interface'; append _string "$v" "," config_get v 'config' 'cid_interface'; append _string "$v" ","
config_get v 'config' 'filter'; append _string "$v" "," config_get v 'config' 'filter'; append _string "$v" ","
config_get_bool v 'config' 'readonly_mode'; append _string "$v" "," config_get_bool v 'config' 'readonly_mode'; append _string "$v" ","
@ -201,7 +204,9 @@ start_service() {
config_get_bool lldpmed_no_inventory 'config' 'lldpmed_no_inventory' 0 config_get_bool lldpmed_no_inventory 'config' 'lldpmed_no_inventory' 0
fi fi
config_get_bool readonly_mode 'config' 'readonly_mode' 0 config_get_bool readonly_mode 'config' 'readonly_mode' 0
if [ "$CONFIG_LLDPD_WITH_SNMP" == "y" ]; then
config_get agentxsocket 'config' 'agentxsocket' config_get agentxsocket 'config' 'agentxsocket'
fi
config_get filter 'config' 'filter' 15 config_get filter 'config' 'filter' 15
mkdir -p ${LLDPD_RUN} mkdir -p ${LLDPD_RUN}
@ -272,7 +277,7 @@ start_service() {
[ $lldp_no_version -gt 0 ] && procd_append_param commanpackage/network/services/lldpd/Makefile package/network/services/lldpd/files/lldpd.initd '-k' [ $lldp_no_version -gt 0 ] && procd_append_param commanpackage/network/services/lldpd/Makefile package/network/services/lldpd/files/lldpd.initd '-k'
[ "$CONFIG_LLDPD_WITH_LLDPMED" == "y" ] && [ $lldpmed_no_inventory -gt 0 ] && procd_append_param command '-i' [ "$CONFIG_LLDPD_WITH_LLDPMED" == "y" ] && [ $lldpmed_no_inventory -gt 0 ] && procd_append_param command '-i'
[ -n "$lldp_class" ] && procd_append_param command -M "$lldp_class" [ -n "$lldp_class" ] && procd_append_param command -M "$lldp_class"
[ -n "$agentxsocket" ] && procd_append_param command -x -X "$agentxsocket" [ "$CONFIG_LLDPD_WITH_SNMP" == "y" ] && [ -n "$agentxsocket" ] && procd_append_param command -x -X "$agentxsocket"
[ -n "$filter" ] && procd_append_param command -H "$filter" [ -n "$filter" ] && procd_append_param command -H "$filter"
# ChassisID interfaces # ChassisID interfaces