2022-05-16 21:40:32 +00:00
|
|
|
From bf7f969a35078e4a26ca2beb562593bcbf636afa Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Dom Cobley <popcornmix@gmail.com>
|
|
|
|
|
Date: Sun, 24 Jan 2021 15:44:10 +0000
|
|
|
|
|
Subject: [PATCH] vc4/drm: Avoid full hdmi audio fifo writes
|
|
|
|
|
|
|
|
|
|
We are getting occasional VC4_HD_MAI_CTL_ERRORF in
|
|
|
|
|
HDMI_MAI_CTL which seem to correspond with audio dropouts.
|
|
|
|
|
|
|
|
|
|
Reduce the threshold where we deassert DREQ to avoid the fifo overfilling
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Dom Cobley <popcornmix@gmail.com>
|
|
|
|
|
---
|
|
|
|
|
drivers/gpu/drm/vc4/vc4_hdmi.c | 8 ++++----
|
|
|
|
|
1 file changed, 4 insertions(+), 4 deletions(-)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
|
|
|
|
|
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
|
2022-05-18 14:32:03 +00:00
|
|
|
@@ -1613,10 +1613,10 @@ static int vc4_hdmi_audio_prepare(struct
|
2022-05-16 21:40:32 +00:00
|
|
|
|
|
|
|
|
/* Set the MAI threshold */
|
|
|
|
|
HDMI_WRITE(HDMI_MAI_THR,
|
|
|
|
|
- VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_PANICHIGH) |
|
|
|
|
|
- VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_PANICLOW) |
|
|
|
|
|
- VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_DREQHIGH) |
|
|
|
|
|
- VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_DREQLOW));
|
|
|
|
|
+ VC4_SET_FIELD(0x08, VC4_HD_MAI_THR_PANICHIGH) |
|
|
|
|
|
+ VC4_SET_FIELD(0x08, VC4_HD_MAI_THR_PANICLOW) |
|
|
|
|
|
+ VC4_SET_FIELD(0x06, VC4_HD_MAI_THR_DREQHIGH) |
|
|
|
|
|
+ VC4_SET_FIELD(0x08, VC4_HD_MAI_THR_DREQLOW));
|
|
|
|
|
|
|
|
|
|
HDMI_WRITE(HDMI_MAI_CONFIG,
|
|
|
|
|
VC4_HDMI_MAI_CONFIG_BIT_REVERSE |
|
