2021-11-04 20:52:43 +00:00
|
|
|
From 2f040a17f5061457ae95035326d3159eddc1e5cc Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali@kernel.org>
|
|
|
|
|
Date: Tue, 30 Nov 2021 18:29:10 +0100
|
|
|
|
|
Subject: [PATCH] PCI: aardvark: Fix memory leak in driver unbind
|
|
|
|
|
MIME-Version: 1.0
|
|
|
|
|
Content-Type: text/plain; charset=UTF-8
|
|
|
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
|
|
|
|
|
|
Free config space for emulated root bridge when unbinding driver to fix
|
|
|
|
|
memory leak. Do it after disabling and masking all interrupts, since
|
|
|
|
|
aardvark interrupt handler accesses config space of emulated root
|
|
|
|
|
bridge.
|
|
|
|
|
|
|
|
|
|
Link: https://lore.kernel.org/r/20211130172913.9727-9-kabel@kernel.org
|
|
|
|
|
Signed-off-by: Pali Rohár <pali@kernel.org>
|
|
|
|
|
Signed-off-by: Marek Behún <kabel@kernel.org>
|
|
|
|
|
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
|
|
|
|
|
---
|
|
|
|
|
drivers/pci/controller/pci-aardvark.c | 3 +++
|
|
|
|
|
1 file changed, 3 insertions(+)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/pci/controller/pci-aardvark.c
|
|
|
|
|
+++ b/drivers/pci/controller/pci-aardvark.c
|
2022-04-14 08:28:11 +00:00
|
|
|
@@ -1718,6 +1718,9 @@ static int advk_pcie_remove(struct platf
|
2021-11-04 20:52:43 +00:00
|
|
|
advk_pcie_remove_msi_irq_domain(pcie);
|
|
|
|
|
advk_pcie_remove_irq_domain(pcie);
|
|
|
|
|
|
|
|
|
|
+ /* Free config space for emulated root bridge */
|
|
|
|
|
+ pci_bridge_emul_cleanup(&pcie->bridge);
|
|
|
|
|
+
|
|
|
|
|
/* Disable outbound address windows mapping */
|
|
|
|
|
for (i = 0; i < OB_WIN_COUNT; i++)
|
|
|
|
|
advk_pcie_disable_ob_win(pcie, i);
|
