mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-26 17:01:14 +00:00
43 lines
1.6 KiB
Diff
43 lines
1.6 KiB
Diff
|
From a2f5c505b4378cd6fc7c4a44ff3665ccef2037db Mon Sep 17 00:00:00 2001
|
||
|
|
From: Sava Jakovljev <savaj@meyersound.com>
|
||
|
|
Date: Wed, 21 Aug 2024 04:16:57 +0200
|
||
|
|
Subject: [PATCH] net: phy: realtek: Fix setting of PHY LEDs Mode B bit on
|
||
|
|
RTL8211F
|
||
|
|
|
||
|
|
The current implementation incorrectly sets the mode bit of the PHY chip.
|
||
|
|
Bit 15 (RTL8211F_LEDCR_MODE) should not be shifted together with the
|
||
|
|
configuration nibble of a LED- it should be set independently of the
|
||
|
|
index of the LED being configured.
|
||
|
|
As a consequence, the RTL8211F LED control is actually operating in Mode A.
|
||
|
|
Fix the error by or-ing final register value to write with a const-value of
|
||
|
|
RTL8211F_LEDCR_MODE, thus setting Mode bit explicitly.
|
||
|
|
|
||
|
|
Fixes: 17784801d888 ("net: phy: realtek: Add support for PHY LEDs on RTL8211F")
|
||
|
|
Signed-off-by: Sava Jakovljev <savaj@meyersound.com>
|
||
|
|
Reviewed-by: Marek Vasut <marex@denx.de>
|
||
|
|
Link: https://patch.msgid.link/PAWP192MB21287372F30C4E55B6DF6158C38E2@PAWP192MB2128.EURP192.PROD.OUTLOOK.COM
|
||
|
|
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
|
||
|
|
---
|
||
|
|
drivers/net/phy/realtek.c | 3 ++-
|
||
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
||
|
|
|
||
|
|
--- a/drivers/net/phy/realtek.c
|
||
|
|
+++ b/drivers/net/phy/realtek.c
|
||
|
|
@@ -555,7 +555,7 @@ static int rtl8211f_led_hw_control_set(s
|
||
|
|
unsigned long rules)
|
||
|
|
{
|
||
|
|
const u16 mask = RTL8211F_LEDCR_MASK << (RTL8211F_LEDCR_SHIFT * index);
|
||
|
|
- u16 reg = RTL8211F_LEDCR_MODE; /* Mode B */
|
||
|
|
+ u16 reg = 0;
|
||
|
|
|
||
|
|
if (index >= RTL8211F_LED_COUNT)
|
||
|
|
return -EINVAL;
|
||
|
|
@@ -575,6 +575,7 @@ static int rtl8211f_led_hw_control_set(s
|
||
|
|
}
|
||
|
|
|
||
|
|
reg <<= RTL8211F_LEDCR_SHIFT * index;
|
||
|
|
+ reg |= RTL8211F_LEDCR_MODE; /* Mode B */
|
||
|
|
|
||
|
|
return phy_modify_paged(phydev, 0xd04, RTL8211F_LEDCR, mask, reg);
|
||
|
|
}
|