mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-21 06:33:41 +00:00
31 lines
1.2 KiB
Diff
31 lines
1.2 KiB
Diff
|
From 4dc7f09b8becfa35a55430a49d95acf19f996e6b Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
||
|
|
Date: Wed, 24 Feb 2021 16:18:41 +0100
|
||
|
|
Subject: [PATCH] net: broadcom: bcm4908_enet: fix RX path possible mem leak
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
After filling RX ring slot with new skb it's required to free old skb.
|
||
|
|
Immediately on error or later in the net subsystem.
|
||
|
|
|
||
|
|
Fixes: 4feffeadbcb2 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
|
||
|
|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
||
|
|
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
|
||
|
|
Link: https://lore.kernel.org/r/20210224151842.2419-1-zajec5@gmail.com
|
||
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
||
|
|
---
|
||
|
|
drivers/net/ethernet/broadcom/bcm4908_enet.c | 1 +
|
||
|
|
1 file changed, 1 insertion(+)
|
||
|
|
|
||
|
|
--- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
|
||
|
|
+++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
|
||
|
|
@@ -570,6 +570,7 @@ static int bcm4908_enet_poll(struct napi
|
||
|
|
|
||
|
|
if (len < ETH_ZLEN ||
|
||
|
|
(ctl & (DMA_CTL_STATUS_SOP | DMA_CTL_STATUS_EOP)) != (DMA_CTL_STATUS_SOP | DMA_CTL_STATUS_EOP)) {
|
||
|
|
+ kfree_skb(slot.skb);
|
||
|
|
enet->netdev->stats.rx_dropped++;
|
||
|
|
break;
|
||
|
|
}
|