mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-24 15:56:49 +00:00
52 lines
1.7 KiB
Diff
52 lines
1.7 KiB
Diff
|
From d2059d3b548409905b20b4f52495bffbd7c8da8b Mon Sep 17 00:00:00 2001
|
||
|
|
From: Viresh Kumar <viresh.kumar@linaro.org>
|
||
|
|
Date: Mon, 22 Apr 2024 08:58:51 +0530
|
||
|
|
Subject: [PATCH] cpufreq: sun50i: Fix build warning around snprint()
|
||
|
|
|
||
|
|
The Sun50i driver generates a warning with W=1:
|
||
|
|
|
||
|
|
warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 2 [-Wformat-truncation=]
|
||
|
|
|
||
|
|
Fix it by allocating a big enough array to print an integer.
|
||
|
|
|
||
|
|
Reported-by: kernel test robot <lkp@intel.com>
|
||
|
|
Closes: https://lore.kernel.org/oe-kbuild-all/202404191715.LDwMm2gP-lkp@intel.com/
|
||
|
|
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
|
||
|
|
Acked-by: Chen-Yu Tsai <wens@csie.org>
|
||
|
|
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
|
||
|
|
Tested-by: Andre Przywara <andre.przywara@arm.com>
|
||
|
|
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
|
||
|
|
---
|
||
|
|
drivers/cpufreq/sun50i-cpufreq-nvmem.c | 6 ++----
|
||
|
|
1 file changed, 2 insertions(+), 4 deletions(-)
|
||
|
|
|
||
|
|
--- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
|
||
|
|
+++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
|
||
|
|
@@ -19,8 +19,6 @@
|
||
|
|
#include <linux/pm_opp.h>
|
||
|
|
#include <linux/slab.h>
|
||
|
|
|
||
|
|
-#define MAX_NAME_LEN 7
|
||
|
|
-
|
||
|
|
#define NVMEM_MASK 0x7
|
||
|
|
#define NVMEM_SHIFT 5
|
||
|
|
|
||
|
|
@@ -208,7 +206,7 @@ static int sun50i_cpufreq_get_efuse(void
|
||
|
|
static int sun50i_cpufreq_nvmem_probe(struct platform_device *pdev)
|
||
|
|
{
|
||
|
|
int *opp_tokens;
|
||
|
|
- char name[MAX_NAME_LEN];
|
||
|
|
+ char name[] = "speedXXXXXXXXXXX"; /* Integers can take 11 chars max */
|
||
|
|
unsigned int cpu, supported_hw;
|
||
|
|
struct dev_pm_opp_config config = {};
|
||
|
|
int speed;
|
||
|
|
@@ -235,7 +233,7 @@ static int sun50i_cpufreq_nvmem_probe(st
|
||
|
|
config.supported_hw_count = 1;
|
||
|
|
}
|
||
|
|
|
||
|
|
- snprintf(name, MAX_NAME_LEN, "speed%d", speed);
|
||
|
|
+ snprintf(name, sizeof(name), "speed%d", speed);
|
||
|
|
config.prop_name = name;
|
||
|
|
|
||
|
|
for_each_possible_cpu(cpu) {
|