2019-03-12 10:44:27 +00:00
|
|
|
From patchwork Tue Mar 12 09:51:43 2019
|
|
|
|
|
Content-Type: text/plain; charset="utf-8"
|
|
|
|
|
MIME-Version: 1.0
|
|
|
|
|
Content-Transfer-Encoding: 7bit
|
2019-03-01 02:34:40 +00:00
|
|
|
X-Patchwork-Submitter: Stanislaw Gruszka <sgruszka@redhat.com>
|
2019-03-12 10:44:27 +00:00
|
|
|
X-Patchwork-Id: 10848963
|
2019-03-01 02:34:40 +00:00
|
|
|
X-Patchwork-Delegate: kvalo@adurom.com
|
2019-03-12 10:44:27 +00:00
|
|
|
From: Stanislaw Gruszka <sgruszka@redhat.com>
|
|
|
|
|
To: linux-wireless@vger.kernel.org
|
|
|
|
|
Cc: =?utf-8?q?Tomislav_Po=C5=BEega?= <pozega.tomislav@gmail.com>,
|
|
|
|
|
Daniel Golle <daniel@makrotopia.org>, Felix Fietkau <nbd@nbd.name>,
|
|
|
|
|
Mathias Kresin <dev@kresin.me>
|
|
|
|
|
Subject: [PATCH v3 4/4] rt2x00: do not print error when queue is full
|
|
|
|
|
Date: Tue, 12 Mar 2019 10:51:43 +0100
|
|
|
|
|
Message-Id: <1552384303-29529-5-git-send-email-sgruszka@redhat.com>
|
|
|
|
|
In-Reply-To: <1552384303-29529-1-git-send-email-sgruszka@redhat.com>
|
|
|
|
|
References: <1552384303-29529-1-git-send-email-sgruszka@redhat.com>
|
2019-02-13 18:47:18 +00:00
|
|
|
|
|
|
|
|
For unknown reasons printk() on some context can cause CPU hung on
|
|
|
|
|
embedded MT7620 AP/router MIPS platforms. What can result on wifi
|
|
|
|
|
disconnects.
|
|
|
|
|
|
|
|
|
|
This patch move queue full messages to debug level what is consistent
|
|
|
|
|
with other mac80211 drivers which drop packet silently if tx queue is
|
|
|
|
|
full. This make MT7620 OpenWRT routers more stable, what was reported
|
|
|
|
|
by various users.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
|
|
|
|
|
---
|
|
|
|
|
drivers/net/wireless/ralink/rt2x00/rt2x00queue.c | 2 +-
|
|
|
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
|
|
|
|
|
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
|
|
|
|
|
@@ -671,7 +671,7 @@ int rt2x00queue_write_tx_frame(struct da
|
|
|
|
|
spin_lock(&queue->tx_lock);
|
|
|
|
|
|
|
|
|
|
if (unlikely(rt2x00queue_full(queue))) {
|
|
|
|
|
- rt2x00_err(queue->rt2x00dev, "Dropping frame due to full tx queue %d\n",
|
|
|
|
|
+ rt2x00_dbg(queue->rt2x00dev, "Dropping frame due to full tx queue %d\n",
|
|
|
|
|
queue->qid);
|
|
|
|
|
ret = -ENOBUFS;
|
|
|
|
|
goto out;
|
