2022-10-18 20:26:34 +00:00
|
|
|
From: Felix Fietkau <nbd@nbd.name>
|
|
|
|
|
Date: Fri, 24 Mar 2023 14:56:58 +0100
|
|
|
|
|
Subject: [PATCH] net: ethernet: mtk_eth_soc: fix tx throughput regression with
|
|
|
|
|
direct 1G links
|
|
|
|
|
|
|
|
|
|
Using the QDMA tx scheduler to throttle tx to line speed works fine for
|
|
|
|
|
switch ports, but apparently caused a regression on non-switch ports.
|
|
|
|
|
|
|
|
|
|
Based on a number of tests, it seems that this throttling can be safely
|
|
|
|
|
dropped without re-introducing the issues on switch ports that the
|
|
|
|
|
tx scheduling changes resolved.
|
|
|
|
|
|
|
|
|
|
Link: https://lore.kernel.org/netdev/trinity-92c3826f-c2c8-40af-8339-bc6d0d3ffea4-1678213958520@3c-app-gmx-bs16/
|
|
|
|
|
Fixes: f63959c7eec3 ("net: ethernet: mtk_eth_soc: implement multi-queue support for per-port queues")
|
|
|
|
|
Reported-by: Frank Wunderlich <frank-w@public-files.de>
|
|
|
|
|
Reported-by: Daniel Golle <daniel@makrotopia.org>
|
|
|
|
|
Tested-by: Daniel Golle <daniel@makrotopia.org>
|
|
|
|
|
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
|
|
|
|
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
2024-03-29 22:15:26 +00:00
|
|
|
@@ -718,8 +718,6 @@ static void mtk_mac_link_up(struct phyli
|
2022-10-18 20:26:34 +00:00
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
- mtk_set_queue_speed(mac->hw, mac->id, speed);
|
|
|
|
|
-
|
|
|
|
|
/* Configure duplex */
|
|
|
|
|
if (duplex == DUPLEX_FULL)
|
|
|
|
|
mcr |= MAC_MCR_FORCE_DPX;
|
