mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-24 15:56:49 +00:00
59 lines
2.1 KiB
Diff
59 lines
2.1 KiB
Diff
|
From 6cf96078969ec00b873db99bae4e47001290685e Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
|
||
|
|
Date: Wed, 27 Sep 2023 21:37:23 +0200
|
||
|
|
Subject: [PATCH 35/42] thermal: lvts: Convert to platform remove callback
|
||
|
|
returning void
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
The .remove() callback for a platform driver returns an int which makes
|
||
|
|
many driver authors wrongly assume it's possible to do error handling by
|
||
|
|
returning an error code. However the value returned is ignored (apart
|
||
|
|
from emitting a warning) and this typically results in resource leaks.
|
||
|
|
|
||
|
|
To improve here there is a quest to make the remove callback return
|
||
|
|
void. In the first step of this quest all drivers are converted to
|
||
|
|
.remove_new(), which already returns void. Eventually after all drivers
|
||
|
|
are converted, .remove_new() will be renamed to .remove().
|
||
|
|
|
||
|
|
Trivially convert this driver from always returning zero in the remove
|
||
|
|
callback to the void returning variant.
|
||
|
|
|
||
|
|
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
|
||
|
|
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
|
||
|
|
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
|
||
|
|
---
|
||
|
|
drivers/thermal/mediatek/lvts_thermal.c | 6 ++----
|
||
|
|
1 file changed, 2 insertions(+), 4 deletions(-)
|
||
|
|
|
||
|
|
--- a/drivers/thermal/mediatek/lvts_thermal.c
|
||
|
|
+++ b/drivers/thermal/mediatek/lvts_thermal.c
|
||
|
|
@@ -1241,7 +1241,7 @@ static int lvts_probe(struct platform_de
|
||
|
|
return 0;
|
||
|
|
}
|
||
|
|
|
||
|
|
-static int lvts_remove(struct platform_device *pdev)
|
||
|
|
+static void lvts_remove(struct platform_device *pdev)
|
||
|
|
{
|
||
|
|
struct lvts_domain *lvts_td;
|
||
|
|
int i;
|
||
|
|
@@ -1252,8 +1252,6 @@ static int lvts_remove(struct platform_d
|
||
|
|
lvts_ctrl_set_enable(&lvts_td->lvts_ctrl[i], false);
|
||
|
|
|
||
|
|
lvts_debugfs_exit(lvts_td);
|
||
|
|
-
|
||
|
|
- return 0;
|
||
|
|
}
|
||
|
|
|
||
|
|
static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = {
|
||
|
|
@@ -1354,7 +1352,7 @@ MODULE_DEVICE_TABLE(of, lvts_of_match);
|
||
|
|
|
||
|
|
static struct platform_driver lvts_driver = {
|
||
|
|
.probe = lvts_probe,
|
||
|
|
- .remove = lvts_remove,
|
||
|
|
+ .remove_new = lvts_remove,
|
||
|
|
.driver = {
|
||
|
|
.name = "mtk-lvts-thermal",
|
||
|
|
.of_match_table = lvts_of_match,
|