ExternalVendorCode/openwrt
1
0
Fork 0
mirror of https://github.com/openwrt/openwrt.git synced 2024-12-26 00:41:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
8179ac3dc1
openwrt/target/linux/generic/hack-4.14/420-allow-ubi-mlc-support.patch

14 lines
519 B
Diff
Raw Normal View History

kernel: tolerate using UBI/UBIFS on MLC flash (FS#1830) starting from upstream commit 577b4eb23811 ("ubi: Reject MLC NAND") it is not allowed to use UBI and UBIFS on a MLC flavoured NAND flash chip. [1] According to David Oberhollenzer [2]: The real problem is that on MLC NAND, pages come in pairs. Multiple voltage levels inside a single, physical memory cell are used to encode more than one bit. Instead of just having pages that are twice as big, the flash exposes them as two different pages. Those pages are usually not ordered sequentially either, but according to a vendor/device specific pairing scheme. Within OpenWrt, devices utilizing this type of flash, combined with UBI(fs) will be bricked when a user upgrades from 17.01.4 to a newer version as the MLC will be refused. As these devices are currently advertised as supported by OpenWrt, we should at least maintain the original state during the lifecycle of the current releases. Support can be gracefully ended when a new release-branch is created. Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com> Acked-by: Hauke Mehrtens <hauke@hauke-m.e> [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.14.77&id=577b4eb23811dfc8e38924dc476dbc866be74253 [2] https://lore.kernel.org/patchwork/patch/920344/
2018-10-18 12:23:36 +00:00
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
kernel: bump 4.14 to 4.14.86 Refreshed all patches. Altered patches: - 180-usb-xhci-add-support-for-performing-fake-doorbell.patch Compile-tested on: cns3xxx, imx6 Runtime-tested on: cns3xxx, imx6 Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
2018-12-06 12:34:21 +00:00
@@ -852,9 +852,8 @@ int ubi_attach_mtd_dev(struct mtd_info *
kernel: tolerate using UBI/UBIFS on MLC flash (FS#1830) starting from upstream commit 577b4eb23811 ("ubi: Reject MLC NAND") it is not allowed to use UBI and UBIFS on a MLC flavoured NAND flash chip. [1] According to David Oberhollenzer [2]: The real problem is that on MLC NAND, pages come in pairs. Multiple voltage levels inside a single, physical memory cell are used to encode more than one bit. Instead of just having pages that are twice as big, the flash exposes them as two different pages. Those pages are usually not ordered sequentially either, but according to a vendor/device specific pairing scheme. Within OpenWrt, devices utilizing this type of flash, combined with UBI(fs) will be bricked when a user upgrades from 17.01.4 to a newer version as the MLC will be refused. As these devices are currently advertised as supported by OpenWrt, we should at least maintain the original state during the lifecycle of the current releases. Support can be gracefully ended when a new release-branch is created. Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com> Acked-by: Hauke Mehrtens <hauke@hauke-m.e> [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.14.77&id=577b4eb23811dfc8e38924dc476dbc866be74253 [2] https://lore.kernel.org/patchwork/patch/920344/
2018-10-18 12:23:36 +00:00
* will die soon and you will lose all your data.
*/
if (mtd->type == MTD_MLCNANDFLASH) {
- pr_err("ubi: refuse attaching mtd%d - MLC NAND is not supported\n",
+ pr_warn("ubi: mtd%d has been identified as a MLC NAND!! - MLC is not supported by UBI and UBIFS and _WILL_ cause corruption in the near future!\n",
mtd->index);
- return -EINVAL;
}
if (ubi_num == UBI_DEV_NUM_AUTO) {
Reference in New Issue Copy Permalink