mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-27 09:12:39 +00:00
31 lines
1019 B
Diff
31 lines
1019 B
Diff
|
From 11b57faf951cd3a570e3d9e463fc7c41023bc8c6 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Colin Ian King <colin.king@canonical.com>
|
||
|
|
Date: Tue, 15 Jun 2021 10:05:16 +0100
|
||
|
|
Subject: [PATCH] net: dsa: b53: remove redundant null check on dev
|
||
|
|
|
||
|
|
The pointer dev can never be null, the null check is redundant
|
||
|
|
and can be removed. Cleans up a static analysis warning that
|
||
|
|
pointer priv is dereferencing dev before dev is being null
|
||
|
|
checked.
|
||
|
|
|
||
|
|
Addresses-Coverity: ("Dereference before null check")
|
||
|
|
Signed-off-by: Colin Ian King <colin.king@canonical.com>
|
||
|
|
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
|
||
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||
|
|
---
|
||
|
|
drivers/net/dsa/b53/b53_srab.c | 3 +--
|
||
|
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
||
|
|
|
||
|
|
--- a/drivers/net/dsa/b53/b53_srab.c
|
||
|
|
+++ b/drivers/net/dsa/b53/b53_srab.c
|
||
|
|
@@ -632,8 +632,7 @@ static int b53_srab_remove(struct platfo
|
||
|
|
struct b53_srab_priv *priv = dev->priv;
|
||
|
|
|
||
|
|
b53_srab_intr_set(priv, false);
|
||
|
|
- if (dev)
|
||
|
|
- b53_switch_remove(dev);
|
||
|
|
+ b53_switch_remove(dev);
|
||
|
|
|
||
|
|
return 0;
|
||
|
|
}
|