mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-30 02:29:01 +00:00
28 lines
977 B
Diff
28 lines
977 B
Diff
|
From 733993f502f254912b1415e13f73651d9f2e74ef Mon Sep 17 00:00:00 2001
|
||
|
|
From: Andrew Lunn <andrew@lunn.ch>
|
||
|
|
Date: Sun, 5 Jul 2020 22:42:27 +0200
|
||
|
|
Subject: [PATCH 1/5] net: dsa: rtl8366: Pass GENMASK() signed bits
|
||
|
|
|
||
|
|
Oddly, GENMASK() requires signed bit numbers, so that it can compare
|
||
|
|
them for < 0. If passed an unsigned type, we get warnings about the
|
||
|
|
test never being true.
|
||
|
|
|
||
|
|
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
|
||
|
|
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
|
||
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||
|
|
---
|
||
|
|
drivers/net/dsa/rtl8366.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
--- a/drivers/net/dsa/rtl8366.c
|
||
|
|
+++ b/drivers/net/dsa/rtl8366.c
|
||
|
|
@@ -285,7 +285,7 @@ int rtl8366_init_vlan(struct realtek_smi
|
||
|
|
/* For the CPU port, make all ports members of this
|
||
|
|
* VLAN.
|
||
|
|
*/
|
||
|
|
- mask = GENMASK(smi->num_ports - 1, 0);
|
||
|
|
+ mask = GENMASK((int)smi->num_ports - 1, 0);
|
||
|
|
else
|
||
|
|
/* For all other ports, enable itself plus the
|
||
|
|
* CPU port.
|