mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-30 18:47:06 +00:00
56 lines
2.3 KiB
Diff
56 lines
2.3 KiB
Diff
|
From patchwork Tue Sep 17 13:49:40 2024
|
||
|
|
Content-Type: text/plain; charset="utf-8"
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Transfer-Encoding: 7bit
|
||
|
|
X-Patchwork-Submitter: Daniel Golle <daniel@makrotopia.org>
|
||
|
|
X-Patchwork-Id: 13806176
|
||
|
|
X-Patchwork-Delegate: kuba@kernel.org
|
||
|
|
Date: Tue, 17 Sep 2024 14:49:40 +0100
|
||
|
|
From: Daniel Golle <daniel@makrotopia.org>
|
||
|
|
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>,
|
||
|
|
Russell King <linux@armlinux.org.uk>,
|
||
|
|
"David S. Miller" <davem@davemloft.net>,
|
||
|
|
Eric Dumazet <edumazet@google.com>,
|
||
|
|
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
|
||
|
|
Daniel Golle <daniel@makrotopia.org>,
|
||
|
|
Christian Marangi <ansuelsmth@gmail.com>,
|
||
|
|
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
|
||
|
|
Robert Marko <robimarko@gmail.com>,
|
||
|
|
Russell King <rmk+kernel@armlinux.org.uk>, netdev@vger.kernel.org,
|
||
|
|
linux-kernel@vger.kernel.org
|
||
|
|
Subject: [PATCH net 1/2] net: phy: aquantia: fix setting active_low bit
|
||
|
|
Message-ID:
|
||
|
|
<ab963584b0a7e3b4dac39472a4b82ca264d79630.1726580902.git.daniel@makrotopia.org>
|
||
|
|
Precedence: bulk
|
||
|
|
X-Mailing-List: netdev@vger.kernel.org
|
||
|
|
List-Id: <netdev.vger.kernel.org>
|
||
|
|
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
|
||
|
|
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Disposition: inline
|
||
|
|
X-Patchwork-Delegate: kuba@kernel.org
|
||
|
|
|
||
|
|
phy_modify_mmd was used wrongly in aqr_phy_led_active_low_set() resulting
|
||
|
|
in a no-op instead of setting the VEND1_GLOBAL_LED_DRIVE_VDD bit.
|
||
|
|
Correctly set VEND1_GLOBAL_LED_DRIVE_VDD bit.
|
||
|
|
|
||
|
|
Fixes: 61578f679378 ("net: phy: aquantia: add support for PHY LEDs")
|
||
|
|
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
|
||
|
|
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
|
||
|
|
---
|
||
|
|
drivers/net/phy/aquantia/aquantia_leds.c | 3 ++-
|
||
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
||
|
|
|
||
|
|
--- a/drivers/net/phy/aquantia/aquantia_leds.c
|
||
|
|
+++ b/drivers/net/phy/aquantia/aquantia_leds.c
|
||
|
|
@@ -120,7 +120,8 @@ int aqr_phy_led_hw_control_set(struct ph
|
||
|
|
int aqr_phy_led_active_low_set(struct phy_device *phydev, int index, bool enable)
|
||
|
|
{
|
||
|
|
return phy_modify_mmd(phydev, MDIO_MMD_VEND1, AQR_LED_DRIVE(index),
|
||
|
|
- VEND1_GLOBAL_LED_DRIVE_VDD, enable);
|
||
|
|
+ VEND1_GLOBAL_LED_DRIVE_VDD,
|
||
|
|
+ enable ? VEND1_GLOBAL_LED_DRIVE_VDD : 0);
|
||
|
|
}
|
||
|
|
|
||
|
|
int aqr_phy_led_polarity_set(struct phy_device *phydev, int index, unsigned long modes)
|