mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-29 01:59:02 +00:00
28 lines
886 B
Diff
28 lines
886 B
Diff
|
From be492eed9f4724798a7b85cf8779772dc901f986 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
||
|
|
Date: Tue, 21 Jan 2020 16:44:14 +0000
|
||
|
|
Subject: [PATCH] driver: char: rpivid: Fix access to freed memory
|
||
|
|
|
||
|
|
The error path during probe frees the private memory block, and
|
||
|
|
then promptly dereferences it to log an error message.
|
||
|
|
|
||
|
|
Use the base device instead of the pointer to it in the private
|
||
|
|
structure.
|
||
|
|
|
||
|
|
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
||
|
|
---
|
||
|
|
drivers/char/broadcom/rpivid-mem.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
--- a/drivers/char/broadcom/rpivid-mem.c
|
||
|
|
+++ b/drivers/char/broadcom/rpivid-mem.c
|
||
|
|
@@ -229,7 +229,7 @@ failed_alloc_chrdev:
|
||
|
|
failed_get_resource:
|
||
|
|
kfree(priv);
|
||
|
|
failed_inst_alloc:
|
||
|
|
- dev_err(priv->dev, "could not load rpivid_mem");
|
||
|
|
+ dev_err(&pdev->dev, "could not load rpivid_mem");
|
||
|
|
return err;
|
||
|
|
}
|
||
|
|
|