2018-11-10 11:03:18 +00:00
|
|
|
From de3b152b3662dbb68537619f2f24a893b59eb2c1 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Phil Elwell <phil@raspberrypi.org>
|
|
|
|
|
Date: Wed, 24 Jan 2018 15:19:39 +0000
|
|
|
|
|
Subject: [PATCH 170/454] lan78xx: Avoid spurious kevent 4 "error"
|
|
|
|
|
|
|
|
|
|
lan78xx_defer_event generates an error message whenever the work item
|
|
|
|
|
is already scheduled. lan78xx_open defers three events -
|
|
|
|
|
EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware
|
|
|
|
|
of the likelihood (or certainty) of an error message, the DEV_OPEN
|
|
|
|
|
event is added to the set of pending events directly, relying on
|
|
|
|
|
the subsequent deferral of the EVENT_LINK_RESET call to schedule the
|
|
|
|
|
work. Take the same precaution with EVENT_STAT_UPDATE to avoid a
|
|
|
|
|
totally unnecessary error message.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
|
|
|
|
|
---
|
|
|
|
|
drivers/net/usb/lan78xx.c | 2 +-
|
|
|
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/net/usb/lan78xx.c
|
|
|
|
|
+++ b/drivers/net/usb/lan78xx.c
|
2020-01-03 23:36:43 +00:00
|
|
|
@@ -2499,7 +2499,7 @@ static void lan78xx_init_stats(struct la
|
2018-11-10 11:03:18 +00:00
|
|
|
dev->stats.rollover_max.eee_tx_lpi_transitions = 0xFFFFFFFF;
|
|
|
|
|
dev->stats.rollover_max.eee_tx_lpi_time = 0xFFFFFFFF;
|
|
|
|
|
|
|
|
|
|
- lan78xx_defer_kevent(dev, EVENT_STAT_UPDATE);
|
|
|
|
|
+ set_bit(EVENT_STAT_UPDATE, &dev->flags);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int lan78xx_open(struct net_device *net)
|
