2021-11-04 20:52:43 +00:00
|
|
|
From b290c6384afabbca5ae6e2af72fb1b2bc37922be Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
|
|
|
|
Date: Thu, 16 Sep 2021 14:03:52 +0200
|
|
|
|
|
Subject: [PATCH] net: dsa: b53: Drop BCM5301x workaround for a wrong CPU/IMP
|
|
|
|
|
port
|
|
|
|
|
MIME-Version: 1.0
|
|
|
|
|
Content-Type: text/plain; charset=UTF-8
|
|
|
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
|
|
|
|
|
|
On BCM5301x port 8 requires a fixed link when used.
|
|
|
|
|
|
|
|
|
|
Years ago when b53 was an OpenWrt downstream driver (with configuration
|
|
|
|
|
based on sometimes bugged NVRAM) there was a need for a fixup. In case
|
|
|
|
|
of forcing fixed link for (incorrectly specified) port 5 the code had to
|
|
|
|
|
actually setup port 8 link.
|
|
|
|
|
|
|
|
|
|
For upstream b53 driver with setup based on DT there is no need for that
|
|
|
|
|
workaround. In DT we have and require correct ports setup.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
|
|
|
|
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
|
|
|
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
|
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
|
|
|
---
|
|
|
|
|
drivers/net/dsa/b53/b53_common.c | 6 ------
|
|
|
|
|
1 file changed, 6 deletions(-)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/net/dsa/b53/b53_common.c
|
|
|
|
|
+++ b/drivers/net/dsa/b53/b53_common.c
|
2022-03-21 14:21:24 +00:00
|
|
|
@@ -1291,12 +1291,6 @@ static void b53_adjust_link(struct dsa_s
|
2021-11-04 20:52:43 +00:00
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
- } else if (is5301x(dev)) {
|
|
|
|
|
- if (port != dev->cpu_port) {
|
|
|
|
|
- b53_force_port_config(dev, dev->cpu_port, 2000,
|
|
|
|
|
- DUPLEX_FULL, true, true);
|
|
|
|
|
- b53_force_link(dev, dev->cpu_port, 1);
|
|
|
|
|
- }
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Re-negotiate EEE if it was enabled already */
|
