2019-07-28 11:52:47 +00:00
|
|
|
From e0bfb9601d4812719167cc4124a0d6db1e2f55e4 Mon Sep 17 00:00:00 2001
|
2019-07-21 09:23:32 +00:00
|
|
|
From: Arend van Spriel <arend.vanspriel@broadcom.com>
|
|
|
|
|
Date: Thu, 11 Jul 2019 11:05:11 +0200
|
2019-07-28 11:52:47 +00:00
|
|
|
Subject: [PATCH] brcmfmac: simply remove flowring if bus is down
|
2019-07-21 09:23:32 +00:00
|
|
|
|
|
|
|
|
When the bus is down, eg. due to rmmod, there is no need to
|
|
|
|
|
attempt to inform firmware about it.
|
|
|
|
|
|
|
|
|
|
Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
|
|
|
|
|
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
|
|
|
|
|
Reviewed-by: Franky Lin <franky.lin@broadcom.com>
|
|
|
|
|
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
|
2019-07-28 11:52:47 +00:00
|
|
|
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
|
2019-07-21 09:23:32 +00:00
|
|
|
---
|
|
|
|
|
drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 7 +++++++
|
|
|
|
|
1 file changed, 7 insertions(+)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
|
|
|
|
|
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
|
|
|
|
|
@@ -1398,6 +1398,13 @@ void brcmf_msgbuf_delete_flowring(struct
|
|
|
|
|
u8 ifidx;
|
|
|
|
|
int err;
|
|
|
|
|
|
|
|
|
|
+ /* no need to submit if firmware can not be reached */
|
|
|
|
|
+ if (drvr->bus_if->state != BRCMF_BUS_UP) {
|
|
|
|
|
+ brcmf_dbg(MSGBUF, "bus down, flowring will be removed\n");
|
|
|
|
|
+ brcmf_msgbuf_remove_flowring(msgbuf, flowid);
|
|
|
|
|
+ return;
|
|
|
|
|
+ }
|
|
|
|
|
+
|
|
|
|
|
commonring = msgbuf->commonrings[BRCMF_H2D_MSGRING_CONTROL_SUBMIT];
|
|
|
|
|
brcmf_commonring_lock(commonring);
|
|
|
|
|
ret_ptr = brcmf_commonring_reserve_for_write(commonring);
|
