2019-09-19 14:43:19 +00:00
|
|
|
From 612a3f0adcf98854dcbe8228551b941b76c6af2c Mon Sep 17 00:00:00 2001
|
2019-07-09 18:32:28 +00:00
|
|
|
From: Phil Elwell <phil@raspberrypi.org>
|
|
|
|
|
Date: Tue, 14 Nov 2017 11:03:22 +0000
|
2019-12-23 12:42:55 +00:00
|
|
|
Subject: [PATCH] mcp2515: Use DT-supplied interrupt flags
|
2019-07-09 18:32:28 +00:00
|
|
|
|
|
|
|
|
The MCP2515 datasheet clearly describes a level-triggered interrupt
|
|
|
|
|
pin. Therefore the receiving interrupt controller must also be
|
|
|
|
|
configured for level-triggered operation otherwise there is a danger
|
|
|
|
|
of a missed interrupt condition blocking all subsequent interrupts.
|
|
|
|
|
The ONESHOT flag ensures that the interrupt is masked until the
|
|
|
|
|
threaded interrupt handler exits.
|
|
|
|
|
|
|
|
|
|
Rather than change the flags globally (they must have worked for at
|
|
|
|
|
least one user), allow the flags to be overridden from Device Tree
|
|
|
|
|
in the event that the device has a DT node.
|
|
|
|
|
|
|
|
|
|
See: https://github.com/raspberrypi/linux/issues/2175
|
|
|
|
|
https://github.com/raspberrypi/linux/issues/2263
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
|
|
|
|
|
---
|
|
|
|
|
drivers/net/can/spi/mcp251x.c | 3 +++
|
|
|
|
|
1 file changed, 3 insertions(+)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/net/can/spi/mcp251x.c
|
|
|
|
|
+++ b/drivers/net/can/spi/mcp251x.c
|
2019-10-14 12:37:25 +00:00
|
|
|
@@ -948,6 +948,9 @@ static int mcp251x_open(struct net_devic
|
2019-07-09 18:32:28 +00:00
|
|
|
priv->tx_skb = NULL;
|
|
|
|
|
priv->tx_len = 0;
|
|
|
|
|
|
|
|
|
|
+ if (spi->dev.of_node)
|
|
|
|
|
+ flags = 0;
|
|
|
|
|
+
|
|
|
|
|
ret = request_threaded_irq(spi->irq, NULL, mcp251x_can_ist,
|
|
|
|
|
flags | IRQF_ONESHOT, DEVICE_NAME, priv);
|
|
|
|
|
if (ret) {
|
