2021-08-21 08:54:34 +00:00
|
|
|
From 491c6fbbe8fadead32fbe316fd5d0f21e9aa01f2 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Maxime Ripard <maxime@cerno.tech>
|
|
|
|
Date: Thu, 22 Apr 2021 10:45:37 +0200
|
|
|
|
Subject: [PATCH] clk: requests: Dereference the request pointer after
|
|
|
|
the check
|
|
|
|
|
|
|
|
The current code will first dereference the req pointer and then test if
|
|
|
|
it's NULL, resulting in a NULL pointer dereference if req is indeed
|
|
|
|
NULL. Reorder the test and derefence to avoid the issue
|
|
|
|
|
|
|
|
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
|
|
|
|
---
|
|
|
|
drivers/clk/clk.c | 3 ++-
|
|
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
|
|
|
|
--- a/drivers/clk/clk.c
|
|
|
|
+++ b/drivers/clk/clk.c
|
2022-04-13 20:25:50 +00:00
|
|
|
@@ -2520,10 +2520,11 @@ EXPORT_SYMBOL_GPL(clk_request_start);
|
2021-08-21 08:54:34 +00:00
|
|
|
*/
|
|
|
|
void clk_request_done(struct clk_request *req)
|
|
|
|
{
|
|
|
|
- struct clk_core *core = req->clk->core;
|
|
|
|
+ struct clk_core *core;
|
|
|
|
|
|
|
|
if (!req)
|
|
|
|
return;
|
|
|
|
+ core = req->clk->core;
|
|
|
|
|
|
|
|
clk_prepare_lock();
|
|
|
|
|