2024-04-10 14:14:32 +00:00
|
|
|
|
From 4d7b17712513710778c0f2f83ea5d9b55ed58c36 Mon Sep 17 00:00:00 2001
|
|
|
|
|
|
From: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= <arinc.unal@arinc9.com>
|
|
|
|
|
|
Date: Tue, 6 Feb 2024 01:08:08 +0300
|
|
|
|
|
|
Subject: [PATCH 18/30] net: dsa: mt7530: do not clear
|
|
|
|
|
|
config->supported_interfaces
|
|
|
|
|
|
MIME-Version: 1.0
|
|
|
|
|
|
Content-Type: text/plain; charset=UTF-8
|
|
|
|
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
|
|
|
|
|
|
|
|
There's no need to clear the config->supported_interfaces bitmap before
|
|
|
|
|
|
reporting the supported interfaces as all bits in the bitmap will already
|
|
|
|
|
|
be initialized to zero when the phylink_config structure is allocated. The
|
|
|
|
|
|
"config" pointer points to &dp->phylink_config, and "dp" is allocated by
|
|
|
|
|
|
dsa_port_touch() with kzalloc(), so all its fields are filled with zeroes.
|
|
|
|
|
|
|
|
|
|
|
|
There's no code that would change the bitmap beforehand. Remove it.
|
|
|
|
|
|
|
|
|
|
|
|
Acked-by: Daniel Golle <daniel@makrotopia.org>
|
|
|
|
|
|
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
|
|
|
|
|
|
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
|
|
|
|
|
|
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
|
|
|
|
|
|
Link: https://lore.kernel.org/r/20240206-for-netnext-mt7530-improvements-2-v5-7-d7d92a185cb1@arinc9.com
|
|
|
|
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
|
|
|
|
---
|
|
|
|
|
|
drivers/net/dsa/mt7530.c | 2 --
|
|
|
|
|
|
1 file changed, 2 deletions(-)
|
|
|
|
|
|
|
|
|
|
|
|
--- a/drivers/net/dsa/mt7530.c
|
|
|
|
|
|
+++ b/drivers/net/dsa/mt7530.c
|
2024-04-17 19:01:37 +00:00
|
|
|
|
@@ -2770,8 +2770,6 @@ static void mt7531_mac_port_get_caps(str
|
2024-04-10 14:14:32 +00:00
|
|
|
|
static void mt7988_mac_port_get_caps(struct dsa_switch *ds, int port,
|
|
|
|
|
|
struct phylink_config *config)
|
|
|
|
|
|
{
|
|
|
|
|
|
- phy_interface_zero(config->supported_interfaces);
|
|
|
|
|
|
-
|
|
|
|
|
|
switch (port) {
|
|
|
|
|
|
/* Ports which are connected to switch PHYs. There is no MII pinout. */
|
|
|
|
|
|
case 0 ... 3:
|
