mirror of
https://github.com/nasa/openmct.git
synced 2024-12-28 08:58:52 +00:00
0413e77d8a
* fix: update broken locator * update eslint package * first pass of lint fixes * update package * change ruleset * update component tests to match linting rules * driveby * start to factor out bad locators * update gauge component * update notebook snapshot drop area * Update plot aria * add draggable true to tree items * update package * driveby to remove dead code * unneeded * unneeded * tells a screenreader that this is a row and a cell * adds an id for dragondrops * this should be a button * first pass at fixing tooltip selectors * review comments * Updating more tests * update to remove expect expect given our use of check functions * add expand component * move role around * update more locators * force * new local storage * remove choochoo steps * test: do `lint:fix` and also add back accidentally removed code * test: add back more removed code * test: remove `unstable` annotation from tests which are not unstable * test: remove invalid test-- the "new" time conductor doesn't allow for millisecond changes in fixed time * test: fix unstable gauge test * test: remove useless asserts-- this was secretly non-functional. now that we've fixed it, it makes no sense and just fails * test: add back accidentally removed changes * test: revert changes that break test * test: more fixes * Remove all notion of the unstable/stable e2e tests * test: eviscerate the flake with FACTS and LOGIC * test: fix anotha one * lint fixes * test: no need to wait for save dialog * test: fix more tests * lint: fix more warnings * test: fix anotha one * test: use `toHaveLength` instead of `.length).toBe()` * test: stabilize tabs view example imagery test * fix: more tests be fixed * test: more `toHaveCount()`s please * test: revert more accidentally removed fixes * test: fix selector * test: fix anotha one * update lint rules to clean up bad locators in shared fixtures * update and remove bad appActions * test: fix some restricted notebook tests * test: mass find/replace to enforce `toHaveCount()` instead of `.count()).toBe()` * Remove some bad appActions and update text * test: fix da tree tests * test: await not await await * test: fix upload plan appAction and add a11y * Updating externalFixtures with best practice locators and add missing appAction framework tests * test: fix test * test: fix appAction test for plans * test: yum yum fix'em up and get rid of some dragon drops * fix: alas, a `.only()` got my hopes up that i was done fixing tests * test: add `setTimeConductorMode` test "suite" which covers most TC related appActions * test: fix arg * test(couchdb): fix some network tests via expect polling * Stabalize visual test * getCanasPixels * test: stabilize tooltip telemetry table test, better a11y for tooltips * chore: update to use `docker compose` instead of `docker-compose` * New rules, new tests, new me * fix sort order * test: add `waitForPlotsToRender` framework test, passthru timeout override * test: remove `clockOptions` test as we have `page.clock` now * test: refactor out `overrideClock` * test: use `clock.install` instead * test: use `clock.install` instead * time clock fix * test: fix timer tests * remove ever reference to old base fixture * test: stabilize restricted notebook test * lint fixes * test: use clock.install * update timelist * test: update visual tests to use `page.clock()`, update snapshots * test: stabilize tree renaming/reordering test * a11y: add aria-label and role=region to object view * refactor: use `dragTo` * refactor: use `dragTo`, other small fixes * test: use `page.clock()` to stabilize tooltip telemetry table test * test: use web-first assertion to stabilize staleness test * test: knock out a few more `page.click`s * test: destroy all `page.click()`s * refactor: consistently use `'Ok'` instead of `'OK'` and `'Ok'` mixed * test: remove gauge aria label * test: more test fixes * test: more fixes and refactors * docs: add comment * test: refactor all instances of `dragAndDrop` * test: remove redundant test (covered in previous test steps) * test: stabilize imagery operations tests for display layout * chore: remove bad unicorn rule * chore(lint): remove unused disable directives --------- Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov>
367 lines
14 KiB
JavaScript
367 lines
14 KiB
JavaScript
/*****************************************************************************
|
|
* Open MCT, Copyright (c) 2014-2024, United States Government
|
|
* as represented by the Administrator of the National Aeronautics and Space
|
|
* Administration. All rights reserved.
|
|
*
|
|
* Open MCT is licensed under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
* http://www.apache.org/licenses/LICENSE-2.0.
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
* Open MCT includes source code licensed under additional open source
|
|
* licenses. See the Open Source Licenses file (LICENSES.md) included with
|
|
* this source code distribution or the Licensing information page available
|
|
* at runtime from the About dialog for additional information.
|
|
*****************************************************************************/
|
|
|
|
import { createDomainObjectWithDefaults } from '../../appActions.js';
|
|
import { waitForAnimations } from '../../baseFixtures.js';
|
|
import { expect, test } from '../../pluginFixtures.js';
|
|
|
|
test.describe('Recent Objects', () => {
|
|
/** @type {import('@playwright/test').Locator} */
|
|
let recentObjectsList;
|
|
/** @type {import('@playwright/test').Locator} */
|
|
let clock;
|
|
/** @type {import('@playwright/test').Locator} */
|
|
let folderA;
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.goto('./', { waitUntil: 'domcontentloaded' });
|
|
|
|
// Set Recent Objects List locator for subsequent tests
|
|
recentObjectsList = page.getByRole('list', {
|
|
name: 'Recent Objects'
|
|
});
|
|
|
|
// Create a folder and nest a Clock within it
|
|
folderA = await createDomainObjectWithDefaults(page, {
|
|
type: 'Folder'
|
|
});
|
|
clock = await createDomainObjectWithDefaults(page, {
|
|
type: 'Clock',
|
|
parent: folderA.uuid
|
|
});
|
|
|
|
// Drag the Recent Objects panel up a bit
|
|
await page
|
|
.locator('.l-pane.l-pane--vertical-handle-before', {
|
|
hasText: 'Recently Viewed'
|
|
})
|
|
.locator('.l-pane__handle')
|
|
.hover();
|
|
await page.mouse.down();
|
|
await page.mouse.move(0, 100);
|
|
await page.mouse.up();
|
|
});
|
|
test('Navigated objects show up in recents, object renames and deletions are reflected', async ({
|
|
page
|
|
}) => {
|
|
test.info().annotations.push({
|
|
type: 'issue',
|
|
description: 'https://github.com/nasa/openmct/issues/6818'
|
|
});
|
|
|
|
// Verify that both created objects appear in the list and are in the correct order
|
|
await assertInitialRecentObjectsListState();
|
|
|
|
// Navigate to the folder by clicking on the main object name in the recent objects list item
|
|
await page.getByRole('listitem', { name: folderA.name }).getByText(folderA.name).click();
|
|
await page.waitForURL(`**/${folderA.uuid}?*`);
|
|
expect(recentObjectsList.getByRole('listitem').nth(0).getByText(folderA.name)).toBeTruthy();
|
|
|
|
// Rename
|
|
folderA.name = `${folderA.name}-NEW!`;
|
|
await page.locator('.l-browse-bar__object-name').fill('');
|
|
await page.locator('.l-browse-bar__object-name').fill(folderA.name);
|
|
await page.keyboard.press('Enter');
|
|
|
|
// Verify rename has been applied in recent objects list item and objects paths
|
|
expect(
|
|
await page
|
|
.getByRole('navigation', {
|
|
name: clock.name
|
|
})
|
|
.locator('a')
|
|
.filter({
|
|
hasText: folderA.name
|
|
})
|
|
.count()
|
|
).toBeGreaterThan(0);
|
|
expect(recentObjectsList.getByRole('listitem', { name: folderA.name })).toBeTruthy();
|
|
|
|
await page.getByLabel('Show selected item in tree').click();
|
|
// Delete the folder via the left tree pane treeitem context menu
|
|
await page
|
|
.getByRole('treeitem', { name: new RegExp(folderA.name) })
|
|
.locator('a')
|
|
.click({
|
|
button: 'right'
|
|
});
|
|
await page.getByRole('menuitem', { name: /Remove/ }).click();
|
|
await page.getByRole('button', { name: 'Ok', exact: true }).click();
|
|
|
|
// Verify that the folder and clock are no longer in the recent objects list
|
|
await expect(recentObjectsList.getByRole('listitem', { name: folderA.name })).toBeHidden();
|
|
await expect(recentObjectsList.getByRole('listitem', { name: clock.name })).toBeHidden();
|
|
});
|
|
|
|
test('Clicking on an object in the path of a recent object navigates to the object', async ({
|
|
page,
|
|
openmctConfig
|
|
}) => {
|
|
const { myItemsFolderName } = openmctConfig;
|
|
test.info().annotations.push({
|
|
type: 'issue',
|
|
description: 'https://github.com/nasa/openmct/issues/6151'
|
|
});
|
|
await page.goto('./#/browse/mine');
|
|
|
|
// Navigate to the folder by clicking on its entry in the Clock's breadcrumb
|
|
const waitForFolderNavigation = page.waitForURL(`**/${folderA.uuid}?*`);
|
|
await page
|
|
.getByRole('navigation', {
|
|
name: clock.name
|
|
})
|
|
.locator('a')
|
|
.filter({
|
|
hasText: folderA.name
|
|
})
|
|
.click();
|
|
|
|
// Verify that the hash URL updates correctly
|
|
await waitForFolderNavigation;
|
|
expect(page.url()).toMatch(new RegExp(`.*${folderA.uuid}?.*`));
|
|
|
|
// Navigate to My Items by clicking on its entry in the Clock's breadcrumb
|
|
const waitForMyItemsNavigation = page.waitForURL(`**/mine?*`);
|
|
await page
|
|
.getByRole('navigation', {
|
|
name: clock.name
|
|
})
|
|
.locator('a')
|
|
.filter({
|
|
hasText: myItemsFolderName
|
|
})
|
|
.click();
|
|
|
|
// Verify that the hash URL updates correctly
|
|
await waitForMyItemsNavigation;
|
|
expect(page.url()).toMatch(new RegExp(`.*mine?.*`));
|
|
});
|
|
test("Clicking on the 'target button' scrolls the object into view in the tree and highlights it", async ({
|
|
page
|
|
}) => {
|
|
const clockTreeItem = page
|
|
.getByRole('tree', { name: 'Main Tree' })
|
|
.getByRole('treeitem', { name: clock.name });
|
|
const folderTreeItem = page.getByRole('tree', { name: 'Main Tree' }).getByRole('treeitem', {
|
|
name: folderA.name,
|
|
expanded: true
|
|
});
|
|
|
|
// Click the "Target" button for the Clock which is nested in a folder
|
|
await page.getByRole('button', { name: `Open and scroll to ${clock.name}` }).click();
|
|
|
|
// Assert that the Clock parent folder has expanded and the Clock is visible)
|
|
await expect(folderTreeItem.locator('.c-disclosure-triangle')).toHaveClass(/--expanded/);
|
|
await expect(clockTreeItem).toBeVisible();
|
|
|
|
// Assert that the Clock treeitem is highlighted
|
|
await expect(clockTreeItem.locator('.c-tree__item')).toHaveClass(/is-targeted-item/);
|
|
|
|
// Wait for highlight animation to end
|
|
await waitForAnimations(clockTreeItem.locator('.c-tree__item'));
|
|
|
|
// Assert that the Clock treeitem is no longer highlighted
|
|
await expect(clockTreeItem.locator('.c-tree__item')).not.toHaveClass(/is-targeted-item/);
|
|
});
|
|
test('Persists on refresh', async ({ page }) => {
|
|
await assertInitialRecentObjectsListState();
|
|
await page.reload();
|
|
await assertInitialRecentObjectsListState();
|
|
});
|
|
test('Displays objects and aliases uniquely', async ({ page }) => {
|
|
const mainTree = page.getByRole('tree', { name: 'Main Tree' });
|
|
|
|
// Navigate to the clock and reveal it in the tree
|
|
await page.goto(clock.url);
|
|
await page.getByLabel('Show selected item in tree').click();
|
|
|
|
// Right click the clock and create an alias using the "link" context menu action
|
|
const clockTreeItem = page
|
|
.getByRole('tree', {
|
|
name: 'Main Tree'
|
|
})
|
|
.getByRole('treeitem', {
|
|
name: clock.name
|
|
});
|
|
await clockTreeItem.click({
|
|
button: 'right'
|
|
});
|
|
await page
|
|
.getByRole('menuitem', {
|
|
name: /Create Link/
|
|
})
|
|
.click();
|
|
await page
|
|
.getByRole('tree', { name: 'Create Modal Tree' })
|
|
.getByRole('treeitem')
|
|
.first()
|
|
.click();
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
|
|
// Click the newly created object alias in the tree
|
|
await mainTree
|
|
.getByRole('treeitem', {
|
|
name: new RegExp(clock.name)
|
|
})
|
|
.filter({
|
|
has: page.locator('.is-alias')
|
|
})
|
|
.click();
|
|
|
|
// Assert that two recent objects are displayed and one of them is an alias
|
|
await expect(recentObjectsList.getByRole('listitem', { name: clock.name })).toHaveCount(2);
|
|
await expect(recentObjectsList.locator('.is-alias')).toHaveCount(1);
|
|
|
|
// Assert that the alias and the original's breadcrumbs are different
|
|
const clockBreadcrumbs = recentObjectsList
|
|
.getByRole('listitem', { name: clock.name })
|
|
.getByRole('navigation');
|
|
await expect(clockBreadcrumbs).toHaveCount(2);
|
|
await expect(clockBreadcrumbs.nth(0)).not.toHaveText(await clockBreadcrumbs.nth(1).innerText());
|
|
});
|
|
test('Enforces a limit of 20 recent objects and clears the recent objects', async ({ page }) => {
|
|
// Creating 21 objects takes a while, so increase the timeout
|
|
test.slow();
|
|
|
|
// Assert that the list initially contains 3 objects (clock, folder, my items)
|
|
await expect(recentObjectsList.locator('.c-recentobjects-listitem')).toHaveCount(3);
|
|
|
|
let lastFolder;
|
|
let lastClock;
|
|
// Create 19 more objects (3 in beforeEach() + 18 new = 21 total)
|
|
for (let i = 0; i < 9; i++) {
|
|
lastFolder = await createDomainObjectWithDefaults(page, {
|
|
type: 'Folder',
|
|
parent: lastFolder?.uuid
|
|
});
|
|
lastClock = await createDomainObjectWithDefaults(page, {
|
|
type: 'Clock',
|
|
parent: lastFolder?.uuid
|
|
});
|
|
}
|
|
|
|
// Assert that the list contains 20 objects
|
|
await expect(recentObjectsList.locator('.c-recentobjects-listitem')).toHaveCount(20);
|
|
|
|
// Collapse the tree
|
|
await page.getByTitle('Collapse all tree items').click();
|
|
const lastFolderTreeItem = page.getByRole('tree', { name: 'Main Tree' }).getByRole('treeitem', {
|
|
name: lastFolder.name,
|
|
expanded: true
|
|
});
|
|
const lastClockTreeItem = page.getByRole('tree', { name: 'Main Tree' }).getByRole('treeitem', {
|
|
name: lastClock.name
|
|
});
|
|
|
|
// Test "Open and Scroll To" in a deeply nested tree, while we're here
|
|
await page.getByRole('button', { name: `Open and scroll to ${lastClock.name}` }).click();
|
|
|
|
// Assert that the Clock parent folder has expanded and the Clock is visible)
|
|
await expect(lastFolderTreeItem.locator('.c-disclosure-triangle')).toHaveClass(/--expanded/);
|
|
await expect(lastClockTreeItem).toBeVisible();
|
|
|
|
// Assert that the Clock treeitem is highlighted
|
|
await expect(lastClockTreeItem.locator('.c-tree__item')).toHaveClass(/is-targeted-item/);
|
|
|
|
// Wait for highlight animation to end
|
|
await waitForAnimations(lastClockTreeItem.locator('.c-tree__item'));
|
|
|
|
// Assert that the Clock treeitem is no longer highlighted
|
|
await expect(lastClockTreeItem.locator('.c-tree__item')).not.toHaveClass(/is-targeted-item/);
|
|
|
|
// Click the aria-label="Clear Recently Viewed" button
|
|
await page.getByRole('button', { name: 'Clear Recently Viewed' }).click();
|
|
|
|
// Click on the "OK" button in the confirmation dialog
|
|
await page.getByRole('button', { name: 'Ok', exact: true }).click();
|
|
|
|
// Assert that the list is empty
|
|
await expect(recentObjectsList.locator('.c-recentobjects-listitem')).toHaveCount(0);
|
|
});
|
|
test('Verify functionality of "clear" and "collapse pane" buttons', async ({ page }) => {
|
|
// Assert that the list initially contains 3 objects (clock, folder, my items)
|
|
await expect(recentObjectsList.locator('.c-recentobjects-listitem')).toHaveCount(3);
|
|
|
|
// Assert that the button is enabled
|
|
await expect(page.getByRole('button', { name: 'Clear Recently Viewed' })).toBeEnabled();
|
|
|
|
// Click the aria-label="Clear Recently Viewed" button
|
|
await page.getByRole('button', { name: 'Clear Recently Viewed' }).click();
|
|
|
|
// Click on the "OK" button in the confirmation dialog
|
|
await page.getByRole('button', { name: 'Ok', exact: true }).click();
|
|
|
|
// Assert that the list is empty
|
|
await expect(recentObjectsList.locator('.c-recentobjects-listitem')).toHaveCount(0);
|
|
|
|
// Assert that the button is disabled
|
|
await expect(page.getByRole('button', { name: 'Clear Recently Viewed' })).toBeDisabled();
|
|
|
|
// Navigate to folder object
|
|
await page.goto(folderA.url);
|
|
|
|
// Assert that the list contains 1 object
|
|
await expect(recentObjectsList.locator('.c-recentobjects-listitem')).toHaveCount(1);
|
|
|
|
// Assert that the button is enabled
|
|
await expect(page.getByRole('button', { name: 'Clear Recently Viewed' })).toBeEnabled();
|
|
|
|
// Assert initial state of pane and collapse the Recent Objects panel
|
|
await expect(page.getByLabel('Expand Recently Viewed Pane')).toBeHidden();
|
|
await expect(page.getByLabel('Collapse Recently Viewed Pane')).toBeVisible();
|
|
await page.getByLabel('Collapse Recently Viewed Pane').click();
|
|
|
|
// Assert that the "Expand Recently Viewed Pane" button is visible
|
|
// and that the "Collapse Recently Viewed Pane" button is hidden
|
|
await expect(page.getByLabel('Expand Recently Viewed Pane')).toBeVisible();
|
|
await expect(page.getByLabel('Collapse Recently Viewed Pane')).toBeHidden();
|
|
|
|
// Expand the Recent Objects panel by clicking on the "Expand Recently Viewed Pane" button
|
|
await page.getByLabel('Expand Recently Viewed Pane').click();
|
|
|
|
// Assert that the "Expand Recently Viewed Pane" button is hidden
|
|
// and that the "Collapse Recently Viewed Pane" button is visible
|
|
await expect(page.getByLabel('Expand Recently Viewed Pane')).toBeHidden();
|
|
await expect(page.getByLabel('Collapse Recently Viewed Pane')).toBeVisible();
|
|
});
|
|
|
|
function assertInitialRecentObjectsListState() {
|
|
return Promise.all([
|
|
expect(recentObjectsList.getByRole('listitem', { name: clock.name })).toBeVisible(),
|
|
expect(recentObjectsList.getByRole('listitem', { name: folderA.name })).toBeVisible(),
|
|
expect(
|
|
recentObjectsList
|
|
.getByRole('listitem', { name: clock.name })
|
|
.locator('a')
|
|
.getByText(folderA.name)
|
|
).toBeVisible(),
|
|
expect(recentObjectsList.getByRole('listitem').nth(0).getByText(clock.name)).toBeVisible(),
|
|
expect(
|
|
recentObjectsList
|
|
.getByRole('listitem', { name: clock.name })
|
|
.locator('a')
|
|
.getByText(folderA.name)
|
|
).toBeVisible(),
|
|
expect(recentObjectsList.getByRole('listitem').nth(3).getByText(folderA.name)).toBeVisible()
|
|
]);
|
|
}
|
|
});
|