mirror of
https://github.com/nasa/openmct.git
synced 2025-01-15 17:30:12 +00:00
0413e77d8a
* fix: update broken locator * update eslint package * first pass of lint fixes * update package * change ruleset * update component tests to match linting rules * driveby * start to factor out bad locators * update gauge component * update notebook snapshot drop area * Update plot aria * add draggable true to tree items * update package * driveby to remove dead code * unneeded * unneeded * tells a screenreader that this is a row and a cell * adds an id for dragondrops * this should be a button * first pass at fixing tooltip selectors * review comments * Updating more tests * update to remove expect expect given our use of check functions * add expand component * move role around * update more locators * force * new local storage * remove choochoo steps * test: do `lint:fix` and also add back accidentally removed code * test: add back more removed code * test: remove `unstable` annotation from tests which are not unstable * test: remove invalid test-- the "new" time conductor doesn't allow for millisecond changes in fixed time * test: fix unstable gauge test * test: remove useless asserts-- this was secretly non-functional. now that we've fixed it, it makes no sense and just fails * test: add back accidentally removed changes * test: revert changes that break test * test: more fixes * Remove all notion of the unstable/stable e2e tests * test: eviscerate the flake with FACTS and LOGIC * test: fix anotha one * lint fixes * test: no need to wait for save dialog * test: fix more tests * lint: fix more warnings * test: fix anotha one * test: use `toHaveLength` instead of `.length).toBe()` * test: stabilize tabs view example imagery test * fix: more tests be fixed * test: more `toHaveCount()`s please * test: revert more accidentally removed fixes * test: fix selector * test: fix anotha one * update lint rules to clean up bad locators in shared fixtures * update and remove bad appActions * test: fix some restricted notebook tests * test: mass find/replace to enforce `toHaveCount()` instead of `.count()).toBe()` * Remove some bad appActions and update text * test: fix da tree tests * test: await not await await * test: fix upload plan appAction and add a11y * Updating externalFixtures with best practice locators and add missing appAction framework tests * test: fix test * test: fix appAction test for plans * test: yum yum fix'em up and get rid of some dragon drops * fix: alas, a `.only()` got my hopes up that i was done fixing tests * test: add `setTimeConductorMode` test "suite" which covers most TC related appActions * test: fix arg * test(couchdb): fix some network tests via expect polling * Stabalize visual test * getCanasPixels * test: stabilize tooltip telemetry table test, better a11y for tooltips * chore: update to use `docker compose` instead of `docker-compose` * New rules, new tests, new me * fix sort order * test: add `waitForPlotsToRender` framework test, passthru timeout override * test: remove `clockOptions` test as we have `page.clock` now * test: refactor out `overrideClock` * test: use `clock.install` instead * test: use `clock.install` instead * time clock fix * test: fix timer tests * remove ever reference to old base fixture * test: stabilize restricted notebook test * lint fixes * test: use clock.install * update timelist * test: update visual tests to use `page.clock()`, update snapshots * test: stabilize tree renaming/reordering test * a11y: add aria-label and role=region to object view * refactor: use `dragTo` * refactor: use `dragTo`, other small fixes * test: use `page.clock()` to stabilize tooltip telemetry table test * test: use web-first assertion to stabilize staleness test * test: knock out a few more `page.click`s * test: destroy all `page.click()`s * refactor: consistently use `'Ok'` instead of `'OK'` and `'Ok'` mixed * test: remove gauge aria label * test: more test fixes * test: more fixes and refactors * docs: add comment * test: refactor all instances of `dragAndDrop` * test: remove redundant test (covered in previous test steps) * test: stabilize imagery operations tests for display layout * chore: remove bad unicorn rule * chore(lint): remove unused disable directives --------- Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov>
202 lines
7.7 KiB
JavaScript
202 lines
7.7 KiB
JavaScript
/*****************************************************************************
|
|
* Open MCT, Copyright (c) 2014-2024, United States Government
|
|
* as represented by the Administrator of the National Aeronautics and Space
|
|
* Administration. All rights reserved.
|
|
*
|
|
* Open MCT is licensed under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
* http://www.apache.org/licenses/LICENSE-2.0.
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
* Open MCT includes source code licensed under additional open source
|
|
* licenses. See the Open Source Licenses file (LICENSES.md) included with
|
|
* this source code distribution or the Licensing information page available
|
|
* at runtime from the About dialog for additional information.
|
|
*****************************************************************************/
|
|
|
|
import {
|
|
dragAndDropEmbed,
|
|
enterTextEntry,
|
|
lockPage,
|
|
startAndAddRestrictedNotebookObject
|
|
} from '../../../../helper/notebookUtils.js';
|
|
import { expect, streamToString, test } from '../../../../pluginFixtures.js';
|
|
|
|
const TEST_TEXT = 'Testing text for entries.';
|
|
const TEST_TEXT_NAME = 'Test Page';
|
|
|
|
test.describe('Restricted Notebook', () => {
|
|
let notebook;
|
|
test.beforeEach(async ({ page }) => {
|
|
notebook = await startAndAddRestrictedNotebookObject(page);
|
|
});
|
|
|
|
test('Can be renamed @addInit', async ({ page }) => {
|
|
await expect(page.locator('.l-browse-bar__object-name')).toContainText(`${notebook.name}`);
|
|
});
|
|
|
|
test('Can be deleted if there are no locked pages @addInit', async ({ page }) => {
|
|
await openObjectTreeContextMenu(page, notebook.url);
|
|
|
|
const menuOptions = page.locator('.c-menu ul');
|
|
await expect.soft(menuOptions).toContainText('Remove');
|
|
|
|
const restrictedNotebookTreeObject = page.locator(`a:has-text("${notebook.name}")`);
|
|
|
|
// notebook tree object exists
|
|
await expect(restrictedNotebookTreeObject).toHaveCount(1);
|
|
|
|
// Click Remove Text
|
|
await page.locator('li[role="menuitem"]:has-text("Remove")').click();
|
|
|
|
// Click 'Ok' on confirmation window
|
|
await page.locator('button:has-text("OK")').click();
|
|
|
|
// has been deleted
|
|
await expect(restrictedNotebookTreeObject).toHaveCount(0);
|
|
});
|
|
|
|
test('Can be locked if at least one page has one entry @addInit', async ({ page }) => {
|
|
await enterTextEntry(page, TEST_TEXT);
|
|
|
|
await expect(page.getByLabel('Commit Entries')).toHaveCount(1);
|
|
});
|
|
});
|
|
|
|
test.describe('Restricted Notebook with at least one entry and with the page locked @addInit', () => {
|
|
let notebook;
|
|
test.beforeEach(async ({ page }) => {
|
|
notebook = await startAndAddRestrictedNotebookObject(page);
|
|
await enterTextEntry(page, TEST_TEXT);
|
|
await lockPage(page);
|
|
|
|
// open sidebar
|
|
await page.locator('button.c-notebook__toggle-nav-button').click();
|
|
});
|
|
|
|
test('Locked page should now be in a locked state @addInit', async ({ page }, testInfo) => {
|
|
// eslint-disable-next-line playwright/no-skipped-test
|
|
test.skip(testInfo.project === 'chrome-beta', 'Test is unreliable on chrome-beta');
|
|
// main lock message on page
|
|
const lockMessage = page.locator(
|
|
'text=This page has been committed and cannot be modified or removed'
|
|
);
|
|
await expect(lockMessage).toHaveCount(1);
|
|
|
|
// lock icon on page in sidebar
|
|
const pageLockIcon = page.locator('ul.c-notebook__pages li div.icon-lock');
|
|
await expect(pageLockIcon).toHaveCount(1);
|
|
|
|
// no way to remove a restricted notebook with a locked page
|
|
await openObjectTreeContextMenu(page, notebook.url);
|
|
const menuOptions = page.locator('.c-menu ul');
|
|
|
|
await expect(menuOptions).not.toContainText('Remove');
|
|
});
|
|
|
|
test('Can still: add page, rename, add entry, delete unlocked pages @addInit', async ({
|
|
page
|
|
}) => {
|
|
// Add a new page to the section
|
|
await page.getByRole('button', { name: 'Add Page' }).click();
|
|
// Focus the new page by clicking it
|
|
await page.getByText('Unnamed Page').nth(1).click();
|
|
// Rename the new page
|
|
await page.getByText('Unnamed Page').nth(1).fill(TEST_TEXT_NAME);
|
|
|
|
// expect to be able to rename unlocked pages
|
|
await page.getByText(TEST_TEXT_NAME).press('Enter'); // exit contenteditable state
|
|
await expect(page.locator('div').filter({ hasText: /^Test Page$/ })).toHaveCount(1);
|
|
|
|
// enter test text
|
|
await enterTextEntry(page, TEST_TEXT);
|
|
|
|
// expect new page to be lockable
|
|
await expect(page.getByLabel('Commit Entries')).toHaveCount(1);
|
|
|
|
// Click the context menu button for the new page
|
|
await page.getByTitle('Open context menu').click();
|
|
// Delete the page
|
|
await page.getByRole('menuitem', { name: 'Delete Page' }).click();
|
|
// Click OK button
|
|
await page.getByRole('button', { name: 'Ok', exact: true }).click();
|
|
|
|
// deleted page, should no longer exist
|
|
const deletedPageElement = page.getByText(TEST_TEXT_NAME);
|
|
await expect(deletedPageElement).toHaveCount(0);
|
|
});
|
|
});
|
|
|
|
test.describe('Restricted Notebook with a page locked and with an embed @addInit', () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
const notebook = await startAndAddRestrictedNotebookObject(page);
|
|
await dragAndDropEmbed(page, notebook);
|
|
});
|
|
|
|
test('Allows embeds to be deleted if page unlocked @addInit', async ({ page }) => {
|
|
// Click embed popup menu
|
|
await page.getByLabel('Notebook Entry').getByLabel('More actions').click();
|
|
|
|
const embedMenu = page.getByLabel('Super Menu');
|
|
await expect(embedMenu).toContainText('Remove This Embed');
|
|
});
|
|
|
|
test('Disallows embeds to be deleted if page locked @addInit', async ({ page }) => {
|
|
await lockPage(page);
|
|
// Click embed popup menu
|
|
await page.getByLabel('Notebook Entry').getByLabel('More actions').click();
|
|
|
|
const embedMenu = page.getByLabel('Super Menu');
|
|
await expect(embedMenu).not.toContainText('Remove This Embed');
|
|
});
|
|
});
|
|
|
|
test.describe('can export restricted notebook as text', () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
await startAndAddRestrictedNotebookObject(page);
|
|
});
|
|
|
|
test('basic functionality', async ({ page }) => {
|
|
await enterTextEntry(page, `Foo bar entry`);
|
|
// Click on 3 Dot Menu
|
|
await page.locator('button[title="More actions"]').click();
|
|
const downloadPromise = page.waitForEvent('download');
|
|
|
|
await page.getByRole('menuitem', { name: /Export Notebook as Text/ }).click();
|
|
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
|
|
//Verify exported text as a stream of text instead of a file read from the filesystem
|
|
const download = await downloadPromise;
|
|
const readStream = await download.createReadStream();
|
|
const exportedText = await streamToString(readStream);
|
|
expect(exportedText).toContain('Foo bar entry');
|
|
});
|
|
|
|
test.fixme('can export multiple notebook entries as text', async ({ page }) => {});
|
|
test.fixme('can export all notebook entry metdata', async ({ page }) => {});
|
|
test.fixme('can export all notebook tags', async ({ page }) => {});
|
|
test.fixme('can export all notebook snapshots', async ({ page }) => {});
|
|
});
|
|
|
|
/**
|
|
* Open the given `domainObject`'s context menu from the object tree.
|
|
* Expands the path to the object and scrolls to it if necessary.
|
|
*
|
|
* @param {import('@playwright/test').Page} page
|
|
* @param {string} url the url to the object
|
|
*/
|
|
async function openObjectTreeContextMenu(page, url) {
|
|
await page.goto(url);
|
|
await page.getByLabel('Show selected item in tree').click();
|
|
await page.locator('.is-navigated-object').click({
|
|
button: 'right'
|
|
});
|
|
}
|