mirror of
https://github.com/nasa/openmct.git
synced 2024-12-29 01:18:52 +00:00
45de84c183
* [Time Conductor] Prevent route change on setting search parameters. fixes #1341 * [Inspector] Fixed incorrect listener deregistration which was causing errors on scope destruction * Bare route is redirect to browse * [Browse] handle routing without breaking $route Manage route transitions such that route changes are properly prevented and navigation events occur while still updating the url. Resolves a number of issues where path and search updates had to be supported in a very hacky manner. https://github.com/nasa/openmct/pull/1342 * [URL] Set search without hacks Changes in previous commit allow the search parameters to be modified without accidentally triggering a page reload. https://github.com/nasa/openmct/pull/1342 * [Views] Update on location changes If the user has a bookmark or tries to change the current view of an object by specifying view=someView as a search parameter, the change would not previously take effect. This resolves that bug. https://github.com/nasa/openmct/pull/1342 * [TC] Set query params to undefined Instead of setting params to null, which would eventually result in those parameters equaling undefined, set them to undefined to skip the extra step. https://github.com/nasa/openmct/pull/1342 * [Instantiate] Instantiate objects with context Add context to instantiate objects so that they can be navigated to for editing. https://github.com/nasa/openmct/pull/1342 * [Tests] Update specs Update specs to match new expectations. * [Style] Fix style * [TC] Remove unused dependency Remove $route dependency from time conductor controller as it was not being used. Resolves review comments. https://github.com/nasa/openmct/pull/1342#pullrequestreview-11449260
95 lines
3.6 KiB
JavaScript
95 lines
3.6 KiB
JavaScript
/*****************************************************************************
|
|
* Open MCT, Copyright (c) 2014-2016, United States Government
|
|
* as represented by the Administrator of the National Aeronautics and Space
|
|
* Administration. All rights reserved.
|
|
*
|
|
* Open MCT is licensed under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
* http://www.apache.org/licenses/LICENSE-2.0.
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
* Open MCT includes source code licensed under additional open source
|
|
* licenses. See the Open Source Licenses file (LICENSES.md) included with
|
|
* this source code distribution or the Licensing information page available
|
|
* at runtime from the About dialog for additional information.
|
|
*****************************************************************************/
|
|
|
|
|
|
define(
|
|
["../src/BrowseObjectController"],
|
|
function (BrowseObjectController) {
|
|
|
|
describe("The browse object controller", function () {
|
|
var mockScope,
|
|
mockLocation,
|
|
mockRoute,
|
|
controller;
|
|
|
|
// Utility function; look for a $watch on scope and fire it
|
|
function fireWatch(expr, value) {
|
|
mockScope.$watch.calls.forEach(function (call) {
|
|
if (call.args[0] === expr) {
|
|
call.args[1](value);
|
|
}
|
|
});
|
|
}
|
|
|
|
beforeEach(function () {
|
|
mockScope = jasmine.createSpyObj(
|
|
"$scope",
|
|
["$on", "$watch"]
|
|
);
|
|
mockRoute = { current: { params: {} } };
|
|
mockLocation = jasmine.createSpyObj(
|
|
"$location",
|
|
["path", "search"]
|
|
);
|
|
mockLocation.search.andReturn({});
|
|
|
|
controller = new BrowseObjectController(
|
|
mockScope,
|
|
mockLocation,
|
|
mockRoute
|
|
);
|
|
});
|
|
|
|
it("updates query parameters when selected view changes", function () {
|
|
fireWatch("representation.selected.key", "xyz");
|
|
expect(mockLocation.search).toHaveBeenCalledWith('view', "xyz");
|
|
|
|
// Allows the path index to be checked
|
|
// prior to setting $route.current
|
|
mockLocation.path.andReturn("/browse/");
|
|
});
|
|
|
|
it("sets the active view from query parameters", function () {
|
|
var mockDomainObject = jasmine.createSpyObj(
|
|
"domainObject",
|
|
['getId', 'getModel', 'getCapability', 'useCapability']
|
|
),
|
|
testViews = [
|
|
{ key: 'abc' },
|
|
{ key: 'def', someKey: 'some value' },
|
|
{ key: 'xyz' }
|
|
];
|
|
|
|
mockDomainObject.useCapability.andCallFake(function (c) {
|
|
return (c === 'view') && testViews;
|
|
});
|
|
mockLocation.search.andReturn({ view: 'def' });
|
|
|
|
fireWatch('domainObject', mockDomainObject);
|
|
expect(mockScope.representation.selected)
|
|
.toEqual(testViews[1]);
|
|
});
|
|
|
|
});
|
|
}
|
|
);
|