openmct/e2e/tests/functional/plugins/lad/lad.e2e.spec.js
John Hill 0413e77d8a
test(e2e): Major refactor and stabilization of e2e tests (#7581)
* fix: update broken locator

* update eslint package

* first pass of lint fixes

* update package

* change ruleset

* update component tests to match linting rules

* driveby

* start to factor out bad locators

* update gauge component

* update notebook snapshot drop area

* Update plot aria

* add draggable true to tree items

* update package

* driveby to remove dead code

* unneeded

* unneeded

* tells a screenreader that this is a row and a cell

* adds an id for dragondrops

* this should be a button

* first pass at fixing tooltip selectors

* review comments

* Updating more tests

* update to remove expect expect given our use of check functions

* add expand component

* move role around

* update more locators

* force

* new local storage

* remove choochoo steps

* test: do `lint:fix` and also add back accidentally removed code

* test: add back more removed code

* test: remove `unstable` annotation from tests which are not unstable

* test: remove invalid test-- the "new" time conductor doesn't allow for millisecond changes in fixed time

* test: fix unstable gauge test

* test: remove useless asserts-- this was secretly non-functional. now that we've fixed it, it makes no sense and just fails

* test: add back accidentally removed changes

* test: revert changes that break test

* test: more fixes

* Remove all notion of the unstable/stable e2e tests

* test: eviscerate the flake with FACTS and LOGIC

* test: fix anotha one

* lint fixes

* test: no need to wait for save dialog

* test: fix more tests

* lint: fix more warnings

* test: fix anotha one

* test: use `toHaveLength` instead of `.length).toBe()`

* test: stabilize tabs view example imagery test

* fix: more tests be fixed

* test: more `toHaveCount()`s please

* test: revert more accidentally removed fixes

* test: fix selector

* test: fix anotha one

* update lint rules to clean up bad locators in shared fixtures

* update and remove bad appActions

* test: fix some restricted notebook tests

* test: mass find/replace to enforce `toHaveCount()` instead of `.count()).toBe()`

* Remove some bad appActions and update text

* test: fix da tree tests

* test: await not await await

* test: fix upload plan appAction and add a11y

* Updating externalFixtures with best practice locators and add missing appAction framework tests

* test: fix test

* test: fix appAction test for plans

* test: yum yum fix'em up and get rid of some dragon drops

* fix: alas, a `.only()` got my hopes up that i was done fixing tests

* test: add `setTimeConductorMode` test "suite" which covers most TC related appActions

* test: fix arg

* test(couchdb): fix some network tests via expect polling

* Stabalize visual test

* getCanasPixels

* test: stabilize tooltip telemetry table test, better a11y for tooltips

* chore: update to use `docker compose` instead of `docker-compose`

* New rules, new tests, new me

* fix sort order

* test: add `waitForPlotsToRender` framework test, passthru timeout override

* test: remove `clockOptions` test as we have `page.clock` now

* test: refactor out `overrideClock`

* test: use `clock.install` instead

* test: use `clock.install` instead

* time clock fix

* test: fix timer tests

* remove ever reference to old base fixture

* test: stabilize restricted notebook test

* lint fixes

* test: use clock.install

* update timelist

* test: update visual tests to use `page.clock()`, update snapshots

* test: stabilize tree renaming/reordering test

* a11y: add aria-label and role=region to object view

* refactor: use `dragTo`

* refactor: use `dragTo`, other small fixes

* test: use `page.clock()` to stabilize tooltip telemetry table test

* test: use web-first assertion to stabilize staleness test

* test: knock out a few more `page.click`s

* test: destroy all `page.click()`s

* refactor: consistently use `'Ok'` instead of `'OK'` and `'Ok'` mixed

* test: remove gauge aria label

* test: more test fixes

* test: more fixes and refactors

* docs: add comment

* test: refactor all instances of `dragAndDrop`

* test: remove redundant test (covered in previous test steps)

* test: stabilize imagery operations tests for display layout

* chore: remove bad unicorn rule

* chore(lint): remove unused disable directives

---------

Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov>
2024-08-07 21:36:14 +00:00

356 lines
18 KiB
JavaScript

/*****************************************************************************
* Open MCT, Copyright (c) 2014-2024, United States Government
* as represented by the Administrator of the National Aeronautics and Space
* Administration. All rights reserved.
*
* Open MCT is licensed under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* http://www.apache.org/licenses/LICENSE-2.0.
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*
* Open MCT includes source code licensed under additional open source
* licenses. See the Open Source Licenses file (LICENSES.md) included with
* this source code distribution or the Licensing information page available
* at runtime from the About dialog for additional information.
*****************************************************************************/
import {
createDomainObjectWithDefaults,
navigateToObjectWithRealTime,
setFixedTimeMode,
setRealTimeMode,
setStartOffset
} from '../../../../appActions.js';
import { expect, test } from '../../../../pluginFixtures.js';
test.describe('Testing LAD table configuration', () => {
let ladTable;
let sineWaveObject;
test.beforeEach(async ({ page }) => {
await page.goto('./', { waitUntil: 'domcontentloaded' });
// Create LAD table
ladTable = await createDomainObjectWithDefaults(page, {
type: 'LAD Table',
name: 'Test LAD Table'
});
// Create Sine Wave Generator
sineWaveObject = await createDomainObjectWithDefaults(page, {
type: 'Sine Wave Generator',
name: 'Test Sine Wave Generator',
parent: ladTable.uuid
});
await page.goto(ladTable.url);
});
test('in edit mode, LAD Tables provide ability to hide columns', async ({ page }) => {
// Edit LAD table
await page.getByLabel('Edit Object').click();
await page.getByRole('tab', { name: 'LAD Table Configuration' }).click();
// make sure headers are visible initially
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeVisible();
// hide timestamp column
await page.getByLabel('Timestamp', { exact: true }).uncheck();
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeVisible();
// hide units & type column
await page.getByLabel('Units').uncheck();
await page.getByLabel('Type', { exact: true }).uncheck();
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeVisible();
// hide WATCH column
await page.getByLabel('WATCH').uncheck();
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeVisible();
// save and reload and verify they columns are still hidden
await page.getByRole('button', { name: 'Save' }).click();
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
await page.reload();
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeVisible();
// Edit LAD table
await page.getByLabel('Edit Object').click();
await page.getByRole('tab', { name: 'LAD Table Configuration' }).click();
// show timestamp column
await page.getByLabel('Timestamp', { exact: true }).check();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeVisible();
// save and reload and make sure timestamp is still visible
await page.getByRole('button', { name: 'Save' }).click();
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
await page.reload();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeVisible();
// Edit LAD table
await page.getByLabel('Edit Object').click();
await page.getByRole('tab', { name: 'LAD Table Configuration' }).click();
// show units, type, and WATCH columns
await page.getByLabel('Units').check();
await page.getByLabel('Type', { exact: true }).check();
await page.getByLabel('WATCH').check();
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeVisible();
// save and reload and make sure all columns are still visible
await page.locator('button[title="Save"]').click();
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
await page.reload();
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeVisible();
});
test('When adding something without Units, do not show Units column', async ({ page }) => {
// Create Sine Wave Generator
await createDomainObjectWithDefaults(page, {
type: 'Event Message Generator',
parent: ladTable.uuid
});
await page.goto(ladTable.url);
// Edit LAD table
await page.getByLabel('Edit Object').click();
await page.getByRole('tab', { name: 'LAD Table Configuration' }).click();
// make sure Sine Wave headers are visible initially too
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeVisible();
// save and reload and verify they columns are still hidden
await page.getByLabel('Save').click();
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
// Remove Sine Wave Generator
openObjectTreeContextMenu(page, sineWaveObject.url);
await page.getByRole('menuitem', { name: /Remove/ }).click();
await page.getByRole('button', { name: 'Ok', exact: true }).click();
// Ensure Units & Limit columns are gone
// as Event Generator don't have them
await page.goto(ladTable.url);
await expect(page.getByRole('columnheader', { name: 'Timestamp', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Type', exact: true })).toBeVisible();
await expect(page.getByRole('columnheader', { name: 'Units' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit WATCH' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit WARNING' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit DISTRESS' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit CRITICAL' })).toBeHidden();
await expect(page.getByRole('columnheader', { name: 'Limit SEVERE' })).toBeHidden();
});
test("LAD Tables don't allow selection of rows but does show context click menus", async ({
page
}) => {
const cell = page.locator('.js-first-data');
const userSelectable = await cell.evaluate((el) => {
return window.getComputedStyle(el).getPropertyValue('user-select');
});
expect(userSelectable).toBe('none');
// Right-click on the LAD table row
await cell.click({
button: 'right'
});
const menuOptions = page.locator('.c-menu ul');
await expect.soft(menuOptions).toContainText('View Full Datum');
await expect.soft(menuOptions).toContainText('View Historical Data');
await expect.soft(menuOptions).toContainText('Remove');
// await page.locator('li[title="Remove this object from its containing object."]').click();
});
});
test.describe('Testing LAD table', () => {
let sineWaveObject;
test.beforeEach(async ({ page }) => {
await page.goto('./', { waitUntil: 'domcontentloaded' });
// Create Sine Wave Generator
sineWaveObject = await createDomainObjectWithDefaults(page, {
type: 'Sine Wave Generator',
name: 'Test Sine Wave Generator'
});
// Switch to real time mode by navigating directly to the URL
await navigateToObjectWithRealTime(page, sineWaveObject.url);
});
test('telemetry value exactly matches latest telemetry value received in realtime mode', async ({
page
}) => {
// Create LAD table
await createDomainObjectWithDefaults(page, {
type: 'LAD Table',
name: 'Test LAD Table'
});
// Edit LAD table
await page.getByLabel('Edit Object').click();
// Expand the 'My Items' folder in the left tree
await page.getByLabel('Expand My Items').click();
// Add the Sine Wave Generator to the LAD table and save changes
await page.getByLabel('Preview Test Sine Wave').dragTo(page.locator('#lad-table-drop-area'));
await page.getByRole('button', { name: 'Save' }).click();
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
// Subscribe to the Sine Wave Generator data
// On getting data, check if the value found in the LAD table is the most recent value
// from the Sine Wave Generator
const getTelemValuePromise = subscribeToTelemetry(page, sineWaveObject.uuid);
const subscribeTelemValue = await getTelemValuePromise;
await expect(page.getByLabel('lad value')).toHaveText(subscribeTelemValue);
const ladTableValue = await page.getByText(subscribeTelemValue).textContent();
expect(ladTableValue).toEqual(subscribeTelemValue);
});
test('telemetry value exactly matches latest telemetry value received in fixed time mode', async ({
page
}) => {
// Create LAD table
await createDomainObjectWithDefaults(page, {
type: 'LAD Table',
name: 'Test LAD Table'
});
// Edit LAD table
await page.getByLabel('Edit Object').click();
// Expand the 'My Items' folder in the left tree
await page.getByLabel('Expand My Items').click();
// Add the Sine Wave Generator to the LAD table and save changes
await page.getByLabel('Preview Test Sine Wave').dragTo(page.locator('#lad-table-drop-area'));
await page.getByRole('button', { name: 'Save' }).click();
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
// Subscribe to the Sine Wave Generator data
const getTelemValuePromise = subscribeToTelemetry(page, sineWaveObject.uuid);
// Set an offset of 1 minute and then change the time mode to fixed to set a 1 minute historical window
await setRealTimeMode(page);
await setStartOffset(page, { startMins: '01' });
await setFixedTimeMode(page);
// On getting data, check if the value found in the LAD table is the most recent value
// from the Sine Wave Generator
const subscribeTelemValue = await getTelemValuePromise;
await expect(page.getByLabel('lad value')).toHaveText(subscribeTelemValue);
});
});
/**
* Util for subscribing to a telemetry object by object identifier
* Limitations: Currently only works to return telemetry once to the node scope
* To Do: See if there's a way to await this multiple times to allow for multiple
* values to be returned over time
* @param {import('@playwright/test').Page} page
* @param {string} objectIdentifier identifier for object
* @returns {Promise<string>} the formatted sin telemetry value
*/
async function subscribeToTelemetry(page, objectIdentifier) {
const getTelemValuePromise = new Promise((resolve) =>
page.exposeFunction('getTelemValue', resolve)
);
await page.evaluate(async (telemetryIdentifier) => {
const telemetryObject = await window.openmct.objects.get(telemetryIdentifier);
const metadata = window.openmct.telemetry.getMetadata(telemetryObject);
const formats = await window.openmct.telemetry.getFormatMap(metadata);
window.openmct.telemetry.subscribe(telemetryObject, (obj) => {
const sinVal = obj.sin;
const formattedSinVal = formats.sin.format(sinVal);
window.getTelemValue(formattedSinVal);
});
}, objectIdentifier);
return getTelemValuePromise;
}
/**
* Open the given `domainObject`'s context menu from the object tree.
* Expands the path to the object and scrolls to it if necessary.
*
* @param {import('@playwright/test').Page} page
* @param {string} url the url to the object
*/
async function openObjectTreeContextMenu(page, url) {
await page.goto(url);
await page.getByLabel('Show selected item in tree').click();
await page.locator('.is-navigated-object').click({
button: 'right'
});
}