mirror of
https://github.com/nasa/openmct.git
synced 2024-12-28 17:08:51 +00:00
4e5887d9ec
TreeView's observers will be called when the selected domain object changes, which can occur for one of two reasons: 1. Because a new value was set externally, from mct-tree. 2. Because a new value was selected, by the user. In the latter case a $apply is needed, but in the former it is not (and causes an error.) However, when that case occurs, the value in scope will be up to date already (it was a watch that triggered the call to treeView.value) so no assignment or $apply is necessary. Fixes #1114.
129 lines
4.9 KiB
JavaScript
129 lines
4.9 KiB
JavaScript
/*****************************************************************************
|
|
* Open MCT, Copyright (c) 2014-2016, United States Government
|
|
* as represented by the Administrator of the National Aeronautics and Space
|
|
* Administration. All rights reserved.
|
|
*
|
|
* Open MCT is licensed under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
* http://www.apache.org/licenses/LICENSE-2.0.
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
* Open MCT includes source code licensed under additional open source
|
|
* licenses. See the Open Source Licenses file (LICENSES.md) included with
|
|
* this source code distribution or the Licensing information page available
|
|
* at runtime from the About dialog for additional information.
|
|
*****************************************************************************/
|
|
|
|
define([
|
|
'../../src/directives/MCTTree'
|
|
], function (MCTTree) {
|
|
describe("The mct-tree directive", function () {
|
|
var mockParse,
|
|
mockGestureService,
|
|
mockExpr,
|
|
mctTree;
|
|
|
|
function makeMockDomainObject(id) {
|
|
var mockDomainObject = jasmine.createSpyObj('domainObject-' + id, [
|
|
'getId',
|
|
'getModel',
|
|
'getCapability',
|
|
'hasCapability'
|
|
]);
|
|
mockDomainObject.getId.andReturn(id);
|
|
mockDomainObject.getModel.andReturn({});
|
|
return mockDomainObject;
|
|
}
|
|
|
|
beforeEach(function () {
|
|
mockGestureService = jasmine.createSpyObj(
|
|
'gestureService',
|
|
['attachGestures']
|
|
);
|
|
mockParse = jasmine.createSpy('$parse');
|
|
mockExpr = jasmine.createSpy('expr');
|
|
mockExpr.assign = jasmine.createSpy('assign');
|
|
mockParse.andReturn(mockExpr);
|
|
|
|
mctTree = new MCTTree(mockParse, mockGestureService);
|
|
});
|
|
|
|
it("is applicable as an element", function () {
|
|
expect(mctTree.restrict).toEqual("E");
|
|
});
|
|
|
|
it("two-way binds to mctObject and mctModel", function () {
|
|
expect(mctTree.scope).toEqual({ mctObject: "=", mctModel: "=" });
|
|
});
|
|
|
|
describe("link", function () {
|
|
var mockScope,
|
|
mockElement,
|
|
testAttrs;
|
|
|
|
beforeEach(function () {
|
|
mockScope =
|
|
jasmine.createSpyObj('$scope', ['$watch', '$on', '$apply']);
|
|
mockElement = jasmine.createSpyObj('element', ['append']);
|
|
testAttrs = { mctModel: "some-expression" };
|
|
mockScope.$parent =
|
|
jasmine.createSpyObj('$scope', ['$watch', '$on']);
|
|
mctTree.link(mockScope, mockElement, testAttrs);
|
|
});
|
|
|
|
it("populates the mct-tree element", function () {
|
|
expect(mockElement.append).toHaveBeenCalled();
|
|
});
|
|
|
|
it("watches for mct-model's expression in the parent", function () {
|
|
expect(mockScope.$watch).toHaveBeenCalledWith(
|
|
"mctModel",
|
|
jasmine.any(Function)
|
|
);
|
|
});
|
|
|
|
it("watches for changes to mct-object", function () {
|
|
expect(mockScope.$watch).toHaveBeenCalledWith(
|
|
"mctObject",
|
|
jasmine.any(Function)
|
|
);
|
|
});
|
|
|
|
it("listens for the $destroy event", function () {
|
|
expect(mockScope.$on).toHaveBeenCalledWith(
|
|
"$destroy",
|
|
jasmine.any(Function)
|
|
);
|
|
});
|
|
|
|
// https://github.com/nasa/openmct/issues/1114
|
|
it("does not trigger $apply during $watches", function () {
|
|
mockScope.mctObject = makeMockDomainObject('root');
|
|
mockScope.mctMode = makeMockDomainObject('selection');
|
|
mockScope.$watch.calls.forEach(function (call) {
|
|
call.args[1](mockScope[call.args[0]]);
|
|
});
|
|
expect(mockScope.$apply).not.toHaveBeenCalled();
|
|
});
|
|
it("does trigger $apply from other value changes", function () {
|
|
// White-boxy; we know this is the setter for the tree's value
|
|
var treeValueFn = mockScope.$watch.calls[0].args[1];
|
|
|
|
mockScope.mctObject = makeMockDomainObject('root');
|
|
mockScope.mctMode = makeMockDomainObject('selection');
|
|
|
|
treeValueFn(makeMockDomainObject('other'));
|
|
|
|
expect(mockScope.$apply).toHaveBeenCalled();
|
|
});
|
|
});
|
|
});
|
|
|
|
});
|