mirror of
https://github.com/nasa/openmct.git
synced 2024-12-26 08:11:05 +00:00
16e1ac2529
* clock, timeConductor and appActions fixes
* Ensure realtime uses upstream context when available
Eliminate ambiguity when looking for time conductor locator
* Fix log plot e2e tests
* Fix displayLayout e2e tests
* Specify global time conductor to fix issues with duplicate selectors with independent time contexts
* a11y: ARIA for conductor and independent time conductor
* a11y: fix label collisions, specify 'Menu' in label
* Add watch mode
* fix(e2e): update appActions and tests to use a11y locators for ITC
* Don't remove the itc popup from the DOM. Just show/hide it once it's added the first time.
* test(e2e): disable one imagery test due to known bug
* Add fixme to tagging tests, issue described in 6822
* Fix locator for time conductor popups
* Improve how time bounds are set in independent time conductor.
Fix tests for flexible layout and timestrip
* Fix some tests for itc for display layouts
* Fix Inspector tabs remounting on change
* fix autoscale test and snapshot
* Fix telemetry table test
* Fix timestrip test
* e2e: move test info annotations to within test
* 6826: Fixes padStart error due to using it on a number rather than a string
* fix(e2e): update snapshots
* fix(e2e): fix restricted notebook locator
* fix(restrictedNotebook): fix issue causing sections not to update on lock
* fix(restrictedNotebook): fix issue causing snapshots to not be able to be deleted from a locked page
- Using `this.$delete(arr, index)` does not update the `length` property on the underlying target object, so it can lead to bizarre issues where your array is of length 4 but it has 3 objects in it.
* fix: replace all instances of `$delete` with `Array.splice()` or `delete`
* fix(e2e): fix grand search test
* fix(#3117): can remove item from displayLayout via tree context menu while viewing another item
* fix: remove typo
* Wait for background image to load
* fix(#6832): timelist events can tick down
* fix: ensure that menuitems have the raw objects so emits work
* fix: assign new arrays instead of editing state in-place
* refactor(timelist): use `getClock()` instead of `clock()`
* Revert "refactor(timelist): use `getClock()` instead of `clock()`"
This reverts commit d888553112
.
* refactor(timelist): use new timeAPI
* Stop ticking when the independent time context is disabled (#6833)
* Turn off the clock ticket for independent time conductor when it is disabled
* Fix linting issues
---------
Co-authored-by: Khalid Adil <khalidadil29@gmail.com>
* test: update couchdb notebook test
* fix: codeQL warnings
* fix(tree-item): infinite spinner issue
- Using `indexOf()` with an object was failing due to some items in the tree being Proxy-wrapped and others not. So instead, use `findIndex()` with a predicate that compares the navigationPaths of both objects
* [Timer] Remove "refresh" call, it is not needed (#6841)
* removing an unneccessary refresh that waas causing many get requests
* lets just pretend this never happened
* fix(mct-tree): maintain reactivity of all tree items
* Hide change role button in the indicator in cases where there is only… (#6840)
Hide change role button in the indicator in cases where there is only a single role available for the current user
---------
Co-authored-by: Shefali <simplyrender@gmail.com>
Co-authored-by: Khalid Adil <khalidadil29@gmail.com>
Co-authored-by: John Hill <john.c.hill@nasa.gov>
Co-authored-by: David Tsay <david.e.tsay@nasa.gov>
Co-authored-by: Jamie V <jamie.j.vigliotta@nasa.gov>
247 lines
10 KiB
JavaScript
247 lines
10 KiB
JavaScript
/*****************************************************************************
|
|
* Open MCT, Copyright (c) 2014-2023, United States Government
|
|
* as represented by the Administrator of the National Aeronautics and Space
|
|
* Administration. All rights reserved.
|
|
*
|
|
* Open MCT is licensed under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
* http://www.apache.org/licenses/LICENSE-2.0.
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
* Open MCT includes source code licensed under additional open source
|
|
* licenses. See the Open Source Licenses file (LICENSES.md) included with
|
|
* this source code distribution or the Licensing information page available
|
|
* at runtime from the About dialog for additional information.
|
|
*****************************************************************************/
|
|
|
|
/*
|
|
This test suite is dedicated to tests which verify the basic operations surrounding Notebooks with CouchDB.
|
|
*/
|
|
|
|
const { test, expect } = require('../../../../pluginFixtures');
|
|
const { createDomainObjectWithDefaults } = require('../../../../appActions');
|
|
const nbUtils = require('../../../../helper/notebookUtils');
|
|
|
|
test.describe('Notebook Tests with CouchDB @couchdb', () => {
|
|
let testNotebook;
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
//Navigate to baseURL
|
|
await page.goto('./', { waitUntil: 'domcontentloaded' });
|
|
|
|
// Create Notebook
|
|
testNotebook = await createDomainObjectWithDefaults(page, { type: 'Notebook' });
|
|
await page.goto(testNotebook.url, { waitUntil: 'networkidle' });
|
|
});
|
|
|
|
test('Inspect Notebook Entry Network Requests', async ({ page }) => {
|
|
//Ensure we're on the annotations Tab in the inspector
|
|
await page.getByText('Annotations').click();
|
|
// Expand sidebar
|
|
await page.locator('.c-notebook__toggle-nav-button').click();
|
|
|
|
// Collect all request events to count and assert after notebook action
|
|
let notebookElementsRequests = [];
|
|
page.on('request', (request) => notebookElementsRequests.push(request));
|
|
|
|
//Clicking Add Page generates
|
|
let [notebookUrlRequest] = await Promise.all([
|
|
// Waits for the next request with the specified url
|
|
page.waitForRequest(`**/openmct/${testNotebook.uuid}`),
|
|
// Triggers the request
|
|
page.click('[aria-label="Add Page"]')
|
|
]);
|
|
// Ensures that there are no other network requests
|
|
await page.waitForLoadState('networkidle');
|
|
|
|
// Assert that only two requests are made
|
|
// Network Requests are:
|
|
// 1) The actual POST to create the page
|
|
expect(notebookElementsRequests.length).toBe(1);
|
|
|
|
// Assert on request object
|
|
expect(notebookUrlRequest.postDataJSON().metadata.name).toBe(testNotebook.name);
|
|
expect(notebookUrlRequest.postDataJSON().model.persisted).toBeGreaterThanOrEqual(
|
|
notebookUrlRequest.postDataJSON().model.modified
|
|
);
|
|
|
|
// Add an entry
|
|
// Network Requests are:
|
|
// 1) The actual POST to create the entry
|
|
// 2) The shared worker event from 👆 POST request
|
|
notebookElementsRequests = [];
|
|
await nbUtils.enterTextEntry(page, 'First Entry');
|
|
await page.waitForLoadState('networkidle');
|
|
expect(notebookElementsRequests.length).toBeLessThanOrEqual(2);
|
|
|
|
// Add some tags
|
|
// Network Requests are for each tag creation are:
|
|
// 1) Getting the original path of the parent object
|
|
// 2) Getting the original path of the grandparent object (recursive call)
|
|
// 3) Creating the annotation/tag object
|
|
// 4) The shared worker event from 👆 POST request
|
|
// 5) Mutate notebook domain object's annotationModified property
|
|
// 6) The shared worker event from 👆 POST request
|
|
// 7) Notebooks fetching new annotations due to annotationModified changed
|
|
// 8) The update of the notebook domain's object's modified property
|
|
// 9) The shared worker event from 👆 POST request
|
|
// 10) Entry is timestamped
|
|
// 11) The shared worker event from 👆 POST request
|
|
|
|
notebookElementsRequests = [];
|
|
await addTagAndAwaitNetwork(page, 'Driving');
|
|
expect(filterNonFetchRequests(notebookElementsRequests).length).toBeLessThanOrEqual(11);
|
|
|
|
notebookElementsRequests = [];
|
|
await addTagAndAwaitNetwork(page, 'Drilling');
|
|
expect(filterNonFetchRequests(notebookElementsRequests).length).toBeLessThanOrEqual(11);
|
|
|
|
notebookElementsRequests = [];
|
|
await addTagAndAwaitNetwork(page, 'Science');
|
|
expect(filterNonFetchRequests(notebookElementsRequests).length).toBeLessThanOrEqual(11);
|
|
|
|
// Delete all the tags
|
|
// Network requests are:
|
|
// 1) Send POST to mutate _delete property to true on annotation with tag
|
|
// 2) The shared worker event from 👆 POST request
|
|
// 3) Timestamp update on entry
|
|
// 4) The shared worker event from 👆 POST request
|
|
// This happens for 3 tags so 12 requests
|
|
notebookElementsRequests = [];
|
|
await removeTagAndAwaitNetwork(page, 'Driving');
|
|
await removeTagAndAwaitNetwork(page, 'Drilling');
|
|
await removeTagAndAwaitNetwork(page, 'Science');
|
|
expect(filterNonFetchRequests(notebookElementsRequests).length).toBeLessThanOrEqual(12);
|
|
|
|
// Add two more pages
|
|
await page.click('[aria-label="Add Page"]');
|
|
await page.click('[aria-label="Add Page"]');
|
|
|
|
// Add three entries
|
|
await nbUtils.enterTextEntry(page, 'First Entry');
|
|
await nbUtils.enterTextEntry(page, 'Second Entry');
|
|
await nbUtils.enterTextEntry(page, 'Third Entry');
|
|
|
|
// Add three tags
|
|
await addTagAndAwaitNetwork(page, 'Science');
|
|
await addTagAndAwaitNetwork(page, 'Drilling');
|
|
await addTagAndAwaitNetwork(page, 'Driving');
|
|
|
|
// Add a fourth entry
|
|
// Network requests are:
|
|
// 1) Send POST to add new entry
|
|
// 2) The shared worker event from 👆 POST request
|
|
// 3) Timestamp update on entry
|
|
// 4) The shared worker event from 👆 POST request
|
|
notebookElementsRequests = [];
|
|
await nbUtils.enterTextEntry(page, 'Fourth Entry');
|
|
page.waitForLoadState('networkidle');
|
|
|
|
expect(filterNonFetchRequests(notebookElementsRequests).length).toBeLessThanOrEqual(4);
|
|
|
|
// Add a fifth entry
|
|
// Network requests are:
|
|
// 1) Send POST to add new entry
|
|
// 2) The shared worker event from 👆 POST request
|
|
// 3) Timestamp update on entry
|
|
// 4) The shared worker event from 👆 POST request
|
|
notebookElementsRequests = [];
|
|
await nbUtils.enterTextEntry(page, 'Fifth Entry');
|
|
page.waitForLoadState('networkidle');
|
|
|
|
expect(filterNonFetchRequests(notebookElementsRequests).length).toBeLessThanOrEqual(4);
|
|
|
|
// Add a sixth entry
|
|
// 1) Send POST to add new entry
|
|
// 2) The shared worker event from 👆 POST request
|
|
// 3) Timestamp update on entry
|
|
// 4) The shared worker event from 👆 POST request
|
|
notebookElementsRequests = [];
|
|
await nbUtils.enterTextEntry(page, 'Sixth Entry');
|
|
page.waitForLoadState('networkidle');
|
|
|
|
expect(filterNonFetchRequests(notebookElementsRequests).length).toBeLessThanOrEqual(4);
|
|
});
|
|
|
|
test('Search tests', async ({ page }) => {
|
|
test.info().annotations.push({
|
|
type: 'issue',
|
|
description: 'https://github.com/akhenry/openmct-yamcs/issues/69'
|
|
});
|
|
await page.getByText('Annotations').click();
|
|
await nbUtils.enterTextEntry(page, 'First Entry');
|
|
|
|
// Add three tags
|
|
await addTagAndAwaitNetwork(page, 'Science');
|
|
await addTagAndAwaitNetwork(page, 'Drilling');
|
|
await addTagAndAwaitNetwork(page, 'Driving');
|
|
|
|
await page.locator('[aria-label="OpenMCT Search"] input[type="search"]').click();
|
|
//Partial match for "Science" should only return Science
|
|
await page.locator('[aria-label="OpenMCT Search"] input[type="search"]').fill('Sc');
|
|
await expect(page.locator('[aria-label="Search Result"]').first()).toContainText('Science');
|
|
await expect(page.locator('[aria-label="Search Result"]').first()).not.toContainText('Driving');
|
|
await expect(page.locator('[aria-label="Search Result"]').first()).not.toContainText(
|
|
'Drilling'
|
|
);
|
|
|
|
//Searching for a tag which does not exist should return an empty result
|
|
await page.locator('[aria-label="OpenMCT Search"] input[type="search"]').click();
|
|
await page.locator('[aria-label="OpenMCT Search"] input[type="search"]').fill('Xq');
|
|
await expect(page.locator('text=No results found')).toBeVisible();
|
|
});
|
|
});
|
|
|
|
// Try to reduce indeterminism of browser requests by only returning fetch requests.
|
|
// Filter out preflight CORS, fetching stylesheets, page icons, etc. that can occur during tests
|
|
function filterNonFetchRequests(requests) {
|
|
return requests.filter((request) => {
|
|
return request.resourceType() === 'fetch';
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Add a tag to a notebook entry by providing a tagName.
|
|
* Reduces indeterminism by waiting until all necessary requests are completed.
|
|
* @param {import('@playwright/test').Page} page
|
|
* @param {string} tagName
|
|
*/
|
|
async function addTagAndAwaitNetwork(page, tagName) {
|
|
await page.hover(`button:has-text("Add Tag")`);
|
|
await page.locator(`button:has-text("Add Tag")`).click();
|
|
await page.locator('[placeholder="Type to select tag"]').click();
|
|
await Promise.all([
|
|
// Waits for the next request with the specified url
|
|
page.waitForRequest('**/openmct/_all_docs?include_docs=true'),
|
|
// Triggers the request
|
|
page.locator(`[aria-label="Autocomplete Options"] >> text=${tagName}`).click(),
|
|
expect(page.locator(`[aria-label="Tag"]:has-text("${tagName}")`)).toBeVisible()
|
|
]);
|
|
await page.waitForLoadState('networkidle');
|
|
}
|
|
|
|
/**
|
|
* Remove a tag to a notebook entry by providing a tagName.
|
|
* Reduces indeterminism by waiting until all necessary requests are completed.
|
|
* @param {import('@playwright/test').Page} page
|
|
* @param {string} tagName
|
|
*/
|
|
async function removeTagAndAwaitNetwork(page, tagName) {
|
|
await page.hover(`[aria-label="Tag"]:has-text("${tagName}")`);
|
|
await Promise.all([
|
|
page.locator(`[aria-label="Remove tag ${tagName}"]`).click(),
|
|
//With this pattern, we're awaiting the response but asserting on the request payload.
|
|
page.waitForResponse(
|
|
(resp) => resp.request().postData().includes(`"_deleted":true`) && resp.status() === 201
|
|
)
|
|
]);
|
|
await expect(page.locator(`[aria-label="Tag"]:has-text("${tagName}")`)).toBeHidden();
|
|
await page.waitForLoadState('networkidle');
|
|
}
|