mirror of
https://github.com/nasa/openmct.git
synced 2024-12-21 06:03:08 +00:00
0413e77d8a
* fix: update broken locator * update eslint package * first pass of lint fixes * update package * change ruleset * update component tests to match linting rules * driveby * start to factor out bad locators * update gauge component * update notebook snapshot drop area * Update plot aria * add draggable true to tree items * update package * driveby to remove dead code * unneeded * unneeded * tells a screenreader that this is a row and a cell * adds an id for dragondrops * this should be a button * first pass at fixing tooltip selectors * review comments * Updating more tests * update to remove expect expect given our use of check functions * add expand component * move role around * update more locators * force * new local storage * remove choochoo steps * test: do `lint:fix` and also add back accidentally removed code * test: add back more removed code * test: remove `unstable` annotation from tests which are not unstable * test: remove invalid test-- the "new" time conductor doesn't allow for millisecond changes in fixed time * test: fix unstable gauge test * test: remove useless asserts-- this was secretly non-functional. now that we've fixed it, it makes no sense and just fails * test: add back accidentally removed changes * test: revert changes that break test * test: more fixes * Remove all notion of the unstable/stable e2e tests * test: eviscerate the flake with FACTS and LOGIC * test: fix anotha one * lint fixes * test: no need to wait for save dialog * test: fix more tests * lint: fix more warnings * test: fix anotha one * test: use `toHaveLength` instead of `.length).toBe()` * test: stabilize tabs view example imagery test * fix: more tests be fixed * test: more `toHaveCount()`s please * test: revert more accidentally removed fixes * test: fix selector * test: fix anotha one * update lint rules to clean up bad locators in shared fixtures * update and remove bad appActions * test: fix some restricted notebook tests * test: mass find/replace to enforce `toHaveCount()` instead of `.count()).toBe()` * Remove some bad appActions and update text * test: fix da tree tests * test: await not await await * test: fix upload plan appAction and add a11y * Updating externalFixtures with best practice locators and add missing appAction framework tests * test: fix test * test: fix appAction test for plans * test: yum yum fix'em up and get rid of some dragon drops * fix: alas, a `.only()` got my hopes up that i was done fixing tests * test: add `setTimeConductorMode` test "suite" which covers most TC related appActions * test: fix arg * test(couchdb): fix some network tests via expect polling * Stabalize visual test * getCanasPixels * test: stabilize tooltip telemetry table test, better a11y for tooltips * chore: update to use `docker compose` instead of `docker-compose` * New rules, new tests, new me * fix sort order * test: add `waitForPlotsToRender` framework test, passthru timeout override * test: remove `clockOptions` test as we have `page.clock` now * test: refactor out `overrideClock` * test: use `clock.install` instead * test: use `clock.install` instead * time clock fix * test: fix timer tests * remove ever reference to old base fixture * test: stabilize restricted notebook test * lint fixes * test: use clock.install * update timelist * test: update visual tests to use `page.clock()`, update snapshots * test: stabilize tree renaming/reordering test * a11y: add aria-label and role=region to object view * refactor: use `dragTo` * refactor: use `dragTo`, other small fixes * test: use `page.clock()` to stabilize tooltip telemetry table test * test: use web-first assertion to stabilize staleness test * test: knock out a few more `page.click`s * test: destroy all `page.click()`s * refactor: consistently use `'Ok'` instead of `'OK'` and `'Ok'` mixed * test: remove gauge aria label * test: more test fixes * test: more fixes and refactors * docs: add comment * test: refactor all instances of `dragAndDrop` * test: remove redundant test (covered in previous test steps) * test: stabilize imagery operations tests for display layout * chore: remove bad unicorn rule * chore(lint): remove unused disable directives --------- Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov>
486 lines
15 KiB
JavaScript
486 lines
15 KiB
JavaScript
/*****************************************************************************
|
|
* Open MCT, Copyright (c) 2014-2024, United States Government
|
|
* as represented by the Administrator of the National Aeronautics and Space
|
|
* Administration. All rights reserved.
|
|
*
|
|
* Open MCT is licensed under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
* http://www.apache.org/licenses/LICENSE-2.0.
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
* Open MCT includes source code licensed under additional open source
|
|
* licenses. See the Open Source Licenses file (LICENSES.md) included with
|
|
* this source code distribution or the Licensing information page available
|
|
* at runtime from the About dialog for additional information.
|
|
*****************************************************************************/
|
|
|
|
/**
|
|
* This test is dedicated to test styling of flex layouts
|
|
*/
|
|
|
|
import { createDomainObjectWithDefaults } from '../../../../appActions.js';
|
|
import { checkStyles, hexToRGB, setStyles } from '../../../../helper/stylingUtils.js';
|
|
import { test } from '../../../../pluginFixtures.js';
|
|
|
|
const setBorderColor = '#ff00ff';
|
|
const setBackgroundColor = '#5b0f00';
|
|
const setTextColor = '#e6b8af';
|
|
const defaultFrameBorderColor = '#e6b8af'; //default border color
|
|
const defaultBorderTargetColor = '#acacac';
|
|
const defaultTextColor = '#acacac'; // default text color
|
|
const inheritedColor = '#acacac'; // inherited from the body style
|
|
const pukeGreen = '#6aa84f'; //Ugliest green known to man 🤮
|
|
const NO_STYLE_RGBA = 'rgba(0, 0, 0, 0)'; //default background color value
|
|
|
|
test.describe('Flexible Layout styling', () => {
|
|
let stackedPlot;
|
|
let flexibleLayout;
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.goto('./', { waitUntil: 'domcontentloaded' });
|
|
|
|
// Create a Flexible Layout and attach to the Stacked Plot
|
|
flexibleLayout = await createDomainObjectWithDefaults(page, {
|
|
type: 'Flexible Layout',
|
|
name: 'Flexible Layout'
|
|
});
|
|
|
|
// Create a Stacked Plot and attach to the Flexible Layout
|
|
stackedPlot = await createDomainObjectWithDefaults(page, {
|
|
type: 'Stacked Plot',
|
|
name: 'StackedPlot1',
|
|
parent: flexibleLayout.uuid
|
|
});
|
|
|
|
// Create a Stacked Plot and attach to the Flexible Layout
|
|
await createDomainObjectWithDefaults(page, {
|
|
type: 'Stacked Plot',
|
|
name: 'StackedPlot2',
|
|
parent: flexibleLayout.uuid
|
|
});
|
|
});
|
|
|
|
test('styling the flexible layout properly applies the styles to flex layout', async ({
|
|
page
|
|
}) => {
|
|
// Directly navigate to the flexible layout
|
|
await page.goto(flexibleLayout.url, { waitUntil: 'domcontentloaded' });
|
|
|
|
// Edit Flexible Layout
|
|
await page.getByLabel('Edit Object').click();
|
|
|
|
// Select styles tab
|
|
await page.getByRole('tab', { name: 'Styles' }).click();
|
|
|
|
// Set styles using setStyles function
|
|
await setStyles(
|
|
page,
|
|
setBorderColor,
|
|
setBackgroundColor,
|
|
setTextColor,
|
|
page.getByLabel('Flexible Layout Column')
|
|
);
|
|
|
|
// Flex Layout Column matches set styles
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page.getByLabel('Flexible Layout Column')
|
|
);
|
|
|
|
// Save Flexible Layout
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
|
|
|
|
// Reload page
|
|
await page.reload({ waitUntil: 'domcontentloaded' });
|
|
|
|
// Check styles of overall Flex Layout
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page.getByLabel('Flexible Layout Column')
|
|
);
|
|
|
|
// Check styles on StackedPlot1. Note: https://github.com/nasa/openmct/issues/7337
|
|
await checkStyles(
|
|
hexToRGB(defaultFrameBorderColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Check styles on StackedPlot2. Note: https://github.com/nasa/openmct/issues/7337
|
|
await checkStyles(
|
|
hexToRGB(defaultFrameBorderColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot2 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
});
|
|
|
|
test('styling a child object of the flexible layout properly applies that style to only that child', async ({
|
|
page
|
|
}) => {
|
|
// Directly navigate to the flexible layout
|
|
await page.goto(flexibleLayout.url, { waitUntil: 'domcontentloaded' });
|
|
|
|
// Edit Flexible Layout
|
|
await page.getByLabel('Edit Object').click();
|
|
|
|
// Select styles tab
|
|
await page.getByRole('tab', { name: 'Styles' }).click();
|
|
|
|
// Check styles on StackedPlot1
|
|
await checkStyles(
|
|
hexToRGB(defaultBorderTargetColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(defaultTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Check styles on StackedPlot2
|
|
await checkStyles(
|
|
hexToRGB(defaultBorderTargetColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(defaultTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot2 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Set styles using setStyles function on StackedPlot1 but not StackedPlot2
|
|
await setStyles(
|
|
page,
|
|
setBorderColor,
|
|
setBackgroundColor,
|
|
setTextColor,
|
|
page.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
);
|
|
|
|
// Check styles on StackedPlot1
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Check styles on StackedPlot2
|
|
await checkStyles(
|
|
hexToRGB(defaultBorderTargetColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(defaultTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot2 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Save Flexible Layout
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
|
|
|
|
// Reload page and verify that styles persist
|
|
await page.reload({ waitUntil: 'domcontentloaded' });
|
|
|
|
// Check styles on StackedPlot1
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Check styles on StackedPlot2
|
|
await checkStyles(
|
|
hexToRGB(defaultBorderTargetColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(defaultTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot2 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
});
|
|
|
|
test('if an overall style has been applied to the parent layout or plot, the individual styling should be able to coexist with that', async ({
|
|
page
|
|
}) => {
|
|
//Navigate to stackedPlot
|
|
await page.goto(stackedPlot.url, { waitUntil: 'domcontentloaded' });
|
|
|
|
// Edit stackedPlot
|
|
await page.getByLabel('Edit Object').click();
|
|
|
|
await page.getByRole('tab', { name: 'Styles' }).click();
|
|
|
|
// Set styles using setStyles function on StackedPlot1 but not StackedPlot2
|
|
await setStyles(
|
|
page,
|
|
setBorderColor,
|
|
setBackgroundColor,
|
|
setTextColor,
|
|
page.getByLabel('Stacked Plot Style Target').locator('div')
|
|
);
|
|
|
|
// Save Flexible Layout
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
|
|
|
|
// Directly navigate to the flexible layout
|
|
await page.goto(flexibleLayout.url, { waitUntil: 'domcontentloaded' });
|
|
|
|
// Edit Flexible Layout
|
|
await page.getByLabel('Edit Object').click();
|
|
|
|
// Select styles tab
|
|
await page.getByRole('tab', { name: 'Styles' }).click();
|
|
|
|
// Check styles on StackedPlot1 to match the set colors
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Check styles on StackedPlot2 to verify they are the default
|
|
await checkStyles(
|
|
hexToRGB(defaultBorderTargetColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(defaultTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot2 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Set styles using setStyles function on StackedPlot2
|
|
await setStyles(
|
|
page,
|
|
setBorderColor,
|
|
setBackgroundColor,
|
|
setTextColor,
|
|
page.getByRole('group', { name: 'StackedPlot2 Frame' })
|
|
);
|
|
|
|
// Check styles on StackedPlot2
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot2 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Save Flexible Layout
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
|
|
|
|
// Reload page and verify that styles persist
|
|
await page.reload({ waitUntil: 'domcontentloaded' });
|
|
|
|
// Check styles on StackedPlot1
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Check styles on StackedPlot2
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot2 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Directly navigate to the flexible layout
|
|
await page.goto(flexibleLayout.url, { waitUntil: 'domcontentloaded' });
|
|
|
|
// Edit Flexible Layout
|
|
await page.getByLabel('Edit Object').click();
|
|
|
|
// Select styles tab
|
|
await page.getByRole('tab', { name: 'Styles' }).click();
|
|
|
|
// Set Flex Layout Column to puke green
|
|
await setStyles(
|
|
page,
|
|
pukeGreen,
|
|
pukeGreen,
|
|
pukeGreen,
|
|
page.getByLabel('Flexible Layout Column')
|
|
);
|
|
// Save Flexible Layout
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
|
|
|
|
// Flex Layout Column matches set styles
|
|
await checkStyles(
|
|
hexToRGB(pukeGreen),
|
|
hexToRGB(pukeGreen),
|
|
hexToRGB(pukeGreen),
|
|
page.getByLabel('Flexible Layout Column')
|
|
);
|
|
|
|
// Check styles on StackedPlot1 matches previously set colors
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Check styles on StackedPlot2 matches previous set colors
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot2 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
});
|
|
|
|
test('when the "no style" option is selected, background and text should be reset to inherited styles', async ({
|
|
page
|
|
}) => {
|
|
// Directly navigate to the flexible layout
|
|
await page.goto(flexibleLayout.url, { waitUntil: 'domcontentloaded' });
|
|
|
|
// Edit Flexible Layout
|
|
await page.getByLabel('Edit Object').click();
|
|
|
|
// Select styles tab
|
|
await page.getByRole('tab', { name: 'Styles' }).click();
|
|
|
|
// Set styles using setStyles function
|
|
await setStyles(
|
|
page,
|
|
setBorderColor,
|
|
setBackgroundColor,
|
|
setTextColor,
|
|
page.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
);
|
|
|
|
// Check styles using checkStyles function
|
|
await checkStyles(
|
|
hexToRGB(setBorderColor),
|
|
hexToRGB(setBackgroundColor),
|
|
hexToRGB(setTextColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
|
|
// Save Flexible Layout
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
|
|
|
|
// Reload page and set Styles to 'None'
|
|
await page.reload({ waitUntil: 'domcontentloaded' });
|
|
|
|
// Edit Flexible Layout
|
|
await page.getByLabel('Edit Object').click();
|
|
|
|
// Select styles tab
|
|
await page.getByRole('tab', { name: 'Styles' }).click();
|
|
|
|
//Select the 'No Style' option
|
|
await setStyles(
|
|
page,
|
|
'No Style',
|
|
'No Style',
|
|
'No Style',
|
|
page.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
);
|
|
|
|
// Check styles using checkStyles function
|
|
await checkStyles(
|
|
hexToRGB(defaultBorderTargetColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(inheritedColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
// Save Flexible Layout
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
|
|
|
|
// Reload page and verify that styles persist
|
|
await page.reload({ waitUntil: 'domcontentloaded' });
|
|
|
|
// Check styles using checkStyles function
|
|
await checkStyles(
|
|
hexToRGB(defaultBorderTargetColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(inheritedColor),
|
|
page
|
|
.getByRole('group', { name: 'StackedPlot1 Frame' })
|
|
.getByLabel('Stacked Plot Style Target')
|
|
);
|
|
});
|
|
|
|
test('Styling, and then canceling reverts to previous style', async ({ page }) => {
|
|
test.info().annotations.push({
|
|
type: 'issue',
|
|
description: 'https://github.com/nasa/openmct/issues/7233'
|
|
});
|
|
|
|
await page.goto(flexibleLayout.url);
|
|
|
|
await page.getByLabel('Edit Object').click();
|
|
await page.getByRole('tab', { name: 'Styles' }).click();
|
|
await setStyles(
|
|
page,
|
|
setBorderColor,
|
|
setBackgroundColor,
|
|
setTextColor,
|
|
page.getByLabel('Flexible Layout Column')
|
|
);
|
|
await page.getByLabel('Cancel Editing').click();
|
|
await page.getByRole('button', { name: 'Ok', exact: true }).click();
|
|
await checkStyles(
|
|
hexToRGB(defaultBorderTargetColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(inheritedColor),
|
|
page.getByLabel('Flexible Layout Column')
|
|
);
|
|
|
|
await page.reload();
|
|
await checkStyles(
|
|
hexToRGB(defaultBorderTargetColor),
|
|
NO_STYLE_RGBA,
|
|
hexToRGB(inheritedColor),
|
|
page.getByLabel('Flexible Layout Column')
|
|
);
|
|
});
|
|
});
|