mirror of
https://github.com/nasa/openmct.git
synced 2025-01-02 03:16:41 +00:00
0413e77d8a
* fix: update broken locator * update eslint package * first pass of lint fixes * update package * change ruleset * update component tests to match linting rules * driveby * start to factor out bad locators * update gauge component * update notebook snapshot drop area * Update plot aria * add draggable true to tree items * update package * driveby to remove dead code * unneeded * unneeded * tells a screenreader that this is a row and a cell * adds an id for dragondrops * this should be a button * first pass at fixing tooltip selectors * review comments * Updating more tests * update to remove expect expect given our use of check functions * add expand component * move role around * update more locators * force * new local storage * remove choochoo steps * test: do `lint:fix` and also add back accidentally removed code * test: add back more removed code * test: remove `unstable` annotation from tests which are not unstable * test: remove invalid test-- the "new" time conductor doesn't allow for millisecond changes in fixed time * test: fix unstable gauge test * test: remove useless asserts-- this was secretly non-functional. now that we've fixed it, it makes no sense and just fails * test: add back accidentally removed changes * test: revert changes that break test * test: more fixes * Remove all notion of the unstable/stable e2e tests * test: eviscerate the flake with FACTS and LOGIC * test: fix anotha one * lint fixes * test: no need to wait for save dialog * test: fix more tests * lint: fix more warnings * test: fix anotha one * test: use `toHaveLength` instead of `.length).toBe()` * test: stabilize tabs view example imagery test * fix: more tests be fixed * test: more `toHaveCount()`s please * test: revert more accidentally removed fixes * test: fix selector * test: fix anotha one * update lint rules to clean up bad locators in shared fixtures * update and remove bad appActions * test: fix some restricted notebook tests * test: mass find/replace to enforce `toHaveCount()` instead of `.count()).toBe()` * Remove some bad appActions and update text * test: fix da tree tests * test: await not await await * test: fix upload plan appAction and add a11y * Updating externalFixtures with best practice locators and add missing appAction framework tests * test: fix test * test: fix appAction test for plans * test: yum yum fix'em up and get rid of some dragon drops * fix: alas, a `.only()` got my hopes up that i was done fixing tests * test: add `setTimeConductorMode` test "suite" which covers most TC related appActions * test: fix arg * test(couchdb): fix some network tests via expect polling * Stabalize visual test * getCanasPixels * test: stabilize tooltip telemetry table test, better a11y for tooltips * chore: update to use `docker compose` instead of `docker-compose` * New rules, new tests, new me * fix sort order * test: add `waitForPlotsToRender` framework test, passthru timeout override * test: remove `clockOptions` test as we have `page.clock` now * test: refactor out `overrideClock` * test: use `clock.install` instead * test: use `clock.install` instead * time clock fix * test: fix timer tests * remove ever reference to old base fixture * test: stabilize restricted notebook test * lint fixes * test: use clock.install * update timelist * test: update visual tests to use `page.clock()`, update snapshots * test: stabilize tree renaming/reordering test * a11y: add aria-label and role=region to object view * refactor: use `dragTo` * refactor: use `dragTo`, other small fixes * test: use `page.clock()` to stabilize tooltip telemetry table test * test: use web-first assertion to stabilize staleness test * test: knock out a few more `page.click`s * test: destroy all `page.click()`s * refactor: consistently use `'Ok'` instead of `'OK'` and `'Ok'` mixed * test: remove gauge aria label * test: more test fixes * test: more fixes and refactors * docs: add comment * test: refactor all instances of `dragAndDrop` * test: remove redundant test (covered in previous test steps) * test: stabilize imagery operations tests for display layout * chore: remove bad unicorn rule * chore(lint): remove unused disable directives --------- Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov>
227 lines
8.2 KiB
JavaScript
227 lines
8.2 KiB
JavaScript
/*****************************************************************************
|
|
* Open MCT, Copyright (c) 2014-2024, United States Government
|
|
* as represented by the Administrator of the National Aeronautics and Space
|
|
* Administration. All rights reserved.
|
|
*
|
|
* Open MCT is licensed under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
* http://www.apache.org/licenses/LICENSE-2.0.
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
* Open MCT includes source code licensed under additional open source
|
|
* licenses. See the Open Source Licenses file (LICENSES.md) included with
|
|
* this source code distribution or the Licensing information page available
|
|
* at runtime from the About dialog for additional information.
|
|
*****************************************************************************/
|
|
|
|
/*
|
|
Tests to verify log plot functionality. Note this test suite if very much under active development and should not
|
|
necessarily be used for reference when writing new tests in this area.
|
|
*/
|
|
|
|
import { createDomainObjectWithDefaults, setTimeConductorBounds } from '../../../../appActions.js';
|
|
import { expect, test } from '../../../../pluginFixtures.js';
|
|
|
|
test.describe('Log plot tests', () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
// fresh page with time range from 2022-03-29 22:00:00.000Z to 2022-03-29 22:00:30.000Z
|
|
await page.goto('./', { waitUntil: 'domcontentloaded' });
|
|
|
|
// Set a specific time range for consistency, otherwise it will change
|
|
// on every test to a range based on the current time.
|
|
const startDate = '2022-03-29';
|
|
const startTime = '22:00:00';
|
|
const endDate = '2022-03-29';
|
|
const endTime = '22:00:30';
|
|
|
|
await setTimeConductorBounds(page, { startDate, startTime, endDate, endTime });
|
|
|
|
const overlayPlot = await createDomainObjectWithDefaults(page, {
|
|
type: 'Overlay Plot',
|
|
name: 'Unnamed Overlay Plot'
|
|
});
|
|
|
|
// create a sinewave generator
|
|
await createDomainObjectWithDefaults(page, {
|
|
type: 'Sine Wave Generator',
|
|
name: 'Unnamed Sine Wave Generator',
|
|
parent: overlayPlot.uuid
|
|
});
|
|
|
|
await page.getByLabel('More actions').click();
|
|
await page.getByLabel('Edit Properties...').click();
|
|
|
|
// set amplitude to 6, offset 4, data rate 2 hz
|
|
await page.getByLabel('Amplitude', { exact: true }).fill('6');
|
|
await page.getByLabel('Offset', { exact: true }).fill('4');
|
|
await page.getByLabel('Data Rate (hz)', { exact: true }).fill('2');
|
|
|
|
await page.getByLabel('Save').click();
|
|
|
|
await page.goto(overlayPlot.url);
|
|
});
|
|
test('Log Plot ticks are functionally correct in regular and log mode and after refresh', async ({
|
|
page
|
|
}) => {
|
|
await testRegularTicks(page);
|
|
await enableEditMode(page);
|
|
await page.getByRole('tab', { name: 'Config' }).click();
|
|
await enableLogMode(page);
|
|
await testLogTicks(page);
|
|
await disableLogMode(page);
|
|
await testRegularTicks(page);
|
|
await enableLogMode(page);
|
|
await testLogTicks(page);
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
|
|
await testLogTicks(page);
|
|
});
|
|
|
|
// Leaving test as 'TODO' for now.
|
|
// NOTE: Not eligible for community contributions.
|
|
test.fixme('Verify that log mode option is reflected in import/export JSON', async ({ page }) => {
|
|
await enableEditMode(page);
|
|
await enableLogMode(page);
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();
|
|
|
|
// TODO ...export, delete the overlay, then import it...
|
|
|
|
//await testLogTicks(page);
|
|
|
|
// TODO, the plot is slightly at different position that in the other test, so this fails.
|
|
// ...We can fix it by copying all steps from the first test...
|
|
// await testLogPlotPixels(page);
|
|
});
|
|
});
|
|
|
|
/**
|
|
* @param {import('@playwright/test').Page} page
|
|
*/
|
|
async function testRegularTicks(page) {
|
|
const yTicks = page.locator('.gl-plot-y-tick-label');
|
|
await expect(yTicks).toHaveCount(7);
|
|
await expect(yTicks.nth(0)).toHaveText('-2');
|
|
await expect(yTicks.nth(1)).toHaveText('0');
|
|
await expect(yTicks.nth(2)).toHaveText('2');
|
|
await expect(yTicks.nth(3)).toHaveText('4');
|
|
await expect(yTicks.nth(4)).toHaveText('6');
|
|
await expect(yTicks.nth(5)).toHaveText('8');
|
|
await expect(yTicks.nth(6)).toHaveText('10');
|
|
}
|
|
|
|
/**
|
|
* @param {import('@playwright/test').Page} page
|
|
*/
|
|
async function testLogTicks(page) {
|
|
const yTicks = page.locator('.gl-plot-y-tick-label');
|
|
await expect(yTicks).toHaveCount(9);
|
|
await expect(yTicks.nth(0)).toHaveText('-2.98');
|
|
await expect(yTicks.nth(1)).toHaveText('-1.51');
|
|
await expect(yTicks.nth(2)).toHaveText('-0.58');
|
|
await expect(yTicks.nth(3)).toHaveText('-0.00');
|
|
await expect(yTicks.nth(4)).toHaveText('0.58');
|
|
await expect(yTicks.nth(5)).toHaveText('1.51');
|
|
await expect(yTicks.nth(6)).toHaveText('2.98');
|
|
await expect(yTicks.nth(7)).toHaveText('5.31');
|
|
await expect(yTicks.nth(8)).toHaveText('9.00');
|
|
}
|
|
|
|
/**
|
|
* @param {import('@playwright/test').Page} page
|
|
*/
|
|
async function enableEditMode(page) {
|
|
// turn on edit mode
|
|
await page.getByRole('button', { name: 'Edit Object' }).click();
|
|
await expect(page.getByRole('button', { name: 'Save' })).toBeVisible();
|
|
}
|
|
|
|
/**
|
|
* @param {import('@playwright/test').Page} page
|
|
*/
|
|
async function enableLogMode(page) {
|
|
await expect(page.getByRole('checkbox', { name: 'Log mode' })).not.toBeChecked();
|
|
await page.getByRole('checkbox', { name: 'Log mode' }).check();
|
|
}
|
|
|
|
/**
|
|
* @param {import('@playwright/test').Page} page
|
|
*/
|
|
async function disableLogMode(page) {
|
|
await expect(page.getByRole('checkbox', { name: 'Log mode' })).toBeChecked();
|
|
await page.getByRole('checkbox', { name: 'Log mode' }).uncheck();
|
|
}
|
|
|
|
/**
|
|
* @param {import('@playwright/test').Page} page
|
|
*/
|
|
// FIXME: Remove this eslint exception once implemented
|
|
// eslint-disable-next-line no-unused-vars
|
|
async function testLogPlotPixels(page) {
|
|
const pixelsMatch = await page.evaluate(async () => {
|
|
// TODO get canvas pixels at a few locations to make sure they're the correct color, to test that the plot comes out as expected.
|
|
|
|
await new Promise((r) => setTimeout(r, 5 * 1000));
|
|
|
|
// These are some pixels that should be blue points in the log plot.
|
|
// If the plot changes shape to an unexpected shape, this will
|
|
// likely fail, which is what we want.
|
|
//
|
|
// I found these pixels by pausing playwright in debug mode at this
|
|
// point, and using similar code as below to output the pixel data, then
|
|
// I logged those pixels here.
|
|
const expectedBluePixels = [
|
|
// TODO these pixel sets only work with the first test, but not the second test.
|
|
|
|
// [60, 35],
|
|
// [121, 125],
|
|
// [156, 377],
|
|
// [264, 73],
|
|
// [372, 186],
|
|
// [576, 73],
|
|
// [659, 439],
|
|
// [675, 423]
|
|
|
|
[60, 35],
|
|
[120, 125],
|
|
[156, 375],
|
|
[264, 73],
|
|
[372, 185],
|
|
[575, 72],
|
|
[659, 437],
|
|
[675, 421]
|
|
];
|
|
|
|
// The first canvas in the DOM is the one that has the plot point
|
|
// icons (canvas 2d), which is the one we are testing. The second
|
|
// one in the DOM is the WebGL canvas with the line. (Why aren't
|
|
// they both WebGL?)
|
|
const canvas = document.querySelector('canvas');
|
|
|
|
const ctx = canvas.getContext('2d');
|
|
|
|
for (const pixel of expectedBluePixels) {
|
|
// XXX Possible optimization: call getImageData only once with
|
|
// area including all pixels to be tested.
|
|
const data = ctx.getImageData(pixel[0], pixel[1], 1, 1).data;
|
|
|
|
// #43b0ffff <-- openmct cyanish-blue with 100% opacity
|
|
// if (data[0] !== 0x43 || data[1] !== 0xb0 || data[2] !== 0xff || data[3] !== 0xff) {
|
|
if (data[0] === 0 && data[1] === 0 && data[2] === 0 && data[3] === 0) {
|
|
// If any pixel is empty, it means we didn't hit a plot point.
|
|
return false;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
});
|
|
|
|
expect(pixelsMatch).toBe(true);
|
|
}
|