mirror of
https://github.com/nasa/openmct.git
synced 2024-12-20 05:37:53 +00:00
0413e77d8a
* fix: update broken locator * update eslint package * first pass of lint fixes * update package * change ruleset * update component tests to match linting rules * driveby * start to factor out bad locators * update gauge component * update notebook snapshot drop area * Update plot aria * add draggable true to tree items * update package * driveby to remove dead code * unneeded * unneeded * tells a screenreader that this is a row and a cell * adds an id for dragondrops * this should be a button * first pass at fixing tooltip selectors * review comments * Updating more tests * update to remove expect expect given our use of check functions * add expand component * move role around * update more locators * force * new local storage * remove choochoo steps * test: do `lint:fix` and also add back accidentally removed code * test: add back more removed code * test: remove `unstable` annotation from tests which are not unstable * test: remove invalid test-- the "new" time conductor doesn't allow for millisecond changes in fixed time * test: fix unstable gauge test * test: remove useless asserts-- this was secretly non-functional. now that we've fixed it, it makes no sense and just fails * test: add back accidentally removed changes * test: revert changes that break test * test: more fixes * Remove all notion of the unstable/stable e2e tests * test: eviscerate the flake with FACTS and LOGIC * test: fix anotha one * lint fixes * test: no need to wait for save dialog * test: fix more tests * lint: fix more warnings * test: fix anotha one * test: use `toHaveLength` instead of `.length).toBe()` * test: stabilize tabs view example imagery test * fix: more tests be fixed * test: more `toHaveCount()`s please * test: revert more accidentally removed fixes * test: fix selector * test: fix anotha one * update lint rules to clean up bad locators in shared fixtures * update and remove bad appActions * test: fix some restricted notebook tests * test: mass find/replace to enforce `toHaveCount()` instead of `.count()).toBe()` * Remove some bad appActions and update text * test: fix da tree tests * test: await not await await * test: fix upload plan appAction and add a11y * Updating externalFixtures with best practice locators and add missing appAction framework tests * test: fix test * test: fix appAction test for plans * test: yum yum fix'em up and get rid of some dragon drops * fix: alas, a `.only()` got my hopes up that i was done fixing tests * test: add `setTimeConductorMode` test "suite" which covers most TC related appActions * test: fix arg * test(couchdb): fix some network tests via expect polling * Stabalize visual test * getCanasPixels * test: stabilize tooltip telemetry table test, better a11y for tooltips * chore: update to use `docker compose` instead of `docker-compose` * New rules, new tests, new me * fix sort order * test: add `waitForPlotsToRender` framework test, passthru timeout override * test: remove `clockOptions` test as we have `page.clock` now * test: refactor out `overrideClock` * test: use `clock.install` instead * test: use `clock.install` instead * time clock fix * test: fix timer tests * remove ever reference to old base fixture * test: stabilize restricted notebook test * lint fixes * test: use clock.install * update timelist * test: update visual tests to use `page.clock()`, update snapshots * test: stabilize tree renaming/reordering test * a11y: add aria-label and role=region to object view * refactor: use `dragTo` * refactor: use `dragTo`, other small fixes * test: use `page.clock()` to stabilize tooltip telemetry table test * test: use web-first assertion to stabilize staleness test * test: knock out a few more `page.click`s * test: destroy all `page.click()`s * refactor: consistently use `'Ok'` instead of `'OK'` and `'Ok'` mixed * test: remove gauge aria label * test: more test fixes * test: more fixes and refactors * docs: add comment * test: refactor all instances of `dragAndDrop` * test: remove redundant test (covered in previous test steps) * test: stabilize imagery operations tests for display layout * chore: remove bad unicorn rule * chore(lint): remove unused disable directives --------- Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov>
167 lines
7.1 KiB
JavaScript
167 lines
7.1 KiB
JavaScript
/*****************************************************************************
|
|
* Open MCT, Copyright (c) 2014-2024, United States Government
|
|
* as represented by the Administrator of the National Aeronautics and Space
|
|
* Administration. All rights reserved.
|
|
*
|
|
* Open MCT is licensed under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
* http://www.apache.org/licenses/LICENSE-2.0.
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
* Open MCT includes source code licensed under additional open source
|
|
* licenses. See the Open Source Licenses file (LICENSES.md) included with
|
|
* this source code distribution or the Licensing information page available
|
|
* at runtime from the About dialog for additional information.
|
|
*****************************************************************************/
|
|
|
|
/*
|
|
* This test suite template is to be used when creating new test suites. It will be kept up to date with the latest improvements
|
|
* made by the Open MCT team. It will also follow our best practices as those evolve. Please use this structure as a _reference_ and clear
|
|
* or update any references when creating a new test suite!
|
|
*
|
|
* To illustrate current best practices, we've included a mocked up test suite for Renaming a Timer domain object.
|
|
*
|
|
* Demonstrated:
|
|
* - Using appActions to leverage existing functions
|
|
* - Structure
|
|
* - await, expect, test, describe syntax
|
|
* - Writing a custom function for a test suite
|
|
* - Test stub for unfinished test coverage (test.fixme)
|
|
*
|
|
* The structure should follow
|
|
* 1. imports
|
|
* 2. test.describe()
|
|
* 3. -> test1
|
|
* -> test2
|
|
* -> test3(stub)
|
|
* 4. Any custom functions
|
|
*/
|
|
|
|
// Structure: Some standard Imports. Please update the required pathing.
|
|
import { createDomainObjectWithDefaults, createExampleTelemetryObject } from '../../appActions.js';
|
|
import { expect, test } from '../../pluginFixtures.js';
|
|
|
|
/**
|
|
* Structure:
|
|
* Try to keep a single describe block per logical groups of tests.
|
|
* If your test runtime exceeds 5 minutes or 500 lines, it's likely that it will need to be split.
|
|
*
|
|
*/
|
|
test.describe('Example - Renaming Timer Object', () => {
|
|
// Top-level declaration of the Timer object created in beforeEach().
|
|
// We can then use this throughout the entire test suite.
|
|
let timer;
|
|
test.beforeEach(async ({ page }) => {
|
|
// Open a browser, navigate to the main page, and wait until all network events to resolve
|
|
await page.goto('./', { waitUntil: 'domcontentloaded' });
|
|
|
|
// We provide some helper functions in appActions like `createDomainObjectWithDefaults()`.
|
|
// This example will create a Timer object with default properties, under the root folder:
|
|
timer = await createDomainObjectWithDefaults(page, { type: 'Timer' });
|
|
|
|
// Assert the object to be created and check its name in the title
|
|
await expect(page.getByRole('main')).toContainText(timer.name);
|
|
});
|
|
|
|
/**
|
|
* Make sure to use testcase names which are descriptive and easy to understand.
|
|
* A good testcase name concisely describes the test's goal(s) and should give
|
|
* some hint as to what went wrong if the test fails.
|
|
*/
|
|
test('An existing Timer object can be renamed via the 3dot actions menu', async ({ page }) => {
|
|
const newObjectName = 'Renamed Timer';
|
|
|
|
// We've created an example of a shared function which passes the page and newObjectName values
|
|
await renameTimerFrom3DotMenu(page, timer.url, newObjectName);
|
|
|
|
// Assert that the name has changed in the browser bar to the value we assigned above
|
|
await expect(page.getByRole('main')).toContainText(newObjectName);
|
|
});
|
|
|
|
test('An existing Timer object can be renamed twice', async ({ page }) => {
|
|
const newObjectName = 'Renamed Timer';
|
|
const newObjectName2 = 'Re-Renamed Timer';
|
|
|
|
await renameTimerFrom3DotMenu(page, timer.url, newObjectName);
|
|
|
|
// Assert that the name has changed in the browser bar to the value we assigned above
|
|
await expect(page.getByRole('main')).toContainText(newObjectName);
|
|
|
|
// Rename the Timer object again
|
|
await renameTimerFrom3DotMenu(page, timer.url, newObjectName2);
|
|
|
|
// Assert that the name has changed in the browser bar to the second value
|
|
await expect(page.getByRole('main')).toContainText(newObjectName2);
|
|
});
|
|
|
|
/**
|
|
* If you run out of time to write new tests, please stub in the missing tests
|
|
* in-place with a test.fixme and BDD-style test steps.
|
|
* Someone will carry the baton!
|
|
*/
|
|
test.fixme('Can Rename Timer Object from Tree', async ({ page }) => {
|
|
//Create a new object
|
|
//Copy this object
|
|
//Delete first object
|
|
//Expect copied object to persist
|
|
});
|
|
});
|
|
|
|
/**
|
|
* The next most important concept in our testing is working with telemetry objects. Telemetry is at the core of Open MCT
|
|
* and we have developed a great pattern for working with it.
|
|
*/
|
|
test.describe('Advanced Example - Working with telemetry objects', () => {
|
|
let displayLayout;
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.goto('./', { waitUntil: 'domcontentloaded' });
|
|
|
|
// Create a Display Layout with a meaningful name
|
|
displayLayout = await createDomainObjectWithDefaults(page, {
|
|
type: 'Display Layout',
|
|
name: 'Display Layout with Embedded SWG'
|
|
});
|
|
// Create Telemetry object within the parent object created above
|
|
//reference the display layout in the creation process
|
|
await createExampleTelemetryObject(page, displayLayout.uuid);
|
|
});
|
|
test('Can directly navigate to a Display Layout with embedded telemetry', async ({ page }) => {
|
|
//Now you can directly navigate to the displayLayout created in the beforeEach with the embedded telemetry
|
|
await page.goto(displayLayout.url);
|
|
//Expect the created Telemetry Object to be visible when directly navigating to the displayLayout
|
|
await expect(page.getByLabel('Alpha-numeric telemetry name')).toBeVisible();
|
|
});
|
|
});
|
|
|
|
/**
|
|
* Structure:
|
|
* Custom functions should be declared last.
|
|
* We are leaning on JSDoc pretty heavily to describe functionality. It is not required, but highly recommended.
|
|
*/
|
|
|
|
/**
|
|
* This is an example of a function which is shared between testcases in this test suite. When refactoring, we'll be looking
|
|
* for common functionality which makes sense to generalize for the entire test framework.
|
|
* @param {import('@playwright/test').Page} page
|
|
* @param {string} timerUrl The URL of the timer object to be renamed
|
|
* @param {string} newNameForTimer New name for object
|
|
*/
|
|
async function renameTimerFrom3DotMenu(page, timerUrl, newNameForTimer) {
|
|
// Navigate to the timer object directly
|
|
await page.goto(timerUrl);
|
|
|
|
await page.getByLabel('More actions').click();
|
|
await page.getByLabel('Edit Properties...').click();
|
|
|
|
// Rename the timer object
|
|
await page.getByLabel('Title', { exact: true }).fill(newNameForTimer);
|
|
|
|
await page.getByLabel('Save').click();
|
|
}
|