mirror of
https://github.com/nasa/openmct.git
synced 2025-01-24 05:18:06 +00:00
0413e77d8a
* fix: update broken locator * update eslint package * first pass of lint fixes * update package * change ruleset * update component tests to match linting rules * driveby * start to factor out bad locators * update gauge component * update notebook snapshot drop area * Update plot aria * add draggable true to tree items * update package * driveby to remove dead code * unneeded * unneeded * tells a screenreader that this is a row and a cell * adds an id for dragondrops * this should be a button * first pass at fixing tooltip selectors * review comments * Updating more tests * update to remove expect expect given our use of check functions * add expand component * move role around * update more locators * force * new local storage * remove choochoo steps * test: do `lint:fix` and also add back accidentally removed code * test: add back more removed code * test: remove `unstable` annotation from tests which are not unstable * test: remove invalid test-- the "new" time conductor doesn't allow for millisecond changes in fixed time * test: fix unstable gauge test * test: remove useless asserts-- this was secretly non-functional. now that we've fixed it, it makes no sense and just fails * test: add back accidentally removed changes * test: revert changes that break test * test: more fixes * Remove all notion of the unstable/stable e2e tests * test: eviscerate the flake with FACTS and LOGIC * test: fix anotha one * lint fixes * test: no need to wait for save dialog * test: fix more tests * lint: fix more warnings * test: fix anotha one * test: use `toHaveLength` instead of `.length).toBe()` * test: stabilize tabs view example imagery test * fix: more tests be fixed * test: more `toHaveCount()`s please * test: revert more accidentally removed fixes * test: fix selector * test: fix anotha one * update lint rules to clean up bad locators in shared fixtures * update and remove bad appActions * test: fix some restricted notebook tests * test: mass find/replace to enforce `toHaveCount()` instead of `.count()).toBe()` * Remove some bad appActions and update text * test: fix da tree tests * test: await not await await * test: fix upload plan appAction and add a11y * Updating externalFixtures with best practice locators and add missing appAction framework tests * test: fix test * test: fix appAction test for plans * test: yum yum fix'em up and get rid of some dragon drops * fix: alas, a `.only()` got my hopes up that i was done fixing tests * test: add `setTimeConductorMode` test "suite" which covers most TC related appActions * test: fix arg * test(couchdb): fix some network tests via expect polling * Stabalize visual test * getCanasPixels * test: stabilize tooltip telemetry table test, better a11y for tooltips * chore: update to use `docker compose` instead of `docker-compose` * New rules, new tests, new me * fix sort order * test: add `waitForPlotsToRender` framework test, passthru timeout override * test: remove `clockOptions` test as we have `page.clock` now * test: refactor out `overrideClock` * test: use `clock.install` instead * test: use `clock.install` instead * time clock fix * test: fix timer tests * remove ever reference to old base fixture * test: stabilize restricted notebook test * lint fixes * test: use clock.install * update timelist * test: update visual tests to use `page.clock()`, update snapshots * test: stabilize tree renaming/reordering test * a11y: add aria-label and role=region to object view * refactor: use `dragTo` * refactor: use `dragTo`, other small fixes * test: use `page.clock()` to stabilize tooltip telemetry table test * test: use web-first assertion to stabilize staleness test * test: knock out a few more `page.click`s * test: destroy all `page.click()`s * refactor: consistently use `'Ok'` instead of `'OK'` and `'Ok'` mixed * test: remove gauge aria label * test: more test fixes * test: more fixes and refactors * docs: add comment * test: refactor all instances of `dragAndDrop` * test: remove redundant test (covered in previous test steps) * test: stabilize imagery operations tests for display layout * chore: remove bad unicorn rule * chore(lint): remove unused disable directives --------- Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov>
333 lines
13 KiB
JavaScript
333 lines
13 KiB
JavaScript
/*****************************************************************************
|
|
* Open MCT, Copyright (c) 2014-2024, United States Government
|
|
* as represented by the Administrator of the National Aeronautics and Space
|
|
* Administration. All rights reserved.
|
|
*
|
|
* Open MCT is licensed under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
* http://www.apache.org/licenses/LICENSE-2.0.
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
* Open MCT includes source code licensed under additional open source
|
|
* licenses. See the Open Source Licenses file (LICENSES.md) included with
|
|
* this source code distribution or the Licensing information page available
|
|
* at runtime from the About dialog for additional information.
|
|
*****************************************************************************/
|
|
|
|
import { expect, test } from '@playwright/test';
|
|
import { fileURLToPath } from 'url';
|
|
|
|
const memoryLeakFilePath = fileURLToPath(
|
|
new URL('../../../../e2e/test-data/memory-leak-detection.json', import.meta.url)
|
|
);
|
|
/**
|
|
* Executes tests to verify that views are not leaking memory on navigation away. This sort of
|
|
* memory leak is generally caused by a failure to clean up registered listeners.
|
|
*
|
|
* These tests are executed on a set of pre-built displays loaded from ../test-data/memory-leak-detection.json.
|
|
*
|
|
* In order to modify the test data set:
|
|
* 1. Run Open MCT locally (npm start)
|
|
* 2. Right click on a folder in the tree, and select "Import From JSON"
|
|
* 3. In the subsequent dialog, select the file ../test-data/memory-leak-detection.json
|
|
* 4. Click "OK"
|
|
* 5. Modify test objects as desired
|
|
* 6. Right click on the "Memory Leak Detection" folder, and select "Export to JSON"
|
|
* 7. Copy the exported file to ../test-data/memory-leak-detection.json
|
|
*
|
|
*/
|
|
|
|
test.describe('Navigation memory leak is not detected in', () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
// Go to baseURL
|
|
await page.goto('./', { waitUntil: 'domcontentloaded' });
|
|
|
|
await page
|
|
.getByRole('treeitem', {
|
|
name: /My Items/
|
|
})
|
|
.click({
|
|
button: 'right'
|
|
});
|
|
|
|
await page
|
|
.getByRole('menuitem', {
|
|
name: /Import from JSON/
|
|
})
|
|
.click();
|
|
|
|
// Upload memory-leak-detection.json
|
|
await page.setInputFiles('#fileElem', memoryLeakFilePath);
|
|
|
|
await page
|
|
.getByRole('button', {
|
|
name: 'Save'
|
|
})
|
|
.click();
|
|
|
|
await expect(page.locator('a:has-text("Memory Leak Detection")')).toBeVisible();
|
|
});
|
|
|
|
test('gauge', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'gauge-single-1hz-swg');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('plan', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'plan-generated');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('time list', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'time-list');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('scatter', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'scatter-plot-single-1hz-swg');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('graph', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'graph-single-1hz-swg');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('gantt chart', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'gantt-chart');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('clock', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'clock');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('timer', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'timer-far-future');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('web page (nasa.gov)', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'web-page');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('Complex Display Layout', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'complex-display-layout');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('plot view', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'overlay-plot-single-1hz-swg');
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('stacked plot view', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'stacked-plot-single-1hz-swg');
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('LAD table view', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'lad-table-single-1hz-swg');
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('LAD table set', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'lad-table-set-single-1hz-swg');
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
//TODO: Figure out why using the `table-row` component inside the `table` component leaks TelemetryTableRow objects
|
|
test('telemetry table view', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(
|
|
page,
|
|
'telemetry-table-single-1hz-swg'
|
|
);
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
//TODO: Figure out why using the `SideBar` component inside the leaks Notebook objects
|
|
test('notebook view', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(
|
|
page,
|
|
'notebook-memory-leak-detection-test'
|
|
);
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('display layout of a single SWG alphanumeric', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(page, 'display-layout-single-1hz-swg');
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('display layout of a single SWG plot', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(
|
|
page,
|
|
'display-layout-single-overlay-plot'
|
|
);
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
//TODO: Figure out why `svg` in the CompassRose component leaks imagery
|
|
test('example imagery view', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(
|
|
page,
|
|
'example-imagery-memory-leak-test'
|
|
);
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('display layout of example imagery views', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(
|
|
page,
|
|
'display-layout-images-memory-leak-test'
|
|
);
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('display layout with plots of swgs, alphanumerics, and condition sets', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(
|
|
page,
|
|
'display-layout-simple-telemetry'
|
|
);
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('flexible layout with plots of swgs', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(
|
|
page,
|
|
'flexible-layout-plots-memory-leak-test'
|
|
);
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('flexible layout of example imagery views', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(
|
|
page,
|
|
'flexible-layout-images-memory-leak-test'
|
|
);
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('tabbed view of display layouts and time strips', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(
|
|
page,
|
|
'tab-view-simple-memory-leak-test'
|
|
);
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
test('time strip view of telemetry', async ({ page }) => {
|
|
const result = await navigateToObjectAndDetectMemoryLeak(
|
|
page,
|
|
'time-strip-telemetry-memory-leak-test'
|
|
);
|
|
|
|
// If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
|
|
expect(result).toBe(true);
|
|
});
|
|
|
|
/**
|
|
*
|
|
* @param {import('@playwright/test').Page} page
|
|
* @param {*} objectName
|
|
* @returns
|
|
*/
|
|
async function navigateToObjectAndDetectMemoryLeak(page, objectName) {
|
|
await page.getByRole('searchbox', { name: 'Search Input' }).click();
|
|
// Fill Search input
|
|
await page.getByRole('searchbox', { name: 'Search Input' }).fill(objectName);
|
|
|
|
//Search Result Appears and is clicked
|
|
await page.getByText(objectName, { exact: true }).click();
|
|
|
|
// Register a finalization listener on the root node for the view. This tends to be the last thing to be
|
|
// garbage collected since it has either direct or indirect references to all resources used by the view. Therefore it's a pretty good proxy
|
|
// for detecting memory leaks.
|
|
await page.evaluate(() => {
|
|
window.gcPromise = new Promise((resolve) => {
|
|
window.fr = new FinalizationRegistry(resolve);
|
|
window.fr.register(
|
|
window.openmct.layout.$refs.browseObject.$refs.objectViewWrapper.firstChild,
|
|
'navigatedObject',
|
|
window.openmct.layout.$refs.browseObject.$refs.objectViewWrapper.firstChild
|
|
);
|
|
});
|
|
});
|
|
|
|
// Nav back to folder
|
|
await page.goto('./#/browse/mine');
|
|
|
|
// This next code block blocks until the finalization listener is called and the gcPromise resolved. This means that the root node for the view has been garbage collected.
|
|
// In the event that the root node is not garbage collected, the gcPromise will never resolve and the test will time out.
|
|
await page.evaluate(() => {
|
|
const gcPromise = window.gcPromise;
|
|
window.gcPromise = null;
|
|
|
|
// Manually invoke the garbage collector once all references are removed.
|
|
window.gc();
|
|
|
|
return gcPromise;
|
|
});
|
|
|
|
// Clean up the finalization registry since we don't need it any more.
|
|
await page.evaluate(() => {
|
|
window.fr = null;
|
|
});
|
|
|
|
// If we get here without timing out, it means the garbage collection promise resolved and the test passed.
|
|
return true;
|
|
}
|
|
});
|