Merge branch 'master' into improve-test-coverage

Bug fixes for plots (#3019 ) (#3069 )
* prevent plots from breaking when more than one NaN is received. * fix y axis label issue * dont emit a viewport change event when marquee doesnt happen
2025-06-28 03:42:21 +00:00 · 2020-05-28 11:55:01 -07:00 · 2020-05-28 09:58:22 -07:00 · 2020-05-27 10:59:02 -07:00 · 2020-05-26 11:39:55 -07:00 · 2020-05-19 09:33:08 -07:00
77 changed files with 320 additions and 182 deletions
--- a/.eslintrc.js
+++ b/.eslintrc.js
@ -10,7 +10,8 @@ module.exports = {
    },
    "extends": [
        "eslint:recommended",
-        "plugin:vue/recommended"
+        "plugin:vue/recommended",
+        "plugin:you-dont-need-lodash-underscore/compatible"
    ],
    "parser": "vue-eslint-parser",
    "parserOptions": {
@ -22,6 +23,9 @@ module.exports = {
        }
    },
    "rules": {
+        "you-dont-need-lodash-underscore/omit": "off",
+        "you-dont-need-lodash-underscore/throttle": "off",
+        "you-dont-need-lodash-underscore/flatten": "off",
        "no-bitwise": "error",
        "curly": "error",
        "eqeqeq": "error",
--- a/example/generator/GeneratorMetadataProvider.js
+++ b/example/generator/GeneratorMetadataProvider.js
@ -100,7 +100,7 @@ define([
    };

    GeneratorMetadataProvider.prototype.getMetadata = function (domainObject) {
-        return _.extend(
+        return Object.assign(
            {},
            domainObject.telemetry,
            METADATA_BY_TYPE[domainObject.type]
--- a/package.json
+++ b/package.json
@ -24,6 +24,7 @@
    "d3-time-format": "2.1.x",
    "eslint": "5.2.0",
    "eslint-plugin-vue": "^6.0.0",
+    "eslint-plugin-you-dont-need-lodash-underscore": "^6.10.0",
    "eventemitter3": "^1.2.0",
    "exports-loader": "^0.7.0",
    "express": "^4.13.1",
@ -48,7 +49,7 @@
    "karma-sourcemap-loader": "^0.3.7",
    "karma-webpack": "^3.0.0",
    "location-bar": "^3.0.1",
-    "lodash": "^3.10.1",
+    "lodash": "^4.17.12",
    "markdown-toc": "^0.11.7",
    "marked": "^0.3.5",
    "mini-css-extract-plugin": "^0.4.1",
--- a/platform/commonUI/edit/src/policies/EditPersistableObjectsPolicy.js
+++ b/platform/commonUI/edit/src/policies/EditPersistableObjectsPolicy.js
@ -21,7 +21,7 @@
 *****************************************************************************/

 define(
-    ['../../../../../src/api/objects/object-utils'],
+    ['objectUtils'],
    function (objectUtils) {

        /**
--- a/platform/containment/src/PersistableCompositionPolicy.js
+++ b/platform/containment/src/PersistableCompositionPolicy.js
@ -26,7 +26,7 @@
 * @namespace platform/containment
 */
 define(
-    ['../../../src/api/objects/object-utils'],
+    ['objectUtils'],
    function (objectUtils) {

        function PersistableCompositionPolicy(openmct) {
--- a/platform/core/src/actions/ActionCapability.js
+++ b/platform/core/src/actions/ActionCapability.js
@ -81,7 +81,7 @@ define(
                baseContext = context || {};
            }

-            var actionContext = _.extend({}, baseContext);
+            var actionContext = Object.assign({}, baseContext);
            actionContext.domainObject = this.domainObject;

            return this.actionService.getActions(actionContext);
--- a/platform/import-export/src/actions/ExportAsJSONAction.js
+++ b/platform/import-export/src/actions/ExportAsJSONAction.js
@ -121,7 +121,7 @@ define(['lodash'], function (_) {
     */
    ExportAsJSONAction.prototype.rewriteLink = function (child, parent) {
        this.externalIdentifiers.push(this.getId(child));
-        var index = _.findIndex(parent.composition, function (id) {
+        var index = parent.composition.findIndex(id => {
            return _.isEqual(child.identifier, id);
        });
        var copyOfChild = this.copyObject(child);
--- a/platform/import-export/src/actions/ImportAsJSONAction.js
+++ b/platform/import-export/src/actions/ImportAsJSONAction.js
@ -19,7 +19,7 @@
 * this source code distribution or the Licensing information page available
 * at runtime from the About dialog for additional information.
 *****************************************************************************/
-define(['zepto', '../../../../src/api/objects/object-utils.js'], function ($, objectUtils) {
+define(['zepto', 'objectUtils'], function ($, objectUtils) {

    /**
     * The ImportAsJSONAction is available from context menus and allows a user
--- a/platform/search/src/services/GenericSearchProvider.js
+++ b/platform/search/src/services/GenericSearchProvider.js
@ -25,7 +25,7 @@
 * Module defining GenericSearchProvider. Created by shale on 07/16/2015.
 */
 define([
-    '../../../../src/api/objects/object-utils',
+    'objectUtils',
    'lodash'
 ], function (
    objectUtils,
@ -191,7 +191,7 @@ define([
        }

        var domainObject = objectUtils.toNewFormat(model, id);
-        var composition = _.find(this.openmct.composition.registry, function (p) {
+        var composition = this.openmct.composition.registry.find(p => {
            return p.appliesTo(domainObject);
        });

--- a/platform/telemetry/src/TelemetryCapability.js
+++ b/platform/telemetry/src/TelemetryCapability.js
@ -25,7 +25,7 @@
 */
 define(
    [
-        '../../../src/api/objects/object-utils',
+        'objectUtils',
        'lodash'
    ],
    function (
@ -235,7 +235,7 @@ define(
            var defaultRange = metadata.valuesForHints(['range'])[0];
            defaultRange = defaultRange ? defaultRange.key : undefined;

-            var sourceMap = _.indexBy(metadata.values(), 'key');
+            var sourceMap = _.keyBy(metadata.values(), 'key');

            var isLegacyProvider = telemetryAPI.findRequestProvider(domainObject) ===
                telemetryAPI.legacyProvider;
@ -300,7 +300,7 @@ define(
            var defaultRange = metadata.valuesForHints(['range'])[0];
            defaultRange = defaultRange ? defaultRange.key : undefined;

-            var sourceMap = _.indexBy(metadata.values(), 'key');
+            var sourceMap = _.keyBy(metadata.values(), 'key');

            var isLegacyProvider = telemetryAPI.findSubscriptionProvider(domainObject) ===
                telemetryAPI.legacyProvider;
--- a/src/MCT.js
+++ b/src/MCT.js
@ -28,7 +28,7 @@ define([
    './api/api',
    './api/overlays/OverlayAPI',
    './selection/Selection',
-    './api/objects/object-utils',
+    'objectUtils',
    './plugins/plugins',
    './adapter/indicators/legacy-indicators-plugin',
    './plugins/buildInfo/plugin',
@ -249,7 +249,7 @@ define([
        this.legacyRegistry = new BundleRegistry();
        installDefaultBundles(this.legacyRegistry);

-        // Plugin's that are installed by default
+        // Plugins that are installed by default

        this.install(this.plugins.Plot());
        this.install(this.plugins.TelemetryTable());
@ -350,17 +350,13 @@ define([
     * @param {HTMLElement} [domElement] the DOM element in which to run
     *        MCT; if undefined, MCT will be run in the body of the document
     */
-    MCT.prototype.start = function (domElement) {
+    MCT.prototype.start = function (domElement = document.body, isHeadlessMode = false) {
        if (!this.plugins.DisplayLayout._installed) {
            this.install(this.plugins.DisplayLayout({
                showAsView: ['summary-widget']
            }));
        }

-        if (!domElement) {
-            domElement = document.body;
-        }
-
        this.element = domElement;

        this.legacyExtension('runs', {
@ -400,6 +396,7 @@ define([
                // something has depended upon objectService.  Cool, right?
                this.$injector.get('objectService');

+                if (!isHeadlessMode) {
                    var appLayout = new Vue({
                        components: {
                            'Layout': Layout.default
@ -413,11 +410,17 @@ define([

                    this.layout = appLayout.$refs.layout;
                    Browse(this);
+                }
                this.router.start();
                this.emit('start');
            }.bind(this));
    };

+    MCT.prototype.startHeadless = function () {
+        let unreachableNode = document.createElement('div');
+        return this.start(unreachableNode, true);
+    }
+
    /**
     * Install a plugin in MCT.
     *
--- a/src/MCTSpec.js
+++ b/src/MCTSpec.js
@ -21,11 +21,11 @@
 *****************************************************************************/

 define([
-    './MCT',
    './plugins/plugins',
-    'legacyRegistry'
-], function (MCT, plugins, legacyRegistry) {
-    xdescribe("MCT", function () {
+    'legacyRegistry',
+    'testUtils'
+], function (plugins, legacyRegistry, testUtils) {
+    describe("MCT", function () {
        var openmct;
        var mockPlugin;
        var mockPlugin2;
@ -38,7 +38,7 @@ define([
            mockListener = jasmine.createSpy('listener');
            oldBundles = legacyRegistry.list();

-            openmct = new MCT();
+            openmct = testUtils.createOpenMct();

            openmct.install(mockPlugin);
            openmct.install(mockPlugin2);
@ -63,8 +63,11 @@ define([
        });

        describe("start", function () {
-            beforeEach(function () {
-                openmct.start();
+            let appHolder;
+            beforeEach(function (done) {
+                appHolder = document.createElement("div");
+                openmct.on('start', done);
+                openmct.start(appHolder);
            });

            it("calls plugins for configuration", function () {
@ -75,25 +78,51 @@ define([
            it("emits a start event", function () {
                expect(mockListener).toHaveBeenCalled();
            });
+
+            it("Renders the application into the provided container element", function () {
+                let openMctShellElements = appHolder.querySelectorAll('div.l-shell');
+                expect(openMctShellElements.length).toBe(1);
+            });
+        });
+
+        describe("startHeadless", function () {
+            beforeEach(function (done) {
+                openmct.on('start', done);
+                openmct.startHeadless();
+            });
+
+            it("calls plugins for configuration", function () {
+                expect(mockPlugin).toHaveBeenCalledWith(openmct);
+                expect(mockPlugin2).toHaveBeenCalledWith(openmct);
+            });
+
+            it("emits a start event", function () {
+                expect(mockListener).toHaveBeenCalled();
+            });
+
+            it("Does not render Open MCT", function () {
+                let openMctShellElements = document.body.querySelectorAll('div.l-shell');
+                expect(openMctShellElements.length).toBe(0);
+            });
        });

        describe("setAssetPath", function () {
            var testAssetPath;

            beforeEach(function () {
-                testAssetPath = "some/path";
                openmct.legacyExtension = jasmine.createSpy('legacyExtension');
-                openmct.setAssetPath(testAssetPath);
            });

-            it("internally configures the path for assets", function () {
-                expect(openmct.legacyExtension).toHaveBeenCalledWith(
-                    'constants',
-                    {
-                        key: "ASSETS_PATH",
-                        value: testAssetPath
-                    }
-                );
+            it("configures the path for assets", function () {
+                testAssetPath = "some/path/";
+                openmct.setAssetPath(testAssetPath);
+                expect(openmct.getAssetPath()).toBe(testAssetPath);
+            });
+
+            it("adds a trailing /", function () {
+                testAssetPath = "some/path";
+                openmct.setAssetPath(testAssetPath);
+                expect(openmct.getAssetPath()).toBe(testAssetPath + "/");
            });
        });
    });
--- a/src/adapter/actions/ActionDialogDecorator.js
+++ b/src/adapter/actions/ActionDialogDecorator.js
@ -21,7 +21,7 @@
 *****************************************************************************/

 define([
-    '../../api/objects/object-utils'
+    'objectUtils'
 ], function (objectUtils) {
    function ActionDialogDecorator(mct, actionService) {
        this.mct = mct;
--- a/src/adapter/capabilities/AdapterCapability.js
+++ b/src/adapter/capabilities/AdapterCapability.js
@ -20,7 +20,7 @@
 * at runtime from the About dialog for additional information.
 *****************************************************************************/

-define(['../../api/objects/object-utils'], function (objectUtils) {
+define(['objectUtils'], function (objectUtils) {
    function AdapterCapability(domainObject) {
        this.domainObject = domainObject;
    }
--- a/src/adapter/capabilities/AlternateCompositionCapability.js
+++ b/src/adapter/capabilities/AlternateCompositionCapability.js
@ -24,7 +24,7 @@
 * Module defining AlternateCompositionCapability. Created by vwoeltje on 11/7/14.
 */
 define([
-    '../../api/objects/object-utils',
+    'objectUtils',
    '../../../platform/core/src/capabilities/ContextualDomainObject'
 ], function (objectUtils, ContextualDomainObject) {
    function AlternateCompositionCapability($injector, domainObject) {
--- a/src/adapter/capabilities/patchViewCapability.js
+++ b/src/adapter/capabilities/patchViewCapability.js
@ -31,6 +31,7 @@ define([
            var capability = viewConstructor(domainObject);
            var oldInvoke = capability.invoke.bind(capability);

+            /* eslint-disable you-dont-need-lodash-underscore/map */
            capability.invoke = function () {
                var availableViews = oldInvoke();
                var newDomainObject = capability
@ -52,6 +53,8 @@ define([
                    .map('view')
                    .value();
            };
+            /* eslint-enable you-dont-need-lodash-underscore/map */
+
            return capability;
        };
    }
--- a/src/adapter/runs/AlternateCompositionInitializer.js
+++ b/src/adapter/runs/AlternateCompositionInitializer.js
@ -22,7 +22,7 @@

 define([
    '../capabilities/AlternateCompositionCapability',
-    '../../api/objects/object-utils'
+    'objectUtils'
 ], function (
    AlternateCompositionCapability,
    objectUtils
--- a/src/adapter/runs/LegacyTelemetryProvider.js
+++ b/src/adapter/runs/LegacyTelemetryProvider.js
@ -21,7 +21,7 @@
 *****************************************************************************/

 define([
-    '../../api/objects/object-utils'
+    'objectUtils'
 ], function (
    utils
 ) {
--- a/src/adapter/runs/TimeSettingsURLHandler.js
+++ b/src/adapter/runs/TimeSettingsURLHandler.js
@ -78,7 +78,7 @@ define([
    };

    TimeSettingsURLHandler.prototype.parseQueryParams = function () {
-        var searchParams = _.pick(this.$location.search(), _.values(SEARCH));
+        var searchParams = _.pick(this.$location.search(), Object.values(SEARCH));
        var parsedParams = {
            clock: searchParams[SEARCH.MODE],
            timeSystem: searchParams[SEARCH.TIME_SYSTEM]
--- a/src/adapter/services/LegacyObjectAPIInterceptor.js
+++ b/src/adapter/services/LegacyObjectAPIInterceptor.js
@ -21,7 +21,7 @@
 *****************************************************************************/

 define([
-    '../../api/objects/object-utils'
+    'objectUtils'
 ], function (
    utils
 ) {
--- a/src/adapter/services/MissingModelCompatibilityDecorator.js
+++ b/src/adapter/services/MissingModelCompatibilityDecorator.js
@ -21,7 +21,7 @@
 *****************************************************************************/

 define([
-    '../../api/objects/object-utils'
+    'objectUtils'
 ], function (
    objectUtils
 ) {
--- a/src/adapter/views/installLegacyViews.js
+++ b/src/adapter/views/installLegacyViews.js
@ -1,7 +1,7 @@
 define([
    './LegacyViewProvider',
    './TypeInspectorViewProvider',
-    '../../api/objects/object-utils'
+    'objectUtils'
 ], function (
    LegacyViewProvider,
    TypeInspectorViewProvider,
--- a/src/api/composition/CompositionAPI.js
+++ b/src/api/composition/CompositionAPI.js
@ -70,7 +70,7 @@ define([
     * @memberof module:openmct.CompositionAPI#
     */
    CompositionAPI.prototype.get = function (domainObject) {
-        var provider = _.find(this.registry, function (p) {
+        var provider = this.registry.find(p => {
            return p.appliesTo(domainObject);
        });

--- a/src/api/composition/CompositionCollection.js
+++ b/src/api/composition/CompositionCollection.js
@ -122,7 +122,7 @@ define([
            throw new Error('Event not supported by composition: ' + event);
        }

-        var index = _.findIndex(this.listeners[event], function (l) {
+        var index = this.listeners[event].findIndex(l => {
            return l.callback === callback && l.context === context;
        });

--- a/src/api/composition/DefaultCompositionProvider.js
+++ b/src/api/composition/DefaultCompositionProvider.js
@ -22,7 +22,7 @@

 define([
    'lodash',
-    '../objects/object-utils'
+    'objectUtils'
 ], function (
    _,
    objectUtils
@ -143,7 +143,7 @@ define([
        var keyString = objectUtils.makeKeyString(domainObject.identifier);
        var objectListeners = this.listeningTo[keyString];

-        var index = _.findIndex(objectListeners[event], function (l) {
+        var index = objectListeners[event].findIndex(l => {
            return l.callback === callback && l.context === context;
        });

@ -196,8 +196,8 @@ define([
     * @private
     */
    DefaultCompositionProvider.prototype.includes = function (parent, childId) {
-        return parent.composition.findIndex(composee =>
-            this.publicAPI.objects.areIdsEqual(composee, childId)) !== -1;
+        return parent.composition.some(composee =>
+            this.publicAPI.objects.areIdsEqual(composee, childId));
    };

    DefaultCompositionProvider.prototype.reorder = function (domainObject, oldIndex, newIndex) {
--- a/src/api/objects/MutableObject.js
+++ b/src/api/objects/MutableObject.js
@ -21,7 +21,7 @@
 *****************************************************************************/

 define([
-    './object-utils.js',
+    'objectUtils',
    'lodash'
 ], function (
    utils,
--- a/src/api/objects/ObjectAPI.js
+++ b/src/api/objects/ObjectAPI.js
@ -22,7 +22,7 @@

 define([
    'lodash',
-    './object-utils',
+    'objectUtils',
    './MutableObject',
    './RootRegistry',
    './RootObjectProvider',
--- a/src/api/objects/RootRegistry.js
+++ b/src/api/objects/RootRegistry.js
@ -43,7 +43,7 @@ define([
    }

    RootRegistry.prototype.addRoot = function (key) {
-        if (isKey(key) || (_.isArray(key) && _.every(key, isKey))) {
+        if (isKey(key) || (Array.isArray(key) && key.every(isKey))) {
            this.providers.push(function () {
                return key;
            });
--- a/src/api/objects/test/object-utilsSpec.js
+++ b/src/api/objects/test/object-utilsSpec.js
@ -1,5 +1,5 @@
 define([
-    '../object-utils'
+    'objectUtils'
 ], function (
    objectUtils
 ) {
--- a/src/api/telemetry/DefaultMetadataProvider.js
+++ b/src/api/telemetry/DefaultMetadataProvider.js
@ -85,9 +85,9 @@ define([
                            value: +e.value
                        };
                    }), 'e.value');
-                valueMetadata.values = _.pluck(valueMetadata.enumerations, 'value');
-                valueMetadata.max = _.max(valueMetadata.values);
-                valueMetadata.min = _.min(valueMetadata.values);
+                valueMetadata.values = valueMetadata.enumerations.map(e => e.value);
+                valueMetadata.max = Math.max(valueMetadata.values);
+                valueMetadata.min = Math.min(valueMetadata.values);
            }

            valueMetadatas.push(valueMetadata);
@ -103,7 +103,7 @@ define([
        var metadata = domainObject.telemetry || {};
        if (this.typeHasTelemetry(domainObject)) {
            var typeMetadata = this.typeService.getType(domainObject.type).typeDef.telemetry;
-            _.extend(metadata, typeMetadata);
+            Object.assign(metadata, typeMetadata);
            if (!metadata.values) {
                metadata.values = valueMetadatasFromOldFormat(metadata);
            }
--- a/src/api/telemetry/TelemetryAPI.js
+++ b/src/api/telemetry/TelemetryAPI.js
@ -24,7 +24,7 @@ define([
    './TelemetryMetadataManager',
    './TelemetryValueFormatter',
    './DefaultMetadataProvider',
-    '../objects/object-utils',
+    'objectUtils',
    'lodash'
 ], function (
    TelemetryMetadataManager,
@ -370,7 +370,7 @@ define([
    TelemetryAPI.prototype.commonValuesForHints = function (metadatas, hints) {
        var options = metadatas.map(function (metadata) {
            var values = metadata.valuesForHints(hints);
-            return _.indexBy(values, 'key');
+            return _.keyBy(values, 'key');
        }).reduce(function (a, b) {
            var results = {};
            Object.keys(a).forEach(function (key) {
@ -383,7 +383,7 @@ define([
        var sortKeys = hints.map(function (h) {
            return 'hints.' + h;
        });
-        return _.sortByAll(options, sortKeys);
+        return _.sortBy(options, sortKeys);
    };

    /**
--- a/src/api/telemetry/TelemetryMetadataManager.js
+++ b/src/api/telemetry/TelemetryMetadataManager.js
@ -57,13 +57,13 @@ define([

        if (valueMetadata.format === 'enum') {
            if (!valueMetadata.values) {
-                valueMetadata.values = _.pluck(valueMetadata.enumerations, 'value');
+                valueMetadata.values = valueMetadata.enumerations.map(e => e.value);
            }
            if (!valueMetadata.hasOwnProperty('max')) {
-                valueMetadata.max = _.max(valueMetadata.values) + 1;
+                valueMetadata.max = Math.max(valueMetadata.values) + 1;
            }
            if (!valueMetadata.hasOwnProperty('min')) {
-                valueMetadata.min = _.min(valueMetadata.values) - 1;
+                valueMetadata.min = Math.min(valueMetadata.values) - 1;
            }
        }

@ -121,7 +121,7 @@ define([
                return metadata.hints[hint];
            }
        });
-        return _.sortByAll(matchingMetadata, ...iteratees);
+        return _.sortBy(matchingMetadata, ...iteratees);
    };

    TelemetryMetadataManager.prototype.getFilterableValues = function () {
--- a/src/plugins/LADTable/components/LADTable.vue
+++ b/src/plugins/LADTable/components/LADTable.vue
@ -75,7 +75,7 @@ export default {
            this.items.push(item);
        },
        removeItem(identifier) {
-            let index = _.findIndex(this.items, (item) => this.openmct.objects.makeKeyString(identifier) === item.key);
+            let index = this.items.findIndex(item => this.openmct.objects.makeKeyString(identifier) === item.key);

            this.items.splice(index, 1);
        },
--- a/src/plugins/LADTable/components/LadTableSet.vue
+++ b/src/plugins/LADTable/components/LadTableSet.vue
@ -102,7 +102,7 @@ export default {
            this.compositions.push({composition, addCallback, removeCallback});
        },
        removePrimary(identifier) {
-            let index = _.findIndex(this.primaryTelemetryObjects, (primary) => this.openmct.objects.makeKeyString(identifier) === primary.key),
+            let index = this.primaryTelemetryObjects.findIndex(primary => this.openmct.objects.makeKeyString(identifier) === primary.key),
                primary = this.primaryTelemetryObjects[index];

            this.$set(this.secondaryTelemetryObjects, primary.key, undefined);
@ -130,7 +130,7 @@ export default {
        removeSecondary(primary) {
            return (identifier) => {
                let array = this.secondaryTelemetryObjects[primary.key],
-                    index = _.findIndex(array, (secondary) => this.openmct.objects.makeKeyString(identifier) === secondary.key);
+                    index = array.findIndex(secondary => this.openmct.objects.makeKeyString(identifier) === secondary.key);

                array.splice(index, 1);

--- a/src/plugins/condition/components/ConditionCollection.vue
+++ b/src/plugins/condition/components/ConditionCollection.vue
@ -200,7 +200,7 @@ export default {
            this.$emit('telemetryUpdated', this.telemetryObjs);
        },
        removeTelemetryObject(identifier) {
-            let index = _.findIndex(this.telemetryObjs, (obj) => {
+            let index = this.telemetryObjs.findIndex(obj => {
                let objId = this.openmct.objects.makeKeyString(obj.identifier);
                let id = this.openmct.objects.makeKeyString(identifier);
                return objId === id;
--- a/src/plugins/condition/components/inspector/ConditionalStylesView.vue
+++ b/src/plugins/condition/components/inspector/ConditionalStylesView.vue
@ -108,6 +108,7 @@ import ConditionError from "@/plugins/condition/components/ConditionError.vue";
 import Vue from 'vue';
 import PreviewAction from "@/ui/preview/PreviewAction.js";
 import {getApplicableStylesForItem} from "@/plugins/condition/utils/styleUtils";
+import isEmpty from 'lodash/isEmpty';

 export default {
    name: 'ConditionalStylesView',
@ -288,7 +289,7 @@ export default {
                delete domainObjectStyles[this.itemId].conditionSetIdentifier;
                domainObjectStyles[this.itemId].styles = undefined;
                delete domainObjectStyles[this.itemId].styles;
-                if (_.isEmpty(domainObjectStyles[this.itemId])) {
+                if (isEmpty(domainObjectStyles[this.itemId])) {
                    delete domainObjectStyles[this.itemId];
                }
            } else {
@ -299,7 +300,7 @@ export default {
                domainObjectStyles.styles = undefined;
                delete domainObjectStyles.styles;
            }
-            if (_.isEmpty(domainObjectStyles)) {
+            if (isEmpty(domainObjectStyles)) {
                domainObjectStyles = undefined;
            }

@ -337,7 +338,7 @@ export default {
                    delete domainObjectStyles[this.itemId];
                }
            });
-            if (_.isEmpty(domainObjectStyles)) {
+            if (isEmpty(domainObjectStyles)) {
                domainObjectStyles = undefined;
            }
            this.persist(domainObjectStyles);
--- a/src/plugins/condition/components/inspector/MultiSelectStylesView.vue
+++ b/src/plugins/condition/components/inspector/MultiSelectStylesView.vue
@ -50,6 +50,7 @@
 import StyleEditor from "./StyleEditor.vue";
 import PreviewAction from "@/ui/preview/PreviewAction.js";
 import { getApplicableStylesForItem, getConsolidatedStyleValues, getConditionalStyleForItem } from "@/plugins/condition/utils/styleUtils";
+import isEmpty from 'lodash/isEmpty';

 export default {
    name: 'MultiSelectStylesView',
@ -178,7 +179,7 @@ export default {
                domainObjectStyles[itemId] = undefined;
                delete domainObjectStyles[this.itemId];

-                if (_.isEmpty(domainObjectStyles)) {
+                if (isEmpty(domainObjectStyles)) {
                    domainObjectStyles = undefined;
                }
                this.persist(this.domainObject, domainObjectStyles);
@ -239,7 +240,7 @@ export default {
                    if (this.isStaticAndConditionalStyles) {
                        this.removeConditionalStyles(domainObjectStyles, item.id);
                    }
-                    if (_.isEmpty(itemStaticStyle)) {
+                    if (isEmpty(itemStaticStyle)) {
                        itemStaticStyle = undefined;
                        domainObjectStyles[item.id] = undefined;
                    } else {
--- a/src/plugins/condition/pluginSpec.js
+++ b/src/plugins/condition/pluginSpec.js
@ -20,25 +20,21 @@
 * at runtime from the About dialog for additional information.
 *****************************************************************************/

-import { createOpenMct } from "testTools";
+import { createOpenMct } from "testUtils";
 import ConditionPlugin from "./plugin";

-let openmct = createOpenMct();
-openmct.install(new ConditionPlugin());
-
+describe('the plugin', function () {
    let conditionSetDefinition;
    let mockConditionSetDomainObject;
    let element;
    let child;
-
-describe('the plugin', function () {
+    let openmct;

    beforeAll((done) => {
+        openmct = createOpenMct();
+        openmct.install(new ConditionPlugin());

        conditionSetDefinition = openmct.types.get('conditionSet').definition;
-        const appHolder = document.createElement('div');
-        appHolder.style.width = '640px';
-        appHolder.style.height = '480px';

        element = document.createElement('div');
        child = document.createElement('div');
@ -55,7 +51,7 @@ describe('the plugin', function () {
        conditionSetDefinition.initialize(mockConditionSetDomainObject);

        openmct.on('start', done);
-        openmct.start(appHolder);
+        openmct.startHeadless();
    });

    let mockConditionSetObject = {
--- a/src/plugins/condition/utils/operations.js
+++ b/src/plugins/condition/utils/operations.js
@ -20,8 +20,6 @@
 * at runtime from the About dialog for additional information.
 *****************************************************************************/

-import _ from 'lodash';
-
 const convertToNumbers = (input) => {
    let numberInputs = [];
    input.forEach(inputValue => numberInputs.push(Number(inputValue)));
@ -257,7 +255,7 @@ export const OPERATIONS = [
            const lhsValue = input[0] !== undefined ? input[0].toString() : '';
            if (input[1]) {
                const values = input[1].split(',');
-                return values.find((value) => lhsValue === _.trim(value.toString()));
+                return values.find((value) => lhsValue === value.toString().trim());
            }
            return false;
        },
@ -274,7 +272,7 @@ export const OPERATIONS = [
            const lhsValue = input[0] !== undefined ? input[0].toString() : '';
            if (input[1]) {
                const values = input[1].split(',');
-                const found = values.find((value) => lhsValue === _.trim(value.toString()));
+                const found = values.find((value) => lhsValue === value.toString().trim());
                return !found;
            }
            return false;
--- a/src/plugins/condition/utils/styleUtils.js
+++ b/src/plugins/condition/utils/styleUtils.js
@ -19,6 +19,8 @@
 * this source code distribution or the Licensing information page available
 * at runtime from the About dialog for additional information.
 *****************************************************************************/
+import isEmpty from 'lodash/isEmpty';
+
 const NONE_VALUE = '__no_value';

 const styleProps = {
@ -154,7 +156,7 @@ export const getApplicableStylesForItem = (domainObject, item) => {
 };

 export const getStylesWithoutNoneValue = (style) => {
-    if (_.isEmpty(style) || !style) {
+    if (isEmpty(style) || !style) {
        return;
    }
    let styleObj = {};
--- a/src/plugins/displayLayout/components/DisplayLayout.vue
+++ b/src/plugins/displayLayout/components/DisplayLayout.vue
@ -68,7 +68,6 @@

 <script>
 import uuid from 'uuid';
-
 import SubobjectView from './SubobjectView.vue'
 import TelemetryView from './TelemetryView.vue'
 import BoxView from './BoxView.vue'
@ -76,6 +75,7 @@ import TextView from './TextView.vue'
 import LineView from './LineView.vue'
 import ImageView from './ImageView.vue'
 import EditMarquee from './EditMarquee.vue'
+import _ from 'lodash'

 const ITEM_TYPE_VIEW_MAP = {
    'subobject-view': SubobjectView,
@ -512,7 +512,7 @@ export default {
            }
        },
        updateTelemetryFormat(item, format) {
-            let index = _.findIndex(this.layoutItems, item);
+            let index = this.layoutItems.findIndex(item);
            item.format = format;
            this.mutate(`configuration.items[${index}]`, item);
        }
--- a/src/plugins/displayLayout/components/LayoutFrame.vue
+++ b/src/plugins/displayLayout/components/LayoutFrame.vue
@ -40,6 +40,7 @@

 <script>
 import LayoutDrag from './../LayoutDrag'
+import _ from 'lodash'

 export default {
    inject: ['openmct'],
--- a/src/plugins/displayLayout/components/LineView.vue
+++ b/src/plugins/displayLayout/components/LineView.vue
@ -62,6 +62,7 @@
 <script>

 import conditionalStylesMixin from "../mixins/objectStyles-mixin";
+import _ from 'lodash';

 const START_HANDLE_QUADRANTS = {
    1: 'c-frame-edit__handle--sw',
--- a/src/plugins/displayLayout/plugin.js
+++ b/src/plugins/displayLayout/plugin.js
@ -22,7 +22,7 @@

 import Layout from './components/DisplayLayout.vue'
 import Vue from 'vue'
-import objectUtils from '../../api/objects/object-utils.js'
+import objectUtils from 'objectUtils'
 import DisplayLayoutType from './DisplayLayoutType.js'
 import DisplayLayoutToolbar from './DisplayLayoutToolbar.js'
 import AlphaNumericFormatViewProvider from './AlphanumericFormatViewProvider.js'
--- a/src/plugins/filters/components/FilterObject.vue
+++ b/src/plugins/filters/components/FilterObject.vue
@ -62,6 +62,7 @@
 <script>
 import FilterField from './FilterField.vue';
 import ToggleSwitch from '../../../ui/components/ToggleSwitch.vue';
+import isEmpty from 'lodash/isEmpty';

 export default {
    inject: ['openmct'],
@ -102,7 +103,7 @@ export default {
        hasActiveFilters() {
            // Should be true when the user has entered any filter values.
            return Object.values(this.persistedFilters).some(comparator => {
-                return (typeof(comparator) === 'object' && !_.isEmpty(comparator));
+                return (typeof(comparator) === 'object' && !isEmpty(comparator));
            });
        }
    },
--- a/src/plugins/filters/components/FiltersView.vue
+++ b/src/plugins/filters/components/FiltersView.vue
@ -27,7 +27,8 @@

 <script>
 import FilterObject from './FilterObject.vue';
-import GlobalFilters from './GlobalFilters.vue'
+import GlobalFilters from './GlobalFilters.vue';
+import _ from 'lodash';

 const FILTER_VIEW_TITLE = 'Filters applied';
 const FILTER_VIEW_TITLE_MIXED = 'Mixed filters applied';
--- a/src/plugins/folderView/components/ListView.vue
+++ b/src/plugins/folderView/components/ListView.vue
@ -64,6 +64,7 @@
 <script>
 import compositionLoader from './composition-loader';
 import ListItem from './ListItem.vue';
+import _ from 'lodash';

 export default {
    components: {ListItem},
--- a/src/plugins/imagery/components/ImageryViewLayout.vue
+++ b/src/plugins/imagery/components/ImageryViewLayout.vue
@ -220,7 +220,7 @@ export default {
                return;
            }

-            const index = _.sortedIndex(this.imageHistory, datum, this.timeFormat.format.bind(this.timeFormat));
+            const index = _.sortedIndexBy(this.imageHistory, datum, this.timeFormat.format.bind(this.timeFormat));
            this.imageHistory.splice(index, 0, datum);
        },
        updateValues(datum) {
--- a/src/plugins/notebook/pluginSpec.js
+++ b/src/plugins/notebook/pluginSpec.js
@ -0,0 +1,58 @@
+/*****************************************************************************
+ * Open MCT, Copyright (c) 2014-2020, United States Government
+ * as represented by the Administrator of the National Aeronautics and Space
+ * Administration. All rights reserved.
+ *
+ * Open MCT is licensed under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ * Open MCT includes source code licensed under additional open source
+ * licenses. See the Open Source Licenses file (LICENSES.md) included with
+ * this source code distribution or the Licensing information page available
+ * at runtime from the About dialog for additional information.
+ *****************************************************************************/
+
+import NotebookPlugin  from './plugin.js';
+import {createOpenMct} from "@/testTools";
+
+describe('When the Notebook Snapshot Plugin is installed,', function () {
+    let openmct = createOpenMct();
+
+    const appHolder = document.createElement('div');
+    appHolder.style.width = '640px';
+    appHolder.style.height = '480px';
+
+    let element = document.createElement('div');
+    let child = document.createElement('div');
+    element.appendChild(child);
+
+    openmct.install(NotebookPlugin());
+
+    let notebookDefinition = openmct.types.get('notebook').definition;
+
+    let mockNotebookObject = {
+        identifier: {
+            key: 'testNotebookKey',
+            namespace: ''
+        },
+        type: 'notebook'
+    };
+
+    notebookDefinition.initialize(mockNotebookObject);
+
+    it('defines a notebook object type with the correct key', () => {
+        expect(notebookDefinition.key).toEqual(mockNotebookObject.key);
+    });
+
+    it('Global Notebook Indicator is installed', function () {
+        expect(openmct.indicators.indicatorObjects.length).toEqual(1);
+    });
+});
--- a/src/plugins/plot/src/chart/MCTChartController.js
+++ b/src/plugins/plot/src/chart/MCTChartController.js
@ -152,7 +152,7 @@ function (
    MCTChartController.prototype.destroy = function () {
        this.isDestroyed = true;
        this.stopListening();
-        _.invoke(this.lines, 'destroy');
+        this.lines.forEach(line => line.destroy());
        DrawLoader.releaseDrawAPI(this.drawAPI);
    };

--- a/src/plugins/plot/src/configuration/Collection.js
+++ b/src/plugins/plot/src/configuration/Collection.js
@ -44,7 +44,7 @@ define([
        this.initialize(options);
    }

-    _.extend(Collection.prototype, EventEmitter.prototype);
+    Object.assign(Collection.prototype, EventEmitter.prototype);
    eventHelpers.extend(Collection.prototype);

    Collection.extend = extend;
@ -105,12 +105,7 @@ define([
    };

    Collection.prototype.indexOf = function (model) {
-        return _.findIndex(
-            this.models,
-            function (m) {
-                return m === model;
-            }
-        );
+        return this.models.findIndex(m => m === model);
    };

    Collection.prototype.remove = function (model) {
--- a/src/plugins/plot/src/configuration/Model.js
+++ b/src/plugins/plot/src/configuration/Model.js
@ -49,7 +49,7 @@ define([
        this.initialize(options);
    }

-    _.extend(Model.prototype, EventEmitter.prototype);
+    Object.assign(Model.prototype, EventEmitter.prototype);
    eventHelpers.extend(Model.prototype);

    Model.extend = extend;
--- a/src/plugins/plot/src/configuration/PlotSeries.js
+++ b/src/plugins/plot/src/configuration/PlotSeries.js
@ -146,7 +146,7 @@ define([
                strategy = 'minmax';
            }

-            options = _.extend({}, { size: 1000, strategy, filters: this.filters }, options || {});
+            options = Object.assign({}, { size: 1000, strategy, filters: this.filters }, options || {});

            if (!this.unsubscribe) {
                this.unsubscribe = this.openmct
@ -160,6 +160,7 @@ define([
                    );
            }

+            /* eslint-disable you-dont-need-lodash-underscore/concat */
            return this.openmct
                .telemetry
                .request(this.domainObject, options)
@ -171,6 +172,7 @@ define([
                        .value();
                    this.reset(newPoints);
                }.bind(this));
+            /* eslint-enable you-dont-need-lodash-underscore/concat */
        },
        /**
         * Update x formatter on x change.
@ -270,7 +272,7 @@ define([
         * @private
         */
        sortedIndex: function (point) {
-            return _.sortedIndex(this.data, point, this.getXVal);
+            return _.sortedIndexBy(this.data, point, this.getXVal);
        },
        /**
         * Update min/max stats for the series.
@ -322,7 +324,15 @@ define([
         *                  a point to the end without dupe checking.
         */
        add: function (point, appendOnly) {
-            var insertIndex = this.data.length;
+            var insertIndex = this.data.length,
+                currentYVal = this.getYVal(point),
+                lastYVal = this.getYVal(this.data[insertIndex - 1]);
+
+            if (this.isValueInvalid(currentYVal) && this.isValueInvalid(lastYVal)) {
+                console.warn('[Plot] Invalid Y Values detected');
+                return;
+            }
+
            if (!appendOnly) {
                insertIndex = this.sortedIndex(point);
                if (this.getXVal(this.data[insertIndex]) === this.getXVal(point)) {
@ -332,11 +342,21 @@ define([
                    return;
                }
            }
+
            this.updateStats(point);
            point.mctLimitState = this.evaluate(point);
            this.data.splice(insertIndex, 0, point);
            this.emit('add', point, insertIndex, this);
        },
+
+        /**
+         *
+         * @private
+         */
+        isValueInvalid: function (val) {
+            return Number.isNaN(val) || val === undefined;
+        },
+
        /**
         * Remove a point from the data array and notify listeners.
         * @private
--- a/src/plugins/plot/src/configuration/SeriesCollection.js
+++ b/src/plugins/plot/src/configuration/SeriesCollection.js
@ -101,11 +101,11 @@ define([
            var plotObject = this.plot.get('domainObject');
            if (plotObject.type === 'telemetry.plot.overlay') {

-                var persistedIndex = _.findIndex(plotObject.configuration.series, function (s) {
+                var persistedIndex = plotObject.configuration.series.findIndex(s => {
                    return _.isEqual(identifier, s.identifier);
                });

-                var configIndex = _.findIndex(this.models, function (m) {
+                var configIndex = this.models.findIndex(m => {
                    return _.isEqual(m.domainObject.identifier, identifier);
                });

--- a/src/plugins/plot/src/configuration/YAxisModel.js
+++ b/src/plugins/plot/src/configuration/YAxisModel.js
@ -182,21 +182,6 @@ define([
            this.set('format', yFormat.format.bind(yFormat));
            this.set('values', yMetadata.values);
            if (!label) {
-                var labelUnits = series.map(function (s) {
-                    return s.metadata.value(s.get('yKey')).units;
-                }).reduce(function (a, b) {
-                    if (a === undefined) {
-                        return b;
-                    }
-                    if (a === b) {
-                        return a;
-                    }
-                    return '';
-                }, undefined);
-                if (labelUnits) {
-                    this.set('label', labelUnits);
-                    return;
-                }
                var labelName = series.map(function (s) {
                    return s.metadata.value(s.get('yKey')).name;
                }).reduce(function (a, b) {
@ -208,7 +193,28 @@ define([
                    }
                    return '';
                }, undefined);
+
+                if (labelName) {
                    this.set('label', labelName);
+                    return;
+                }
+
+                var labelUnits = series.map(function (s) {
+                    return s.metadata.value(s.get('yKey')).units;
+                }).reduce(function (a, b) {
+                    if (a === undefined) {
+                        return b;
+                    }
+                    if (a === b) {
+                        return a;
+                    }
+                    return '';
+                }, undefined);
+
+                if (labelUnits) {
+                    this.set('label', labelUnits);
+                    return;
+                }
            }
        },
        defaults: function (options) {
--- a/src/plugins/plot/src/draw/Draw2D.js
+++ b/src/plugins/plot/src/draw/Draw2D.js
@ -51,7 +51,7 @@ define([
        }
    }

-    _.extend(Draw2D.prototype, EventEmitter.prototype);
+    Object.assign(Draw2D.prototype, EventEmitter.prototype);
    eventHelpers.extend(Draw2D.prototype);

    // Convert from logical to physical x coordinates
--- a/src/plugins/plot/src/draw/DrawWebGL.js
+++ b/src/plugins/plot/src/draw/DrawWebGL.js
@ -78,7 +78,7 @@ define([
        this.listenTo(this.canvas, "webglcontextlost", this.onContextLost, this);
    }

-    _.extend(DrawWebGL.prototype, EventEmitter.prototype);
+    Object.assign(DrawWebGL.prototype, EventEmitter.prototype);
    eventHelpers.extend(DrawWebGL.prototype);

    DrawWebGL.prototype.onContextLost = function (event) {
--- a/src/plugins/plot/src/inspector/PlotOptionsController.js
+++ b/src/plugins/plot/src/inspector/PlotOptionsController.js
@ -23,7 +23,7 @@
 define([
    '../configuration/configStore',
    '../lib/eventHelpers',
-    '../../../../api/objects/object-utils',
+    'objectUtils',
    'lodash'
 ], function (
    configStore,
--- a/src/plugins/plot/src/inspector/PlotSeriesFormController.js
+++ b/src/plugins/plot/src/inspector/PlotSeriesFormController.js
@ -31,7 +31,7 @@ define([
    function dynamicPathForKey(key) {
        return function (object, model) {
            var modelIdentifier = model.get('identifier');
-            var index = _.findIndex(object.configuration.series, function (s) {
+            var index = object.configuration.series.findIndex(s => {
                return _.isEqual(s.identifier, modelIdentifier);
            });
            return 'configuration.series[' + index + '].' + key;
--- a/src/plugins/plot/src/inspector/PlotYAxisFormController.js
+++ b/src/plugins/plot/src/inspector/PlotYAxisFormController.js
@ -73,10 +73,10 @@ define([
                    if (range.max === '' || range.max === null || typeof range.max === 'undefined') {
                        return 'Must specify Maximum';
                    }
-                    if (_.isNaN(Number(range.min))) {
+                    if (Number.isNaN(Number(range.min))) {
                        return 'Minimum must be a number.';
                    }
-                    if (_.isNaN(Number(range.max))) {
+                    if (Number.isNaN(Number(range.max))) {
                        return 'Maximum must be a number.';
                    }
                    if (Number(range.min) > Number(range.max)) {
--- a/src/plugins/plot/src/telemetry/StackedPlotController.js
+++ b/src/plugins/plot/src/telemetry/StackedPlotController.js
@ -76,7 +76,7 @@ define([
                if (childObj) {
                    var index = telemetryObjects.indexOf(childObj);
                    telemetryObjects.splice(index, 1);
-                    $scope.$broadcast('plot:tickWidth', _.max(tickWidthMap));
+                    $scope.$broadcast('plot:tickWidth', Math.max(...Object.values(tickWidthMap)));
                }
            }

--- a/src/plugins/staticRootPlugin/StaticModelProvider.js
+++ b/src/plugins/staticRootPlugin/StaticModelProvider.js
@ -1,5 +1,5 @@
 define([
-    '../../api/objects/object-utils'
+    'objectUtils'
 ], function (
    objectUtils
 ) {
--- a/src/plugins/summaryWidget/src/ConditionManager.js
+++ b/src/plugins/summaryWidget/src/ConditionManager.js
@ -1,6 +1,6 @@
 define ([
    './ConditionEvaluator',
-    '../../../api/objects/object-utils',
+    'objectUtils',
    'EventEmitter',
    'zepto',
    'lodash'
@ -9,7 +9,8 @@ define ([
    objectUtils,
    EventEmitter,
    $,
-    _
+    _,
+
 ) {

    /**
--- a/src/plugins/summaryWidget/src/SummaryWidget.js
+++ b/src/plugins/summaryWidget/src/SummaryWidget.js
@ -5,7 +5,7 @@ define([
    './TestDataManager',
    './WidgetDnD',
    './eventHelpers',
-    '../../../api/objects/object-utils',
+    'objectUtils',
    'lodash',
    'zepto'
 ], function (
--- a/src/plugins/summaryWidget/src/input/ObjectSelect.js
+++ b/src/plugins/summaryWidget/src/input/ObjectSelect.js
@ -1,6 +1,6 @@
 define([
    './Select',
-    '../../../../api/objects/object-utils'
+    'objectUtils'
 ], function (
    Select,
    objectUtils
--- a/src/plugins/summaryWidget/src/telemetry/EvaluatorPool.js
+++ b/src/plugins/summaryWidget/src/telemetry/EvaluatorPool.js
@ -22,7 +22,7 @@

 define([
    './SummaryWidgetEvaluator',
-    '../../../../api/objects/object-utils'
+    'objectUtils'
 ], function (
    SummaryWidgetEvaluator,
    objectUtils
--- a/src/plugins/summaryWidget/src/telemetry/SummaryWidgetEvaluator.js
+++ b/src/plugins/summaryWidget/src/telemetry/SummaryWidgetEvaluator.js
@ -23,7 +23,7 @@
 define([
    './SummaryWidgetRule',
    '../eventHelpers',
-    '../../../../api/objects/object-utils',
+    'objectUtils',
    'lodash'
 ], function (
    SummaryWidgetRule,
@ -80,10 +80,12 @@ define([
                    }
                }.bind(this);

+                /* eslint-disable you-dont-need-lodash-underscore/map */
                unsubscribes = _.map(
                    realtimeStates,
                    this.subscribeToObjectState.bind(this, updateCallback)
                );
+                /* eslint-enable you-dont-need-lodash-underscore/map */
            }.bind(this));

        return function () {
@ -151,11 +153,13 @@ define([
    SummaryWidgetEvaluator.prototype.getBaseStateClone = function () {
        return this.load()
            .then(function () {
+                /* eslint-disable you-dont-need-lodash-underscore/values */
                return _(this.baseState)
                    .values()
                    .map(_.clone)
-                    .indexBy('id')
+                    .keyBy('id')
                    .value();
+                /* eslint-enable you-dont-need-lodash-underscore/values */
            }.bind(this));
    };

@ -182,7 +186,7 @@ define([
     * @private.
     */
    SummaryWidgetEvaluator.prototype.updateObjectStateFromLAD = function (options, objectState) {
-        options = _.extend({}, options, {
+        options = Object.assign({}, options, {
            strategy: 'latest',
            size: 1
        });
@ -255,10 +259,12 @@ define([
            }
        }

+        /* eslint-disable you-dont-need-lodash-underscore/map */
        var latestTimestamp = _(state)
            .map('timestamps')
            .sortBy(timestampKey)
            .last();
+        /* eslint-enable you-dont-need-lodash-underscore/map */

        if (!latestTimestamp) {
            latestTimestamp = {};
--- a/src/plugins/summaryWidget/src/views/SummaryWidgetViewProvider.js
+++ b/src/plugins/summaryWidget/src/views/SummaryWidgetViewProvider.js
@ -1,7 +1,7 @@
 define([
    '../SummaryWidget',
    './SummaryWidgetView',
-    '../../../../api/objects/object-utils'
+    'objectUtils'
 ], function (
    SummaryWidgetEditView,
    SummaryWidgetView,
--- a/src/plugins/telemetryMean/src/MeanTelemetryProvider.js
+++ b/src/plugins/telemetryMean/src/MeanTelemetryProvider.js
@ -22,7 +22,7 @@
 /*jshint latedef: nofunc */
 /*global console */
 define([
-    '../../../api/objects/object-utils',
+    'objectUtils',
    './TelemetryAverager'
 ], function (objectUtils, TelemetryAverager) {

--- a/src/plugins/telemetryTable/TableConfigurationViewProvider.js
+++ b/src/plugins/telemetryTable/TableConfigurationViewProvider.js
@ -21,7 +21,7 @@
 *****************************************************************************/

 define([
-    '../../api/objects/object-utils',
+    'objectUtils',
    './components/table-configuration.vue',
    './TelemetryTableConfiguration',
    'vue'
--- a/src/plugins/telemetryTable/TelemetryTableConfiguration.js
+++ b/src/plugins/telemetryTable/TelemetryTableConfiguration.js
@ -100,7 +100,7 @@ define([

        hasColumnWithKey(columnKey) {
            return _.flatten(Object.values(this.columns))
-                .findIndex(column => column.getKey() === columnKey) !== -1;
+                .some(column => column.getKey() === columnKey);
        }

        getColumns() {
@ -109,9 +109,10 @@ define([

        getAllHeaders() {
            let flattenedColumns = _.flatten(Object.values(this.columns));
+            /* eslint-disable you-dont-need-lodash-underscore/uniq */
            let headers = _.uniq(flattenedColumns, false, column => column.getKey())
                .reduce(fromColumnsToHeadersMap, {});
-
+            /* eslint-enable you-dont-need-lodash-underscore/uniq */
            function fromColumnsToHeadersMap(headersMap, column) {
                headersMap[column.getKey()] = column.getTitle();
                return headersMap;
--- a/src/plugins/telemetryTable/collections/SortedTableRowCollection.js
+++ b/src/plugins/telemetryTable/collections/SortedTableRowCollection.js
@ -93,7 +93,7 @@ define(
                    // same time stamp
                    let potentialDupes = this.rows.slice(startIx, endIx + 1);
                    // Search potential dupes for exact dupe
-                    isDuplicate = _.findIndex(potentialDupes, _.isEqual.bind(undefined, row)) > -1;
+                    isDuplicate = potentialDupes.some(_.isEqual.bind(undefined, row));
                }

                if (!isDuplicate) {
@ -120,7 +120,7 @@ define(
                const firstValue = this.getValueForSortColumn(this.rows[0]);
                const lastValue = this.getValueForSortColumn(this.rows[this.rows.length - 1]);

-                lodashFunction = lodashFunction || _.sortedIndex;
+                lodashFunction = lodashFunction || _.sortedIndexBy;

                if (this.sortOptions.direction === 'asc') {
                    if (testRowValue > lastValue) {
@ -201,7 +201,7 @@ define(
            sortBy(sortOptions) {
                if (arguments.length > 0) {
                    this.sortOptions = sortOptions;
-                    this.rows = _.sortByOrder(this.rows, (row) => row.getParsedValue(sortOptions.key) , sortOptions.direction);
+                    this.rows = _.orderBy(this.rows, (row) => row.getParsedValue(sortOptions.key) , sortOptions.direction);
                    this.emit('sort');
                }
                // Return duplicate to avoid direct modification of underlying object
--- a/src/plugins/telemetryTable/components/TelemetryFilterIndicator.vue
+++ b/src/plugins/telemetryTable/components/TelemetryFilterIndicator.vue
@ -17,6 +17,8 @@
 </template>

 <script>
+import _ from 'lodash';
+
 const FILTER_INDICATOR_LABEL = 'Filters:';
 const FILTER_INDICATOR_LABEL_MIXED = 'Mixed Filters:';
 const FILTER_INDICATOR_TITLE = 'Data filters are being applied to this view.';
--- a/src/plugins/telemetryTable/pluginSpec.js
+++ b/src/plugins/telemetryTable/pluginSpec.js
@ -24,34 +24,39 @@ import Vue from 'vue';
 import {
    createOpenMct,
    createMouseEvent
-} from 'testTools';
+} from 'testUtils';

+describe("the plugin", () => {
    let openmct;
    let tablePlugin;
    let element;
    let child;

-describe("the plugin", () => {
    beforeEach((done) => {
-        const appHolder = document.createElement('div');
-        appHolder.style.width = '640px';
-        appHolder.style.height = '480px';
-
        openmct = createOpenMct();

+        // Table Plugin is actually installed by default, but because installing it
+        // again is harmless it is left here as an examplar for non-default plugins.
+        tablePlugin = new TablePlugin();
+        openmct.install(tablePlugin);
+
        element = document.createElement('div');
        child = document.createElement('div');
        element.appendChild(child);

-        tablePlugin = new TablePlugin();
-        openmct.install(tablePlugin);
-
        spyOn(openmct.telemetry, 'request').and.returnValue(Promise.resolve([]));

        openmct.on('start', done);
-        openmct.start(appHolder);
+        openmct.startHeadless();
    });

+    describe("defines a table object", function () {
+        it("that is creatable", () => {
+            let tableType = openmct.types.get('table');
+            expect(tableType.definition.creatable).toBe(true);
+        });
+    })
+
    it("provides a table view for objects with telemetry", () => {
        const testTelemetryObject = {
            id:"test-object",
--- a/src/testUtils.js
+++ b/src/testUtils.js
--- a/src/ui/layout/CreateButton.vue
+++ b/src/ui/layout/CreateButton.vue
@ -39,7 +39,7 @@

 <script>
 import CreateAction from '../../../platform/commonUI/edit/src/creation/CreateAction';
-import objectUtils from '../../api/objects/object-utils';
+import objectUtils from 'objectUtils';

 export default {
    inject: ['openmct'],
--- a/webpack.config.js
+++ b/webpack.config.js
@ -42,7 +42,8 @@ const webpackConfig = {
            "printj": path.join(__dirname, "node_modules/printj/dist/printj.min.js"),
            "styles": path.join(__dirname, "src/styles"),
            "MCT": path.join(__dirname, "src/MCT"),
-            "testTools": path.join(__dirname, "src/testTools.js")
+            "testUtils": path.join(__dirname, "src/testUtils.js"),
+            "objectUtils": path.join(__dirname, "src/api/objects/object-utils.js")
        }
    },
    devtool: devMode ? 'eval-source-map' : 'source-map',
Author	SHA1	Message	Date
Shefali Joshi	ffca1a8f33	Merge branch 'master' into improve-test-coverage	2020-05-28 11:55:01 -07:00
Deep Tailor	04598b6cf1	Bug fixes for plots (#3019 ) (#3069 ) * prevent plots from breaking when more than one NaN is received. * fix y axis label issue * dont emit a viewport change event when marquee doesnt happen	2020-05-28 09:58:22 -07:00
Joel McKinnon	43628ad9d6	Lodash upgrade and cleanup (#2990 ) * Upgrades lodash * Replaces some usage of lodash with native functions. * Adds linting to catch cases where native functions could be used instead of lodash functions * Renamed testTools to testUtils Co-authored-by: Joshi <simplyrender@gmail.com> Co-authored-by: David Tsay <david.e.tsay@nasa.gov> Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com> Co-authored-by: Andrew Henry <akhenry@gmail.com>	2020-05-27 10:59:02 -07:00
Andrew Henry	67bea86bc8	Added headless mode start option (#3065 ) * Added headless mode start option. Fixes #3064	2020-05-26 11:39:55 -07:00
Shefali Joshi	f8b5c8e6a1	Merge branch 'master' into improve-test-coverage	2020-05-19 09:33:08 -07:00
Shefali Joshi	e43a23f1c5	Merge branch 'master' into improve-test-coverage	2020-05-15 09:36:05 -07:00
Shefali Joshi	b672b50359	Updated copyright end year	2020-05-12 14:57:20 -07:00
Joshi	eaf8faa1f1	Quick and easy test to bump up test coverage to 62%	2020-05-12 11:48:15 -07:00