Victor Woeltjen
c450c22ddd
[Code Style] Satisfy JSLint
...
Add missing semicolons etc. to satisfy JSLint after
changes for WTD-1482.
2015-08-11 13:03:06 -07:00
Victor Woeltjen
f8a0ddb484
[Code Style] Avoid retaining reference to window
...
Avoid https://docs.angularjs.org/error/ng/cpws
by changing way reference to is retained.
WTD-1482.
2015-08-10 12:39:56 -07:00
Victor Woeltjen
a77920bd18
[Code Style] Use prototypes in Browse bundle
...
WTD-1482.
2015-08-10 11:52:23 -07:00
Victor Woeltjen
c08a460d30
[JSDoc] Add annotations
...
Bulk-add JSDoc annotations, WTD-1482.
2015-08-07 11:44:54 -07:00
Shivam Dave
ca6f44f7b6
[Windowing] URL Fix
...
The URL malformation was caused by the same
function returning the view and index path for
both the newtab window and the browse controller
window. As a result, the BrowseController now only
uses a path that excludes the view and index paths,
like before the UrlService was added. Another,
separate function uses this url for the location
and includes the view and index paths for new
tabs, in order to maintain the current view. WTD 23.
2015-06-25 09:47:58 -07:00
Shivam Dave
c827c40c03
[Windowing] used
...
Used instead of window in the
NewTabAction. WTD 16.
2015-06-24 12:58:48 -07:00
Shivam Dave
6863af9cd9
[Windowing] Comment/Formatting
...
Reformatted code and added comments
to the unit test. Also refined the
NewTabActionSpec unit test to be
clearer. WTD 16.
2015-06-24 12:50:21 -07:00
Shivam Dave
43cfab1031
[Windowing] Unit Test
...
Unit Tests for UrlService and NewTabAction
created and partially written. UrlService
returns 100% and NewTabAction returns 88%.
WTD 16.
2015-06-24 11:32:59 -07:00
Shivam Dave
61d9545414
[Windowing] UrlService
...
UrlService added which takes in a
mode (browse or edit), and also a
domainObject. Returns the url
path to that domainObject. WTD-16.
2015-06-23 16:11:06 -07:00
Shivam Dave
21462bf60d
[Windowing] View Set
...
Sets the view to bethe current
page's view mode. WTD-16.
2015-06-23 15:39:48 -07:00
Shivam Dave
29efb5cf3b
[Windowing] Selected Object
...
Uses the context to get the selected object
or the navigated object. This allows contextual
menu new tab access from the tree. WTD-16.
2015-06-23 13:32:09 -07:00
Shivam Dave
e55cd88d38
[Windowing] View
...
Includes the view using the
.search().view to find
the view key and append that to the
end of the url. Prints this out using
the alert window. WTD-16.
2015-06-23 11:38:01 -07:00
Shivam Dave
e38ad7b082
[Windowing] Path Alert
...
Alerts user of the current path
using an alert window, however
the path is partially shown.
It is the part of the current
path after index.html#. WTD-16.
2015-06-23 11:05:00 -07:00
Shivam Dave
d5a9019493
[Windowing] Comment Adjusted
...
Changed window to tab in comments in
file. WTF-16.
2015-06-22 15:54:32 -07:00
Shivam Dave
1c445e1ce3
[Windowing] New Tab Adjustment
...
Added NewTabAction to spec file and adjusted
it to new name. Also changed comment in
NewTabAction along with a code fix.
WTD-16.
2015-06-22 15:44:09 -07:00
Shivam Dave
c7154447e2
[Windowing] Tabbing Rename
...
Renamed all instances of NewWindow to be
NewTab instead. WTD-16.
2015-06-22 15:35:08 -07:00
