Joshi
ba780981a5
Merge branch 'topic-conditionals' of https://github.com/nasa/openmct into conditionals-refactor
2020-02-28 11:09:41 -08:00
Joshi
e526626e09
Merge branch 'topic-conditionals' of https://github.com/nasa/openmct into condition-trigger
2020-02-28 10:49:56 -08:00
Joel McKinnon
371a7d3a3e
removed disabled inputs with no telemetry
2020-02-28 10:04:10 -08:00
Joel McKinnon
8539d60562
enable trigger
2020-02-28 10:01:37 -08:00
Joel McKinnon
d333fd5822
disabled add or edit condition set without telemetry
2020-02-28 10:01:37 -08:00
Joshi
364191eddc
Merge branch 'topic-conditionals' of https://github.com/nasa/openmct into conditionals-refactor
2020-02-28 09:57:00 -08:00
Shefali Joshi
28255dce01
Merge pull request #2687 from nasa/remove-criteria
...
Added controls for remove and duplicate criteria
2020-02-28 09:53:53 -08:00
Joshi
2609a41ee8
Addresses comments
...
Removes console log statements
Fixes import paths
2020-02-27 11:21:40 -08:00
Joshi
b8dc5acf00
Merge branch 'topic-conditionals' of https://github.com/nasa/openmct into conditionals-refactor
2020-02-27 11:19:35 -08:00
Joel McKinnon
614206b10c
remove criterion working
2020-02-26 11:42:06 -08:00
Joshi
3109c8d825
Destroy condition manager when the ConditionSet vue is destroyed
2020-02-25 15:06:45 -08:00
Joshi
b744467f21
Bug fixes:
...
Ensures that the default condition emits a condition result update
Fixes remove condition
2020-02-25 12:29:47 -08:00
Joshi
5814d2a35e
Updates conditionManager.js to emit the output of the winning condition instead of the identifier of that condition
2020-02-24 15:43:03 -08:00
Joshi
6ab84c0bc3
Refactoring conditionals
...
Move logic for conditions into conditionManager out of conditionCollection.vue
2020-02-24 15:05:33 -08:00
Joel McKinnon
6db78af69f
fixed condition name persistance
2020-02-23 09:58:32 -08:00
Joel McKinnon
50b331c451
fixed condition clone
2020-02-20 14:45:30 -08:00
Joshi
93e3065b3e
Fixes subscription of telelemtry when new criteria is added to a condition
2020-02-19 12:51:24 -08:00
Joshi
dc08877bbb
Persists the condition domain object so that we can retrieve it with it's identifier in child components like condition.vue
2020-02-18 15:35:03 -08:00
Joel McKinnon
f08caa6135
addressed review comments
2020-02-18 12:40:33 -08:00
Joel McKinnon
ad7d029ce8
addressed review comments
2020-02-18 11:14:50 -08:00
Joel McKinnon
4ede6351ec
addressed some review comments
2020-02-14 12:45:32 -08:00
Joel McKinnon
24bbcb466f
wip: fixing add criteria
2020-02-13 16:13:29 -08:00
Joel McKinnon
b6b5cfe403
fixed default state of output selector
2020-02-13 10:52:37 -08:00
Joel McKinnon
2b5d6beb84
resolved conflicts
2020-02-12 11:14:17 -08:00
Joel McKinnon
86316d8940
Add multiple criteria, set and persist inputs
2020-02-12 10:41:43 -08:00
Joel McKinnon
8db6f8f633
criteria component WIP
2020-02-06 15:22:56 -08:00
Joel McKinnon
79557165a3
refactored condition and conditionEdit components into single component named condition
2020-02-06 11:53:31 -08:00
Joel McKinnon
ec1d4abde9
before Deep comments
2020-02-06 07:23:32 -08:00
Joshi
07c5e2800a
Merge branch 'topic-conditionals' of https://github.com/nasa/openmct into condition-clone
2020-02-04 15:19:11 -08:00
Joshi
79811d6662
Merge condition-ui branch into this.
2020-02-04 15:12:33 -08:00
Joshi
7029dcf09e
Merge commit 'e580734c9593ab863f397b52ec9662f045fc7b61' of https://github.com/nasa/openmct into condition-ui-redo
2020-02-04 14:37:39 -08:00
Joel McKinnon
fc03b3a79d
updateTemetry failing to return object on line 328
2020-02-02 08:22:23 -08:00
Joel McKinnon
096d6371f1
add condition no errors
2020-02-01 10:07:40 -08:00
Shefali Joshi
e580734c95
Set criteria options ( #2630 )
...
* Set criteria options on condition edit
* Persists telemetry options correctly and loads them on mount
* Fixes saving the input value for criteria
* Display active condition's output in read only view
* Destroy classes and unsubscribe when condition set view is destroyed
* Fixes saving the input value for a criteria
* Handle telemetry removal
* Fixes tests
* Addresses comments - change function names, consolidate compute function
* Addresses review comments
- Use camelCase for events (did not change properties as eslint complains)
- Reduce repeated property access by assigning to a variable
- Use descriptive variable name
* Addressing comments - improves input value field visibility logic
* Change variable name to reflect intent
2020-01-31 14:44:28 -08:00
Joel McKinnon
2690156a9d
changed kebab-case event names to camelCase
2020-01-31 13:44:07 -08:00
Joel McKinnon
7ac7a40b1b
resolve merge conflicts
2020-01-31 13:21:31 -08:00
Joel McKinnon
8baee7a0c9
WIP: debugging
2020-01-31 09:54:37 -08:00
Joel McKinnon
dc85063467
added isDragging prop to prevent other drag actions
2020-01-31 08:08:39 -08:00
Joel McKinnon
04da88e3b4
addressed review comments
2020-01-30 14:53:19 -08:00
Joshi
1ff4d41b7c
Addresses review comments
...
- Use camelCase for events (did not change properties as eslint complains)
- Reduce repeated property access by assigning to a variable
- Use descriptive variable name
2020-01-30 11:06:25 -08:00
Joel McKinnon
f9ba46fe85
added button and set up iteratable render of criteria
2020-01-29 12:45:34 -08:00
Joel McKinnon
03a6de55d6
typo in comment
2020-01-28 12:16:18 -08:00
Joel McKinnon
3c5047df5e
passed definition prop instead of just name
2020-01-28 12:10:21 -08:00
Joel McKinnon
01b1d66bea
duplicate condition complete
2020-01-28 10:05:58 -08:00
Joel McKinnon
bc9cadaa77
fixed reorder bugs
2020-01-27 09:34:50 -08:00
Joshi
f42ec7e2c5
Handle telemetry removal
2020-01-26 23:30:19 -08:00
Joshi
0beda1d053
Display active condition's output in read only view
2020-01-26 22:19:27 -08:00
Joel McKinnon
5055a18ca1
reorder wip
2020-01-25 12:46:15 -08:00
Joel McKinnon
96746f4042
drag to reorder conditions
2020-01-24 13:23:02 -08:00
Joel McKinnon
7e0f475c63
style changes for dnd
2020-01-23 16:13:28 -08:00