Commit Graph

332 Commits

Author SHA1 Message Date
Victor Woeltjen
b080f90f64 [Telemetry] Move formatter implementation
Move implementation of formatter used for display
of domain values out of plot, and into the telemetry
bundle, from which it can be exposed as a general-use
service. WTD-599.
2014-12-24 10:34:43 -08:00
Victor Woeltjen
453b853a75 [Telemetry] Add skeleton formatter
Add skeleton for implementation of a formatter for
telemetry data, including reorganizing libraries
such that moment.min.js only occurs once. WTD-599.
2014-12-24 10:28:58 -08:00
bwyu
217b622db7 Merge remote-tracking branch 'origin/wtd627' into open-master 2014-12-19 17:52:13 -08:00
bwyu
51376fb38a Merge remote-tracking branch 'origin/open608' into open-master 2014-12-18 13:25:29 -08:00
Victor Woeltjen
24048024f6 [Browse] Test auto-expand fix
Add a test to verify fix for WTD-627 (specifically, verify
that a node does not auto-expand if a selection is made
in some other subtree.)
2014-12-17 15:41:44 -08:00
Victor Woeltjen
4d94ab6fd6 [Browse] Fix tree node autoexpand/highlighting
Repair tree node auto-expand/highlight behavior, to
address WTD-627. Specifically:

* Check the full path when deciding to highlight,
  instead of just the parent. This avoids duplicate highlighting
  in cases where the same parent is visible in two subtrees.
* Don't make a redundant getId call in path-checking;
  domain object paths have already been mapped to identifier
  paths at this point. This avoids erroneous auto-expansion of
  the whole tree.
2014-12-17 15:32:20 -08:00
Victor Woeltjen
4a572decf3 [Indicators] Fill in specs
Fill in specs to ensure code coverage for scripts introduced
to support indicators as a category of extension. WTD-608.
2014-12-16 14:06:19 -08:00
Victor Woeltjen
8ce693af0a [Indicators] Add skeleton specs
Add skeleton specs for the bottom bar controller (introduced
to handle display of indicators introduced as extensions)
and the Couch indicator (introduced to exercise the above,
and to report connection status relative to the Couch
database.) WTD-608.
2014-12-16 13:47:25 -08:00
Victor Woeltjen
ff8572f055 [Indicators] Add tooltip
Add tooltips to indicators, using a description field
from the provided indicator. WTD-608.
2014-12-16 13:43:51 -08:00
Victor Woeltjen
5c71491549 [Indicators] Add JSDoc to CouchIndicator
Add in-line documentation to the CouchDB status indicator
added to exercise/demonstrate support of the indicators
category-of-extension, WTD-608.
2014-12-16 13:36:40 -08:00
Victor Woeltjen
1a50f50310 [Indicators] Support template override
Allow indicators to include their own custom templates.
WTD-608.
2014-12-16 13:23:20 -08:00
Victor Woeltjen
c1ea620341 [Indicators] Implement CouchDB indicator
Initial implementation of an indicator which reflects
current connection to CouchDB. WTD-608.
2014-12-16 13:22:46 -08:00
Victor Woeltjen
8cfcd2cd15 [Indicators] Begin adding Couch indicator
Begin adding indicator to display connection status for
CouchDB. WTD-608.
2014-12-15 10:37:16 -08:00
Victor Woeltjen
48bcb662c6 [Indicators] Add notion of indicators
Add indicators as a category-of-extension, utilized
from the bottom bar to populate its contents.
WTD-608.
2014-12-15 10:17:02 -08:00
Victor Woeltjen
921aad9e2f [Plot] Update plot immediately on mode change
Make sure current telemetry is drawn immediately upon
switching between Overlaid and Stacked plot modes.
WTD-625.
2014-12-12 15:14:20 -08:00
Victor Woeltjen
662412a31d [Plot] Avoid displaying bad labels
Avoid displaying bad labels for tick marks, or in the
coordinates shown on hover. Done in the context of
refactoring to support WTD-625.
2014-12-12 15:07:06 -08:00
Victor Woeltjen
b1158ce230 [Plot] Add JSDoc for stack plots
Add JSDoc for new classes introduced (and revised interfaces
exposed by existing classes) to support stacked plots,
WTD-625.
2014-12-12 14:37:06 -08:00
Victor Woeltjen
80852177c7 [Plot] Complete specs related to stacked mode
Add specs for SubPlot, which was introduced to support
presenting multiple plot areas within a single plot
view (stacked plots, WTD-625.)
2014-12-12 13:20:50 -08:00
Victor Woeltjen
c8c50f8fb1 [Plot] Add specs for plotting modes
Add specs for stacked/overlaid plot modes. WTD-625.
2014-12-12 12:56:26 -08:00
Victor Woeltjen
112d94e189 [Plot] Specs for PlotModeOptions
Add specs for PlotModeOptions, introduced to
allow switching between Stacked and Overlaid
mode for WTD-625.
2014-12-12 11:20:04 -08:00
Victor Woeltjen
7ea63fce8c [Plot] Add specs for PlotPanZoomStackGroup
Add specs to verify the behavior of PlotPanZoomStackGroup,
which is responsible for synchronizing the domain axis
between multiple sub-plots in a stacked plot view.
WTD-625.
2014-12-12 11:10:52 -08:00
Victor Woeltjen
a2d22a4558 [Plot] Restore coverage on PlotController
Restore full test coverage on PlotController after
refactoring for WTD-625, stacked plots.
2014-12-12 10:08:58 -08:00
Victor Woeltjen
4586146da2 [Plot] Remove failing specs
Remove specs which fail due to refactoring for
WTD-625.
2014-12-12 09:49:44 -08:00
Victor Woeltjen
a677ed258e [Plot] Add skeleton specs for stacked plots
Add skeleton specs for classes introduced to support
stacked plot mode, WTD-625.
2014-12-12 09:44:05 -08:00
Victor Woeltjen
06036ce8b3 [Plot] Restore range tick marks
Restore range tick marks; these were lost in refactoring
to support multiple subplots-per-view due to a missed
occurrence of an out-of-date interface usage. WTD-625.
2014-12-11 19:36:01 -08:00
Victor Woeltjen
188e98a78b [Plot] Update stacked plots immediately
When changes to pan-zoom bounds are made in one
subplot, this will effect the pan-zoom bounds of
other subplots. Ensure this occurs immediately.
WTD-625.
2014-12-11 19:33:09 -08:00
Victor Woeltjen
9c1d72f917 [Plot] Integrate PlotPanZoomStackGroup
Utilize PlotPanZoomStackGroup; that is, utilize changes
such that a set of pan-zoom stacks can be treated as one,
while their domain axis synchronizes, and their range
axis does not. WTD-625.
2014-12-11 19:21:52 -08:00
Victor Woeltjen
0ce0517e09 [Plot] Initially implement synced pan/zoom stack
Initially implement a synchronized pan/zoom stack,
which maintains the same domain axis bounds for all
subplots in a stacked plot view, but allows each to
have independent range axes. WTD-625.
2014-12-11 17:27:44 -08:00
Victor Woeltjen
9344809998 [Plot] Restrict hover coordinates
Only show hover coordinates in a stacked plot for
the plot which the user is specifically hovering
over. WTD-625.
2014-12-11 17:09:08 -08:00
Victor Woeltjen
1b6ce10dd9 [Plot] Change style when stacked
Change plot style when in stacked plot mode, such that
plots stack as expected. (Without this change, the
gl-plot class's height of 100% will cause all plots to
fill the full vertical space, effectively acting
overlaid.) WTD-625.
2014-12-11 17:02:07 -08:00
Victor Woeltjen
cd8deca1b3 [Plot] Add initial stack-plot implementation
Add initial implementation of stacked mode for
Plot view. Note that this will not stack correctly
due to markup/style issues. WTD-625.
2014-12-10 20:16:23 -08:00
Victor Woeltjen
eb90a3eeba [Plot] Fix refactoring issues
Fix issues related to refactoring of view-level
to subplot-level behavior, such that previous
functionality is restored. This refactoring
supports introduction of a stacked-plot mode,
for WTD-625.
2014-12-10 20:04:10 -08:00
Victor Woeltjen
784b2b6186 [Plot] Begin refactoring for stacked plots
Begin refactoring Plot view to support stacked plots;
separate out behavior which needs to occur per-plot
from area which should occur per-view, and add a
handler for the Overlay mode. WTD-625.
2014-12-10 19:51:27 -08:00
Victor Woeltjen
1c3d2d923f [Plot] Add notion of subplots to template
Add notion of subplots to the plot template; these
are elements within a stacked plot. WTD-625.
2014-12-10 18:55:47 -08:00
Victor Woeltjen
01f1a92d09 [Plot] Get/set from overlay switcher
Get/set mode from the plot mode switcher; only show
the switcher if there is more than one mode available
(which should only occur when there is more than one
telemetry object in the plot.) WTD-625.
2014-12-10 18:38:42 -08:00
Victor Woeltjen
3a0e80d360 [Plot] Add switcher for Stacked/Overlaid
Add switcher to handle changing between Stacked and Overlaid
plots. WTD-625.
2014-12-10 18:29:18 -08:00
Victor Woeltjen
4173dd748b [Telemetry] Keep telemetryObjects reference
Return the same value from getTelemetryObjects if thes e
haven't changed, to permit this return value to be
watched directly without appearing unstable. Supports
the addition of stacked plot controls, which need
to be conditioned on the number of telemetry objects
present. WTD-625.
2014-12-10 18:28:38 -08:00
bwyu
ce608eedc3 Merge remote-tracking branch 'origin/wtd535' into open-master 2014-12-09 14:12:50 -08:00
bwyu
a9d6009610 Merge conflicts with wtd593 2014-12-09 13:33:58 -08:00
bwyu
91e5ba75de Merge conflicts for wtd537 2014-12-09 11:22:21 -08:00
bwyu
32ae75088f Merge remote-tracking branch 'origin/wtd576' into open-master 2014-12-09 01:38:13 -08:00
bwyu
ed6c06b453 Merged conflicts with wtd534 2014-12-08 18:07:49 -08:00
bwyu
301153cc1b Merge remote-tracking branch 'origin/wtd533' into open-master
Conflicts:
	bundles.json
2014-12-08 17:29:19 -08:00
Victor Woeltjen
b1f8a54dab [Layout] Update specs
Update specs to reflect changes made to the manner in
which a view may persist view configuration changes,
for WTD-535.
2014-12-06 09:45:43 -08:00
Victor Woeltjen
3f41dc716f [Layout] Add commit to scope
Add a commit function to scope from the edit representer;
this avoids issues trying to transparently detect and
persist changes made during edit mode, while still requiring
only minimal action from individual views. WTD-535.
2014-12-06 09:38:36 -08:00
Victor Woeltjen
5faf81e9a5 [Layout] Handle mutation edge case
Fix an edge case in the mutation capability where model
data could be lost during a mutation; this supports
auto-mutate/persist functionality for representations,
which allows Layout editing (transitioned for WTD-535)
to be persisted thereby.
2014-12-06 09:28:46 -08:00
Victor Woeltjen
6de973c11e [Layout] Add JSDoc to new scripts
Add in-line documentation to new scripts introduced to
support the transitioned Layout view, WTD-535.
2014-12-05 18:01:38 -08:00
Victor Woeltjen
c01d253c8e [Layout] Complete specs
Complete specs for scripts which implement the Layout
view, transitioned for WTD-535.
2014-12-05 16:53:53 -08:00
Victor Woeltjen
ecb4283df0 [Layout] Fill in non-layout specs
Complete specs for scripts introduced in support of
Layout objects/views. WTD-535.
2014-12-05 16:27:32 -08:00
Victor Woeltjen
d3f0505385 [Layout] Fix failing specs
Repair or remove failing specs to reflect changes and
refactoring performed during transition of Layout views,
WTD-535.
2014-12-05 15:48:13 -08:00
Victor Woeltjen
f418491cc4 [Layout] Add empty specs
Add empty specs for new scripts introduced during the
transition of Layout object type and view, WTD-535.
2014-12-05 15:39:07 -08:00
Victor Woeltjen
2ef244edce [Layout] Refer to new scripts from test suites
Add entries for new scripts to test suites, to ensure
tests fail until scripts added to support transition
of Layout object/view (WTD-535) have been completed.
WTD-535.
2014-12-05 15:33:25 -08:00
Victor Woeltjen
0a27ebfe09 [Layout] Fix bottom resize handle
Repair the arguments given to the bottom resize
handle for frames in a layout; previously this had
been parameterized erroneously to function as a
right-hand resize handle. Part of transition of
layout elements, WTD-535.
2014-12-05 15:23:18 -08:00
Victor Woeltjen
874efa40ea [Layout] Avoid infinite digest error
Perform initial population of scope in mct-representation
at link time, instead of waiting for watches to be fired;
this avoids the need for extra digest iterations, which
Angular detects as indicators of infinite loops (throwing
exceptions accordingly.) Fixed in the context of supporting
transition of editable Layouts, because these errors were
being thrown upon exiting Edit mode. WTD-535.
2014-12-05 15:22:14 -08:00
Victor Woeltjen
b1457c9eaf [Layout] Add un-minified Angular
Add un-minified Angular and source mappings to aid
in debugging infinite digests. These are occurring
when leaving Edit mode, e.g. after editing a Layout,
so this is needed to complete transition of the
Layout object type. WTD-535.
2014-12-05 15:15:38 -08:00
Victor Woeltjen
a0486495c4 [Layout] Cache reference to body later in mct-drag
Get a reference to the body element at link-time,
instead of instantiation time, from the mct-drag
directive. Failure to do so causes the reference
to fall out of date when switching between Browse
and Edit mode.

Supports position/sizing interactions for Layout
view, WTD-535.
2014-12-05 14:21:10 -08:00
Victor Woeltjen
7080ca585e [Layout] Avoid infinite digest exception
Auto-expand tree nodes on a timeout, instead of immediately.
This is necessary in cases where auto-expansion several
layers deep occurs; if done immediately, each expansion
will trigger a new digest cycle, which at a certain depth
will appear to Angular as unstable.

Done in the context of WTD-535.
2014-12-05 13:31:57 -08:00
Victor Woeltjen
7dadc62f23 [Layout] Store position/size changes
Store changes to the size and position of panels in a
layout to its configuration. The mct-representation
directive (and its constituent parts) is responsible
for detecting and persisting these changes as
appropriate. WTD-535.
2014-12-05 12:49:40 -08:00
Victor Woeltjen
a6de53c118 [Layout] Add auto-save behavior
Add an EditRepresenter which detects changes to domain
object model or view configuration and, when these
occur, triggers mutation and persistence of the domain
object. (Note that in Edit mode, 'persistence' only
flags an object as dirty; actual persistence does not
occur until the user chooses Save.)

This supports editing of position/size in Layout mode,
and the persistence of those changes. WTD-535
2014-12-05 12:48:21 -08:00
Victor Woeltjen
67b9af54b3 [Layout] Add notion of representers
Add representers as a category of extension; these are extra
steps to perform when representing a domain object. This
will be used to support automatic mutation/persistence of
domain objects from a watch, while avoiding bloat within
the mct-representation directive itself. This, in turn,
simplifies the persistence strategy to be employed by
Layout views when editing concludes. WTD-535.
2014-12-05 09:46:21 -08:00
Victor Woeltjen
b50f40f399 [Layout] Fix view switcher in frame
Recognize choice from the view switcher in a frame
in a Layout and display that chosen view. WTD-535.
2014-12-05 09:13:16 -08:00
Victor Woeltjen
f61eb143e7 [Layout] Restrict Items view to folders
Restrict the Items view to folders, such that it does not
show for Layouts (and, more broadly, for any non-folders.)
WTD-535.
2014-12-05 09:12:35 -08:00
Victor Woeltjen
ffb9352da0 [Layout] Disallow editing when not in edit mode
Disallow positioning and resizing of frames within a layout
when not in Edit mode. WTD-535.
2014-12-05 09:07:58 -08:00
Victor Woeltjen
04649d6d71 [Layout] Add remaining panel handles
Add remaining panel handles to allow sizing and positioning
of frames within a layout. WTD-535.
2014-12-05 09:04:22 -08:00
Victor Woeltjen
707641d5b6 [Layout] Trigger digest from mct-drag
Trigger digest using scope. during mct-drag
interactions, to ensure that changes which have
resulted from the drag are applied promptly.
WTD-535.
2014-12-05 08:55:54 -08:00
Victor Woeltjen
847144c630 [Layout] Utilize mct-drag
Utilize mct-drag in the layout view to allow editing
of frame position by drag. WTD-535.
2014-12-05 08:51:41 -08:00
Victor Woeltjen
b941557b41 [Layout] Fix errors in mct-drag
Properly reset the initial drag position tracked by the
mct-drag position so that multiple drags upon the same
element are correctly offset from an initial position.
Also, preventDefault from events to avoid selection
highlights during drag.

Supports editing Layout objects, for WTD-535.
2014-12-05 08:50:45 -08:00
bwyu
505b6ee241 Merge remote-tracking branch 'origin/wtd575' into open-master
Conflicts:
	bundles.json
2014-12-05 00:44:22 -08:00
Victor Woeltjen
479aaa09fb [Layout] Add mct-drag directive
Add an mct-drag directive to support various draggable
things, including frames in a layout. WTD-535.
2014-12-04 14:45:19 -08:00
Victor Woeltjen
8956be1209 [Layout] Add methods for interaction
Add methods for tracking interactions with
frames in a layout. WTD-535.
2014-12-04 14:01:41 -08:00
Victor Woeltjen
4db2febbb3 [Layout] Add LayoutController
Add a controller for Layouts to choose frame
positions. WTD-535.
2014-12-04 13:22:39 -08:00
Victor Woeltjen
7b1c275dee [Layout] Use refactored switcher in Edit
Update templates for Edit mode to reflect
simplifications to the view switcher introduced
to support its use on Layouts, transitioned for
WTD-535.
2014-12-04 12:32:35 -08:00
Victor Woeltjen
2c0574abff [Layout] Update view switcher spec
Update spec for ViewSwitcherController to reflect
refactoring to simplify usage, performed in the
context of transitioning Layouts. WTD-535.
2014-12-04 12:17:43 -08:00
Victor Woeltjen
1b9f9a8db7 [Layout] Move spec for view switcher
Move spec for view switcher from bundle
platform/commonUI/browse to bundle
platform/commonUI/general to reflect refactoring
to simplify usage in other places (including in
Layouts, which are being transitioned for
WTD-535.)
2014-12-04 12:15:22 -08:00
Victor Woeltjen
6cd0cd8e3c [Layout] Refactor view switcher
Refactor view switcher to simplify it; treat it
as a representation of a domain object that modifies
an ng-model. This simplifies reuse, e.g. in frames
within a layout. WTD-535.
2014-12-04 12:12:41 -08:00
Victor Woeltjen
cbb77f0a14 [Layout] Initial layout templates
Bring over and perform initial transition of templates
for the Layout view. WTD-535.
2014-12-04 11:53:05 -08:00
Victor Woeltjen
e1ba2487b3 [Layout] Add Layout type
Add the type definition for Layout domain objects.
Part of transitioning Layouts, WTD-535.
2014-12-04 10:42:54 -08:00
Victor Woeltjen
ba14aeabc6 [Forms] Complete specs
Fill in new specs and amend existing specs to ensure
full coverage after integration of forms component,
and associated changes. WTD-593.
2014-12-03 17:59:37 -08:00
Victor Woeltjen
6fb5da1b35 [Forms] Prune obsolete specs
Prune obsolete specs after changes made to support
integration of forms component, WTD-593.
2014-12-03 17:26:02 -08:00
Victor Woeltjen
5aff4e3777 [Forms] Edit Properties specs
Add baseline specs (not yet matched up to current implementation)
for Edit Properties action. WTD-593.
2014-12-03 17:07:01 -08:00
Victor Woeltjen
a8f2de6f5e [Forms] Remove obsolete declaration
Remove obsolete controller declaration (this was triggering
warnings in the console.) WTD-593.
2014-12-03 17:03:06 -08:00
Victor Woeltjen
61cee6d8f8 [Forms] Change CreateWizard method name
Change CreateWizard method name to be consistent
with terms used for form structure elsewhere.
WTD-593.
2014-12-03 17:00:22 -08:00
Victor Woeltjen
bbd0271fc5 [Forms] Add Edit Properties
Add the Edit Properties action, now that Forms are
available to support it. Integration of forms
component, WTD-593.
2014-12-03 16:50:14 -08:00
Victor Woeltjen
75f4daa5c3 [Forms] Add specs, doc for CompositeController
Add spec and in-line documentation for CompositeController,
introduced to support integration of forms with the Create
menu, WTD-593.
2014-12-03 16:19:01 -08:00
Victor Woeltjen
218f732dc2 [Forms] Add CompositeController
Add a controller for composite controls; this is used
to flag contained controls as required when they have
been partially filled in (to treat entering one of two
such fields as invalid.) WTD-593.
2014-12-03 16:07:46 -08:00
Victor Woeltjen
6a6797bf53 [Forms] Handle required flag in composite controls
Handle the ng-required flag in composite controls.
WTD-593.
2014-12-03 15:51:42 -08:00
Victor Woeltjen
d54524a96c [Forms] Provide initial property arrays
Provide initial empty arrays for type properties that
are array-like; this is needed to support two-way data
binding for composite controls. Part of ongoing integration
of forms component, WTD-593.
2014-12-03 15:19:23 -08:00
Victor Woeltjen
363a6f6b47 [Forms] Add composite control type
Add a type for composite controls, to allow populating
arrays (e.g. preferred size). WTD-593.
2014-12-03 15:08:41 -08:00
Victor Woeltjen
3d95c8b744 [Forms] Tie OK button to validation
Enable/disable the confirmation button in overlay dialogs
such that it is only enabled when the included form is
valid. WTD-593.
2014-12-03 14:08:42 -08:00
Victor Woeltjen
1753aa6784 [Forms] Add placeholder spec for Locator
Add placeholder spec for the LocatorController, introduced
to support forms used from the Create menu. Part of ongoing
integration of forms bundle, WTD-593.
2014-12-03 14:04:44 -08:00
Victor Woeltjen
2476941eb2 [Forms] Add Locator control
Add Locator form control, to allow selection of a
destination for newly-created domain objects in a
tree. WTD-593.
2014-12-03 13:51:07 -08:00
Victor Woeltjen
9dd0a54568 [Forms] Initialize model from form value
Correctly initialize domain object model from form
value upon domain object creation. Integration of
forms component, WTD-593.
2014-12-03 13:44:27 -08:00
Victor Woeltjen
e04b9828ea [Forms] Use ng-model for tree state
Use ng-model when communicating state to/from the
tree in browse mode. This will simplify implementation
of the Locator control, which also uses a tree, but
which should not set navigation state. WTD-593.
2014-12-03 13:18:51 -08:00
Victor Woeltjen
80ba6f4da3 [Forms] Reorganize Create templates
Reorganize templates associated with the Create menu in
preparation for adding the Locator control, used to
specify the destination folder for object creation.
WTD-593.
2014-12-03 12:56:53 -08:00
Victor Woeltjen
ccdd1bcd57 [Forms] Adjust Create form formats
Adjust formats used in Create forms to match those used
by the mct-form directive. Integration of forms bundle,
WTD-593.
2014-12-03 12:52:51 -08:00
Victor Woeltjen
d0e29befa6 [Forms] Use forms from DialogService
Use the mct-form when displaying a dialog for user input,
replacing the placeholder textarea used prior to integration
of the forms bundle. WTD-593.
2014-12-03 12:32:00 -08:00
Victor Woeltjen
2bee842509 [Forms] Merge in forms bundle
Merge in forms bundle from its development branch
to begin work integrating Forms into the general
UI, for WTD-593.
2014-12-03 12:22:12 -08:00
Victor Woeltjen
a6fc9badfe [Persistence] Hide dangling underscores
Hide dangling underscores; JSLint considers these a problem
and the command line build fails as a consequence when they
are present directly in the code, but CouchDB provides these
so we cannot avoid them entirely. So, hide them behind
variables and use []-style lookup.

Concludes transition work for the CouchDB persistence adapter,
WTD-537.
2014-12-03 08:59:40 -08:00
Victor Woeltjen
9b47e47e93 [Persistence] Add JSDoc
Fill in JSDoc for the CouchDB adapter which provides
the ability to persist domain object models. Part of
ongoing transition of the platform/persistence bundle,
WTD-537.
2014-12-02 18:06:49 -08:00
Victor Woeltjen
c303d29768 [Persistence] Complete specs for CouchDB adapter
Complete test coverage for CouchDB adapter, WTD-537.
2014-12-02 17:53:55 -08:00