Commit Graph

90 Commits

Author SHA1 Message Date
Victor Woeltjen
7ed62babe3 [Browse] Simplify view switcher event ordering
Don't pass a domainObject instance into mct-representation
until a view for that specific domainObject is available;
this avoids ordering issues where a new domainObject is
passed briefly to controllers in represented views before
a  event is issued, which can result in undesired
behavior for views that need to manage resources (such as
the subscriptions used to support telemetry retrieved
from the WARP Server, WTD-644.
2015-01-12 08:30:21 -08:00
Victor Woeltjen
d916111060 [Tree] Restore wait spinner
Restore wait spinner in tree (missed during Angular transition);
this feedback is important when waiting for the contents of
the Packets node (WTD-644) to load.
2015-01-09 17:40:46 -08:00
Victor Woeltjen
782edfc3b7 [WARP Telemetry] Work around platform issues
Work around issues in platform which manifest as bugs or
latency issues when attempting to visualize telemetry
from the WARP Server. Specifically:

* Handle the possibility that there is no matching
  representation for an object from EditRepresenter.
* Don't attempt to look up colon-separated domain object
  identifiers from persistence. This is a workaround to
  avoid latency issues from excessive persistence calls;
  filed WTD-659 to improve this solution.

Changes made to support resolution of WTD-644.
2015-01-09 17:25:55 -08:00
bwyu
9981543156 Merge remote-tracking branch 'origin/open614d' into open-master 2015-01-05 11:14:07 -08:00
Charles Hacskaylo
d281bd52de Fixing inadvertant breakage of super-menu
Fixing inadvertant breakage of super-menu
from changes to .pane classes related to split-pane CSS changes
WTD-618
2015-01-02 14:12:22 -08:00
Charles Hacskaylo
f820cd47b6 [Bug] CSS and markup mods
CSS markup and mods to fix issues related to bug WTD-618;
fix is complete and verified in Chrome
2015-01-02 14:11:29 -08:00
Victor Woeltjen
ad4c5849c1 [Autoflow] Remove obsolete font file
Remove obsolete font file, unintentionally restored while
cherry-picking from autoflow topic branch. WTD-614.
2014-12-31 13:41:56 -08:00
Victor Woeltjen
b51d5762d8 [Common UI] Add JSDoc
Add JSDoc for GetterSetterController, which was added to
support the input filtering control used in autoflow
tabular views, WTD-614.
2014-12-31 13:40:10 -08:00
Victor Woeltjen
0976374e1d [Common UI] Fill in new specs
Complete test coverage for new scripts added to bundle
platform/commonUI/general in suport of autoflow
tabular views, WTD-614. Specifically, these provide a
directive to watch element sizes, and a controller to
help as an intermediary between getter-setter style
ngModels, and plain assignable ones.
2014-12-31 13:40:03 -08:00
Victor Woeltjen
dd1b8f7c2f [Common UI] Add skeleton specs
Add empty test scripts for new scripts introduced to
the platform/commonUI/general bundle in support of
the autoflow tabular view, WTD-614.
2014-12-31 13:39:39 -08:00
Victor Woeltjen
54c075dc88 [Common UI] Reorganize general UI tests
Reorganize folder strucutre for tests in bundle
platform/commonUI/general; source folder structure
has been modified to accommodate additional classes
added to support autoflow tabular views, WTD-614,
so test folder needs to be reorganized accordingly
2014-12-31 13:38:54 -08:00
Victor Woeltjen
112622ab9f [Common UI] Reorganize general UI bundle
Reorganize sources for bundle platform/commonUI/general;
number of classes here has grown as a consequence of
additions for WTD-614 and so an additional layer of
organization is helpful.

Conflicts:
	platform/commonUI/general/bundle.json
	platform/commonUI/general/src/directives/MCTResize.js
2014-12-31 13:38:26 -08:00
Victor Woeltjen
3251be2d1c [Autoflow] Add getter-setter controller
Add a utility controller for interacting with
getter-setter style ngModels (similar to ng-model-options
with getterSetter: true, but support for that is not
present in the current version of Angular.) Specifically,
this is used to support the input filter control, which
in turn is used within the autoflow tabular view. WTD-614.
2014-12-31 13:37:28 -08:00
Victor Woeltjen
7db5c0692b [Autoflow] Add SCSS files
Merge in SCSS files and platform markup which supports
autoflow tabular views for WTD-611 into the open-source-friendly
master branch.
2014-12-31 10:43:01 -08:00
bwyu
217b622db7 Merge remote-tracking branch 'origin/wtd627' into open-master 2014-12-19 17:52:13 -08:00
Victor Woeltjen
24048024f6 [Browse] Test auto-expand fix
Add a test to verify fix for WTD-627 (specifically, verify
that a node does not auto-expand if a selection is made
in some other subtree.)
2014-12-17 15:41:44 -08:00
Victor Woeltjen
4d94ab6fd6 [Browse] Fix tree node autoexpand/highlighting
Repair tree node auto-expand/highlight behavior, to
address WTD-627. Specifically:

* Check the full path when deciding to highlight,
  instead of just the parent. This avoids duplicate highlighting
  in cases where the same parent is visible in two subtrees.
* Don't make a redundant getId call in path-checking;
  domain object paths have already been mapped to identifier
  paths at this point. This avoids erroneous auto-expansion of
  the whole tree.
2014-12-17 15:32:20 -08:00
Victor Woeltjen
4a572decf3 [Indicators] Fill in specs
Fill in specs to ensure code coverage for scripts introduced
to support indicators as a category of extension. WTD-608.
2014-12-16 14:06:19 -08:00
Victor Woeltjen
8ce693af0a [Indicators] Add skeleton specs
Add skeleton specs for the bottom bar controller (introduced
to handle display of indicators introduced as extensions)
and the Couch indicator (introduced to exercise the above,
and to report connection status relative to the Couch
database.) WTD-608.
2014-12-16 13:47:25 -08:00
Victor Woeltjen
ff8572f055 [Indicators] Add tooltip
Add tooltips to indicators, using a description field
from the provided indicator. WTD-608.
2014-12-16 13:43:51 -08:00
Victor Woeltjen
1a50f50310 [Indicators] Support template override
Allow indicators to include their own custom templates.
WTD-608.
2014-12-16 13:23:20 -08:00
Victor Woeltjen
48bcb662c6 [Indicators] Add notion of indicators
Add indicators as a category-of-extension, utilized
from the bottom bar to populate its contents.
WTD-608.
2014-12-15 10:17:02 -08:00
Victor Woeltjen
b1f8a54dab [Layout] Update specs
Update specs to reflect changes made to the manner in
which a view may persist view configuration changes,
for WTD-535.
2014-12-06 09:45:43 -08:00
Victor Woeltjen
3f41dc716f [Layout] Add commit to scope
Add a commit function to scope from the edit representer;
this avoids issues trying to transparently detect and
persist changes made during edit mode, while still requiring
only minimal action from individual views. WTD-535.
2014-12-06 09:38:36 -08:00
Victor Woeltjen
6de973c11e [Layout] Add JSDoc to new scripts
Add in-line documentation to new scripts introduced to
support the transitioned Layout view, WTD-535.
2014-12-05 18:01:38 -08:00
Victor Woeltjen
ecb4283df0 [Layout] Fill in non-layout specs
Complete specs for scripts introduced in support of
Layout objects/views. WTD-535.
2014-12-05 16:27:32 -08:00
Victor Woeltjen
d3f0505385 [Layout] Fix failing specs
Repair or remove failing specs to reflect changes and
refactoring performed during transition of Layout views,
WTD-535.
2014-12-05 15:48:13 -08:00
Victor Woeltjen
f418491cc4 [Layout] Add empty specs
Add empty specs for new scripts introduced during the
transition of Layout object type and view, WTD-535.
2014-12-05 15:39:07 -08:00
Victor Woeltjen
2ef244edce [Layout] Refer to new scripts from test suites
Add entries for new scripts to test suites, to ensure
tests fail until scripts added to support transition
of Layout object/view (WTD-535) have been completed.
WTD-535.
2014-12-05 15:33:25 -08:00
Victor Woeltjen
a0486495c4 [Layout] Cache reference to body later in mct-drag
Get a reference to the body element at link-time,
instead of instantiation time, from the mct-drag
directive. Failure to do so causes the reference
to fall out of date when switching between Browse
and Edit mode.

Supports position/sizing interactions for Layout
view, WTD-535.
2014-12-05 14:21:10 -08:00
Victor Woeltjen
7080ca585e [Layout] Avoid infinite digest exception
Auto-expand tree nodes on a timeout, instead of immediately.
This is necessary in cases where auto-expansion several
layers deep occurs; if done immediately, each expansion
will trigger a new digest cycle, which at a certain depth
will appear to Angular as unstable.

Done in the context of WTD-535.
2014-12-05 13:31:57 -08:00
Victor Woeltjen
a6de53c118 [Layout] Add auto-save behavior
Add an EditRepresenter which detects changes to domain
object model or view configuration and, when these
occur, triggers mutation and persistence of the domain
object. (Note that in Edit mode, 'persistence' only
flags an object as dirty; actual persistence does not
occur until the user chooses Save.)

This supports editing of position/size in Layout mode,
and the persistence of those changes. WTD-535
2014-12-05 12:48:21 -08:00
Victor Woeltjen
f61eb143e7 [Layout] Restrict Items view to folders
Restrict the Items view to folders, such that it does not
show for Layouts (and, more broadly, for any non-folders.)
WTD-535.
2014-12-05 09:12:35 -08:00
Victor Woeltjen
707641d5b6 [Layout] Trigger digest from mct-drag
Trigger digest using scope. during mct-drag
interactions, to ensure that changes which have
resulted from the drag are applied promptly.
WTD-535.
2014-12-05 08:55:54 -08:00
Victor Woeltjen
b941557b41 [Layout] Fix errors in mct-drag
Properly reset the initial drag position tracked by the
mct-drag position so that multiple drags upon the same
element are correctly offset from an initial position.
Also, preventDefault from events to avoid selection
highlights during drag.

Supports editing Layout objects, for WTD-535.
2014-12-05 08:50:45 -08:00
Victor Woeltjen
479aaa09fb [Layout] Add mct-drag directive
Add an mct-drag directive to support various draggable
things, including frames in a layout. WTD-535.
2014-12-04 14:45:19 -08:00
Victor Woeltjen
7b1c275dee [Layout] Use refactored switcher in Edit
Update templates for Edit mode to reflect
simplifications to the view switcher introduced
to support its use on Layouts, transitioned for
WTD-535.
2014-12-04 12:32:35 -08:00
Victor Woeltjen
2c0574abff [Layout] Update view switcher spec
Update spec for ViewSwitcherController to reflect
refactoring to simplify usage, performed in the
context of transitioning Layouts. WTD-535.
2014-12-04 12:17:43 -08:00
Victor Woeltjen
1b9f9a8db7 [Layout] Move spec for view switcher
Move spec for view switcher from bundle
platform/commonUI/browse to bundle
platform/commonUI/general to reflect refactoring
to simplify usage in other places (including in
Layouts, which are being transitioned for
WTD-535.)
2014-12-04 12:15:22 -08:00
Victor Woeltjen
6cd0cd8e3c [Layout] Refactor view switcher
Refactor view switcher to simplify it; treat it
as a representation of a domain object that modifies
an ng-model. This simplifies reuse, e.g. in frames
within a layout. WTD-535.
2014-12-04 12:12:41 -08:00
Victor Woeltjen
ba14aeabc6 [Forms] Complete specs
Fill in new specs and amend existing specs to ensure
full coverage after integration of forms component,
and associated changes. WTD-593.
2014-12-03 17:59:37 -08:00
Victor Woeltjen
6fb5da1b35 [Forms] Prune obsolete specs
Prune obsolete specs after changes made to support
integration of forms component, WTD-593.
2014-12-03 17:26:02 -08:00
Victor Woeltjen
5aff4e3777 [Forms] Edit Properties specs
Add baseline specs (not yet matched up to current implementation)
for Edit Properties action. WTD-593.
2014-12-03 17:07:01 -08:00
Victor Woeltjen
a8f2de6f5e [Forms] Remove obsolete declaration
Remove obsolete controller declaration (this was triggering
warnings in the console.) WTD-593.
2014-12-03 17:03:06 -08:00
Victor Woeltjen
61cee6d8f8 [Forms] Change CreateWizard method name
Change CreateWizard method name to be consistent
with terms used for form structure elsewhere.
WTD-593.
2014-12-03 17:00:22 -08:00
Victor Woeltjen
bbd0271fc5 [Forms] Add Edit Properties
Add the Edit Properties action, now that Forms are
available to support it. Integration of forms
component, WTD-593.
2014-12-03 16:50:14 -08:00
Victor Woeltjen
3d95c8b744 [Forms] Tie OK button to validation
Enable/disable the confirmation button in overlay dialogs
such that it is only enabled when the included form is
valid. WTD-593.
2014-12-03 14:08:42 -08:00
Victor Woeltjen
1753aa6784 [Forms] Add placeholder spec for Locator
Add placeholder spec for the LocatorController, introduced
to support forms used from the Create menu. Part of ongoing
integration of forms bundle, WTD-593.
2014-12-03 14:04:44 -08:00
Victor Woeltjen
2476941eb2 [Forms] Add Locator control
Add Locator form control, to allow selection of a
destination for newly-created domain objects in a
tree. WTD-593.
2014-12-03 13:51:07 -08:00
Victor Woeltjen
9dd0a54568 [Forms] Initialize model from form value
Correctly initialize domain object model from form
value upon domain object creation. Integration of
forms component, WTD-593.
2014-12-03 13:44:27 -08:00