Andrew Henry
7477536478
Disable broken unit tests ( #2519 )
...
* Disabling broken unit tests
* Removed legacy RemoveAction
2019-10-10 16:23:29 -07:00
Deep Tailor
a27b3737f1
Fixes testathon 3/21 ( #2328 )
...
* fix error in location.vue because of drawing objects in selection
* add conditional to check if view is editable before forcing edit after create
* show original location only in inspector, add original location for drawing objects
* fix document title
* set document title in browse.js
* sort items in create menu
* sort children in tree by name
* remove ordering from tree items
* add loading spinner
* fix minor bug
2019-03-25 18:26:39 -07:00
Andrew Henry
c748569433
Address testathon issues relating to context menu ( #2235 )
...
* Support category arrays for legacy actions
* Fixed object path listener. Removed old context menus
* Removed old fullscreen action and Screenfull dependency
* Restore confirmation dialog on remove
* Restored tests
* Remove unused legacy policies
2018-12-07 10:15:11 -08:00
Pete Richards
0d53898af9
Build refactor to webpack ( #2139 )
...
* Move to webpack build
* Use webpack for building openmct. Move SCSS to one folder and load
all core css up front. Remove bower, begin removing gulp in favor
of npm run.
* Uses eslint instead of jshint and jscs. Merge style checking rules
into .eshintrc.js, carrying over core parts of crockford style and
our adaptations. Current code base fails to pass the linter, want
to separate linter changes from fixes to linting rules.
* Support for Vue SFC with example
* Remove outdated examples
* Use HTML loader for html (supports relative imports of resources e.g.
images) and raw-loader for when javascript must be loaded as text.
2018-08-07 14:47:50 -07:00
Andrew Henry
433dee0314
Update test specs to use Jasmine 3 ( #2089 )
...
* Updated Karma and Jasmine versions
* Added DOMObserver class. Supports promise-based testing of DOM changes
Update asynchronous test specs to use promises or done() instead of waitsFor/runs
* Modified ActionCapability to duplicate context object properties as own properties for better object equality comparisons
* Global find + replace to fix syntax issues
* Fixed various issues caused by non-deterministic runtime order of tests in Jasmine 3. Fixed issues caused by changes to determination of object equality
* Addressed review comments
* Resolved merge conflicts with master
* Fixed style errors
* Use spy.calls.count() instead of manually tracking
2018-06-29 17:32:59 -07:00
Nick Weingartner
c55eaeb193
[Copyright] Update copyright year across platform code references
...
Fixes #2034 .
2018-05-14 15:46:17 -07:00
Pegah Sarram
715219c44d
[Edit] Fix the issue with currentTarget being null and HTML being added on Enter
...
Remove the line break that is added when the return key is pressed.
Check the current target directly.
Use textContent for inline editing instead of innerHTML, which will hoist up some HTML content implicitly created around user input for a contenteditable span.
Note that there is a removeAllRanges in addition to a blur here; see
https://stackoverflow.com/questions/4878713/how-can-i-blur-a-div-where-contenteditable-true
Fix broken tests.
Fixes #1757
2017-10-13 11:50:40 -07:00
Pegah Sarram
eb4ded39b3
[Edit] Allow inline-editing the name only if the object is editable
...
Made the contenteditable attribute conditional based on whether the object can be edited or not. If the object is not editable, the attribute is removed.
Add Tests.
Fixes #1746
2017-10-10 12:32:51 -07:00
Pegah Sarram
1419c75503
Inline edit object names ( #1700 )
...
* Inline edit object name.
Change the title-label span to a conteneditable span to allow editing object names inline. Implement a controller to handle updaing the name. Add tests.
Fixes #1679
[Front-end] Add span contenteditable to input styling
[Front-end] Styling for contenteditable span
styling for span[contenteditable].s-status-editing in _controls.scss;
removed s-filter class;
[Front-end] min-width added to .s-inline-edit
* [Frontend] Style tweaks, cleanup and simplification
Fixes #1679
Style sanding on .s-inline-edit; added
:focus outline:0 to select in _controls.scss;
New .s-input-inline class; removed ng-class from object-header.html,
uses :focus instead; refactoring of input-related mixins;
Bring Time Conductor real-time inputs into parity
Apply .s-input-inline to TC inputs; finesse .s-input-inline selector;
Prevent nested inline inputs from editing
Fixed nested editing prevention selector
* Create an object header template for objects inside a frame.
Fix code review requests.
Fixes 1679
2017-09-21 11:16:04 -07:00
Deep Tailor
c472ab044b
Add functionality to allow users to add hideParameters to the url, which will hide tree and/or the inspector
...
New Tab automatically appends hideTree and hideInspector params to hide those panes by default
Add appropriate tests for new functionality and fix broken tests
2017-08-17 15:25:01 -07:00
Victor Woeltjen
185567cf29
[Licenses] Update copyright year to 2017
...
Fixes #1517
2017-04-05 14:52:46 -07:00
Andrew Henry
2088fc52f3
Merge pull request #1446 from nasa/fix-orphan-navigation
...
Orphan check uses capability not model
2017-02-21 17:08:40 -08:00
Pete Richards
cfecc36ae6
Orphan check uses capability not model
...
Switch orphan checking to use capability instead of model.
This ensures that new-style composition providers work as intended.
2017-02-21 12:10:17 -08:00
Pete Richards
aaedf5d576
cssclass is now cssClass
...
Make property name consistent with standard camelCase naming.
2017-02-21 11:14:46 -08:00
Pete Richards
60d1b73160
Update tests and correct style
...
Update tests to reflect new functionality.
Closes https://github.com/nasa/openmct/issues/1360
2016-12-20 16:49:13 -08:00
Andrew Henry
45de84c183
[Time Conductor] Prevent route change when time conductor values change ( #1342 )
...
* [Time Conductor] Prevent route change on setting search parameters. fixes #1341
* [Inspector] Fixed incorrect listener deregistration which was causing errors on scope destruction
* Bare route is redirect to browse
* [Browse] handle routing without breaking $route
Manage route transitions such that route changes are properly
prevented and navigation events occur while still updating the url.
Resolves a number of issues where path and search updates had
to be supported in a very hacky manner.
https://github.com/nasa/openmct/pull/1342
* [URL] Set search without hacks
Changes in previous commit allow the search parameters to be modified
without accidentally triggering a page reload.
https://github.com/nasa/openmct/pull/1342
* [Views] Update on location changes
If the user has a bookmark or tries to change the current view of an
object by specifying view=someView as a search parameter, the change would
not previously take effect. This resolves that bug.
https://github.com/nasa/openmct/pull/1342
* [TC] Set query params to undefined
Instead of setting params to null, which would eventually result in those
parameters equaling undefined, set them to undefined to skip the extra
step.
https://github.com/nasa/openmct/pull/1342
* [Instantiate] Instantiate objects with context
Add context to instantiate objects so that they can be navigated
to for editing.
https://github.com/nasa/openmct/pull/1342
* [Tests] Update specs
Update specs to match new expectations.
* [Style] Fix style
* [TC] Remove unused dependency
Remove $route dependency from time conductor controller as it was
not being used. Resolves review comments.
https://github.com/nasa/openmct/pull/1342#pullrequestreview-11449260
2016-12-07 13:33:53 -08:00
Henry
98f387b605
[Edit Mode] Renamed function from EditAction.cancel() to EditAction.finish()
2016-09-22 17:34:53 -07:00
Henry
7a94efccbf
[Edit Mode] Fixed spelling mistake, moved variable declaration
2016-09-22 11:04:04 -07:00
Henry
3548cde9c4
[Edit Mode] Fixed issue with save dialog not being displayed for new objects after mutation. Fixes 1080
2016-09-21 16:12:09 -07:00
Victor Woeltjen
d1e1ba1c66
[Frontend] Refactor glyphs to classes
...
Squashes #1103 , fixes #1047 .
Squashed commit of the following:
commit 0e060f174dFixes #1047
commit 9f74395a79Fixes #1047
commit 7278c9534cFixes #1047
Fixed .s-status-editing and s-status-pending;
commit 4606d617d1d5bff5559436f7d5bff555e0Fixes #1047
commit b72d82baefFixes #1047
commit af36b9996dFixes #1047
<mct-form> must now include class
'validates' to display validation glyph icons;
removed 'no-validate' from markup; cleaned
up validation scss;
commit 69dc893b4bFixes #1047
Fixes and enhancements for mobile,
particularly in tree; Removed
`display: inline-block` from containerSubtle
mixin;
commit 7bca18b186Fixes #1047
.s-menu-btn > .s-menu-button;
.create-btn > .create-button;
removed unused l-btn, t-btn,
t-btns-zoom from markup
commit 5d229198b7Fixes #1047
commit 36479e2e8bFixes #1047
commit 89e4f06de9Fixes #1047
commit e65ca1cb8bFixes #1047
- Clock, timer, plots updated
commit 3e7eb98ac2Fixes #1047
- Finessing mini-tab and making able to
control per theme; s-clickable and s-toggle-icon
classes cleaned up
commit 18e08074a8Fixes #1047
- Splitter and mini-tab-icon elements
commit 44fda8d68fFixes #1047
mini-tabs, splitters and bg-splash updated;
moved position of Inspector collapse mini-tab
to allow position transition;
splitter-sm class added for Timelines;
commit 2aee8bc0d8Fixes #1047
commit 624f09777fce7591f4d2f159ce7591f642Fixes #1047
Restored no-collapse and float-right
properties;
commit 5324c8edbaFixes #1047
New font files that were missed in
last commit; updated icomoon proj
file; fixed missing char codes in
glyphs.scss;
commit a3b2628883Fixes #1047
New icons for overlay and stacked plots;
revised art and new description for
Fixed Position object;
commit 8a41c6dbc7Fixes #1047
Updated comment
commit eb293b21ebFixes #1047
Removed commented code
commit d8b1fb7781Fixes #1047
Search and removal of "glyph" definitions in bundle
and other JS files; updating tests accordingly;
commit 650fbcc921Fixes #1047
Search and removal of "glyph" definitions in bundle
and other JS files; updating tests accordingly;
commit 574b8bd5c1Fixes #1047
Fixing test cases
commit dd84177441Fixes #1047
WIP: Fixing test cases: fixed test in Timers that was expecting
glyph return;
commit 2231f8e124Fixes #1047
Fixing test cases: fixed test in Timers that was expecting
glyph return;
commit ae59ecfa97Fixes #1047
WIP: fixed line-height issue for t-item-icon class
commit d43bff1445Fixes #1047
WIP: fixed colors and style defs related to clickable
icons
commit c2db6f8805Fixes #1047
WIP: fixed colors related to changes to
btnSubtle mixin; new constants for clickable
icons
commit a4753c44d1Fixes #1047
WIP
commit 2704640b94Fixes #1047
Normalize color constant values for themes; consolidated
and cleaned up btn-related mixins; fixed hover color issues
commit 421286c7e4Fixes #1047
WIP
commit a4111f3855Fixes #1047
WIP: Timeline-related glyph refactoring; s-btn
styles and hover color fixes
commit 883f9992159d9cabb14f1a1f9d9cabb760Fixes #1047
WIP: search, toolbar buttons; mods
to flex archetypes
commit 28b663ce41Fixes #1047
Glyph refactoring WIP for toolbar buttons;
Timeline glyph refactoring continued
commit a9326f572fFixes #1047
Timeline glyph refactoring; Resource Graph icons
in swimlanes now display grayed-out version when not
added to the Resource Graph; minor color tweaks
commit d6e173780388054e56176ca2Fixes #1047
Resolved conflict in icomoon.json file
commit 88054e5e8efixes #1047
In progress: significant mods to pane collapse/expand
buttons and symbols, minor tweaks to splitter look,
limits glyph definitions
commit 7c47343f5cfixes #1047
In progress: updated font files glyphs, mostly
for pane collapse icons
commit fd00bdce54fixes #1047
In progress: search menu
commit 272b4b649efixes #1047
In progress: moved limits classes out
of _contants and into _glyphs;
timers, entanglement context menu items,
form validation, date picker.
commit 95d26e6fe7Fixes #1047
In-progress; limits
commit 26b30d96dbFixes #1047
In-progress; overlay close, search inputs,
messages and message banners,
ui-symbol removal in-progress.
commit 4e2a01ad85Fixes #1047
In-progress; .labeled added to .s-btn,
removed .s-icon-btn
commit 521db3c3feFixes #1047
In-progress; plot options, imagery buttons,
cleanups in buttons.scss, edit-action buttons,
.s-btn .no-label class added.
commit 8bb8db69e6Fixes #1047
In-progress; indicators, notifications, actions,
tests
commit 53ed0bfb22fixes #1047
In progress, really: view icons, timer/clock
commit 47dc7f2f6bfixes #1047
In progress: grid items
commit 2bd34f71befixes #1047
Context menus and associated actions,
custom checkboxes, tree item being edited
commit b561d4f60efixes #1047
In-progess: glyphs.scss now uses $vars to
allow other scss to use a var instead of string
literals;
commit 0cf4089620fixes #1047
In-progess: tree-labels, unknown objects, object
header
commit 46cae10905fixes #1047
In-progess, menus and Create menu fixes
commit fe3097707f7d69ae4652a50c7d69ae401bfixes #1047
In-progress, converting types, mods to
Create Menu template
commit 18d9f3d6b2fixes #1047
Very much In-progess: convert some controls;
commit e93a90a782fixes #1047
Very much In-progess, classes for all symbols
added to glyphs.scss; .menu cleaned up;
commit dc670b22a6fixes #1047
Very much In-progess, "icon-" selector,
browse bar buttons
commit 8b29ccf3affixes #1047
Very much In-progess, s-btn and
s-btn-menu refactoring
commit f574ffed16fixes #1047
In-progess, e900 > e904
commit bc62ee4565fixes #1047
New font files; no re-mapping yet in the app.
commit 614f0c6e9ffixes #1047
Moved all glyphs into PUA area of font, and
re-organized by category.
commit 47bd4031d5Fixes #1047
- Modified sass to point to renamed font files;
- Added new 12px symbols font files to sass;
commit 22a51d6bbbFixes #1047
- Renamed main project file;
- Added new 12px symbols project file;
commit 13ded2fd84Fixes #1047
commit aef5660dfdFixes #1047
2016-08-01 14:33:25 -07:00
Pete Richards
14f1a1f740
Merge remote-tracking branch 'origin/open1031'
2016-07-18 11:43:55 -07:00
Henry
c8898ac6aa
[Documentation] Updated copyright statement. Fixes #1081
2016-07-12 16:55:57 -07:00
Henry
c0311be192
[Browse] Inspector shown when object switched to edit mode. Fixes #1031
2016-06-20 20:27:56 -07:00
Henry
c2517c1670
[Edit Mode] Canceling edit mode with unsaved changes now shows confirmation dialog to user. Fixes #664
2016-06-15 17:10:29 -07:00
Victor Woeltjen
56ff98cce7
Merge branch 'master' into orphan-navigation-765
2016-05-26 12:35:48 -07:00
Henry
32d7187db6
Relocated creation package to edit bundle
2016-05-24 17:08:12 -07:00
Henry
f0ab817e87
Added tests, and fixed failing ones
2016-05-24 10:53:04 -07:00
Victor Woeltjen
1ced47fc2c
[Navigation] Prevent navigation to orphan objects
...
This is particularly useful when a persistence failure has caused
a created object not to be added to its parent container. #765
2016-05-23 14:07:09 -07:00
Victor Woeltjen
ad5691142e
[Code Style] Rename shadowing variables
2016-05-20 13:05:32 -07:00
Victor Woeltjen
fa77139077
[Code Style] Run gulp fixstyle
...
...to apply code style settings from #142 .
2016-05-19 11:29:13 -07:00
Victor Woeltjen
d6ec7e9ab8
[Build] Remove unused variables from specs
...
...to satisfy JSHint.
2016-03-04 12:56:14 -08:00
Victor Woeltjen
4f85616632
[Build] Fix FullscreenAction spec
...
...to reflect acquisition of screenfull dependency via
AMD
2016-03-04 11:46:15 -08:00
Victor Woeltjen
ac5ac8d34e
[Build] Remove boilerplate from scripts
...
No longer necessary after JSHint configuration.
2016-03-04 10:46:38 -08:00
Henry
7b5218c5ba
[Edit Mode] #627 Fixed failing tests
...
Removed reference to defunct NavigationServiceDecorator
Removed virtual panels from drop gesture
2016-03-02 11:12:41 -08:00
Henry
f192544be3
Addressing issues from code review
2016-03-02 11:10:49 -08:00
Henry
2cc2c6a9d3
[Edit Mode] #627 removed edit concerns from browse controllers and markup
...
Fixed elements not appearing in edit mode
Fixed failing tests
2016-03-02 11:05:23 -08:00
Pete Richards
748673f99b
Merge branch 'master' into open638_rebase
2016-03-01 10:48:53 -08:00
Pete Richards
fcdf89a4ee
Merge branch 'master' into open638_rebase
2016-02-23 10:56:13 -08:00
Victor Woeltjen
d3e274bfdd
Merge branch 'master' into open401
...
Resolve conflicts for #416
Conflicts:
platform/commonUI/browse/bundle.json
platform/commonUI/browse/src/BrowseController.js
2016-02-22 14:27:21 -08:00
Henry
645bd5743f
[Plots] #638 Addressing feedback from code review
...
[Plots] #638 Fixing failing tests
[Plot] Changed PlotOptionsController to prototype form
Fixed spacing
Fixed jslint issue
2016-02-08 23:36:45 -08:00
Victor Woeltjen
b0e4947bf0
Merge pull request #500 from nasa/open480
...
[New Edit Mode] Adding sub objects to Timelines
2016-02-08 11:59:54 -08:00
Victor Woeltjen
5d4ace64cb
Merge pull request #625 from nasa/open491
...
[Create] #491 Apply default context root in Locator when none available from object
2016-02-05 17:30:22 -08:00
Henry
abf5f22155
[Plots] #638 added onchange handling in order to synchronize forms with domain object model.
...
Fixed failing test
Added tests
jslint errors
Minor refactoring of layout bundle
revert layout/bundle.json
2016-02-04 14:26:21 -08:00
Victor Woeltjen
aebae27391
[Tests] Remove suite.json files
...
Remove obsolete suite.json files; #482
2016-02-02 09:35:50 -08:00
Henry
54653f3914
[Create] #491 Locator is not visible when creating a new object where selected object does not have location
...
Added additional test for default context
Fixed JSLint error
2016-01-21 16:35:18 -08:00
Henry
cd2b19eb1e
[New Edit Mode] Fixed failing tests, and added new test in CreateWizard
...
[New Edit Mode] #480 fixed JSLint errors
[New Edit Mode] #480 do not show locator for sub objects
[New Edit Mode] Modified persistence in SaveAction
Removed redundant variable
Fixed Failing Test
Fixed JSLint errors
Improved some documentation
2016-01-21 12:01:38 -08:00
Henry
c65096f166
[New Edit Mode] Added AddAction, modified EditableDomainObject to properly wrap inherited functions, added new EditableInstantiationCapability
2016-01-20 18:49:39 -08:00
Victor Woeltjen
43f6981ba1
[Browse] Test navigation when path is not found
2015-12-11 13:21:52 -08:00
Victor Woeltjen
5f7f349f29
[Browse] Specify default selection in a constant
...
https://github.com/nasa/openmctweb/issues/401
2015-12-11 12:31:06 -08:00
Henry
6058e50216
JSLint fixes
2015-12-09 10:04:49 -08:00
