David Tsay
97694fa29c
Bump copyright year to 2020 ( #3169 )
2020-09-14 11:17:31 -07:00
Joel McKinnon
4d560086dd
ESLint upgrade, implement additional rules ( #3230 )
...
* upgrade to ESLintv7, added overrides for rules violated
* removed overrides for spec files
* fixed no-prototype-builtins issues
* added rules for default-case-last, default-param-last, grouped-accessor-pairs, no-constructor-return, and added override for one violation
Co-authored-by: Andrew Henry <akhenry@gmail.com>
Co-authored-by: Shefali Joshi <simplyrender@gmail.com>
2020-08-10 11:23:35 -07:00
Andrew Henry
a09da30768
New eslint rules auto fix ( #3058 )
...
* no-implicit-coercion and no-unneeded-ternary
* End every line with a semicolon
* Spacing and formatting
* Enabled semi-spacing
* Applies npm run lint:fix to code after master merge
* Fix merge issues
* Switched operator-linebreak to 'before'
Co-authored-by: Joshi <simplyrender@gmail.com>
2020-07-31 12:11:03 -07:00
Joel McKinnon
43628ad9d6
Lodash upgrade and cleanup ( #2990 )
...
* Upgrades lodash
* Replaces some usage of lodash with native functions.
* Adds linting to catch cases where native functions could be used instead of lodash functions
* Renamed testTools to testUtils
Co-authored-by: Joshi <simplyrender@gmail.com>
Co-authored-by: David Tsay <david.e.tsay@nasa.gov>
Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-05-27 10:59:02 -07:00
Deep Tailor
8b715f331c
Search indexer ( #2445 )
...
* add a bare bones indexer
* use constant to fallback to legacy indexer
2019-10-22 16:53:06 -07:00
Pete Richards
1bb1330cba
Squashed commit of the following:
...
commit 5aad2e6863139e5ab184e3bb3871396edaea0889bd8fab3726cf89e8a86fb3ad4c4c1449cead8cc6c6ff381cf07cfbfe3d967d7eeff462cf160c27e9022126ca213f1e649526f9b764bb64a1d9c11e82b65cca277e3e71204529b070cc27f42ee7a77a863a2439cd164e0dcb68bf02afd44dd1703abe36c980a185440b93196379a8378dfa61https://github.com/nasa/openmct into core-vue-bootstrap
commit 93196379aabea135a2218378dfa613e4420c17c65aa2be97618d4734ef5be641aa6949c3262de1b78addfb886ee6be02fb84203dbf8ehttps://github.com/nasa/openmct into core-vue-bootstrap
commit e6be02fb8d4203dbf8e15a07f0d2b5e6b22cbcb63f22c3f2https://github.com/nasa/openmct into core-vue-bootstrap
commit e6b22cbcbe63f22c3f2117cf0cf1e6233c17e75b1eaa568e0482dd8e22e3957fd61982dd8e22e73957fd619a91eefbfa7b5deff887fc6708c797547c83db11ade24852bb843f978e18https://github.com/nasa/openmct into core-vue-bootstrap
commit e24852bb8343f978e185f67f03af47f6b90caaff4c5baf183ab2d12f95ee4449994ca484fde4bd349424f9f49edfc02cdf2594a3e9e798d35aed2d6232cdecebcef811318d184d9b7fe3e4dd9365330684430d34b150be483421fe2667285ec7bd7d97d5219f5394https://github.com/nasa/openmct into core-vue-bootstrap
commit 5219f5394ec7bd7d97dc0a7c16031ab18bb348https://github.com/nasa/openmct into core-vue-bootstrap
commit ab18bb34842f54f404c29c0d5f7dbf0a7c1603150fa09e31a62f54f404c2279e0bf29d
2018-08-31 12:03:15 -07:00
Pete Richards
0d53898af9
Build refactor to webpack ( #2139 )
...
* Move to webpack build
* Use webpack for building openmct. Move SCSS to one folder and load
all core css up front. Remove bower, begin removing gulp in favor
of npm run.
* Uses eslint instead of jshint and jscs. Merge style checking rules
into .eshintrc.js, carrying over core parts of crockford style and
our adaptations. Current code base fails to pass the linter, want
to separate linter changes from fixes to linting rules.
* Support for Vue SFC with example
* Remove outdated examples
* Use HTML loader for html (supports relative imports of resources e.g.
images) and raw-loader for when javascript must be loaded as text.
2018-08-07 14:47:50 -07:00
Nick Weingartner
c55eaeb193
[Copyright] Update copyright year across platform code references
...
Fixes #2034 .
2018-05-14 15:46:17 -07:00
Pete Richards
9956ce31e5
[Search] Use new composition in search
...
Use private parts of new composition API for generic search indexer
so that all objects are properly accessible in search results.
Also prevent ROOT object from getting indexed but still traverse
composition. That way, "The root object" no longer shows in search
results.
Update tests to cover changes.
Fixes #1579
2017-05-18 08:51:44 -07:00
Victor Woeltjen
185567cf29
[Licenses] Update copyright year to 2017
...
Fixes #1517
2017-04-05 14:52:46 -07:00
steven mirecki
e751461194
Typo corrections, I avoided making changes to words that have regional spelling differences.
2016-09-03 09:16:54 -04:00
Kevin Van Kessel
e29efbbcdf
[Search] 'All' selected upon no filters. Fixes #1117
...
Upon deselecting every filter, the search returns nothing. This serves
no useful purpose as discussed in #1117 . Now deselecting every filter
automatically selects 'All'.
2016-08-22 12:52:34 -07:00
Henry
c8898ac6aa
[Documentation] Updated copyright statement. Fixes #1081
2016-07-12 16:55:57 -07:00
Victor Woeltjen
ad5691142e
[Code Style] Rename shadowing variables
2016-05-20 13:05:32 -07:00
Victor Woeltjen
fa77139077
[Code Style] Run gulp fixstyle
...
...to apply code style settings from #142 .
2016-05-19 11:29:13 -07:00
Henry
44f4a82fa1
Resolved merge conflicts
2016-05-12 16:14:31 -07:00
Pete Richards
f3b265bdd5
Merge branch 'master' into open671
2016-05-09 10:19:24 -07:00
Pete Richards
7fad4e9ea1
[General] remove dupe, debounce inputs
...
Remove duplicate ClickAwayController implementation that was obscuring actual
implementation. Debounce clickaway action in case toggle is invoked in a
click handler.
Resolves https://github.com/nasa/openmct/issues/888
2016-05-05 18:25:37 -07:00
Victor Woeltjen
aa45e53440
[Build] Revert setTimeout changes
...
Restore usage of setTimeout (instead of the Angular-wrapped version) per
https://github.com/nasa/openmct/pull/724#issuecomment-193542314
2016-04-08 16:29:49 -07:00
Victor Woeltjen
0b11ddbcfd
[Build] Satisfy JSHint
...
Restore globals lost during removal due to merge, remove unused
variables and use threequals in new scripts.
2016-04-08 16:22:40 -07:00
Victor Woeltjen
5088453712
[Build] Remove use strict, global
...
Remove usages of use strict and global declarations that are
no longer necessary with JSHint configuration, from files
added/changed since #724
2016-04-08 16:11:12 -07:00
Victor Woeltjen
5e44bfc6c7
Merge branch 'master' into open671
...
Conflicts:
main.js
platform/commonUI/edit/src/policies/EditableMovePolicy.js
platform/commonUI/general/src/directives/MCTTree.js
platform/commonUI/general/src/ui/ToggleView.js
platform/core/src/actions/ActionCapability.js
platform/core/test/models/CachingModelDecoratorSpec.js
platform/core/test/services/InstantiateSpec.js
platform/features/events/bundle.js
platform/features/events/src/DomainColumn.js
platform/features/events/src/EventListController.js
platform/features/events/src/EventListPopulator.js
platform/features/events/src/RangeColumn.js
platform/features/events/src/directives/MCTDataTable.js
platform/features/events/src/policies/MessagesViewPolicy.js
platform/features/events/test/DomainColumnSpec.js
platform/features/events/test/EventListControllerSpec.js
platform/features/events/test/EventListPopulatorSpec.js
platform/features/events/test/RangeColumnSpec.js
platform/features/events/test/policies/MessagesViewPolicySpec.js
platform/features/rtevents/bundle.js
platform/features/rtevents/src/DomainColumn.js
platform/features/rtevents/src/RTEventListController.js
platform/features/rtevents/src/RangeColumn.js
platform/features/rtevents/src/directives/MCTRTDataTable.js
platform/features/rtevents/src/policies/RTMessagesViewPolicy.js
platform/features/rtevents/test/DomainColumnSpec.js
platform/features/rtevents/test/RTEventListControllerSpec.js
platform/features/rtevents/test/RangeColumnSpec.js
platform/features/rtevents/test/policies/RTMessagesViewPolicySpec.js
platform/features/rtscrolling/bundle.js
platform/features/rtscrolling/src/DomainColumn.js
platform/features/rtscrolling/src/NameColumn.js
platform/features/rtscrolling/src/RTScrollingListController.js
platform/features/rtscrolling/src/RangeColumn.js
platform/features/scrolling/src/DomainColumn.js
platform/features/scrolling/src/RangeColumn.js
platform/features/scrolling/src/ScrollingListController.js
platform/features/scrolling/src/ScrollingListPopulator.js
platform/features/scrolling/test/DomainColumnSpec.js
platform/features/scrolling/test/RangeColumnSpec.js
platform/features/scrolling/test/ScrollingListControllerSpec.js
platform/features/scrolling/test/ScrollingListPopulatorSpec.js
platform/features/table/src/directives/MCTTable.js
platform/features/table/test/controllers/TelemetryTableControllerSpec.js
platform/representation/src/gestures/DropGesture.js
platform/telemetry/src/TelemetryFormatter.js
test-main.js
2016-04-08 16:08:19 -07:00
Victor Woeltjen
107ecfe687
[Search] Don't index objects being edited
...
https://github.com/nasa/openmctweb/pull/727#issuecomment-195570183
2016-03-11 14:55:16 -08:00
Victor Woeltjen
2d305415b3
[Search] Index directly on mutation
...
Pass model directly when indexing is triggered via object mutation,
to avoid issuing an extra, unnecessary request to the server.
Additionally supports indexing of objects which have been created
but not yet persisted.
Addresses #377 .
2016-03-07 14:46:36 -08:00
Victor Woeltjen
134452582c
[Build] Remove/qualify for-in usages
2016-03-04 13:10:23 -08:00
Victor Woeltjen
9526207af8
[Build] Replace setTimeout with
...
To avoid need to declare global usage to satisfy JSHint
2016-03-04 11:13:34 -08:00
Victor Woeltjen
6aeb156a58
[Build] Declare global self in worker
2016-03-04 11:09:41 -08:00
Victor Woeltjen
ac5ac8d34e
[Build] Remove boilerplate from scripts
...
No longer necessary after JSHint configuration.
2016-03-04 10:46:38 -08:00
Victor Woeltjen
bf24ac7c93
[Search] Update field name
...
Update field name in GenericSearchProvider to reflect changes
from nasa/openmctweb#193 . Avoids exceptions on mutation.
Additionally, add test case exercising relevant code and verifying
that reindexing is scheduled upon mutation as expected.
2015-10-23 12:23:01 -07:00
Pete Richards
496cf85b7e
[JSDoc] Correct mistake
2015-10-21 09:46:32 -07:00
Pete Richards
833f57e284
[Search] Don't block UI between requests
...
Timeout subsequent calls to keepIndexing at the end of a
indexRequest, so that UI operations are not blocked.
2015-10-21 07:51:53 -07:00
Pete Richards
ce42429fbd
[Search] expose constants, add fudge factor
...
The SearchAggregator exposes it's constants to add stability to
tests.
It also has a fudge factor which increaases the number of results
it requests from providers to better support pagination when using
client side filtering.
2015-10-20 15:17:15 -07:00
Pete Richards
76151d09a0
[Search] use service for filters, add spec
...
Add a spec for the SearchController, and use the SearchService to
execute filters by supplying a filterPredicate.
2015-10-20 15:17:15 -07:00
Pete Richards
1ddce48f7e
[Search] Specs for GenericSearchProvider
...
Write specs for GenericSearchProvider and resolve some implementation
bugs they uncovered.
2015-10-20 15:17:14 -07:00
Pete Richards
98b5ff3c77
[Search] Decrement number of pending requests
2015-10-20 15:17:14 -07:00
Pete Richards
0f63e4dde9
[Tests] Rewrite search aggregator specs
2015-10-16 17:06:23 -07:00
Pete Richards
12efb47be7
[Search] Remove timeouts and timestamps
...
Remove timeouts and timestamps which were not effectively doing anything.
2015-10-16 16:09:51 -07:00
Pete Richards
78e5c0143b
[Search] Overhaul generic search provider
...
Rewrite the generic search provider to use prototypes. Increase performance
by utilizing the model service instead of the object service, and use a
simplified method of request queueing.
2015-10-16 15:30:14 -07:00
Pete Richards
099591ad2e
[Search] Aggregator returns objects, providers return models
...
Search providers return search results as models for domain objects, as the
actual number of max results is enforced by the aggregator, and because the
individual providers store and return the models for their objects already.
This lowers the amount of resources consumed instantiating domain objects, and
also allows the individual search providers to implement function-based
filtering on domain object models, which is beneficial as it allows the search
filtering in the search controller to be done before paginating of results.
2015-10-16 15:26:04 -07:00
Pete Richards
b5505f372f
[Search] Generic Worker Performance Tweaks
...
The generic search worker now does indexing work during the index operation,
ensuring that queries do not have to do extraneous or repeat calculations.
Change the return format slightly and fixed a bug in the GenericSearchProvider
which caused more objects than intended to be returned from the provider.
2015-10-16 12:39:41 -07:00
Pete Richards
9ad860babd
[Search] Rewrite search controller, tidy
...
Rewrite the search controller, making numerous changes and using prototypical
style.
First, the search controller immediately hides previous results when a new
search is started. Secondly, the search controller ensures that search results
displayed match the currently entered query, preventing race conditions. Finally,
the search controller uses a poor filtering option that means it may not display
all results.
2015-10-16 12:34:47 -07:00
Victor Woeltjen
134b749bbf
[Generic Search] Track pending indexes
...
Track domain objects which have indexing operations pending,
to avoid redundantly indexing in cases where a broader
indexed check is insufficient.
2015-10-05 10:11:38 -07:00
Victor Woeltjen
36d06e8b54
[Generic Search] Reduce flush interval
...
Per discussion from nasa/openmctweb#141 , minimize the
interval at which new objects get indexed, instead of
presuming requirements for CPU utilization.
2015-10-05 10:06:55 -07:00
Victor Woeltjen
77b0086d18
[Generic Search] Use appropriate data structure
...
Per code review, nasa/openmctweb#165
2015-10-05 09:54:57 -07:00
Victor Woeltjen
78f3f8367e
[Search] Vary batch size
...
When indexing for generic search, issue new batches of
requests as individual requests finish (instead of waiting
for whole batches to finish) varying size to keep the
number of outstanding requests below some maximum.
nasa/openmctweb#141
2015-09-29 18:37:44 -07:00
Victor Woeltjen
85ac4a9a32
[Search] Log indexing time
...
...to aid in tuning of generic search parameters.
2015-09-29 18:37:44 -07:00
Victor Woeltjen
77c66053f3
[Search] Change indexing approach
...
Change indexing approach to more carefully control the
rate at which objects are loaded to be indexed, to improve
performance. nasa/openmctweb#141 .
2015-09-29 18:37:44 -07:00
Victor Woeltjen
2979ee90a3
Revert "[Search] Don't trigger digest cycles while indexing"
...
This reverts commit 4b8a5ac0b257737ee33effc966816afca6c11b94.
Performance measurements indicates this is harmful for performance,
although this is not well-explained.
2015-09-29 18:37:44 -07:00
Victor Woeltjen
77c399f2a2
[Search] Don't trigger digest cycles while indexing
...
Avoid triggering digest cycles while indexing;
remove extra call to $timeout
2015-09-29 18:37:44 -07:00
Victor Woeltjen
fe8543158e
[Search] Fix reindexing
...
Flag domain objects as non-indexed on mutation to ensure
reindexing. Done in the context of nasa/openmctweb#141 .
2015-09-29 18:37:44 -07:00
