tobiasbrown
a1d206bfc3
[Remove] Add confirmation dialog ( #1870 )
...
* [Remove] Added confirmation dialog before the remove action is performed
Addresses #563
2018-07-27 13:54:41 -07:00
Andrew Henry
433dee0314
Update test specs to use Jasmine 3 ( #2089 )
...
* Updated Karma and Jasmine versions
* Added DOMObserver class. Supports promise-based testing of DOM changes
Update asynchronous test specs to use promises or done() instead of waitsFor/runs
* Modified ActionCapability to duplicate context object properties as own properties for better object equality comparisons
* Global find + replace to fix syntax issues
* Fixed various issues caused by non-deterministic runtime order of tests in Jasmine 3. Fixed issues caused by changes to determination of object equality
* Addressed review comments
* Resolved merge conflicts with master
* Fixed style errors
* Use spy.calls.count() instead of manually tracking
2018-06-29 17:32:59 -07:00
Pegah Sarram
73e38f1955
[Toolbar] Implement a public API for adding toolbars ( #1908 )
...
* [API] Implement a toolbar registry and a plugin to allow providing a toolbar for a selected object.
* Modify the mct-toolbar directive to get the toolbar structure from a provider based on selection.
* Implements the layout toolbar in the layout bundle
2018-06-27 13:30:01 -07:00
Nick Weingartner
c55eaeb193
[Copyright] Update copyright year across platform code references
...
Fixes #2034 .
2018-05-14 15:46:17 -07:00
Pegah Sarram
75ae5ab3bb
[Toolbar] set selection initially in fixed controller and toolbar... ( #1994 )
...
* [Toolbar] set selection initially in fixed controller and toolbar...
... to make the add button appear in the toolbar when a fixed position is created.
Remove selection change listener on destroy.
Start a digest cycle when handling selection in toolbar to avoid delays in toolbar.
Fixes #1991 , #1987
* fixed checkstyle and lint errors
* Fix tests
* Update comment
2018-04-20 08:45:29 -07:00
Pegah Sarram
6145843e86
[Inspector] Add check to prevent race condition before setting the scope composition. ( #1931 )
...
Fixes #1918
2018-02-28 13:38:00 -08:00
Pegah Sarram
e5d869f01e
[Layout] Select the fixed position view only if the parent is not selected.
...
Also, add mutation listener if domain object is defined to fix the TypeError.
Fixes # 1909 and #1912
2018-02-13 13:23:49 -08:00
Pegah Sarram
d4e3e6689c
[Inspector] Listen for mutation and refresh composition
...
...so that elements pool is updated when selected object's composition changes. Fixes #1869
2018-02-12 10:49:56 -08:00
Deep Tailor
557cd91b21
fix tests
2018-01-04 12:56:57 -08:00
Pegah Sarram
425655bae0
[Layout] Support sub-object selection in layout ( #1811 )
...
Updates to sub object selection, first cut of selection APIs.
* [API] Add inspector view registry to register inspector view providers and show a view in the inspector.
[API] Modify the selection API to register the click event and handle the event. The API will add a class to the selected object and the immediate parent of the selected object.
[Directive] Implemenet mct-selectable directive for making an element selectable.
[Layout] Update the layout controller to use the Selection API. Also, add double click gesture to allow drilling into a selected object.
Populate the Elements pool with contained elements of the selected object. Update toolbar and inspector to listen for the changes in selection.
* [Frontend] Mods to markup and CSS for sub-object selection
* MCTSelectable allows selection in initialization, use to select on navigation
[Frontend] Show grid in first nested layout, hide from deeper nesting. Only show grids when applicable to relative selection.
* Fix checkstyle and lint errors
* Bring back the change that made mct-init-select work
* [Inspector] Make sure the right content is displayed based on whether a view provider exists or not.
* Only show table options when editing
* Make reviewers' requested changes
* Fix broken tests
* [Frontend] Cleanups and tweaks
Fixes #1811
- Cleanups between frame, editor and selecting.scss;
- Hover and selected borders visually pumped up a bit;
- Solid borders on hover and selecting when browsing;
- Dashed borders for layouts when editing;
- Fixed cursor to only show move capability when
element is selected;
* [Frontend] Tweaks to frame.no-frame layout
Fixes #1811
- Margin set to 0;
- Overflow set to hidden;
* [Frontend] Fixed position items border width fixed
Fixes #1811
- Set to 1px;
* Add tests for inspector controller and fix broken tests. Clean up code.
* [Fixed Position] Stop event propagation on click handlers in fixed position to avoid the event reaching the selection click handlers which caused issues with toolbar and selection."
* Fix tests
* Add tests
* Add test
* Remove element from document
2017-12-07 13:04:46 -08:00
Deep Tailor
550e7a15e6
[persistence] fix for issue #1593
...
prevent EditorCapability#finish from calling transactionservice#cancel when transactionService was not active - leading to console error everytime user would leave edit mode
Add tests for changes made and also to check for return type in either case (isActive or not)
2017-11-21 12:07:59 -08:00
Andrew Henry
ec4fe8efb3
Merge pull request #1518 from nasa/copyright-1517
...
[Licenses] Update copyright year to 2017
2017-04-23 17:22:01 -07:00
Victor Woeltjen
185567cf29
[Licenses] Update copyright year to 2017
...
Fixes #1517
2017-04-05 14:52:46 -07:00
Henry
4e457f1cf0
Fixed failing tests, and added new tests
2017-03-27 11:15:27 -07:00
Andrew Henry
f7ff5af60b
Merge pull request #1448 from nasa/update-composition-policy
...
Update composition policy
2017-02-21 17:18:59 -08:00
Pete Richards
2a10a2cae2
Update specs to match composition policies
2017-02-21 15:14:35 -08:00
Pete Richards
aaedf5d576
cssclass is now cssClass
...
Make property name consistent with standard camelCase naming.
2017-02-21 11:14:46 -08:00
Pete Richards
a768b12985
[Edit] Set key on represent
...
Set key on represent so that commit function can properly persist
configuration per object type. Add tests to EditRepresenter
Fixes https://github.com/nasa/openmct/issues/1367
2016-12-23 11:22:29 -08:00
Pete Richards
60d1b73160
Update tests and correct style
...
Update tests to reflect new functionality.
Closes https://github.com/nasa/openmct/issues/1360
2016-12-20 16:49:13 -08:00
Pete Richards
daa71c4f69
[Navigation] remove mct-before-unload
...
Remove mct-before-unload, and move the functionality to the navigation
service. The navigation service considers "unload" to be a navigation
event and prompts in much the same way as it would before any other
navigation event.
https://github.com/nasa/openmct/issues/1360
2016-12-20 16:43:23 -08:00
Alex M
d99b4d35ab
[Failing Test] Mock cloned object in SaveAs spec
2016-12-20 12:41:58 +02:00
Bogdan Alexandru Marginean
532f7a76f9
[Edit] Add notifications to Save & SaveAs ( #1258 )
...
* [Edit] Added notifications to SaveAsAction
* [Edit] Added notifications to SaveAction
* [Edit] Update SaveAsActionSpec
* [Edit] No error notif when user cancels SaveAs
2016-12-19 10:59:26 -08:00
Victor Woeltjen
1a88c9a651
Merge remote-tracking branch 'origin/master' into persist-on-mutation-825
2016-10-07 11:27:58 -07:00
Henry
275dda820b
Merge branch 'mct588comm' of https://github.com/BogdanAlexandru/openmct into BogdanAlexandru-mct588comm
2016-09-22 17:33:42 -07:00
Henry
3548cde9c4
[Edit Mode] Fixed issue with save dialog not being displayed for new objects after mutation. Fixes 1080
2016-09-21 16:12:09 -07:00
Alex M
0c27a5f361
[Edit] Remove CreationService dep from SaveAs
2016-09-19 23:52:30 +03:00
Alex M
e08704e6d3
[Edit] Make checkstyle happy
2016-09-19 20:39:54 +03:00
Alex M
b50278e92f
[Edit] Remove mocked unused UrlService
2016-09-19 20:22:46 +03:00
Alex M
2a2e9ef99d
[Edit] Make linter happy
2016-09-16 03:24:00 +03:00
Alex M
1446b16e77
[Edit] Using spy objects as save action mocks
2016-09-16 03:15:10 +03:00
Alex M
f03003b366
[Edit] Fix CreateActionSpec
2016-09-15 23:18:53 +03:00
Alex M
d1f67fd8b9
[Edit] Introduce dropdown Save menu
...
And fix style issues in SaveAsActionSpec
2016-09-15 22:40:02 +03:00
Alex M
31ee92b711
[Edit] Remove editor.cancel from SaveActionSpec
2016-09-15 20:39:02 +03:00
Alex M
1ea7fa3084
[Edit] SaveAsAction tests cover save and finish
2016-09-15 20:28:29 +03:00
Alex M
0be84a4e51
[Edit] CreateAction closes editor after save
2016-09-13 23:59:28 +03:00
Alex M
4382745012
[Edit] Final two actions now use finish()
2016-09-13 22:35:11 +03:00
Alex M
79b16ddda6
[Edit] SaveAs now calls finish()
2016-09-13 21:24:20 +03:00
Alex M
3dee082141
[Edit] Add reason for redundant mocks
2016-09-03 19:02:05 +03:00
Alex M
7d52d348b2
[Edit] Fix style issues
2016-09-03 18:33:27 +03:00
Alex M
ded52b8d19
[Edit] Rename cancel() to finish()
2016-09-03 17:55:05 +03:00
Alex M
ab4ce0caba
[Edit] Introduced SaveAndStopEditingAction
...
It replaces SaveAction in the bundle.
2016-09-03 17:55:04 +03:00
Alex M
90c13a3959
[Edit] EditorCapability continues edit on save
2016-09-03 17:55:04 +03:00
Alex M
9847c40e34
[Edit] SaveAction not navigating anymore
2016-09-03 17:55:04 +03:00
steven mirecki
e751461194
Typo corrections, I avoided making changes to words that have regional spelling differences.
2016-09-03 09:16:54 -04:00
Victor Woeltjen
10d2794bb7
[Locator] Don't reset root unnecessarily
...
...as this will trigger a refresh of the mct-representation for
the tree, which will in turn create a new mct-tree instance,
resulting in any expanded/collapsed state being lost.
Fixes #1008 .
2016-08-19 13:28:56 -07:00
Victor Woeltjen
2ebf05ae5b
[Persistence] Test NestedTransaction
2016-08-08 13:41:13 -07:00
Victor Woeltjen
73d10ab093
[Persistence] Test Transaction
2016-08-08 13:29:39 -07:00
Victor Woeltjen
668b7b6a39
[Persistence] Add empty specs for Transactions
2016-08-08 13:21:48 -07:00
Victor Woeltjen
d1e1ba1c66
[Frontend] Refactor glyphs to classes
...
Squashes #1103 , fixes #1047 .
Squashed commit of the following:
commit 0e060f174dFixes #1047
commit 9f74395a79Fixes #1047
commit 7278c9534cFixes #1047
Fixed .s-status-editing and s-status-pending;
commit 4606d617d1d5bff5559436f7d5bff555e0Fixes #1047
commit b72d82baefFixes #1047
commit af36b9996dFixes #1047
<mct-form> must now include class
'validates' to display validation glyph icons;
removed 'no-validate' from markup; cleaned
up validation scss;
commit 69dc893b4bFixes #1047
Fixes and enhancements for mobile,
particularly in tree; Removed
`display: inline-block` from containerSubtle
mixin;
commit 7bca18b186Fixes #1047
.s-menu-btn > .s-menu-button;
.create-btn > .create-button;
removed unused l-btn, t-btn,
t-btns-zoom from markup
commit 5d229198b7Fixes #1047
commit 36479e2e8bFixes #1047
commit 89e4f06de9Fixes #1047
commit e65ca1cb8bFixes #1047
- Clock, timer, plots updated
commit 3e7eb98ac2Fixes #1047
- Finessing mini-tab and making able to
control per theme; s-clickable and s-toggle-icon
classes cleaned up
commit 18e08074a8Fixes #1047
- Splitter and mini-tab-icon elements
commit 44fda8d68fFixes #1047
mini-tabs, splitters and bg-splash updated;
moved position of Inspector collapse mini-tab
to allow position transition;
splitter-sm class added for Timelines;
commit 2aee8bc0d8Fixes #1047
commit 624f09777fce7591f4d2f159ce7591f642Fixes #1047
Restored no-collapse and float-right
properties;
commit 5324c8edbaFixes #1047
New font files that were missed in
last commit; updated icomoon proj
file; fixed missing char codes in
glyphs.scss;
commit a3b2628883Fixes #1047
New icons for overlay and stacked plots;
revised art and new description for
Fixed Position object;
commit 8a41c6dbc7Fixes #1047
Updated comment
commit eb293b21ebFixes #1047
Removed commented code
commit d8b1fb7781Fixes #1047
Search and removal of "glyph" definitions in bundle
and other JS files; updating tests accordingly;
commit 650fbcc921Fixes #1047
Search and removal of "glyph" definitions in bundle
and other JS files; updating tests accordingly;
commit 574b8bd5c1Fixes #1047
Fixing test cases
commit dd84177441Fixes #1047
WIP: Fixing test cases: fixed test in Timers that was expecting
glyph return;
commit 2231f8e124Fixes #1047
Fixing test cases: fixed test in Timers that was expecting
glyph return;
commit ae59ecfa97Fixes #1047
WIP: fixed line-height issue for t-item-icon class
commit d43bff1445Fixes #1047
WIP: fixed colors and style defs related to clickable
icons
commit c2db6f8805Fixes #1047
WIP: fixed colors related to changes to
btnSubtle mixin; new constants for clickable
icons
commit a4753c44d1Fixes #1047
WIP
commit 2704640b94Fixes #1047
Normalize color constant values for themes; consolidated
and cleaned up btn-related mixins; fixed hover color issues
commit 421286c7e4Fixes #1047
WIP
commit a4111f3855Fixes #1047
WIP: Timeline-related glyph refactoring; s-btn
styles and hover color fixes
commit 883f9992159d9cabb14f1a1f9d9cabb760Fixes #1047
WIP: search, toolbar buttons; mods
to flex archetypes
commit 28b663ce41Fixes #1047
Glyph refactoring WIP for toolbar buttons;
Timeline glyph refactoring continued
commit a9326f572fFixes #1047
Timeline glyph refactoring; Resource Graph icons
in swimlanes now display grayed-out version when not
added to the Resource Graph; minor color tweaks
commit d6e173780388054e56176ca2Fixes #1047
Resolved conflict in icomoon.json file
commit 88054e5e8efixes #1047
In progress: significant mods to pane collapse/expand
buttons and symbols, minor tweaks to splitter look,
limits glyph definitions
commit 7c47343f5cfixes #1047
In progress: updated font files glyphs, mostly
for pane collapse icons
commit fd00bdce54fixes #1047
In progress: search menu
commit 272b4b649efixes #1047
In progress: moved limits classes out
of _contants and into _glyphs;
timers, entanglement context menu items,
form validation, date picker.
commit 95d26e6fe7Fixes #1047
In-progress; limits
commit 26b30d96dbFixes #1047
In-progress; overlay close, search inputs,
messages and message banners,
ui-symbol removal in-progress.
commit 4e2a01ad85Fixes #1047
In-progress; .labeled added to .s-btn,
removed .s-icon-btn
commit 521db3c3feFixes #1047
In-progress; plot options, imagery buttons,
cleanups in buttons.scss, edit-action buttons,
.s-btn .no-label class added.
commit 8bb8db69e6Fixes #1047
In-progress; indicators, notifications, actions,
tests
commit 53ed0bfb22fixes #1047
In progress, really: view icons, timer/clock
commit 47dc7f2f6bfixes #1047
In progress: grid items
commit 2bd34f71befixes #1047
Context menus and associated actions,
custom checkboxes, tree item being edited
commit b561d4f60efixes #1047
In-progess: glyphs.scss now uses $vars to
allow other scss to use a var instead of string
literals;
commit 0cf4089620fixes #1047
In-progess: tree-labels, unknown objects, object
header
commit 46cae10905fixes #1047
In-progess, menus and Create menu fixes
commit fe3097707f7d69ae4652a50c7d69ae401bfixes #1047
In-progress, converting types, mods to
Create Menu template
commit 18d9f3d6b2fixes #1047
Very much In-progess: convert some controls;
commit e93a90a782fixes #1047
Very much In-progess, classes for all symbols
added to glyphs.scss; .menu cleaned up;
commit dc670b22a6fixes #1047
Very much In-progess, "icon-" selector,
browse bar buttons
commit 8b29ccf3affixes #1047
Very much In-progess, s-btn and
s-btn-menu refactoring
commit f574ffed16fixes #1047
In-progess, e900 > e904
commit bc62ee4565fixes #1047
New font files; no re-mapping yet in the app.
commit 614f0c6e9ffixes #1047
Moved all glyphs into PUA area of font, and
re-organized by category.
commit 47bd4031d5Fixes #1047
- Modified sass to point to renamed font files;
- Added new 12px symbols font files to sass;
commit 22a51d6bbbFixes #1047
- Renamed main project file;
- Added new 12px symbols project file;
commit 13ded2fd84Fixes #1047
commit aef5660dfdFixes #1047
2016-08-01 14:33:25 -07:00
Victor Woeltjen
6c4419fb72
[Persistence] Refactor out Transaction
...
https://github.com/nasa/openmct/pull/874#issuecomment-233068178
2016-07-25 16:45:32 -07:00
