Pete Richards
8e13819e1e
[API] composition providers receive new-style objects
...
Ensure that composition providers get new-style objects (with id
included) so that they can properly check for applicability.
2017-02-21 11:21:08 -08:00
Pete Richards
a768b12985
[Edit] Set key on represent
...
Set key on represent so that commit function can properly persist
configuration per object type. Add tests to EditRepresenter
Fixes https://github.com/nasa/openmct/issues/1367
2016-12-23 11:22:29 -08:00
Pete Richards
60d1b73160
Update tests and correct style
...
Update tests to reflect new functionality.
Closes https://github.com/nasa/openmct/issues/1360
2016-12-20 16:49:13 -08:00
Pete Richards
6328bd9354
[Edit] Cancel action depends on promise resolution
...
Cancel action no longer cares about return value, simply
will not execute if navigtion promise does not resolve.
https://github.com/nasa/openmct/issues/1360
2016-12-20 16:43:23 -08:00
Pete Richards
fcda211800
[Edit] manage editing in EditObjectController
...
EditObjectController now exits edit mode when it is destroyed.
It also injects a check function in the navigation service to
replace the old functionality implemented in EditNavigationPolicy.
https://github.com/nasa/openmct/issues/1360
2016-12-20 16:43:23 -08:00
Pete Richards
daa71c4f69
[Navigation] remove mct-before-unload
...
Remove mct-before-unload, and move the functionality to the navigation
service. The navigation service considers "unload" to be a navigation
event and prompts in much the same way as it would before any other
navigation event.
https://github.com/nasa/openmct/issues/1360
2016-12-20 16:43:23 -08:00
Pete Richards
0b79ec1235
[Browse] Simplify Edit Representation
...
Simplify edit registration and remove extra abstractions. No longer
attach a status listener for every representation-- just use a single watch
for the edit controller. Simplifies logic involved in switching controllers.
https://github.com/nasa/openmct/issues/1360
2016-12-20 16:43:23 -08:00
Alex M
d99b4d35ab
[Failing Test] Mock cloned object in SaveAs spec
2016-12-20 12:41:58 +02:00
Bogdan Alexandru Marginean
532f7a76f9
[Edit] Add notifications to Save & SaveAs ( #1258 )
...
* [Edit] Added notifications to SaveAsAction
* [Edit] Added notifications to SaveAction
* [Edit] Update SaveAsActionSpec
* [Edit] No error notif when user cancels SaveAs
2016-12-19 10:59:26 -08:00
Pete Richards
4d3ec398c9
[Style] Fix style, disable tests
...
disable tests for later follow-up.
2016-11-08 16:21:38 -08:00
Pete Richards
f991dcfb76
Clear cache when no transactions active
2016-11-08 13:51:30 -08:00
Pete Richards
2708562872
[Transaction] Sync mutation within transaction
2016-11-08 10:34:20 -08:00
Pete Richards
65043d0ff3
squash merge open933 into integration-1089, resolve merge conflicts.
2016-10-12 13:47:56 -07:00
Victor Woeltjen
0833674b91
[Persistence] Address refactoring error
...
...caught by unit tests
2016-10-07 11:54:54 -07:00
Victor Woeltjen
947b54555a
[Edit Mode] Simplify transaction stack
...
https://github.com/nasa/openmct/pull/874#r76593588
2016-10-07 11:35:35 -07:00
Victor Woeltjen
1a88c9a651
Merge remote-tracking branch 'origin/master' into persist-on-mutation-825
2016-10-07 11:27:58 -07:00
Alex M
a34e89d56a
[Edit] Bind action to .perform() inside mct-button
2016-09-27 21:19:25 +03:00
Alex M
4b51e604a7
[Edit] Switch other edit actions to mct-control
2016-09-24 20:43:35 +03:00
Andrew Henry
f6ed0e8ab6
Merge pull request #1178 from hudsonfoo/open1168
...
[Frontend] Delay visibility of progress bar
2016-09-23 10:10:09 -07:00
Henry
275dda820b
Merge branch 'mct588comm' of https://github.com/BogdanAlexandru/openmct into BogdanAlexandru-mct588comm
2016-09-22 17:33:42 -07:00
Henry
7a94efccbf
[Edit Mode] Fixed spelling mistake, moved variable declaration
2016-09-22 11:04:04 -07:00
Henry
3548cde9c4
[Edit Mode] Fixed issue with save dialog not being displayed for new objects after mutation. Fixes 1080
2016-09-21 16:12:09 -07:00
Alex M
0c27a5f361
[Edit] Remove CreationService dep from SaveAs
2016-09-19 23:52:30 +03:00
Alex M
abfabc85b5
[Edit] Fix edit-action-buttons indent
2016-09-19 20:41:50 +03:00
Alex M
e08704e6d3
[Edit] Make checkstyle happy
2016-09-19 20:39:54 +03:00
Alex M
f60fc2ebad
[Edit] EditorCapability.finish returns domainObj
2016-09-19 20:33:12 +03:00
Alex M
b50278e92f
[Edit] Remove mocked unused UrlService
2016-09-19 20:22:46 +03:00
Alex M
5ef6617062
[Edit] Rename action to Save and Finish Editing
2016-09-17 01:05:46 +03:00
Alex M
ae89dcd62d
[Edit] Make single save button use mct-control
2016-09-17 00:39:49 +03:00
steven mirecki
f9597fe799
Merge branch 'master' of https://github.com/nasa/openmct
2016-09-16 17:16:35 -04:00
Alex M
2a2e9ef99d
[Edit] Make linter happy
2016-09-16 03:24:00 +03:00
Alex M
1446b16e77
[Edit] Using spy objects as save action mocks
2016-09-16 03:15:10 +03:00
Alex M
f03003b366
[Edit] Fix CreateActionSpec
2016-09-15 23:18:53 +03:00
Alex M
d3db26499c
[Edit] CreateAction needs to perform("save-as")
2016-09-15 23:14:12 +03:00
Alex M
d1f67fd8b9
[Edit] Introduce dropdown Save menu
...
And fix style issues in SaveAsActionSpec
2016-09-15 22:40:02 +03:00
Alex M
31ee92b711
[Edit] Remove editor.cancel from SaveActionSpec
2016-09-15 20:39:02 +03:00
Alex M
1ea7fa3084
[Edit] SaveAsAction tests cover save and finish
2016-09-15 20:28:29 +03:00
Alex M
d8dc3c8445
Merge branch 'master' into mct588comm
2016-09-14 19:50:19 +03:00
Alex M
0be84a4e51
[Edit] CreateAction closes editor after save
2016-09-13 23:59:28 +03:00
Alex M
d87ed1414e
[Edit] Update EditorCapability comments
2016-09-13 22:36:27 +03:00
Alex M
4382745012
[Edit] Final two actions now use finish()
2016-09-13 22:35:11 +03:00
Alex M
79b16ddda6
[Edit] SaveAs now calls finish()
2016-09-13 21:24:20 +03:00
David Hudson
2740b6f957
[Frontend] Add optional delay parameter to dialog service
...
Issue #1168
2016-09-13 16:36:25 +09:00
Andrew Henry
4c6ca58c95
Merge pull request #1157 from TypicalFooBar/843
...
[Context Menu] New Tab button available in edit mode. #843
2016-09-11 21:21:49 -07:00
Alex M
3dee082141
[Edit] Add reason for redundant mocks
2016-09-03 19:02:05 +03:00
Alex M
7d52d348b2
[Edit] Fix style issues
2016-09-03 18:33:27 +03:00
Alex M
ded52b8d19
[Edit] Rename cancel() to finish()
2016-09-03 17:55:05 +03:00
Alex M
ab4ce0caba
[Edit] Introduced SaveAndStopEditingAction
...
It replaces SaveAction in the bundle.
2016-09-03 17:55:04 +03:00
Alex M
90c13a3959
[Edit] EditorCapability continues edit on save
2016-09-03 17:55:04 +03:00
Alex M
9847c40e34
[Edit] SaveAction not navigating anymore
2016-09-03 17:55:04 +03:00