Andrew Henry
45de84c183
[Time Conductor] Prevent route change when time conductor values change ( #1342 )
...
* [Time Conductor] Prevent route change on setting search parameters. fixes #1341
* [Inspector] Fixed incorrect listener deregistration which was causing errors on scope destruction
* Bare route is redirect to browse
* [Browse] handle routing without breaking $route
Manage route transitions such that route changes are properly
prevented and navigation events occur while still updating the url.
Resolves a number of issues where path and search updates had
to be supported in a very hacky manner.
https://github.com/nasa/openmct/pull/1342
* [URL] Set search without hacks
Changes in previous commit allow the search parameters to be modified
without accidentally triggering a page reload.
https://github.com/nasa/openmct/pull/1342
* [Views] Update on location changes
If the user has a bookmark or tries to change the current view of an
object by specifying view=someView as a search parameter, the change would
not previously take effect. This resolves that bug.
https://github.com/nasa/openmct/pull/1342
* [TC] Set query params to undefined
Instead of setting params to null, which would eventually result in those
parameters equaling undefined, set them to undefined to skip the extra
step.
https://github.com/nasa/openmct/pull/1342
* [Instantiate] Instantiate objects with context
Add context to instantiate objects so that they can be navigated
to for editing.
https://github.com/nasa/openmct/pull/1342
* [Tests] Update specs
Update specs to match new expectations.
* [Style] Fix style
* [TC] Remove unused dependency
Remove $route dependency from time conductor controller as it was
not being used. Resolves review comments.
https://github.com/nasa/openmct/pull/1342#pullrequestreview-11449260
2016-12-07 13:33:53 -08:00
Henry
a3f5873501
[Edit Mode] Fix issue with navigation not triggering unsaved changes message for new objects. Removed logic that prevented mutation of new objects from triggering a transactional persist call. Fixes #1278
2016-12-05 15:52:14 -08:00
Henry
86b337ec88
Revert "[Edit Mode] Fix issue with navigation not triggering unsaved changes message for new objects. Removed logic that prevented mutation of new objects from triggering a transactional persist call. Fixes #1278 "
...
This reverts commit 7dda85cc5f
2016-12-05 15:49:50 -08:00
Henry
7dda85cc5f
[Edit Mode] Fix issue with navigation not triggering unsaved changes message for new objects. Removed logic that prevented mutation of new objects from triggering a transactional persist call. Fixes #1278
2016-12-05 15:46:56 -08:00
Pete Richards
73b3ae7264
[Composition] Composition api improvements ( #1332 ). Fixes #1322 and Fixes #1253
...
* [Composition] provide ids, sync via mutation
Composition provides ids, and we sync things via mutation. This
simplifies the composition provider interface some, and also
fixes some issues with the previous default composition provider
related to #1322
fixes #1253
* [Style] Fix style, update jsdoc
Fix style, update jsdoc, clean up composition api changes for
Fixes #1322
* [Style] Tidy and JSDoc
* [Composition] Utilize new composition API
Ensures that composition provided by new API works in old API.
Some functionality is not present in both places, but for the
time being this is sufficient.
https://github.com/nasa/openmct/pull/1332
* [Utils] add tests, fix bugs
Add tests to objectUtils to ensure correctness. This caught a bug
where character escapes were not properly applied or removed. As
a result, any missing object that contained a colon in it's key
would cause an infinite loop and cause the application to crash.
Bug discovered in VISTA integration.
* [Style] Fix style
* [Roots] Depend on new api for ROOT
Depend on new API for ROOT model, ensuring consistency when
fetching ROOT model.
* [Style] Remove commented code
2016-11-30 12:00:01 -08:00
Pete Richards
4d3ec398c9
[Style] Fix style, disable tests
...
disable tests for later follow-up.
2016-11-08 16:21:38 -08:00
Pete Richards
b169089156
get rid of feel-good code
2016-11-08 16:07:53 -08:00
Pete Richards
66a6b6d89b
Always put in cache on mutation, assuming persistence
2016-11-08 14:58:15 -08:00
Pete Richards
d74eba1922
Move mutation listening out of cache service
2016-11-08 14:14:56 -08:00
Pete Richards
9a7f69a614
Model Cache updates models on mutation
2016-11-08 13:54:31 -08:00
Pete Richards
0578a651da
cache on instantiate
2016-11-08 13:51:50 -08:00
Pete Richards
f991dcfb76
Clear cache when no transactions active
2016-11-08 13:51:30 -08:00
Pete Richards
42c48cb93b
disable cache
2016-11-08 11:20:34 -08:00
Pete Richards
2708562872
[Transaction] Sync mutation within transaction
2016-11-08 10:34:20 -08:00
Victor Woeltjen
9578fb0cd8
[Views] Update representations on mutation ( #1312 )
...
* [Core] Log errors from topic
Log full error (including stack trace) when catching errors
from the topic service. Aids debugging of #1303 (and should
aid in future debugging of any similar issues.)
* [API] Fix identifier usage in handleMutation
To address console errors observed in the context of #1303
* [Views] Listen to mutation
Listen for mutation instead of watching modified timestamp;
more reliable due to recent API changes. Fixes #1303 .
* [Views] Update spec for mct-representation
...to reflect changes for #1303
2016-11-07 10:08:53 -08:00
Victor Woeltjen
70985c5dbd
Revert "[Roots] Remove obsolete provider"
...
This reverts commit b49fef78f5Fixes #1284
2016-10-26 10:09:10 -07:00
Victor Woeltjen
9dec99824e
Revert "[Roots] Remove obsolete spec"
...
This reverts commit 2cced53c97
2016-10-26 10:08:35 -07:00
Victor Woeltjen
d4730e1656
Revert "[Roots] Remove legacy root model provider"
...
This reverts commit 7b0506bbdb
2016-10-26 10:08:30 -07:00
Victor Woeltjen
b49fef78f5
[Roots] Remove obsolete provider
2016-10-19 17:02:12 -07:00
Victor Woeltjen
2cced53c97
[Roots] Remove obsolete spec
2016-10-19 16:54:26 -07:00
Victor Woeltjen
7b0506bbdb
[Roots] Remove legacy root model provider
2016-10-19 16:19:11 -07:00
Victor Woeltjen
64ff463200
Revert "Revert "Async root registration""
2016-10-19 14:55:07 -07:00
Victor Woeltjen
4eca80a770
Revert "Async root registration"
2016-10-18 10:48:26 -07:00
Pete Richards
891412bdb9
[Roots] Move my-items to separate bundle
...
My Items root is now opt-in, and does not need to be enabled for all
deployments. My Items is enabled by default in the development edition.
https://github.com/nasa/openmct/issues/1251
2016-10-14 12:38:47 -07:00
Victor Woeltjen
1a88c9a651
Merge remote-tracking branch 'origin/master' into persist-on-mutation-825
2016-10-07 11:27:58 -07:00
Victor Woeltjen
7d950d067c
Merge pull request #1194 from hudsonfoo/open1184
...
[Frontend] Add notes property to all item types
2016-09-27 15:28:49 -07:00
David Hudson
56267095cb
[Forms] Add style for small textareas
...
Issue #1184 . This allows for a generically sized text area in forms. I am
anticipating some potential feedback on this given the approach and the sizing
I chose may or may not be ideal for your requirements.
2016-09-18 01:47:07 +09:00
David Hudson
f9ce27def3
[Frontend] Add attributes for storing notes
...
Issue #1184
2016-09-18 01:27:12 +09:00
David Hudson
4429e847e8
[Properties] Add notes field to all item types
...
Issue #1184
2016-09-18 01:18:26 +09:00
steven mirecki
e751461194
Typo corrections, I avoided making changes to words that have regional spelling differences.
2016-09-03 09:16:54 -04:00
Victor Woeltjen
385d90b056
[Persistence] Fix code style
2016-08-08 13:51:10 -07:00
Victor Woeltjen
70c072be0b
[Persistence] Test more cases
...
Add more test cases for TransactingMutationListener to
distinguish active-transaction case from no-transaction
case.
2016-08-08 13:18:40 -07:00
Victor Woeltjen
eb2fbcd8d0
[Persistence] Cover TransactingMutationListener
...
Add test cases sufficient for line coverage of
TransactingMutationListener.
2016-08-08 12:34:46 -07:00
Victor Woeltjen
02f34d1c04
[Persistence] Begin testing TransactingMutationListener
2016-08-08 12:28:13 -07:00
Victor Woeltjen
d1e1ba1c66
[Frontend] Refactor glyphs to classes
...
Squashes #1103 , fixes #1047 .
Squashed commit of the following:
commit 0e060f174dFixes #1047
commit 9f74395a79Fixes #1047
commit 7278c9534cFixes #1047
Fixed .s-status-editing and s-status-pending;
commit 4606d617d1d5bff5559436f7d5bff555e0Fixes #1047
commit b72d82baefFixes #1047
commit af36b9996dFixes #1047
<mct-form> must now include class
'validates' to display validation glyph icons;
removed 'no-validate' from markup; cleaned
up validation scss;
commit 69dc893b4bFixes #1047
Fixes and enhancements for mobile,
particularly in tree; Removed
`display: inline-block` from containerSubtle
mixin;
commit 7bca18b186Fixes #1047
.s-menu-btn > .s-menu-button;
.create-btn > .create-button;
removed unused l-btn, t-btn,
t-btns-zoom from markup
commit 5d229198b7Fixes #1047
commit 36479e2e8bFixes #1047
commit 89e4f06de9Fixes #1047
commit e65ca1cb8bFixes #1047
- Clock, timer, plots updated
commit 3e7eb98ac2Fixes #1047
- Finessing mini-tab and making able to
control per theme; s-clickable and s-toggle-icon
classes cleaned up
commit 18e08074a8Fixes #1047
- Splitter and mini-tab-icon elements
commit 44fda8d68fFixes #1047
mini-tabs, splitters and bg-splash updated;
moved position of Inspector collapse mini-tab
to allow position transition;
splitter-sm class added for Timelines;
commit 2aee8bc0d8Fixes #1047
commit 624f09777fce7591f4d2f159ce7591f642Fixes #1047
Restored no-collapse and float-right
properties;
commit 5324c8edbaFixes #1047
New font files that were missed in
last commit; updated icomoon proj
file; fixed missing char codes in
glyphs.scss;
commit a3b2628883Fixes #1047
New icons for overlay and stacked plots;
revised art and new description for
Fixed Position object;
commit 8a41c6dbc7Fixes #1047
Updated comment
commit eb293b21ebFixes #1047
Removed commented code
commit d8b1fb7781Fixes #1047
Search and removal of "glyph" definitions in bundle
and other JS files; updating tests accordingly;
commit 650fbcc921Fixes #1047
Search and removal of "glyph" definitions in bundle
and other JS files; updating tests accordingly;
commit 574b8bd5c1Fixes #1047
Fixing test cases
commit dd84177441Fixes #1047
WIP: Fixing test cases: fixed test in Timers that was expecting
glyph return;
commit 2231f8e124Fixes #1047
Fixing test cases: fixed test in Timers that was expecting
glyph return;
commit ae59ecfa97Fixes #1047
WIP: fixed line-height issue for t-item-icon class
commit d43bff1445Fixes #1047
WIP: fixed colors and style defs related to clickable
icons
commit c2db6f8805Fixes #1047
WIP: fixed colors related to changes to
btnSubtle mixin; new constants for clickable
icons
commit a4753c44d1Fixes #1047
WIP
commit 2704640b94Fixes #1047
Normalize color constant values for themes; consolidated
and cleaned up btn-related mixins; fixed hover color issues
commit 421286c7e4Fixes #1047
WIP
commit a4111f3855Fixes #1047
WIP: Timeline-related glyph refactoring; s-btn
styles and hover color fixes
commit 883f9992159d9cabb14f1a1f9d9cabb760Fixes #1047
WIP: search, toolbar buttons; mods
to flex archetypes
commit 28b663ce41Fixes #1047
Glyph refactoring WIP for toolbar buttons;
Timeline glyph refactoring continued
commit a9326f572fFixes #1047
Timeline glyph refactoring; Resource Graph icons
in swimlanes now display grayed-out version when not
added to the Resource Graph; minor color tweaks
commit d6e173780388054e56176ca2Fixes #1047
Resolved conflict in icomoon.json file
commit 88054e5e8efixes #1047
In progress: significant mods to pane collapse/expand
buttons and symbols, minor tweaks to splitter look,
limits glyph definitions
commit 7c47343f5cfixes #1047
In progress: updated font files glyphs, mostly
for pane collapse icons
commit fd00bdce54fixes #1047
In progress: search menu
commit 272b4b649efixes #1047
In progress: moved limits classes out
of _contants and into _glyphs;
timers, entanglement context menu items,
form validation, date picker.
commit 95d26e6fe7Fixes #1047
In-progress; limits
commit 26b30d96dbFixes #1047
In-progress; overlay close, search inputs,
messages and message banners,
ui-symbol removal in-progress.
commit 4e2a01ad85Fixes #1047
In-progress; .labeled added to .s-btn,
removed .s-icon-btn
commit 521db3c3feFixes #1047
In-progress; plot options, imagery buttons,
cleanups in buttons.scss, edit-action buttons,
.s-btn .no-label class added.
commit 8bb8db69e6Fixes #1047
In-progress; indicators, notifications, actions,
tests
commit 53ed0bfb22fixes #1047
In progress, really: view icons, timer/clock
commit 47dc7f2f6bfixes #1047
In progress: grid items
commit 2bd34f71befixes #1047
Context menus and associated actions,
custom checkboxes, tree item being edited
commit b561d4f60efixes #1047
In-progess: glyphs.scss now uses $vars to
allow other scss to use a var instead of string
literals;
commit 0cf4089620fixes #1047
In-progess: tree-labels, unknown objects, object
header
commit 46cae10905fixes #1047
In-progess, menus and Create menu fixes
commit fe3097707f7d69ae4652a50c7d69ae401bfixes #1047
In-progress, converting types, mods to
Create Menu template
commit 18d9f3d6b2fixes #1047
Very much In-progess: convert some controls;
commit e93a90a782fixes #1047
Very much In-progess, classes for all symbols
added to glyphs.scss; .menu cleaned up;
commit dc670b22a6fixes #1047
Very much In-progess, "icon-" selector,
browse bar buttons
commit 8b29ccf3affixes #1047
Very much In-progess, s-btn and
s-btn-menu refactoring
commit f574ffed16fixes #1047
In-progess, e900 > e904
commit bc62ee4565fixes #1047
New font files; no re-mapping yet in the app.
commit 614f0c6e9ffixes #1047
Moved all glyphs into PUA area of font, and
re-organized by category.
commit 47bd4031d5Fixes #1047
- Modified sass to point to renamed font files;
- Added new 12px symbols font files to sass;
commit 22a51d6bbbFixes #1047
- Renamed main project file;
- Added new 12px symbols project file;
commit 13ded2fd84Fixes #1047
commit aef5660dfdFixes #1047
2016-08-01 14:33:25 -07:00
Victor Woeltjen
b60eff2f5e
[Persistence] Update bundle definition
2016-07-26 15:26:43 -07:00
Victor Woeltjen
f6d6cb929f
[Persistence] Add to transaction on mutation
2016-07-26 15:24:16 -07:00
Victor Woeltjen
766e94ed62
Merge remote-tracking branch 'origin/master' into persist-on-mutation-825b
...
Conflicts:
platform/core/src/capabilities/PersistenceCapability.js
2016-07-25 16:30:49 -07:00
Andrew Henry
6176ca2260
Merge pull request #1084 from nasa/transaction-clearing-1059
...
[Persistence] Clear transactions selectively
2016-07-15 16:20:19 -07:00
Victor Woeltjen
4c7ad6d93a
Merge branch 'undirty-on-refresh-1046' into transaction-clearing-1059
...
Conflicts:
platform/commonUI/edit/src/actions/SaveAsAction.js
2016-07-14 11:53:39 -07:00
Victor Woeltjen
1fb18c7919
[Context] Add test, tweak logic
...
Add test to verify that warnings are not shown based on
composition/location inconsistencies when editing.
2016-07-14 11:16:07 -07:00
Victor Woeltjen
1c2378b3b4
[Context] Suppress warnings while editing
...
Don't expect consistency between composition and location fields
while an object is being edited; this avoids benign warnings
being logged. Fixes #624
2016-07-14 11:10:15 -07:00
Henry
c8898ac6aa
[Documentation] Updated copyright statement. Fixes #1081
2016-07-12 16:55:57 -07:00
Victor Woeltjen
8244e435bf
[Edit] Update failing spec
2016-06-22 16:13:26 -07:00
Victor Woeltjen
a3a0f003f0
[Edit] Don't refresh unpersisted objects
2016-06-22 15:41:06 -07:00
Pete Richards
c00b053aa7
[Tests] verify that identifier service provides key
...
Verify that the results of the identifier service are used for
persistence calls instead of the domain object id.
https://github.com/nasa/openmct/issues/1013
2016-06-15 10:31:25 -07:00
Pete Richards
2d5824c4ab
[Persistence] Use identifier service to get key
...
Retrieve key from identifier service for all persist operations.
Fixes https://github.com/nasa/openmct/issues/1013
2016-06-14 10:56:54 -07:00
Henry
165e158f37
[Edit Mode] #629 Removed redundant test from DomainObjectProviderSpec
2016-05-26 11:44:43 -07:00
Victor Woeltjen
fb8fe93529
[Persistence] Fix mistake in JSDoc
...
https://github.com/nasa/openmct/pull/874#discussion_r64639089
2016-05-25 13:06:58 -07:00
Victor Woeltjen
26839c7fd1
[Persistence] Fix code style after merge
2016-05-20 14:27:53 -07:00
