Commit Graph

3468 Commits

Author SHA1 Message Date
Victor Woeltjen
a947ff1274 [Fixed Position] Add element factory
Add element factory, which will take on responsibility
for populating initial states of elements and (if necessary)
prompting for user input. WTD-880.
2015-02-20 12:21:28 -08:00
Victor Woeltjen
f1a8e84a93 [Fixed Position] Allow adding elements
Allow adding of elements (without any element-specific
properties beyond type.) WTD-880.
2015-02-20 11:53:50 -08:00
Victor Woeltjen
6fca03521b [Fixed Position] Add initial element templates
Add element templates for fixed position elements introduced
via the Add button, WTD-880.
2015-02-20 11:39:29 -08:00
Victor Woeltjen
2be58579dc [Fixed Position] Add 'Add' menu button
Add UI for the Add button in fixed position view,
WTD-880.
2015-02-20 11:30:04 -08:00
Victor Woeltjen
1015e97b3e [Fixed Position] Add tests for FixedController
Add additional test cases for controller for Fixed Position
view to meet code coverage after changes for WTD-879.
2015-02-19 16:24:45 -08:00
Victor Woeltjen
3cfcd027e0 [Fixed Position] Fill in specs for selection proxies
Fill in specs for fixed position views selection proxies,
WTD-879.
2015-02-19 13:29:43 -08:00
Victor Woeltjen
7882dd1401 [Fixed Position] Add spec for selection
Add spec for selection manager for layout and fixed position
views, WTD-879.
2015-02-19 13:06:55 -08:00
Victor Woeltjen
8c653d39d7 [Edit] Update specs
Update specs for toolbars in Edit mode to reflect
changes for WTD-879.
2015-02-19 12:44:00 -08:00
Victor Woeltjen
280c854658 [Fixed Position] Update drop gesture spec
Update drop gesture spec for changes made for WTD-879
2015-02-19 12:34:22 -08:00
Victor Woeltjen
14cbb9fb40 [Fixed Position] Add placeholder specs
Add placeholder specs for classes added to support
selection of elements in a fixed position view,
WTD-879.
2015-02-19 12:21:39 -08:00
Victor Woeltjen
7498e340d6 [Fixed Position] Rename accessor
Rename utility function used by fixed position elements
to be more accurate. WTD-879.
2015-02-19 12:10:43 -08:00
bwyu
b29d3a148f Merge remote-tracking branch 'origin/open829' into open-master 2015-02-19 11:08:05 -08:00
Victor Woeltjen
83872946bf [Fixed Position] Fix grid size spec
Fix spec which ensures that FixedController correctly
populates background grid based on user-defined grid
size, after changes for WTD-879.
2015-02-19 10:22:12 -08:00
Victor Woeltjen
9a50f6d84d [Fixed Position] Fix globals
Fix globals to pass JSLint check in command line build. WTD-879.
2015-02-19 09:37:02 -08:00
Victor Woeltjen
5df41966a4 [Fixed Position] Disable failing specs
Disable failing specs after significant rewrite of
FixedController to handle element selection, WTD-879.
2015-02-19 09:13:45 -08:00
Victor Woeltjen
81159a8801 [Telemetry] Update subscription spec
Update spec for TelemetrySubscription to account for the fact
that it initially calls back when the set of telemetry objects
is available (which supports views such as Fixed Position
which want to defer all telemetry-handling responsibility to
the subscription.) WTD-879.
2015-02-19 09:11:59 -08:00
Victor Woeltjen
035b2e36c3 [Telemetry] Fire callback when objects are available
Fire callback from telemetry subscriber when the set of
object references changes. This allows views which use
the subscriber to register one callback, while still
ensuring that they are notified when there is new
information to show. Supports fixed position view, WTD-879.
2015-02-18 20:37:23 -08:00
Victor Woeltjen
7bd41a9f80 [Fixed Position] Allow dragging of elements
Restore dragging behavior to elements in a fixed position
view, WTD-879.
2015-02-18 20:29:54 -08:00
Victor Woeltjen
5680710c06 [Fixed Position] Implement remove
Implement remove button for selected elements in fixed
position view. WTD-879.
2015-02-18 20:12:55 -08:00
Victor Woeltjen
f66fb0a32d [Fixed Position] Add remove button
Add a 'remove' button when elements are selected in
fixed position view, WTD-879.
2015-02-18 19:56:54 -08:00
Victor Woeltjen
a4dd730764 [Fixed Position] Allow select/deselect
Allow select/deselect of individual elements in fixed position
view, WTD-879.
2015-02-18 19:51:42 -08:00
Victor Woeltjen
cd98fd475d [Fixed Position] Begin using proxies
Begin using proxies for elements in fixed position view,
WTD-879.
2015-02-18 19:41:27 -08:00
Victor Woeltjen
f24f62dedc [Fixed Position] Begin adding element proxy classes
Begin adding proxy classes to allow the toolbar to interact with
elements in a fixed position view, WTD-879.
2015-02-18 19:26:06 -08:00
Victor Woeltjen
466a169562 [Fixed Position] Continue refactoring controller
Continue refactoring Fixed Position controller for
selection support, WTD-879.
2015-02-18 15:11:52 -08:00
Victor Woeltjen
bf36141e91 [Fixed Position] Begin refactoring controller
Begin refactoring Fixed Position controller to facilitate
selection support, as well as multiple types of elements;
WTD-879.
2015-02-18 13:50:25 -08:00
Victor Woeltjen
8662689974 [Fixed Position] Begin breaking apart template
Begin breaking apart template to allow multiple
types of fixed position elements, WTD-879.
2015-02-18 13:19:59 -08:00
Victor Woeltjen
97b844563d [Fixed Position] Add proxy object
Add proxy object to represent the selection of the fixed position
view itself, WTD-879.
2015-02-18 09:03:50 -08:00
Victor Woeltjen
4be2a3f1cd [Fixed Position] Add selection manager
Add utility class so that layouts/fixed position views
can track their current selection state more simply.
WTD-879.
2015-02-18 08:55:58 -08:00
Victor Woeltjen
7a680873e3 [Fixed Position] Begin adding placeholder toolbar
Begin adding placeholder toolbar for fixed position view,
WTD-879.
2015-02-17 16:29:42 -08:00
Victor Woeltjen
db2f2eb098 [Fixed Position] Improve button support
Improve button support from toolbars by adding a click
function when generating structures for mct-toolbar based
on view definitions. WTD-879.
2015-02-17 16:29:15 -08:00
Victor Woeltjen
7fced99390 [Fixed Position] Add placeholder toolbar definition
Add a mostly-empty toolbar definition to Fixed Position view,
WTD-879.
2015-02-17 16:15:25 -08:00
Victor Woeltjen
98caa31d7b Merge branch 'open877' into open879
Merge fixed position view work and general toolbar
work to begin adding toolbars for fixed position view,
WTD-879."

Conflicts:
	platform/commonUI/edit/res/templates/edit-object.html
2015-02-17 15:58:36 -08:00
Victor Woeltjen
3916968544 [Edit] Add EditToolbarRepresenter spec
Add tests for representer which mediates between view's
selection and toolbar contents, WTD-878.
2015-02-17 15:47:18 -08:00
Victor Woeltjen
48754c78bf [Edit] Wire in toolbar representer
Wire in representer for handling toolbars in Edit mode,
and add some clarifying documentation. WTD-878.
2015-02-17 15:30:23 -08:00
Victor Woeltjen
023c12ec3b [Edit] Add toolbar representer
Add a representer to handle exposing toolbars for views in
edit mode. WTD-878.
2015-02-17 14:31:02 -08:00
Victor Woeltjen
5dc72b15c2 [Edit] Implement EditToolbar
Implement EditToolbar (sufficient to satisfy spec) which will
construct an mct-toolbar-friendly form structure based on both
the current selection and the view's defined toolbar structure.
WTD-878.
2015-02-17 13:47:14 -08:00
Victor Woeltjen
8f14f4e5eb [Edit] Add spec for toolbar
Add spec for class that will convert toolbar definition
provided by views to suitable input for mct-toolbar, WTD-878.
2015-02-17 12:58:36 -08:00
Victor Woeltjen
ab546c9541 [Edit] Document toolbar behavior
Document how toolbars may be described by a view such
that Edit mode will populate the actual displayed
toolbar, WTD-878.
2015-02-17 12:19:35 -08:00
Victor Woeltjen
0510705f3a [Representation] Update docs
Update documentation to reflect that an event is broadcast
when drops occur. WTD-877.
2015-02-17 10:56:38 -08:00
Victor Woeltjen
156f053421 [Fixed Position] Add specs for drop
Add specs related to positioning of objects based on
drop position, WTD-877.
2015-02-17 10:50:02 -08:00
Victor Woeltjen
553101100b [Fixed Position] Refresh subscriptions
Refresh subscriptions when composition changes, such as due to
a drag-drop addition of an element to the view. WTD-877.
2015-02-17 10:34:13 -08:00
Victor Woeltjen
136dddab86 [Fixed Position] Position elements where dropped
Position elements where they are dropped in Fixed Position
view, WTD-877
2015-02-17 10:27:37 -08:00
Victor Woeltjen
ef4ed50605 [Layout] Separate out handleDrop
Separate drop-handling into a non-anonymous function in
LayoutController to satisfy code style guidelines;
WTD-877.
2015-02-17 10:25:31 -08:00
Victor Woeltjen
01d953bf45 [Layout] Position frames on drop
Position frames within a layout based on the position
where they were dropped into the layout, WTD-877.
2015-02-17 10:23:10 -08:00
Victor Woeltjen
e158f2811c [Views] Wire in drop gesture
Support drop gesture from fixed position view and from
layout view, WTD-877.
2015-02-17 10:03:48 -08:00
Victor Woeltjen
4190941bfb [Views] Broadcast event on drop
Broadcast an event when drag-drop domain object composition
occurs, such that the view in question may utilize the drop
coordinates (e.g. to position elements in a layout or fixed
position view.) WTD-877.
2015-02-17 10:01:27 -08:00
Victor Woeltjen
8d6b218646 [Fixed Position] Add initial spec
Add initial spec for FixedController to satisfy minimum
coverage requirements, in preparation for review. WTD-889.
2015-02-17 09:03:23 -08:00
Victor Woeltjen
c2b1775d75 [Fixed Position] Free up resources
Free up resources when a fixed position view is destroyed,
WTD-889.
2015-02-17 08:35:32 -08:00
Victor Woeltjen
71a132d374 [Fixed Position] Improve doc of FixedController
Improve documentation for Fixed Position controller, WTD-889.
2015-02-17 08:32:35 -08:00
Victor Woeltjen
abe4be9238 [Fixed Position] Remove unused representer
Remove unused representer for view toolbars; clean up for
WTD-889.
2015-02-17 08:30:42 -08:00