Commit Graph

4268 Commits

Author SHA1 Message Date
Victor Woeltjen
d7c7e2835f [Forms] Let Angular force required rows
Pass along ng-required values such that Angular may
handle tracking of form validity based on the presence
of required fields. WTD-530.
2014-11-26 13:20:07 -08:00
Victor Woeltjen
ede3e4f31e [Forms] Add validation classes
Add classes for required, valid, and invalid, based on
form state and on arguments passed into the form.
WTD-530.
2014-11-26 13:15:12 -08:00
Victor Woeltjen
b31b4770d1 [Forms] Communicate dirty state
Communicate dirty state out of generated forms;
WTD-530.
2014-11-26 13:08:57 -08:00
Victor Woeltjen
77c1b150d9 [Forms] Add more form controls
Add remaining platform form controls; amend mct-form
and mct-control directives to better communicate state.
Begin working on problem of communicating validation
back out of the form. WTD-530.
2014-11-26 12:50:51 -08:00
Victor Woeltjen
658d485ccc [Forms] Initial minimal functionality
Initial minimal working implementation where a
two-way binding between form and form user is
observable.

Notably, change ng-options to options, since
ng-options is terminal (it breaks mct-control).

WTD-530
2014-11-26 10:43:48 -08:00
Victor Woeltjen
9576673b84 [Forms] Add mct-control directive
Add an mct-control directive which can represent
individual form controls. WTD-530.
2014-11-26 08:43:41 -08:00
Victor Woeltjen
695ca5c0cf [Forms] Bring in initial work on forms
Bring in previous work on the forms component; this includes
transitioned versions of specific form elements, and the
mct-form direction which generates these. WTD-530
2014-11-26 08:01:00 -08:00
Victor Woeltjen
0bacc03e58 [Common UI] Fix FullscreenActionSpec
Fix FullscreenActionSpec such that it will execute on
command line; the global screenfull dependency behaves
differently during attempts to spy on methods from
the command line build, so replace it entirely.

Concludes work on WTD-574 in preparation to submit for
review.
2014-11-25 23:08:47 -08:00
Victor Woeltjen
b0cb8a8455 [Common UI] Fix Save/Cancel quirk
Fix a defect in the Save/Cancel buttons in Edit mode
that was causing the first click to be missed; this
was due to Angular's inability to detect when a
native promise (as opposed to one from ) had been
resolved.

Since the Editor capability is introduced indirectly
and is a few degrees of separation removed from
the declared extension layer (where we would be able
to get a reference to ), and all we need to do is
make something look Promise-like, a convenience
function to do this is added.

Part of ongoing transition of common user interface
elements, WTD-574.
2014-11-25 22:58:34 -08:00
Victor Woeltjen
52ec1aeb89 [Common UI] Complete remaining specs
Complete remaining specs to achieve full test coverage
for common user interface bundles being transitioned
as part of WTD-574.
2014-11-25 22:48:12 -08:00
Victor Woeltjen
3aa551c4ea [Common UI] Fill in CreationService spec
Fill in specs for CreationService, which supports the
Create action, which, in turn, is included to support
the Create button in Browse mode. Part of the transition
of common user interface elements for WTD-574.
2014-11-25 22:35:30 -08:00
Victor Woeltjen
48ff8c4c03 [Common UI] Continue filling in Browse specs
Continue filling in specs for scripts introduced as part
of bundle platform/commonUI/browse, which is responsible
for browse mode. WTD-574.
2014-11-25 20:26:37 -08:00
Victor Woeltjen
528f6bdf56 [Common UI] Spec for ViewSwitcherController
Fill in spec for the controller which maintains a set of
applicable and selected view options to populate the
view switcher. Part of Browse mode and, in turn, part
of the common user interface elements that are being
transitioned for WTD-574.
2014-11-25 19:46:56 -08:00
Victor Woeltjen
9bc05f27a5 [Common UI] Skeleton specs for Browse
Add skeleton specs for browse mode. WTD-574.
2014-11-25 18:30:30 -08:00
Victor Woeltjen
36fab50825 [Common UI] Add in-line docs for Browse
Add in-line docs for bundle platform/commonUI/browse,
which implements Browse mode, one of the common user
interface bundles being transitioned in WTD-574.
2014-11-25 16:53:22 -08:00
Victor Woeltjen
b97e2d0324 [Common UI] Add JSDoc, remove UUIDService
Add JSDoc to Create-related classes and remove the
UUIDService (replaced by third-party lib) to reduce
amount of code to cover and prepare for code review,
as part of ongoing transition of common user interface
elements, WTD-574.
2014-11-25 16:14:09 -08:00
Victor Woeltjen
242d40fab2 [Common UI] Fill in dialog specs
Fill in specs for bundle platform/commonUI/dialog,
which provides the ability to show dialogs. One
of the common user interface elements being transitioned
for WTD-574.
2014-11-25 15:59:04 -08:00
Victor Woeltjen
f04e02359a [Common UI] Skeleton spec for dialogs
Skeleton specs for bundle platform/commonUI/dialog,
responsible for displaying dialog overlays. Part of
ongoing transition of common user interface elements
for WTD-574.
2014-11-25 14:44:16 -08:00
Victor Woeltjen
0faf4c934e [Common UI] Refactor dialogs
Refactor bundle platform/commonUI/dialog such that
the concerns of showing dialogs (including showing
a single instance thereof) and managing changes to
the DOM are more cleanly separated. This simplifies
testing and satisfies code style guidelines for
this bundle, in preparation for its inclusion among
common user interface bundles to be transitioned
in WTD-574.
2014-11-25 14:39:40 -08:00
Victor Woeltjen
6cce00d601 [Common UI] Add JSDoc to DialogService
Add in-line documentation to the dialog service,
exposed by bundle platform/commonUI/dialog, one
of the common user interface bundles being
transitioned for WTD-574.
2014-11-25 13:31:30 -08:00
Victor Woeltjen
d950fe14e5 [Common UI] Finish JSDoc for edit mode
Complete in-line documentation for bundle
platform/commonUI/edit (Edit Mode), one of the
common user interface bundles being transitioned
for WTD-574.
2014-11-25 12:50:06 -08:00
Victor Woeltjen
4c0e5e963e [Common UI] Add JSDoc for edit actions
Add in-line documentation for actions that are introduced
by the bundle platform/commonUI/edit, which introduces
Edit mode. One of the common user interface bundles being
transitioned for WTD-574.
2014-11-25 11:53:53 -08:00
Victor Woeltjen
c432a4eb1e [Common UI] Complete specs for edit mode
Add specs for remaining capabilities and capability
wrappers employed by Edit mode. Completes coverage
for bundle platform/commonUI/edit, which is being
transitioned along with other commonUI bundles in
WTD-574.
2014-11-25 10:51:23 -08:00
Victor Woeltjen
7ddfcbca9b [Common UI] Fill in spec for RemoveAction
Fill in spec for the Remove action, included as part of
the bundle platform/commonUI/edit. WTD-574.
2014-11-25 10:08:50 -08:00
Victor Woeltjen
19b4dc3fa3 [Common UI] Spec for EditAction
Fill in spec for the Edit action, which enters Edit mode
Part of bundle platform/commonUI/edit, being transitioned
for WTD-574.
2014-11-25 09:48:54 -08:00
Victor Woeltjen
2f7746df53 [Common UI] Add specs for Save/Cancel
Add specs for the save and cancel conclude-editing
actions, part of bundle platform/commonUI/edit
(Edit Mode) which is transitioned among the various
common UI bundles. WTD-574
2014-11-25 09:35:55 -08:00
Victor Woeltjen
d7fbd596ef [Common UI] Specs for edit controllers
Add specs for controllers used to support Edit mode,
one of the common UI elements being transitioned for
WTD-574.
2014-11-24 17:29:42 -08:00
Victor Woeltjen
093ccb637f [Common UI] Amend ActionGroupControllerSpec
Amend ActionGroupControllerSpec (introduced for WTD-574,
transition of common UI elements) such that it handles
the case where no action capability is defined.
2014-11-24 17:09:56 -08:00
Victor Woeltjen
88f3221938 [Common UI] Add skeleton specs for edit mode
Add empty files which will contain specs for
bundle platform/commonUI/edit, which is responsible
for Edit mode. WTD-574.
2014-11-24 17:07:17 -08:00
Victor Woeltjen
80430234d6 [Common UI] Add JSDoc
Add JSDoc to remaining scripts in bundle
platform/commonUI/general. WTD-574.
2014-11-24 16:39:52 -08:00
Victor Woeltjen
2f43e8cd7f [Common UI] Document TreeNodeController
Add in-line documentation to TreeNodeController, and update
glossary with some clarifying definition.

Additionally, change name from tree-item to tree-node for
consistency.

Part of ongoing transition of commonUI bundles, WTD-574.
2014-11-24 15:42:15 -08:00
Victor Woeltjen
e0b201aa17 [Common UI] Add spec for mct-container
Add spec for the mct-container directive, introduced
as part of the general user interface support bundle,
platform/commonUI/general. WTD-574.
2014-11-24 15:22:03 -08:00
Victor Woeltjen
2b1fdc2204 [Common UI] Add specs for controllers
Add specs for controllers in the commonUI/general bundle.
WTD-574.
2014-11-24 15:10:29 -08:00
Victor Woeltjen
b026e313be [Common UI] Add skeleton specs
Add skeleton specs for bundle platform/commonUI/general.
WTD-574.
2014-11-24 13:39:52 -08:00
Victor Woeltjen
f6850ffc4f [Common UI] Encapsulate TreeNodeController
Reduce reliance on  from TreeNodeController,
clean up and better isolate node expansion behavior.
Part of transition of common UI elements, WTD-574.
2014-11-24 10:30:45 -08:00
Victor Woeltjen
eff9747198 [Common UI] Correct dialog failure behavior
When a dialog is already showing, act as if the
user input was cancelled and show a warning.
Part of ongoing transition of common user interface
bundles for WTD-574.
2014-11-24 07:54:26 -08:00
Victor Woeltjen
2ab3f5f5f9 [Common UI] Generalize ToggleController
Add a general-purpose ToggleController for things that
need to expand and contract. WTD-574.
2014-11-24 07:49:50 -08:00
Victor Woeltjen
845c1ad7d7 [Common UI] Add JSDoc for CreateMenuController
Add JSDoc and clarifying comments to the CreateMenuController,
which is responsible for maintaining an up-to-date set of
Create actions for a given domain object. WTD-574.
2014-11-24 07:20:49 -08:00
Victor Woeltjen
6e9d6e2199 [Common UI] Remove CreateButtonController
Remove CreateButtonController; this has been generalized to
ClickAwayController in the platform/commonUI/general bundle.
WTD-574.
2014-11-24 07:19:40 -08:00
Victor Woeltjen
3a5a015097 [Common UI] Generalize click-away behavior
Add a general-purpose controller for UI elements which
have 'click-away' behavior; that is, they should be
deactivated on document clicks.

This generalizes existing behavior added for the Create
menu, such that it may be used on other, similar menus
and UI elements.

Part of ongoing transition of common user interface
components, WTD-574.
2014-11-24 07:12:45 -08:00
Victor Woeltjen
42de4b8b13 [Common UI] Add common UI bundles
Add bundles under commonUI to the set of active
bundles. WTD-574.
2014-11-24 07:11:11 -08:00
Victor Woeltjen
078d63de36 [Common UI] Add JSDoc
Add JSDoc to classes from commonUI bundles. WTD-574.
2014-11-23 18:03:48 -08:00
Victor Woeltjen
49df6ee0ce [Common UI] Incorporate stylesheets
Incorporate stylesheets explicitly into the top-level
index.html; these are needed to properly display
elements from commonUI bundles. WTD-574.
2014-11-23 18:03:10 -08:00
Victor Woeltjen
8e50078823 [Example] Bring in example persistence
Bring in BrowserPersistenceService as an example, to use
as a stub to develop and integrate commonUI bundles
against. WTD-574.
2014-11-23 17:58:19 -08:00
Victor Woeltjen
1b0303e517 [Common UI] Initial commonUI bundles
Bring in work on general-purpose and over-arching
user interface bundles from the sandbox transition
branch. WTD-574.
2014-11-23 15:41:20 -08:00
Victor Woeltjen
0cd331e8a5 [Representation] Fix gesture-related definitions
Fix extension definitions related to the refactoring
of GestureProvider out of the mct-representation
directive. Completing work on the initial version
of the representation bundle, WTD-521.
2014-11-23 15:35:53 -08:00
Victor Woeltjen
f89402132b [Representation] Add JSDoc
Add in-line documentation for the representation component,
WTD-521.
2014-11-23 15:28:46 -08:00
Victor Woeltjen
2e0178ffa9 [Representation] Update documentation
Update documentation of the representation component,
WTD-521.
2014-11-22 13:02:51 -08:00
Victor Woeltjen
26cb03c555 [Representation] Spec for gesture provider
Add spec for GestureProvider, introduced to separate out the
attachment of gestures from the creation of representations.
WTD-521.
2014-11-22 11:52:24 -08:00
Victor Woeltjen
83093f8e6f [Representation] Spec for mct-representation
Add spec for the mct-representation; separate out gesture
attachment to improve testability and increase cohesion.
Part of ongoing initial authorship of representation
component, WTD-521.
2014-11-22 11:35:57 -08:00